* [Buildroot] [PATCH] Makefile: introduce check-package target
@ 2018-08-10 21:51 Thomas Petazzoni
2018-08-11 0:44 ` Ricardo Martincoski
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2018-08-10 21:51 UTC (permalink / raw)
To: buildroot
The snippet of code that runs a check-package on all
.mk/.hash/Config.in files is currently only available within
.gitlab-ci.yml, and isn't immediately and easily usable by Buildroot
users. In order to simplify this, this commit introduces a top-level
"check-package" make target that implements the same logic. The
.gitlab-ci.yml file is changed to use "make check-package".
Since this target is oriented towards Buildroot developers, we
intentionally do not clutter the already noisy "make help" text with
this additional make target.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
I often found myself copy/pasting this find command line from
.gitlab-ci.yml to my shell, and got tired of doing this, hence this
patch.
---
.gitlab-ci.yml | 3 +--
Makefile | 4 ++++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 9d4301076f..d4807c5c85 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -43,8 +43,7 @@ check-flake8:
check-package:
script:
- - find . -type f \( -name '*.mk' -o -name '*.hash' -o -name 'Config.*' \)
- -exec ./utils/check-package {} +
+ - make check-package
.defconfig: &defconfig
# Running the defconfigs for every push is too much, so limit to
diff --git a/Makefile b/Makefile
index f79d39fd26..e7fb216442 100644
--- a/Makefile
+++ b/Makefile
@@ -1125,6 +1125,10 @@ release:
print-version:
@echo $(BR2_VERSION_FULL)
+check-package:
+ find $(TOPDIR) -type f \( -name '*.mk' -o -name '*.hash' -o -name 'Config.*' \) \
+ -exec ./utils/check-package {} +
+
.PHONY: .gitlab-ci.yml
.gitlab-ci.yml: .gitlab-ci.yml.in
cp $< $@
--
2.14.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] Makefile: introduce check-package target
2018-08-10 21:51 [Buildroot] [PATCH] Makefile: introduce check-package target Thomas Petazzoni
@ 2018-08-11 0:44 ` Ricardo Martincoski
2018-08-11 10:44 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Ricardo Martincoski @ 2018-08-11 0:44 UTC (permalink / raw)
To: buildroot
Hello,
Very handy make target!
On Fri, Aug 10, 2018 at 06:51 PM, Thomas Petazzoni wrote:
[snip]
> ---
> .gitlab-ci.yml | 3 +--
> Makefile | 4 ++++
> 2 files changed, 5 insertions(+), 2 deletions(-)
You forgot to change .gitlab-ci.yml.in
[snip]
> +++ b/Makefile
> @@ -1125,6 +1125,10 @@ release:
> print-version:
> @echo $(BR2_VERSION_FULL)
>
> +check-package:
Shouldn't it be added to noconfig_targets?
Regards,
Ricardo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] Makefile: introduce check-package target
2018-08-11 0:44 ` Ricardo Martincoski
@ 2018-08-11 10:44 ` Thomas Petazzoni
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2018-08-11 10:44 UTC (permalink / raw)
To: buildroot
Hello Ricardo,
On Fri, 10 Aug 2018 21:44:06 -0300, Ricardo Martincoski wrote:
> On Fri, Aug 10, 2018 at 06:51 PM, Thomas Petazzoni wrote:
>
> [snip]
> > ---
> > .gitlab-ci.yml | 3 +--
> > Makefile | 4 ++++
> > 2 files changed, 5 insertions(+), 2 deletions(-)
>
> You forgot to change .gitlab-ci.yml.in
>
> [snip]
> > +++ b/Makefile
> > @@ -1125,6 +1125,10 @@ release:
> > print-version:
> > @echo $(BR2_VERSION_FULL)
> >
> > +check-package:
>
> Shouldn't it be added to noconfig_targets?
Thanks for your review! I've fixed those issues and sent a v2.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-11 10:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-10 21:51 [Buildroot] [PATCH] Makefile: introduce check-package target Thomas Petazzoni
2018-08-11 0:44 ` Ricardo Martincoski
2018-08-11 10:44 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.