[PATCH v2 0/7] arm64: qcom: sm8550: enable RNG

[PATCH v2 0/7] arm64: qcom: sm8550: enable RNG

[Neil Armstrong]

Enable RNG on SM8550 by reverting the PRNG bindings & DT
for SM8450 and correctly document it as a True Random Number Generator.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Changes in v2:
- Revert SM8450 DT & bindings
- Add new qcom,trng compatible and use it for SM8450 & SM8550
- Explicitly didn't collect the Reviewed-by tags due to the compatible change
- Link to v1: https://lore.kernel.org/r/20230822-topic-sm8550-rng-v1-0-8e10055165d1@linaro.org

---
Neil Armstrong (7):
      Revert "dt-bindings: crypto: qcom,prng: Add SM8450"
      Revert "arm64: dts: qcom: sm8450: Add PRNG"
      dt-bindings: crypto: qcom,prng: document that RNG on SM8450 is a TRNG
      crypto: qcom-rng - Add support for trng
      dt-bindings: crypto: qcom,prng: document SM8550
      arm64: dts: qcom: sm8550: add TRNG node
      arm64: dts: qcom: sm8450: add TRNG node

 Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 8 +++++---
 arch/arm64/boot/dts/qcom/sm8450.dtsi                    | 2 +-
 arch/arm64/boot/dts/qcom/sm8550.dtsi                    | 5 +++++
 drivers/crypto/qcom-rng.c                               | 1 +
 4 files changed, 12 insertions(+), 4 deletions(-)
---
base-commit: 28c736b0e92e11bfe2b9997688213dc43cb22182
change-id: 20230822-topic-sm8550-rng-c83142783e20

Best regards,
-- 
Neil Armstrong <neil.armstrong@linaro.org>

[PATCH v2 1/7] Revert "dt-bindings: crypto: qcom,prng: Add SM8450"

[Neil Armstrong]

This reverts commit b9296bb41275 ("dt-bindings: crypto: qcom,prng: Add SM8450"),
since the RNG HW on the SM8450 SoC is in fact a True Random Number Generator,
a more appropriate compatible should be instead as reported at [1].

[1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/

Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 .../devicetree/bindings/crypto/qcom,prng.yaml      | 24 +++++-----------------
 1 file changed, 5 insertions(+), 19 deletions(-)

diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
index 36b0ebd9a44b..bb42f4588b40 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
@@ -11,13 +11,9 @@ maintainers:
 
 properties:
   compatible:
-    oneOf:
-      - enum:
-          - qcom,prng  # 8916 etc.
-          - qcom,prng-ee  # 8996 and later using EE
-      - items:
-          - const: qcom,sm8450-prng-ee
-          - const: qcom,prng-ee
+    enum:
+      - qcom,prng  # 8916 etc.
+      - qcom,prng-ee  # 8996 and later using EE
 
   reg:
     maxItems: 1
@@ -32,18 +28,8 @@ properties:
 required:
   - compatible
   - reg
-
-allOf:
-  - if:
-      not:
-        properties:
-          compatible:
-            contains:
-              const: qcom,sm8450-prng-ee
-    then:
-      required:
-        - clocks
-        - clock-names
+  - clocks
+  - clock-names
 
 additionalProperties: false
 

-- 
2.34.1

[PATCH v2 2/7] Revert "arm64: dts: qcom: sm8450: Add PRNG"

[Neil Armstrong]

This reverts commit 76a6dd7bfcbb ("arm64: dts: qcom: sm8450: Add PRNG"),
since the RNG HW on the SM8450 SoC is in fact a True Random Number Generator,
a more appropriate compatible should be instead as reported at [1].

[1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/

Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8450.dtsi | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 2a60cf8bd891..6ae64059cea5 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -1738,11 +1738,6 @@ spi14: spi@a98000 {
 			};
 		};
 
-		rng: rng@10c3000 {
-			compatible = "qcom,sm8450-prng-ee", "qcom,prng-ee";
-			reg = <0 0x010c3000 0 0x1000>;
-		};
-
 		pcie0: pci@1c00000 {
 			compatible = "qcom,pcie-sm8450-pcie0";
 			reg = <0 0x01c00000 0 0x3000>,

-- 
2.34.1

[PATCH v2 3/7] dt-bindings: crypto: qcom,prng: document that RNG on SM8450 is a TRNG

[Neil Armstrong]

It has been reported at [1] the RNG HW on SM8450 is in fact a True Random
Number Generator and no more Pseudo, document this by adding
a new qcom,trng and the corresponding SoC specific sm8450 compatible.

[1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/

Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 .../devicetree/bindings/crypto/qcom,prng.yaml      | 24 +++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
index bb42f4588b40..4245c9e424a3 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
@@ -11,9 +11,13 @@ maintainers:
 
 properties:
   compatible:
-    enum:
-      - qcom,prng  # 8916 etc.
-      - qcom,prng-ee  # 8996 and later using EE
+    oneOf:
+      - enum:
+          - qcom,prng  # 8916 etc.
+          - qcom,prng-ee  # 8996 and later using EE
+      - items:
+          - const: qcom,sm8450-trng
+          - const: qcom,trng
 
   reg:
     maxItems: 1
@@ -28,8 +32,18 @@ properties:
 required:
   - compatible
   - reg
-  - clocks
-  - clock-names
+
+allOf:
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              const: qcom,trng
+    then:
+      required:
+        - clocks
+        - clock-names
 
 additionalProperties: false
 

-- 
2.34.1

[PATCH v2 4/7] crypto: qcom-rng - Add support for trng

[Neil Armstrong]

The SM8450 & later SoCs RNG HW is now a True Random Number Generator
and a new compatible has been introduced to handle the difference.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 drivers/crypto/qcom-rng.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/qcom-rng.c b/drivers/crypto/qcom-rng.c
index 825a729f205e..fb54b8cfc35f 100644
--- a/drivers/crypto/qcom-rng.c
+++ b/drivers/crypto/qcom-rng.c
@@ -207,6 +207,7 @@ MODULE_DEVICE_TABLE(acpi, qcom_rng_acpi_match);
 static const struct of_device_id __maybe_unused qcom_rng_of_match[] = {
 	{ .compatible = "qcom,prng", .data = (void *)0},
 	{ .compatible = "qcom,prng-ee", .data = (void *)1},
+	{ .compatible = "qcom,trng", .data = (void *)1},
 	{}
 };
 MODULE_DEVICE_TABLE(of, qcom_rng_of_match);

-- 
2.34.1

[PATCH v2 5/7] dt-bindings: crypto: qcom,prng: document SM8550

[Neil Armstrong]

Document SM8550 compatible for the True Random Number Generator.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
index 4245c9e424a3..633993f801c6 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
@@ -16,7 +16,9 @@ properties:
           - qcom,prng  # 8916 etc.
           - qcom,prng-ee  # 8996 and later using EE
       - items:
-          - const: qcom,sm8450-trng
+          - enum:
+              - qcom,sm8450-trng
+              - qcom,sm8550-trng
           - const: qcom,trng
 
   reg:

-- 
2.34.1

[PATCH v2 6/7] arm64: dts: qcom: sm8550: add TRNG node

[Neil Armstrong]

Add the Qualcomm True Random Number Generator node.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8550.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index d115960bdeec..c42c5bd03a37 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -1661,6 +1661,11 @@ mmss_noc: interconnect@1780000 {
 			qcom,bcm-voters = <&apps_bcm_voter>;
 		};
 
+		rng: rng@10c3000 {
+			compatible = "qcom,sm8550-trng", "qcom,trng";
+			reg = <0 0x010c3000 0 0x1000>;
+		};
+
 		pcie0: pci@1c00000 {
 			device_type = "pci";
 			compatible = "qcom,pcie-sm8550";

-- 
2.34.1

[PATCH v2 7/7] arm64: dts: qcom: sm8450: add TRNG node

[Neil Armstrong]

The SM8450 SoC has a True Random Number Generator, add the node with
the correct compatible set.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8450.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 6ae64059cea5..e267c6286b1a 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -1738,6 +1738,11 @@ spi14: spi@a98000 {
 			};
 		};
 
+		rng: rng@10c3000 {
+			compatible = "qcom,sm8450-trng", "qcom,trng";
+			reg = <0 0x010c3000 0 0x1000>;
+		};
+
 		pcie0: pci@1c00000 {
 			compatible = "qcom,pcie-sm8450-pcie0";
 			reg = <0 0x01c00000 0 0x3000>,

-- 
2.34.1

Re: [PATCH v2 1/7] Revert "dt-bindings: crypto: qcom,prng: Add SM8450"

[Konrad Dybcio]

On 24.08.2023 13:33, Neil Armstrong wrote:
> This reverts commit b9296bb41275 ("dt-bindings: crypto: qcom,prng: Add SM8450"),
> since the RNG HW on the SM8450 SoC is in fact a True Random Number Generator,
> a more appropriate compatible should be instead as reported at [1].
> 
> [1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/
> 
> Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

Re: [PATCH v2 2/7] Revert "arm64: dts: qcom: sm8450: Add PRNG"

[Konrad Dybcio]

On 24.08.2023 13:33, Neil Armstrong wrote:
> This reverts commit 76a6dd7bfcbb ("arm64: dts: qcom: sm8450: Add PRNG"),
> since the RNG HW on the SM8450 SoC is in fact a True Random Number Generator,
> a more appropriate compatible should be instead as reported at [1].
> 
> [1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/
> 
> Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

Re: [PATCH v2 6/7] arm64: dts: qcom: sm8550: add TRNG node

[Konrad Dybcio]

On 24.08.2023 13:33, Neil Armstrong wrote:
> Add the Qualcomm True Random Number Generator node.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

Re: [PATCH v2 7/7] arm64: dts: qcom: sm8450: add TRNG node

[Konrad Dybcio]

On 24.08.2023 13:33, Neil Armstrong wrote:
> The SM8450 SoC has a True Random Number Generator, add the node with
> the correct compatible set.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

Re: [PATCH v2 1/7] Revert "dt-bindings: crypto: qcom,prng: Add SM8450"

[Rob Herring]

On Thu, Aug 24, 2023 at 01:33:20PM +0200, Neil Armstrong wrote:
> This reverts commit b9296bb41275 ("dt-bindings: crypto: qcom,prng: Add SM8450"),
> since the RNG HW on the SM8450 SoC is in fact a True Random Number Generator,
> a more appropriate compatible should be instead as reported at [1].
> 
> [1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/
> 
> Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Is it just me or looks like an unrenderable character in these.

> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>  .../devicetree/bindings/crypto/qcom,prng.yaml      | 24 +++++-----------------
>  1 file changed, 5 insertions(+), 19 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> index 36b0ebd9a44b..bb42f4588b40 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> @@ -11,13 +11,9 @@ maintainers:
>  
>  properties:
>    compatible:
> -    oneOf:
> -      - enum:
> -          - qcom,prng  # 8916 etc.
> -          - qcom,prng-ee  # 8996 and later using EE
> -      - items:
> -          - const: qcom,sm8450-prng-ee
> -          - const: qcom,prng-ee
> +    enum:
> +      - qcom,prng  # 8916 etc.
> +      - qcom,prng-ee  # 8996 and later using EE
>  
>    reg:
>      maxItems: 1
> @@ -32,18 +28,8 @@ properties:
>  required:
>    - compatible
>    - reg
> -
> -allOf:
> -  - if:
> -      not:
> -        properties:
> -          compatible:
> -            contains:
> -              const: qcom,sm8450-prng-ee
> -    then:
> -      required:
> -        - clocks
> -        - clock-names
> +  - clocks
> +  - clock-names
>  
>  additionalProperties: false
>  
> 
> -- 
> 2.34.1
> 

Re: [PATCH v2 1/7] Revert "dt-bindings: crypto: qcom,prng: Add SM8450"

[Herbert Xu]

On Thu, Aug 24, 2023 at 01:33:20PM +0200, Neil Armstrong wrote:
> This reverts commit b9296bb41275 ("dt-bindings: crypto: qcom,prng: Add SM8450"),
> since the RNG HW on the SM8450 SoC is in fact a True Random Number Generator,
> a more appropriate compatible should be instead as reported at [1].
> 
> [1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/
> 
> Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>  .../devicetree/bindings/crypto/qcom,prng.yaml      | 24 +++++-----------------
>  1 file changed, 5 insertions(+), 19 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 3/7] dt-bindings: crypto: qcom,prng: document that RNG on SM8450 is a TRNG

[Om Prakash Singh]

On 8/24/2023 5:03 PM, Neil Armstrong wrote:
> It has been reported at [1] the RNG HW on SM8450 is in fact a True Random
> Number Generator and no more Pseudo, document this by adding
> a new qcom,trng and the corresponding SoC specific sm8450 compatible.
> 
> [1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/
> 
> Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Reviewed-by: Om Prakash Singh <quic_omprsing@quicinc.com>

Re: [PATCH v2 4/7] crypto: qcom-rng - Add support for trng

[Om Prakash Singh]

On 8/24/2023 5:03 PM, Neil Armstrong wrote:
> The SM8450 & later SoCs RNG HW is now a True Random Number Generator
> and a new compatible has been introduced to handle the difference.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Reviewed-by: Om Prakash Singh <quic_omprsing@quicinc.com>

Re: [PATCH v2 5/7] dt-bindings: crypto: qcom,prng: document SM8550

[Om Prakash Singh]

On 8/24/2023 5:03 PM, Neil Armstrong wrote:
> Document SM8550 compatible for the True Random Number Generator.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Reviewed-by: Om Prakash Singh <quic_omprsing@quicinc.com>

Re: [PATCH v2 1/7] Revert "dt-bindings: crypto: qcom,prng: Add SM8450"

[Om Prakash Singh]

On 8/25/2023 2:59 AM, Rob Herring wrote:
> On Thu, Aug 24, 2023 at 01:33:20PM +0200, Neil Armstrong wrote:
>> This reverts commit b9296bb41275 ("dt-bindings: crypto: qcom,prng: Add SM8450"),
>> since the RNG HW on the SM8450 SoC is in fact a True Random Number Generator,
>> a more appropriate compatible should be instead as reported at [1].
>>
>> [1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/
>>
>> Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> 
> Is it just me or looks like an unrenderable character in these.
Yes there are spacial character before Om and Konrad that should have 
been removed.
> 
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>>   .../devicetree/bindings/crypto/qcom,prng.yaml      | 24 +++++-----------------
>>   1 file changed, 5 insertions(+), 19 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>> index 36b0ebd9a44b..bb42f4588b40 100644
>> --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>> +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>> @@ -11,13 +11,9 @@ maintainers:
>>   
>>   properties:
>>     compatible:
>> -    oneOf:
>> -      - enum:
>> -          - qcom,prng  # 8916 etc.
>> -          - qcom,prng-ee  # 8996 and later using EE
>> -      - items:
>> -          - const: qcom,sm8450-prng-ee
>> -          - const: qcom,prng-ee
>> +    enum:
>> +      - qcom,prng  # 8916 etc.
>> +      - qcom,prng-ee  # 8996 and later using EE
>>   
>>     reg:
>>       maxItems: 1
>> @@ -32,18 +28,8 @@ properties:
>>   required:
>>     - compatible
>>     - reg
>> -
>> -allOf:
>> -  - if:
>> -      not:
>> -        properties:
>> -          compatible:
>> -            contains:
>> -              const: qcom,sm8450-prng-ee
>> -    then:
>> -      required:
>> -        - clocks
>> -        - clock-names
>> +  - clocks
>> +  - clock-names
>>   
>>   additionalProperties: false
>>   
>>
>> -- 
>> 2.34.1
>>

Re: [PATCH v2 1/7] Revert "dt-bindings: crypto: qcom,prng: Add SM8450"

[Neil Armstrong]

Hi,

On 28/08/2023 08:25, Om Prakash Singh wrote:
> 
> 
> On 8/25/2023 2:59 AM, Rob Herring wrote:
>> On Thu, Aug 24, 2023 at 01:33:20PM +0200, Neil Armstrong wrote:
>>> This reverts commit b9296bb41275 ("dt-bindings: crypto: qcom,prng: Add SM8450"),
>>> since the RNG HW on the SM8450 SoC is in fact a True Random Number Generator,
>>> a more appropriate compatible should be instead as reported at [1].
>>>
>>> [1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/
>>>
>>> Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
>>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>
>> Is it just me or looks like an unrenderable character in these.
> Yes there are spacial character before Om and Konrad that should have been removed.

Let me resend a v2 without this space and the review tags.

Neil

>>
>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>> ---
>>>   .../devicetree/bindings/crypto/qcom,prng.yaml      | 24 +++++-----------------
>>>   1 file changed, 5 insertions(+), 19 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>>> index 36b0ebd9a44b..bb42f4588b40 100644
>>> --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>>> +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>>> @@ -11,13 +11,9 @@ maintainers:
>>>   properties:
>>>     compatible:
>>> -    oneOf:
>>> -      - enum:
>>> -          - qcom,prng  # 8916 etc.
>>> -          - qcom,prng-ee  # 8996 and later using EE
>>> -      - items:
>>> -          - const: qcom,sm8450-prng-ee
>>> -          - const: qcom,prng-ee
>>> +    enum:
>>> +      - qcom,prng  # 8916 etc.
>>> +      - qcom,prng-ee  # 8996 and later using EE
>>>     reg:
>>>       maxItems: 1
>>> @@ -32,18 +28,8 @@ properties:
>>>   required:
>>>     - compatible
>>>     - reg
>>> -
>>> -allOf:
>>> -  - if:
>>> -      not:
>>> -        properties:
>>> -          compatible:
>>> -            contains:
>>> -              const: qcom,sm8450-prng-ee
>>> -    then:
>>> -      required:
>>> -        - clocks
>>> -        - clock-names
>>> +  - clocks
>>> +  - clock-names
>>>   additionalProperties: false
>>>
>>> -- 
>>> 2.34.1
>>>

Re: [PATCH v2 4/7] crypto: qcom-rng - Add support for trng

[Om Prakash Singh]

I missed to notice. Please correct "-" to ":" in subject line

On 8/28/2023 10:29 AM, Om Prakash Singh wrote:
> 
> 
> On 8/24/2023 5:03 PM, Neil Armstrong wrote:
>> The SM8450 & later SoCs RNG HW is now a True Random Number Generator
>> and a new compatible has been introduced to handle the difference.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
> Reviewed-by: Om Prakash Singh <quic_omprsing@quicinc.com>

Re: [PATCH v2 4/7] crypto: qcom-rng - Add support for trng

[Krzysztof Kozlowski]

On 01/09/2023 14:56, Om Prakash Singh wrote:
> I missed to notice. Please correct "-" to ":" in subject line

Hm? What do you want to correct? The subject prefix is correct, why do
you ask to change it?

Best regards,
Krzysztof

Re: [PATCH v2 4/7] crypto: qcom-rng - Add support for trng

[Om Prakash Singh]

On 9/3/2023 11:03 PM, Krzysztof Kozlowski wrote:
> On 01/09/2023 14:56, Om Prakash Singh wrote:
>> I missed to notice. Please correct "-" to ":" in subject line
> 
> Hm? What do you want to correct? The subject prefix is correct, why do
> you ask to change it?
Previous applied patch using different subject line format-

"crypto: qcom-rng: Make the core clock optional regardless of ACPI presence"

But looks like What Neil is using is the right way, looking at change 
log for the file.

> 
> Best regards,
> Krzysztof
>