* [PATCH -next] net: mlx5: Kconfig: Fix MLX5_CORE_EN dependencies
@ 2019-08-27 3:12 ` Mao Wenan
0 siblings, 0 replies; 12+ messages in thread
From: Mao Wenan @ 2019-08-27 3:12 UTC (permalink / raw)
To: saeedm, leon, davem
Cc: netdev, linux-rdma, linux-kernel, kernel-janitors, Mao Wenan
When MLX5_CORE_EN=y and PCI_HYPERV_INTERFACE is not set, below errors are found:
drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function `mlx5e_nic_enable':
en_main.c:(.text+0xb649): undefined reference to `mlx5e_hv_vhca_stats_create'
drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function `mlx5e_nic_disable':
en_main.c:(.text+0xb8c4): undefined reference to `mlx5e_hv_vhca_stats_destroy'
This because CONFIG_PCI_HYPERV_INTERFACE is newly introduced by 'commit 348dd93e40c1
("PCI: hv: Add a Hyper-V PCI interface driver for software backchannel interface"),
Fix this by making MLX5_CORE_EN imply PCI_HYPERV_INTERFACE.
Fixes: cef35af34d6d ("net/mlx5e: Add mlx5e HV VHCA stats agent")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
index 37fef8c..a6a70ce 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
+++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
@@ -35,6 +35,7 @@ config MLX5_CORE_EN
depends on IPV6=y || IPV6=n || MLX5_CORE=m
select PAGE_POOL
select DIMLIB
+ imply PCI_HYPERV_INTERFACE
default n
---help---
Ethernet support in Mellanox Technologies ConnectX-4 NIC.
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH -next] net: mlx5: Kconfig: Fix MLX5_CORE_EN dependencies
@ 2019-08-27 3:12 ` Mao Wenan
0 siblings, 0 replies; 12+ messages in thread
From: Mao Wenan @ 2019-08-27 3:12 UTC (permalink / raw)
To: saeedm, leon, davem
Cc: netdev, linux-rdma, linux-kernel, kernel-janitors, Mao Wenan
When MLX5_CORE_EN=y and PCI_HYPERV_INTERFACE is not set, below errors are found:
drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function `mlx5e_nic_enable':
en_main.c:(.text+0xb649): undefined reference to `mlx5e_hv_vhca_stats_create'
drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function `mlx5e_nic_disable':
en_main.c:(.text+0xb8c4): undefined reference to `mlx5e_hv_vhca_stats_destroy'
This because CONFIG_PCI_HYPERV_INTERFACE is newly introduced by 'commit 348dd93e40c1
("PCI: hv: Add a Hyper-V PCI interface driver for software backchannel interface"),
Fix this by making MLX5_CORE_EN imply PCI_HYPERV_INTERFACE.
Fixes: cef35af34d6d ("net/mlx5e: Add mlx5e HV VHCA stats agent")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
index 37fef8c..a6a70ce 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
+++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
@@ -35,6 +35,7 @@ config MLX5_CORE_EN
depends on IPV6=y || IPV6=n || MLX5_CORE=m
select PAGE_POOL
select DIMLIB
+ imply PCI_HYPERV_INTERFACE
default n
---help---
Ethernet support in Mellanox Technologies ConnectX-4 NIC.
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH -next] net: mlx5: Kconfig: Fix MLX5_CORE_EN dependencies
2019-08-27 3:12 ` Mao Wenan
@ 2019-08-27 7:24 ` walter harms
-1 siblings, 0 replies; 12+ messages in thread
From: walter harms @ 2019-08-27 7:24 UTC (permalink / raw)
To: Mao Wenan
Cc: saeedm, leon, davem, netdev, linux-rdma, linux-kernel, kernel-janitors
Am 27.08.2019 05:12, schrieb Mao Wenan:
> When MLX5_CORE_EN=y and PCI_HYPERV_INTERFACE is not set, below errors are found:
> drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function `mlx5e_nic_enable':
> en_main.c:(.text+0xb649): undefined reference to `mlx5e_hv_vhca_stats_create'
> drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function `mlx5e_nic_disable':
> en_main.c:(.text+0xb8c4): undefined reference to `mlx5e_hv_vhca_stats_destroy'
>
> This because CONFIG_PCI_HYPERV_INTERFACE is newly introduced by 'commit 348dd93e40c1
> ("PCI: hv: Add a Hyper-V PCI interface driver for software backchannel interface"),
> Fix this by making MLX5_CORE_EN imply PCI_HYPERV_INTERFACE.
>
> Fixes: cef35af34d6d ("net/mlx5e: Add mlx5e HV VHCA stats agent")
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> index 37fef8c..a6a70ce 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> @@ -35,6 +35,7 @@ config MLX5_CORE_EN
> depends on IPV6=y || IPV6=n || MLX5_CORE=m
OT but ...
is that IPV6 needed at all ? can there be something else that yes or no ?
re,
wh
> select PAGE_POOL
> select DIMLIB
> + imply PCI_HYPERV_INTERFACE
> default n
> ---help---
> Ethernet support in Mellanox Technologies ConnectX-4 NIC.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH -next] net: mlx5: Kconfig: Fix MLX5_CORE_EN dependencies
@ 2019-08-27 7:24 ` walter harms
0 siblings, 0 replies; 12+ messages in thread
From: walter harms @ 2019-08-27 7:24 UTC (permalink / raw)
To: Mao Wenan
Cc: saeedm, leon, davem, netdev, linux-rdma, linux-kernel, kernel-janitors
Am 27.08.2019 05:12, schrieb Mao Wenan:
> When MLX5_CORE_EN=y and PCI_HYPERV_INTERFACE is not set, below errors are found:
> drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function `mlx5e_nic_enable':
> en_main.c:(.text+0xb649): undefined reference to `mlx5e_hv_vhca_stats_create'
> drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function `mlx5e_nic_disable':
> en_main.c:(.text+0xb8c4): undefined reference to `mlx5e_hv_vhca_stats_destroy'
>
> This because CONFIG_PCI_HYPERV_INTERFACE is newly introduced by 'commit 348dd93e40c1
> ("PCI: hv: Add a Hyper-V PCI interface driver for software backchannel interface"),
> Fix this by making MLX5_CORE_EN imply PCI_HYPERV_INTERFACE.
>
> Fixes: cef35af34d6d ("net/mlx5e: Add mlx5e HV VHCA stats agent")
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> index 37fef8c..a6a70ce 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> @@ -35,6 +35,7 @@ config MLX5_CORE_EN
> depends on IPV6=y || IPV6=n || MLX5_CORE=m
OT but ...
is that IPV6 needed at all ? can there be something else that yes or no ?
re,
wh
> select PAGE_POOL
> select DIMLIB
> + imply PCI_HYPERV_INTERFACE
> default n
> ---help---
> Ethernet support in Mellanox Technologies ConnectX-4 NIC.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH -next] net: mlx5: Kconfig: Fix MLX5_CORE_EN dependencies
2019-08-27 7:24 ` walter harms
@ 2019-08-27 9:51 ` maowenan
-1 siblings, 0 replies; 12+ messages in thread
From: maowenan @ 2019-08-27 9:51 UTC (permalink / raw)
To: wharms
Cc: saeedm, leon, davem, netdev, linux-rdma, linux-kernel, kernel-janitors
On 2019/8/27 15:24, walter harms wrote:
>
>
> Am 27.08.2019 05:12, schrieb Mao Wenan:
>> When MLX5_CORE_EN=y and PCI_HYPERV_INTERFACE is not set, below errors are found:
>> drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function `mlx5e_nic_enable':
>> en_main.c:(.text+0xb649): undefined reference to `mlx5e_hv_vhca_stats_create'
>> drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function `mlx5e_nic_disable':
>> en_main.c:(.text+0xb8c4): undefined reference to `mlx5e_hv_vhca_stats_destroy'
>>
>> This because CONFIG_PCI_HYPERV_INTERFACE is newly introduced by 'commit 348dd93e40c1
>> ("PCI: hv: Add a Hyper-V PCI interface driver for software backchannel interface"),
>> Fix this by making MLX5_CORE_EN imply PCI_HYPERV_INTERFACE.
>>
>> Fixes: cef35af34d6d ("net/mlx5e: Add mlx5e HV VHCA stats agent")
>> Signed-off-by: Mao Wenan <maowenan@huawei.com>
>> ---
>> drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
>> index 37fef8c..a6a70ce 100644
>> --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
>> @@ -35,6 +35,7 @@ config MLX5_CORE_EN
>> depends on IPV6=y || IPV6=n || MLX5_CORE=m
>
> OT but ...
> is that IPV6 needed at all ? can there be something else that yes or no ?
If I set IPV6=m, errors are found as below:
drivers/net/ethernet/mellanox/mlx5/core/main.o: In function `mlx5_unload':
main.c:(.text+0x275): undefined reference to `mlx5_hv_vhca_cleanup'
drivers/net/ethernet/mellanox/mlx5/core/main.o: In function `mlx5_cleanup_once':
main.c:(.text+0x2e8): undefined reference to `mlx5_hv_vhca_destroy'
drivers/net/ethernet/mellanox/mlx5/core/main.o: In function `mlx5_load_one':
main.c:(.text+0x23c1): undefined reference to `mlx5_hv_vhca_create'
main.c:(.text+0x248f): undefined reference to `mlx5_hv_vhca_init'
main.c:(.text+0x25e0): undefined reference to `mlx5_hv_vhca_cleanup
>
> re,
> wh
>
>> select PAGE_POOL
>> select DIMLIB
>> + imply PCI_HYPERV_INTERFACE
>> default n
>> ---help---
>> Ethernet support in Mellanox Technologies ConnectX-4 NIC.
>
> .
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH -next] net: mlx5: Kconfig: Fix MLX5_CORE_EN dependencies
@ 2019-08-27 9:51 ` maowenan
0 siblings, 0 replies; 12+ messages in thread
From: maowenan @ 2019-08-27 9:51 UTC (permalink / raw)
To: wharms
Cc: saeedm, leon, davem, netdev, linux-rdma, linux-kernel, kernel-janitors
On 2019/8/27 15:24, walter harms wrote:
>
>
> Am 27.08.2019 05:12, schrieb Mao Wenan:
>> When MLX5_CORE_EN=y and PCI_HYPERV_INTERFACE is not set, below errors are found:
>> drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function `mlx5e_nic_enable':
>> en_main.c:(.text+0xb649): undefined reference to `mlx5e_hv_vhca_stats_create'
>> drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function `mlx5e_nic_disable':
>> en_main.c:(.text+0xb8c4): undefined reference to `mlx5e_hv_vhca_stats_destroy'
>>
>> This because CONFIG_PCI_HYPERV_INTERFACE is newly introduced by 'commit 348dd93e40c1
>> ("PCI: hv: Add a Hyper-V PCI interface driver for software backchannel interface"),
>> Fix this by making MLX5_CORE_EN imply PCI_HYPERV_INTERFACE.
>>
>> Fixes: cef35af34d6d ("net/mlx5e: Add mlx5e HV VHCA stats agent")
>> Signed-off-by: Mao Wenan <maowenan@huawei.com>
>> ---
>> drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
>> index 37fef8c..a6a70ce 100644
>> --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
>> @@ -35,6 +35,7 @@ config MLX5_CORE_EN
>> depends on IPV6=y || IPV6=n || MLX5_CORE=m
>
> OT but ...
> is that IPV6 needed at all ? can there be something else that yes or no ?
If I set IPV6=m, errors are found as below:
drivers/net/ethernet/mellanox/mlx5/core/main.o: In function `mlx5_unload':
main.c:(.text+0x275): undefined reference to `mlx5_hv_vhca_cleanup'
drivers/net/ethernet/mellanox/mlx5/core/main.o: In function `mlx5_cleanup_once':
main.c:(.text+0x2e8): undefined reference to `mlx5_hv_vhca_destroy'
drivers/net/ethernet/mellanox/mlx5/core/main.o: In function `mlx5_load_one':
main.c:(.text+0x23c1): undefined reference to `mlx5_hv_vhca_create'
main.c:(.text+0x248f): undefined reference to `mlx5_hv_vhca_init'
main.c:(.text+0x25e0): undefined reference to `mlx5_hv_vhca_cleanup
>
> re,
> wh
>
>> select PAGE_POOL
>> select DIMLIB
>> + imply PCI_HYPERV_INTERFACE
>> default n
>> ---help---
>> Ethernet support in Mellanox Technologies ConnectX-4 NIC.
>
> .
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH -next] net: mlx5: Kconfig: Fix MLX5_CORE_EN dependencies
2019-08-27 3:12 ` Mao Wenan
@ 2019-08-27 20:14 ` Saeed Mahameed
-1 siblings, 0 replies; 12+ messages in thread
From: Saeed Mahameed @ 2019-08-27 20:14 UTC (permalink / raw)
To: davem, maowenan, leon; +Cc: kernel-janitors, netdev, linux-rdma, linux-kernel
On Tue, 2019-08-27 at 11:12 +0800, Mao Wenan wrote:
> When MLX5_CORE_EN=y and PCI_HYPERV_INTERFACE is not set, below errors
> are found:
> drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function
> `mlx5e_nic_enable':
> en_main.c:(.text+0xb649): undefined reference to
> `mlx5e_hv_vhca_stats_create'
> drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function
> `mlx5e_nic_disable':
> en_main.c:(.text+0xb8c4): undefined reference to
> `mlx5e_hv_vhca_stats_destroy'
>
> This because CONFIG_PCI_HYPERV_INTERFACE is newly introduced by
> 'commit 348dd93e40c1
> ("PCI: hv: Add a Hyper-V PCI interface driver for software
> backchannel interface"),
> Fix this by making MLX5_CORE_EN imply PCI_HYPERV_INTERFACE.
>
let's not imply anything..
mlx5e_hv_vhca_* should already have stubs in
mlx5/core/en/hv_vhca_stat.h when PCI_HYPERV_INTERFACE is off/undef !
I Just tried:
$ ./scripts/config -s PCI_HYPERV_INTERFACE
$ ./scripts/config -s MLX5_CORE
$ ./scripts/config -s MLX5_CORE_EN
undef
y
y
$ make
And build passed just fine.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH -next] net: mlx5: Kconfig: Fix MLX5_CORE_EN dependencies
@ 2019-08-27 20:14 ` Saeed Mahameed
0 siblings, 0 replies; 12+ messages in thread
From: Saeed Mahameed @ 2019-08-27 20:14 UTC (permalink / raw)
To: davem, maowenan, leon; +Cc: kernel-janitors, netdev, linux-rdma, linux-kernel
T24gVHVlLCAyMDE5LTA4LTI3IGF0IDExOjEyICswODAwLCBNYW8gV2VuYW4gd3JvdGU6DQo+IFdo
ZW4gTUxYNV9DT1JFX0VOPXkgYW5kIFBDSV9IWVBFUlZfSU5URVJGQUNFIGlzIG5vdCBzZXQsIGJl
bG93IGVycm9ycw0KPiBhcmUgZm91bmQ6DQo+IGRyaXZlcnMvbmV0L2V0aGVybmV0L21lbGxhbm94
L21seDUvY29yZS9lbl9tYWluLm86IEluIGZ1bmN0aW9uDQo+IGBtbHg1ZV9uaWNfZW5hYmxlJzoN
Cj4gZW5fbWFpbi5jOigudGV4dCsweGI2NDkpOiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvDQo+IGBt
bHg1ZV9odl92aGNhX3N0YXRzX2NyZWF0ZScNCj4gZHJpdmVycy9uZXQvZXRoZXJuZXQvbWVsbGFu
b3gvbWx4NS9jb3JlL2VuX21haW4ubzogSW4gZnVuY3Rpb24NCj4gYG1seDVlX25pY19kaXNhYmxl
JzoNCj4gZW5fbWFpbi5jOigudGV4dCsweGI4YzQpOiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvDQo+
IGBtbHg1ZV9odl92aGNhX3N0YXRzX2Rlc3Ryb3knDQo+IA0KPiBUaGlzIGJlY2F1c2UgQ09ORklH
X1BDSV9IWVBFUlZfSU5URVJGQUNFIGlzIG5ld2x5IGludHJvZHVjZWQgYnkNCj4gJ2NvbW1pdCAz
NDhkZDkzZTQwYzENCj4gKCJQQ0k6IGh2OiBBZGQgYSBIeXBlci1WIFBDSSBpbnRlcmZhY2UgZHJp
dmVyIGZvciBzb2Z0d2FyZQ0KPiBiYWNrY2hhbm5lbCBpbnRlcmZhY2UiKSwNCj4gRml4IHRoaXMg
YnkgbWFraW5nIE1MWDVfQ09SRV9FTiBpbXBseSBQQ0lfSFlQRVJWX0lOVEVSRkFDRS4NCj4gDQoN
CmxldCdzIG5vdCBpbXBseSBhbnl0aGluZy4uIA0KbWx4NWVfaHZfdmhjYV8qIHNob3VsZCBhbHJl
YWR5IGhhdmUgc3R1YnMgIGluIA0KbWx4NS9jb3JlL2VuL2h2X3ZoY2Ffc3RhdC5oIHdoZW4gUENJ
X0hZUEVSVl9JTlRFUkZBQ0UgaXMgb2ZmL3VuZGVmICENCg0KSSBKdXN0IHRyaWVkOg0KDQokIC4v
c2NyaXB0cy9jb25maWcgLXMgUENJX0hZUEVSVl9JTlRFUkZBQ0UNCiQgLi9zY3JpcHRzL2NvbmZp
ZyAtcyBNTFg1X0NPUkUNCiQgLi9zY3JpcHRzL2NvbmZpZyAtcyBNTFg1X0NPUkVfRU4NCnVuZGVm
DQp5DQp5DQoNCiQgbWFrZQ0KDQpBbmQgYnVpbGQgcGFzc2VkIGp1c3QgZmluZS4NCg0KDQo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH -next] net: mlx5: Kconfig: Fix MLX5_CORE_EN dependencies
2019-08-27 9:51 ` maowenan
@ 2019-08-27 21:15 ` Saeed Mahameed
-1 siblings, 0 replies; 12+ messages in thread
From: Saeed Mahameed @ 2019-08-27 21:15 UTC (permalink / raw)
To: wharms, maowenan
Cc: linux-rdma, kernel-janitors, davem, netdev, leon, linux-kernel
On Tue, 2019-08-27 at 17:51 +0800, maowenan wrote:
>
> On 2019/8/27 15:24, walter harms wrote:
> >
> > Am 27.08.2019 05:12, schrieb Mao Wenan:
> > > When MLX5_CORE_EN=y and PCI_HYPERV_INTERFACE is not set, below
> > > errors are found:
> > > drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function
> > > `mlx5e_nic_enable':
> > > en_main.c:(.text+0xb649): undefined reference to
> > > `mlx5e_hv_vhca_stats_create'
> > > drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function
> > > `mlx5e_nic_disable':
> > > en_main.c:(.text+0xb8c4): undefined reference to
> > > `mlx5e_hv_vhca_stats_destroy'
> > >
> > > This because CONFIG_PCI_HYPERV_INTERFACE is newly introduced by
> > > 'commit 348dd93e40c1
> > > ("PCI: hv: Add a Hyper-V PCI interface driver for software
> > > backchannel interface"),
> > > Fix this by making MLX5_CORE_EN imply PCI_HYPERV_INTERFACE.
> > >
> > > Fixes: cef35af34d6d ("net/mlx5e: Add mlx5e HV VHCA stats agent")
> > > Signed-off-by: Mao Wenan <maowenan@huawei.com>
> > > ---
> > > drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> > > b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> > > index 37fef8c..a6a70ce 100644
> > > --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
> > > @@ -35,6 +35,7 @@ config MLX5_CORE_EN
> > > depends on IPV6=y || IPV6=n || MLX5_CORE=m
> >
> > OT but ...
> > is that IPV6 needed at all ? can there be something else that yes
> > or no ?
only needed for en_rep.c/en_tc.c which are only compiled when
MLX5_ESWITCH is selected, so actually such condition should be for
MLX5_ESWITCH and not MLX5_CORE_EN
tested with:
MLX5_CORE=y
MLX5_CORE_EN=y
IPV6=m
and removed the dependency.
so if ipv6 is a module but mlx5 is builtin this will happen..
ld: drivers/net/ethernet/mellanox/mlx5/core/en_rep.o: in function
`mlx5e_rep_neigh_update_init_interval':
/home/saeedm/devel/linux/drivers/net/ethernet/mellanox/mlx5/core/en_rep
.c:505: undefined reference to `nd_tbl'
ld: drivers/net/ethernet/mellanox/mlx5/core/en_rep.o: in function
`mlx5e_rep_netevent_event':
/home/saeedm/devel/linux/drivers/net/ethernet/mellanox/mlx5/core/en_rep
.c:946: undefined reference to `nd_tbl'
ld:
/home/saeedm/devel/linux/drivers/net/ethernet/mellanox/mlx5/core/en_rep
.c:919: undefined reference to `nd_tbl'
ld: drivers/net/ethernet/mellanox/mlx5/core/en_tc.o: in function
`mlx5e_tc_update_neigh_used_value':
/home/saeedm/devel/linux/drivers/net/ethernet/mellanox/mlx5/core/en_tc.
c:1497: undefined reference to `nd_tbl'
the problem is that mlx5_core can't be builtin if ipv6 is a module due
to this nd_tbl dependency
I think this is solvable by using ipv6_stub->nd_tbl, instead of
referencing md_tbl directly from mlx5.
>
> If I set IPV6=m, errors are found as below:
> drivers/net/ethernet/mellanox/mlx5/core/main.o: In function
> `mlx5_unload':
> main.c:(.text+0x275): undefined reference to `mlx5_hv_vhca_cleanup'
> drivers/net/ethernet/mellanox/mlx5/core/main.o: In function
> `mlx5_cleanup_once':
> main.c:(.text+0x2e8): undefined reference to `mlx5_hv_vhca_destroy'
> drivers/net/ethernet/mellanox/mlx5/core/main.o: In function
> `mlx5_load_one':
> main.c:(.text+0x23c1): undefined reference to `mlx5_hv_vhca_create'
> main.c:(.text+0x248f): undefined reference to `mlx5_hv_vhca_init'
> main.c:(.text+0x25e0): undefined reference to `mlx5_hv_vhca_cleanup
this is not related, i think there is something wrong with your local
repository.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH -next] net: mlx5: Kconfig: Fix MLX5_CORE_EN dependencies
@ 2019-08-27 21:15 ` Saeed Mahameed
0 siblings, 0 replies; 12+ messages in thread
From: Saeed Mahameed @ 2019-08-27 21:15 UTC (permalink / raw)
To: wharms, maowenan
Cc: linux-rdma, kernel-janitors, davem, netdev, leon, linux-kernel
T24gVHVlLCAyMDE5LTA4LTI3IGF0IDE3OjUxICswODAwLCBtYW93ZW5hbiB3cm90ZToNCj4gDQo+
IE9uIDIwMTkvOC8yNyAxNToyNCwgd2FsdGVyIGhhcm1zIHdyb3RlOg0KPiA+IA0KPiA+IEFtIDI3
LjA4LjIwMTkgMDU6MTIsIHNjaHJpZWIgTWFvIFdlbmFuOg0KPiA+ID4gV2hlbiBNTFg1X0NPUkVf
RU49eSBhbmQgUENJX0hZUEVSVl9JTlRFUkZBQ0UgaXMgbm90IHNldCwgYmVsb3cNCj4gPiA+IGVy
cm9ycyBhcmUgZm91bmQ6DQo+ID4gPiBkcml2ZXJzL25ldC9ldGhlcm5ldC9tZWxsYW5veC9tbHg1
L2NvcmUvZW5fbWFpbi5vOiBJbiBmdW5jdGlvbg0KPiA+ID4gYG1seDVlX25pY19lbmFibGUnOg0K
PiA+ID4gZW5fbWFpbi5jOigudGV4dCsweGI2NDkpOiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvDQo+
ID4gPiBgbWx4NWVfaHZfdmhjYV9zdGF0c19jcmVhdGUnDQo+ID4gPiBkcml2ZXJzL25ldC9ldGhl
cm5ldC9tZWxsYW5veC9tbHg1L2NvcmUvZW5fbWFpbi5vOiBJbiBmdW5jdGlvbg0KPiA+ID4gYG1s
eDVlX25pY19kaXNhYmxlJzoNCj4gPiA+IGVuX21haW4uYzooLnRleHQrMHhiOGM0KTogdW5kZWZp
bmVkIHJlZmVyZW5jZSB0bw0KPiA+ID4gYG1seDVlX2h2X3ZoY2Ffc3RhdHNfZGVzdHJveScNCj4g
PiA+IA0KPiA+ID4gVGhpcyBiZWNhdXNlIENPTkZJR19QQ0lfSFlQRVJWX0lOVEVSRkFDRSBpcyBu
ZXdseSBpbnRyb2R1Y2VkIGJ5DQo+ID4gPiAnY29tbWl0IDM0OGRkOTNlNDBjMQ0KPiA+ID4gKCJQ
Q0k6IGh2OiBBZGQgYSBIeXBlci1WIFBDSSBpbnRlcmZhY2UgZHJpdmVyIGZvciBzb2Z0d2FyZQ0K
PiA+ID4gYmFja2NoYW5uZWwgaW50ZXJmYWNlIiksDQo+ID4gPiBGaXggdGhpcyBieSBtYWtpbmcg
TUxYNV9DT1JFX0VOIGltcGx5IFBDSV9IWVBFUlZfSU5URVJGQUNFLg0KPiA+ID4gDQo+ID4gPiBG
aXhlczogY2VmMzVhZjM0ZDZkICgibmV0L21seDVlOiBBZGQgbWx4NWUgSFYgVkhDQSBzdGF0cyBh
Z2VudCIpDQo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBNYW8gV2VuYW4gPG1hb3dlbmFuQGh1YXdlaS5j
b20+DQo+ID4gPiAtLS0NCj4gPiA+ICBkcml2ZXJzL25ldC9ldGhlcm5ldC9tZWxsYW5veC9tbHg1
L2NvcmUvS2NvbmZpZyB8IDEgKw0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr
KQ0KPiA+ID4gDQo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvbWVsbGFu
b3gvbWx4NS9jb3JlL0tjb25maWcNCj4gPiA+IGIvZHJpdmVycy9uZXQvZXRoZXJuZXQvbWVsbGFu
b3gvbWx4NS9jb3JlL0tjb25maWcNCj4gPiA+IGluZGV4IDM3ZmVmOGMuLmE2YTcwY2UgMTAwNjQ0
DQo+ID4gPiAtLS0gYS9kcml2ZXJzL25ldC9ldGhlcm5ldC9tZWxsYW5veC9tbHg1L2NvcmUvS2Nv
bmZpZw0KPiA+ID4gKysrIGIvZHJpdmVycy9uZXQvZXRoZXJuZXQvbWVsbGFub3gvbWx4NS9jb3Jl
L0tjb25maWcNCj4gPiA+IEBAIC0zNSw2ICszNSw3IEBAIGNvbmZpZyBNTFg1X0NPUkVfRU4NCj4g
PiA+ICAJZGVwZW5kcyBvbiBJUFY2PXkgfHwgSVBWNj1uIHx8IE1MWDVfQ09SRT1tDQo+ID4gDQo+
ID4gT1QgYnV0IC4uLg0KPiA+IGlzIHRoYXQgSVBWNiBuZWVkZWQgYXQgYWxsID8gY2FuIHRoZXJl
IGJlIHNvbWV0aGluZyBlbHNlIHRoYXQgeWVzDQo+ID4gb3Igbm8gPw0KDQpvbmx5IG5lZWRlZCBm
b3IgZW5fcmVwLmMvZW5fdGMuYyB3aGljaCBhcmUgb25seSBjb21waWxlZCB3aGVuDQpNTFg1X0VT
V0lUQ0ggaXMgc2VsZWN0ZWQsIHNvIGFjdHVhbGx5IHN1Y2ggY29uZGl0aW9uIHNob3VsZCBiZSBm
b3INCk1MWDVfRVNXSVRDSCBhbmQgbm90IE1MWDVfQ09SRV9FTg0KDQp0ZXN0ZWQgd2l0aDoNCk1M
WDVfQ09SRT15DQpNTFg1X0NPUkVfRU49eQ0KSVBWNj1tDQoNCmFuZCByZW1vdmVkIHRoZSBkZXBl
bmRlbmN5Lg0Kc28gaWYgaXB2NiBpcyBhIG1vZHVsZSBidXQgbWx4NSBpcyBidWlsdGluIHRoaXMg
d2lsbCBoYXBwZW4uLiANCg0KbGQ6IGRyaXZlcnMvbmV0L2V0aGVybmV0L21lbGxhbm94L21seDUv
Y29yZS9lbl9yZXAubzogaW4gZnVuY3Rpb24NCmBtbHg1ZV9yZXBfbmVpZ2hfdXBkYXRlX2luaXRf
aW50ZXJ2YWwnOg0KL2hvbWUvc2FlZWRtL2RldmVsL2xpbnV4L2RyaXZlcnMvbmV0L2V0aGVybmV0
L21lbGxhbm94L21seDUvY29yZS9lbl9yZXANCi5jOjUwNTogdW5kZWZpbmVkIHJlZmVyZW5jZSB0
byBgbmRfdGJsJw0KbGQ6IGRyaXZlcnMvbmV0L2V0aGVybmV0L21lbGxhbm94L21seDUvY29yZS9l
bl9yZXAubzogaW4gZnVuY3Rpb24NCmBtbHg1ZV9yZXBfbmV0ZXZlbnRfZXZlbnQnOg0KL2hvbWUv
c2FlZWRtL2RldmVsL2xpbnV4L2RyaXZlcnMvbmV0L2V0aGVybmV0L21lbGxhbm94L21seDUvY29y
ZS9lbl9yZXANCi5jOjk0NjogdW5kZWZpbmVkIHJlZmVyZW5jZSB0byBgbmRfdGJsJw0KbGQ6DQov
aG9tZS9zYWVlZG0vZGV2ZWwvbGludXgvZHJpdmVycy9uZXQvZXRoZXJuZXQvbWVsbGFub3gvbWx4
NS9jb3JlL2VuX3JlcA0KLmM6OTE5OiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBuZF90YmwnDQps
ZDogZHJpdmVycy9uZXQvZXRoZXJuZXQvbWVsbGFub3gvbWx4NS9jb3JlL2VuX3RjLm86IGluIGZ1
bmN0aW9uDQpgbWx4NWVfdGNfdXBkYXRlX25laWdoX3VzZWRfdmFsdWUnOg0KL2hvbWUvc2FlZWRt
L2RldmVsL2xpbnV4L2RyaXZlcnMvbmV0L2V0aGVybmV0L21lbGxhbm94L21seDUvY29yZS9lbl90
Yy4NCmM6MTQ5NzogdW5kZWZpbmVkIHJlZmVyZW5jZSB0byBgbmRfdGJsJw0KDQp0aGUgcHJvYmxl
bSBpcyB0aGF0IG1seDVfY29yZSBjYW4ndCBiZSBidWlsdGluIGlmIGlwdjYgaXMgYSBtb2R1bGUg
ZHVlDQp0byB0aGlzIG5kX3RibCBkZXBlbmRlbmN5IA0KDQpJIHRoaW5rIHRoaXMgaXMgc29sdmFi
bGUgYnkgdXNpbmcgaXB2Nl9zdHViLT5uZF90YmwsIGluc3RlYWQgb2YNCnJlZmVyZW5jaW5nIG1k
X3RibCBkaXJlY3RseSBmcm9tIG1seDUuDQoNCj4gDQo+IElmIEkgc2V0IElQVjY9bSwgZXJyb3Jz
IGFyZSBmb3VuZCBhcyBiZWxvdzoNCj4gZHJpdmVycy9uZXQvZXRoZXJuZXQvbWVsbGFub3gvbWx4
NS9jb3JlL21haW4ubzogSW4gZnVuY3Rpb24NCj4gYG1seDVfdW5sb2FkJzoNCj4gbWFpbi5jOigu
dGV4dCsweDI3NSk6IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8gYG1seDVfaHZfdmhjYV9jbGVhbnVw
Jw0KPiBkcml2ZXJzL25ldC9ldGhlcm5ldC9tZWxsYW5veC9tbHg1L2NvcmUvbWFpbi5vOiBJbiBm
dW5jdGlvbg0KPiBgbWx4NV9jbGVhbnVwX29uY2UnOg0KPiBtYWluLmM6KC50ZXh0KzB4MmU4KTog
dW5kZWZpbmVkIHJlZmVyZW5jZSB0byBgbWx4NV9odl92aGNhX2Rlc3Ryb3knDQo+IGRyaXZlcnMv
bmV0L2V0aGVybmV0L21lbGxhbm94L21seDUvY29yZS9tYWluLm86IEluIGZ1bmN0aW9uDQo+IGBt
bHg1X2xvYWRfb25lJzoNCj4gbWFpbi5jOigudGV4dCsweDIzYzEpOiB1bmRlZmluZWQgcmVmZXJl
bmNlIHRvIGBtbHg1X2h2X3ZoY2FfY3JlYXRlJw0KPiBtYWluLmM6KC50ZXh0KzB4MjQ4Zik6IHVu
ZGVmaW5lZCByZWZlcmVuY2UgdG8gYG1seDVfaHZfdmhjYV9pbml0Jw0KPiBtYWluLmM6KC50ZXh0
KzB4MjVlMCk6IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8gYG1seDVfaHZfdmhjYV9jbGVhbnVwDQoN
CnRoaXMgaXMgbm90IHJlbGF0ZWQsIGkgdGhpbmsgdGhlcmUgaXMgc29tZXRoaW5nIHdyb25nIHdp
dGggeW91ciBsb2NhbA0KcmVwb3NpdG9yeS4NCg0K
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH -next] net: mlx5: Kconfig: Fix MLX5_CORE_EN dependencies
2019-08-27 3:12 ` Mao Wenan
@ 2019-08-30 21:43 ` Saeed Mahameed
-1 siblings, 0 replies; 12+ messages in thread
From: Saeed Mahameed @ 2019-08-30 21:43 UTC (permalink / raw)
To: davem, maowenan, leon; +Cc: kernel-janitors, netdev, linux-rdma, linux-kernel
On Tue, 2019-08-27 at 11:12 +0800, Mao Wenan wrote:
> When MLX5_CORE_EN=y and PCI_HYPERV_INTERFACE is not set, below errors
The issue happens when PCI_HYPERV_INTERFACE is a module and mlx5_core
is built-in.
> are found:
> drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function
> `mlx5e_nic_enable':
> en_main.c:(.text+0xb649): undefined reference to
> `mlx5e_hv_vhca_stats_create'
> drivers/net/ethernet/mellanox/mlx5/core/en_main.o: In function
> `mlx5e_nic_disable':
> en_main.c:(.text+0xb8c4): undefined reference to
> `mlx5e_hv_vhca_stats_destroy'
>
> This because CONFIG_PCI_HYPERV_INTERFACE is newly introduced by
> 'commit 348dd93e40c1
> ("PCI: hv: Add a Hyper-V PCI interface driver for software
> backchannel interface"),
> Fix this by making MLX5_CORE_EN imply PCI_HYPERV_INTERFACE.
>
the imply should be in MLX5_CORE not MLX5_CORE_EN since the
implementation also involves MLX5_CORE.
I will prepare a patch with these fixups.
Thanks,
Saeed.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH -next] net: mlx5: Kconfig: Fix MLX5_CORE_EN dependencies
@ 2019-08-30 21:43 ` Saeed Mahameed
0 siblings, 0 replies; 12+ messages in thread
From: Saeed Mahameed @ 2019-08-30 21:43 UTC (permalink / raw)
To: davem, maowenan, leon; +Cc: kernel-janitors, netdev, linux-rdma, linux-kernel
T24gVHVlLCAyMDE5LTA4LTI3IGF0IDExOjEyICswODAwLCBNYW8gV2VuYW4gd3JvdGU6DQo+IFdo
ZW4gTUxYNV9DT1JFX0VOPXkgYW5kIFBDSV9IWVBFUlZfSU5URVJGQUNFIGlzIG5vdCBzZXQsIGJl
bG93IGVycm9ycw0KDQpUaGUgaXNzdWUgaGFwcGVucyB3aGVuIFBDSV9IWVBFUlZfSU5URVJGQUNF
IGlzIGEgbW9kdWxlIGFuZCBtbHg1X2NvcmUNCmlzIGJ1aWx0LWluLg0KDQo+IGFyZSBmb3VuZDoN
Cj4gZHJpdmVycy9uZXQvZXRoZXJuZXQvbWVsbGFub3gvbWx4NS9jb3JlL2VuX21haW4ubzogSW4g
ZnVuY3Rpb24NCj4gYG1seDVlX25pY19lbmFibGUnOg0KPiBlbl9tYWluLmM6KC50ZXh0KzB4YjY0
OSk6IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8NCj4gYG1seDVlX2h2X3ZoY2Ffc3RhdHNfY3JlYXRl
Jw0KPiBkcml2ZXJzL25ldC9ldGhlcm5ldC9tZWxsYW5veC9tbHg1L2NvcmUvZW5fbWFpbi5vOiBJ
biBmdW5jdGlvbg0KPiBgbWx4NWVfbmljX2Rpc2FibGUnOg0KPiBlbl9tYWluLmM6KC50ZXh0KzB4
YjhjNCk6IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8NCj4gYG1seDVlX2h2X3ZoY2Ffc3RhdHNfZGVz
dHJveScNCj4gDQo+IFRoaXMgYmVjYXVzZSBDT05GSUdfUENJX0hZUEVSVl9JTlRFUkZBQ0UgaXMg
bmV3bHkgaW50cm9kdWNlZCBieQ0KPiAnY29tbWl0IDM0OGRkOTNlNDBjMQ0KPiAoIlBDSTogaHY6
IEFkZCBhIEh5cGVyLVYgUENJIGludGVyZmFjZSBkcml2ZXIgZm9yIHNvZnR3YXJlDQo+IGJhY2tj
aGFubmVsIGludGVyZmFjZSIpLA0KPiBGaXggdGhpcyBieSBtYWtpbmcgTUxYNV9DT1JFX0VOIGlt
cGx5IFBDSV9IWVBFUlZfSU5URVJGQUNFLg0KPiANCg0KdGhlIGltcGx5IHNob3VsZCBiZSBpbiBN
TFg1X0NPUkUgbm90IE1MWDVfQ09SRV9FTiBzaW5jZSB0aGUNCmltcGxlbWVudGF0aW9uIGFsc28g
aW52b2x2ZXMgTUxYNV9DT1JFLiANCg0KSSB3aWxsIHByZXBhcmUgYSBwYXRjaCB3aXRoIHRoZXNl
IGZpeHVwcy4NCg0KVGhhbmtzLA0KU2FlZWQuDQoNCg=
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-08-30 21:43 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-27 3:12 [PATCH -next] net: mlx5: Kconfig: Fix MLX5_CORE_EN dependencies Mao Wenan
2019-08-27 3:12 ` Mao Wenan
2019-08-27 7:24 ` walter harms
2019-08-27 7:24 ` walter harms
2019-08-27 9:51 ` maowenan
2019-08-27 9:51 ` maowenan
2019-08-27 21:15 ` Saeed Mahameed
2019-08-27 21:15 ` Saeed Mahameed
2019-08-27 20:14 ` Saeed Mahameed
2019-08-27 20:14 ` Saeed Mahameed
2019-08-30 21:43 ` Saeed Mahameed
2019-08-30 21:43 ` Saeed Mahameed
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.