From: Rob Herring <robh@kernel.org> To: Leilk Liu <leilk.liu@mediatek.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, yt.shen@mediatek.com, Mark Brown <broonie@kernel.org>, linux-mediatek@lists.infradead.org, Matthias Brugger <matthias.bgg@gmail.com>, mengqi.zhang@mediatek.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] spis: mediatek: add bindings for Mediatek MT2712 soc platform Date: Tue, 4 Sep 2018 08:18:38 -0500 [thread overview] Message-ID: <5b8e8a7f.1c69fb81.dab09.e985@mx.google.com> (raw) In-Reply-To: <1535437685-30230-2-git-send-email-leilk.liu@mediatek.com> On Tue, Aug 28, 2018 at 02:28:03PM +0800, Leilk Liu wrote: > This patch adds a DT binding documentation for the MT2712 soc. > > Signed-off-by: Leilk Liu <leilk.liu@mediatek.com> > --- > .../devicetree/bindings/spi/spi-slave-mt27xx.txt | 39 ++++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt > > diff --git a/Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt b/Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt > new file mode 100644 > index 0000000..dcb8934 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt > @@ -0,0 +1,39 @@ > +Binding for MTK SPI Slave controller Only does slave mode? If not, then the file name and doc should be just for the SPI controller (master and slave). The "spi-slave" property selects the mode. If it is only slave mode, then you don't need the spi-slave property. > + > +Required properties: > +- compatible: should be one of the following. > + - mediatek,mt2712-spi: for mt2712 platforms > + > +- reg: Address and length of the register set for the device > + > +- interrupts: Should contain spi interrupt > + > +- clocks: phandles to input clocks. > + The first should be one of the following. It's PLL. > + - <&topckgen CLK_TOP_UNIVPLL1_D2>: specify parent clock 312MHZ. > + It's the default one. > + - <&topckgen CLK_TOP_UNIVPLL1_D4>: specify parent clock 156MHZ. > + - <&topckgen CLK_TOP_UNIVPLL2_D4>: specify parent clock 104MHZ. > + - <&topckgen CLK_TOP_UNIVPLL1_D8>: specify parent clock 78MHZ. > + The second should be <&topckgen CLK_TOP_SPISLV_SEL>. It's clock mux. > + The third is <&infracfg CLK_INFRA_AO_SPI1>. It's clock gate. > + > +- clock-names: shall be "parent-clk" for the parent clock, "sel-clk" for the > + muxes clock, and "spi-clk" for the clock gate. "-clk" is redundant. Is the parent clock actually connected to the block? The assigned-clocks properties are used for constraints on parent clocks. > + > +- spi-slave: Empty property indicating the SPI controller is used in slave mode. > + > +Example: > + > +- SoC Specific Portion: > +spis: spi@10013000 { > + compatible = "mediatek,mt2712-spi-slave"; > + reg = <0 0x10013000 0 0x100>; > + interrupts = <GIC_SPI 283 IRQ_TYPE_LEVEL_LOW>; > + clocks = <&topckgen CLK_TOP_UNIVPLL1_D2>, > + <&topckgen CLK_TOP_SPISLV_SEL>, > + <&infracfg CLK_INFRA_AO_SPI1>; > + clock-names = "parent-clk", "sel-clk", "spi-clk"; > + spi-slave; > + status = "disabled"; Don't should status in examples. > +}; > -- > 1.7.9.5 >
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/3] spis: mediatek: add bindings for Mediatek MT2712 soc platform Date: Tue, 4 Sep 2018 08:18:38 -0500 [thread overview] Message-ID: <5b8e8a7f.1c69fb81.dab09.e985@mx.google.com> (raw) In-Reply-To: <1535437685-30230-2-git-send-email-leilk.liu@mediatek.com> On Tue, Aug 28, 2018 at 02:28:03PM +0800, Leilk Liu wrote: > This patch adds a DT binding documentation for the MT2712 soc. > > Signed-off-by: Leilk Liu <leilk.liu@mediatek.com> > --- > .../devicetree/bindings/spi/spi-slave-mt27xx.txt | 39 ++++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt > > diff --git a/Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt b/Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt > new file mode 100644 > index 0000000..dcb8934 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt > @@ -0,0 +1,39 @@ > +Binding for MTK SPI Slave controller Only does slave mode? If not, then the file name and doc should be just for the SPI controller (master and slave). The "spi-slave" property selects the mode. If it is only slave mode, then you don't need the spi-slave property. > + > +Required properties: > +- compatible: should be one of the following. > + - mediatek,mt2712-spi: for mt2712 platforms > + > +- reg: Address and length of the register set for the device > + > +- interrupts: Should contain spi interrupt > + > +- clocks: phandles to input clocks. > + The first should be one of the following. It's PLL. > + - <&topckgen CLK_TOP_UNIVPLL1_D2>: specify parent clock 312MHZ. > + It's the default one. > + - <&topckgen CLK_TOP_UNIVPLL1_D4>: specify parent clock 156MHZ. > + - <&topckgen CLK_TOP_UNIVPLL2_D4>: specify parent clock 104MHZ. > + - <&topckgen CLK_TOP_UNIVPLL1_D8>: specify parent clock 78MHZ. > + The second should be <&topckgen CLK_TOP_SPISLV_SEL>. It's clock mux. > + The third is <&infracfg CLK_INFRA_AO_SPI1>. It's clock gate. > + > +- clock-names: shall be "parent-clk" for the parent clock, "sel-clk" for the > + muxes clock, and "spi-clk" for the clock gate. "-clk" is redundant. Is the parent clock actually connected to the block? The assigned-clocks properties are used for constraints on parent clocks. > + > +- spi-slave: Empty property indicating the SPI controller is used in slave mode. > + > +Example: > + > +- SoC Specific Portion: > +spis: spi at 10013000 { > + compatible = "mediatek,mt2712-spi-slave"; > + reg = <0 0x10013000 0 0x100>; > + interrupts = <GIC_SPI 283 IRQ_TYPE_LEVEL_LOW>; > + clocks = <&topckgen CLK_TOP_UNIVPLL1_D2>, > + <&topckgen CLK_TOP_SPISLV_SEL>, > + <&infracfg CLK_INFRA_AO_SPI1>; > + clock-names = "parent-clk", "sel-clk", "spi-clk"; > + spi-slave; > + status = "disabled"; Don't should status in examples. > +}; > -- > 1.7.9.5 >
next prev parent reply other threads:[~2018-09-04 13:18 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-28 6:28 [PATCH 0/3] Add Mediatek SPI slave driver Leilk Liu 2018-08-28 6:28 ` Leilk Liu 2018-08-28 6:28 ` Leilk Liu 2018-08-28 6:28 ` Leilk Liu 2018-08-28 6:28 ` [PATCH 1/3] spis: mediatek: add bindings for Mediatek MT2712 soc platform Leilk Liu 2018-08-28 6:28 ` Leilk Liu 2018-08-28 6:28 ` Leilk Liu 2018-08-28 15:44 ` Matthias Brugger 2018-08-28 15:44 ` Matthias Brugger 2018-08-29 1:43 ` [SPAM]Re: " lei liu 2018-08-29 1:43 ` lei liu 2018-09-04 13:18 ` Rob Herring [this message] 2018-09-04 13:18 ` Rob Herring 2018-09-05 3:00 ` lei liu 2018-09-05 3:00 ` lei liu 2018-08-28 6:28 ` [PATCH 2/3] spis: mediatek: add spi slave for Mediatek MT2712 Leilk Liu 2018-08-28 6:28 ` Leilk Liu 2018-08-28 6:28 ` Leilk Liu 2018-08-31 2:41 ` [SPAM][PATCH " Sean Wang 2018-08-31 2:41 ` Sean Wang 2018-09-03 5:47 ` lei liu 2018-09-03 5:47 ` lei liu 2018-08-28 6:28 ` [PATCH 3/3] arm64: dts: Add spi slave dts Leilk Liu 2018-08-28 6:28 ` Leilk Liu 2018-08-28 6:28 ` Leilk Liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5b8e8a7f.1c69fb81.dab09.e985@mx.google.com \ --to=robh@kernel.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=leilk.liu@mediatek.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=matthias.bgg@gmail.com \ --cc=mengqi.zhang@mediatek.com \ --cc=s.hauer@pengutronix.de \ --cc=yt.shen@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.