All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Jes Sorensen <Jes.Sorensen@redhat.com>,
	Bastien Nocera <hadess@hadess.net>
Cc: Hanno Zulla <abos@hanno.de>,
	linux-wireless@vger.kernel.org, anthony.wong@canonical.com
Subject: Re: Support of rtl8723bs
Date: Mon, 12 Sep 2016 10:09:25 -0500	[thread overview]
Message-ID: <5b920339-abcd-0fc4-f054-039155c531a0@lwfinger.net> (raw)
In-Reply-To: <wrfjtwdli39u.fsf@redhat.com>

On 09/12/2016 09:47 AM, Jes Sorensen wrote:
> Bastien Nocera <hadess@hadess.net> writes:
>> On Mon, 2016-09-12 at 11:20 +0200, Hanno Zulla wrote:
>>> Hi Jes,
>>> hello linux-wireless,
>>> it as a guinea pig to test on my hardware. The newer vendor driver
>>> crashed on Ubuntu' 4.4 sources and doesn't compile yet on Ubuntu 4.8-
>>> rc
>>> sources.
>>> https://github.com/anthonywong/rtl8723bs/issues/1
>>
>> I really don't care about the vendor driver. There's no way to track
>> changes other than through code dumps.
>>
>> Longer term, it seems likely that improving Jes' driver is the way to
>> go. At least there's 170k less lines of code to read in the rtl8723bs
>> driver to get things going.
>
> Longer term I think it makes sense to add SDIO support to rtl8xxxu. The
> differences between the USB version and the SDIO version are rather
> small.
>
> That said, I have quite a lot of things on my TODO list so it is going
> to take some time until I can look at this. It may make sense to pull
> a cleaned up version of the vendor driver into staging until then if
> there is a desperate need for it, but otherwise any help would be
> appreciated :)

I agree with Jes that adding support for SDIO in rtl8xxxu would be a useful 
step. If anyone wants to help, that would be the place to start. I disagree that 
this driver should be dumped into staging. If one reads the various issues 
associated with the GitHub repo, you will see that this driver has severe 
problems that are unlikely to be fixed with a cleanup. The latest report is that 
the driver causes the loss of clock interrupts, which is not surprising given 
the sorry state of locking in the driver.

Complicating matters is that no one outside Realtek ever sees the details of any 
commit. At intervals, they make a dump of their current code and release it. The 
differences between two such releases amounts to many thousands of lines, and 
finding any changes due to bug fixes is a "needle in the haystack" problem.

Larry

  reply	other threads:[~2016-09-12 15:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12  9:20 Support of rtl8723bs Hanno Zulla
2016-09-12 12:23 ` Bastien Nocera
2016-09-12 14:27   ` Anthony Wong
2016-09-12 14:47   ` Jes Sorensen
2016-09-12 15:09     ` Larry Finger [this message]
2016-09-12 15:48       ` Hanno Zulla
2016-09-12 15:50         ` Bastien Nocera
2016-09-12 16:07           ` Jes Sorensen
2016-09-13  7:47             ` Hanno Zulla
2016-09-13 15:05               ` Larry Finger
2017-01-16 13:09             ` Hanno Zulla
2017-01-16 13:25               ` Jes Sorensen
2017-01-16 17:24                 ` Larry Finger
2017-03-29 10:20               ` Hanno Zulla
2017-03-29 15:24                 ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b920339-abcd-0fc4-f054-039155c531a0@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=Jes.Sorensen@redhat.com \
    --cc=abos@hanno.de \
    --cc=anthony.wong@canonical.com \
    --cc=hadess@hadess.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.