All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Bastien Nocera <hadess@hadess.net>
Cc: Hanno Zulla <abos@hanno.de>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	anthony.wong@canonical.com, linux-wireless@vger.kernel.org
Subject: Re: Support of rtl8723bs
Date: Mon, 12 Sep 2016 12:07:53 -0400	[thread overview]
Message-ID: <wrfj4m5lhzja.fsf@redhat.com> (raw)
In-Reply-To: <1473695458.6389.3.camel@hadess.net> (Bastien Nocera's message of "Mon, 12 Sep 2016 17:50:58 +0200")

Bastien Nocera <hadess@hadess.net> writes:
> On Mon, 2016-09-12 at 17:48 +0200, Hanno Zulla wrote:
>> Hi,
>> 
>> > Longer term I think it makes sense to add SDIO support to rtl8xxxu.
>> > The
>> > differences between the USB version and the SDIO version are rather
>> > small.
>> 
>> 
>> This is beyond my expertise, sadly.
>> 
>> Is there a good blueprint / example of a previous case where a USB
>> driver had SDIO support added that one might learn from?
>
> I don't know on top of my head, sorry. Best look in the kernel sources
> directly.

The issues I am aware of is to start out changing the register access
macros into function pointers and stick them all into the fileops
structure. Provide a set of SDIO ones to match the USB ones. Then you
will need some code to detect the device, as that part will obviously be
different from the USB device detection.

I know there are a few issues to look out for in the hw register init
files to look out for too, that does some special casing for SDIO, but
that should be limited. I am happy to point someone in the right
direction on that when they get to that.

Cheers,
Jes

  reply	other threads:[~2016-09-12 16:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12  9:20 Support of rtl8723bs Hanno Zulla
2016-09-12 12:23 ` Bastien Nocera
2016-09-12 14:27   ` Anthony Wong
2016-09-12 14:47   ` Jes Sorensen
2016-09-12 15:09     ` Larry Finger
2016-09-12 15:48       ` Hanno Zulla
2016-09-12 15:50         ` Bastien Nocera
2016-09-12 16:07           ` Jes Sorensen [this message]
2016-09-13  7:47             ` Hanno Zulla
2016-09-13 15:05               ` Larry Finger
2017-01-16 13:09             ` Hanno Zulla
2017-01-16 13:25               ` Jes Sorensen
2017-01-16 17:24                 ` Larry Finger
2017-03-29 10:20               ` Hanno Zulla
2017-03-29 15:24                 ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wrfj4m5lhzja.fsf@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=abos@hanno.de \
    --cc=anthony.wong@canonical.com \
    --cc=hadess@hadess.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.