* [PATCH 1/1] media: i2c: ov2640: Depend on V4L2_FWNODE
@ 2022-04-27 20:20 Mike Pagano
2022-04-27 20:54 ` Sakari Ailus
0 siblings, 1 reply; 5+ messages in thread
From: Mike Pagano @ 2022-04-27 20:20 UTC (permalink / raw)
To: linux-media
Add V4L2_FWNODE as a dependency to match other drivers and prevent
failures when compile testing.
Signed-off-by: Mike Pagano <mpagano@gentoo.org>
---
drivers/media/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index fae2baabb773..6168c04d8b37 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -372,6 +372,7 @@ config VIDEO_OV13B10
config VIDEO_OV2640
tristate "OmniVision OV2640 sensor support"
depends on VIDEO_DEV && I2C
+ select V4L2_FWNODE
help
This is a Video4Linux2 sensor driver for the OmniVision
OV2640 camera.
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] media: i2c: ov2640: Depend on V4L2_FWNODE
2022-04-27 20:20 [PATCH 1/1] media: i2c: ov2640: Depend on V4L2_FWNODE Mike Pagano
@ 2022-04-27 20:54 ` Sakari Ailus
2022-04-27 20:56 ` Mike Pagano
0 siblings, 1 reply; 5+ messages in thread
From: Sakari Ailus @ 2022-04-27 20:54 UTC (permalink / raw)
To: Mike Pagano; +Cc: linux-media
Hi Mike,
Thanks for the patch.
On Wed, Apr 27, 2022 at 04:20:12PM -0400, Mike Pagano wrote:
> Add V4L2_FWNODE as a dependency to match other drivers and prevent
> failures when compile testing.
>
> Signed-off-by: Mike Pagano <mpagano@gentoo.org>
> ---
> drivers/media/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index fae2baabb773..6168c04d8b37 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -372,6 +372,7 @@ config VIDEO_OV13B10
> config VIDEO_OV2640
> tristate "OmniVision OV2640 sensor support"
> depends on VIDEO_DEV && I2C
> + select V4L2_FWNODE
The driver doesn't use v4l2-fwnode but seems to depend on v4l2-async.
Shouldn't this be V4L2_ASYNC instead?
Could you also add this tag:
Fixes: ff3cc65cadb5 ("media: v4l: async, fwnode: Improve module organisation")
> help
> This is a Video4Linux2 sensor driver for the OmniVision
> OV2640 camera.
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] media: i2c: ov2640: Depend on V4L2_FWNODE
2022-04-27 20:54 ` Sakari Ailus
@ 2022-04-27 20:56 ` Mike Pagano
2022-04-27 21:59 ` [PATCH 1/1 v2] media: i2c: ov2640: Depend on V4L2_ASYNC Mike Pagano
0 siblings, 1 reply; 5+ messages in thread
From: Mike Pagano @ 2022-04-27 20:56 UTC (permalink / raw)
To: linux-media
On 4/27/22 16:54, Sakari Ailus wrote:
> Hi Mike,
>
> Thanks for the patch.
>
> On Wed, Apr 27, 2022 at 04:20:12PM -0400, Mike Pagano wrote:
>> Add V4L2_FWNODE as a dependency to match other drivers and prevent
>> failures when compile testing.
>>
>> Signed-off-by: Mike Pagano <mpagano@gentoo.org>
>> ---
>> drivers/media/i2c/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
>> index fae2baabb773..6168c04d8b37 100644
>> --- a/drivers/media/i2c/Kconfig
>> +++ b/drivers/media/i2c/Kconfig
>> @@ -372,6 +372,7 @@ config VIDEO_OV13B10
>> config VIDEO_OV2640
>> tristate "OmniVision OV2640 sensor support"
>> depends on VIDEO_DEV && I2C
>> + select V4L2_FWNODE
>
> The driver doesn't use v4l2-fwnode but seems to depend on v4l2-async.
>
> Shouldn't this be V4L2_ASYNC instead?
>
> Could you also add this tag:
>
> Fixes: ff3cc65cadb5 ("media: v4l: async, fwnode: Improve module organisation")
>
>> help
>> This is a Video4Linux2 sensor driver for the OmniVision
>> OV2640 camera.
>
Thank-you for the response, Sakari, I will fix and resubmit.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1 v2] media: i2c: ov2640: Depend on V4L2_ASYNC
2022-04-27 20:56 ` Mike Pagano
@ 2022-04-27 21:59 ` Mike Pagano
2022-04-28 10:51 ` Sakari Ailus
0 siblings, 1 reply; 5+ messages in thread
From: Mike Pagano @ 2022-04-27 21:59 UTC (permalink / raw)
To: linux-media
Add V4L2_ASYNC as a dependency to match other drivers and prevent failures when compile testing.
Fixes: ff3cc65cadb5 ("media: v4l: async, fwnode: Improve module organisation")
Signed-off-by: Mike Pagano <mpagano@gentoo.org>
---
drivers/media/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index fae2baabb773..2b20aa6c37b1 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -372,6 +372,7 @@ config VIDEO_OV13B10
config VIDEO_OV2640
tristate "OmniVision OV2640 sensor support"
depends on VIDEO_DEV && I2C
+ select V4L2_ASYNC
help
This is a Video4Linux2 sensor driver for the OmniVision
OV2640 camera.
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1 v2] media: i2c: ov2640: Depend on V4L2_ASYNC
2022-04-27 21:59 ` [PATCH 1/1 v2] media: i2c: ov2640: Depend on V4L2_ASYNC Mike Pagano
@ 2022-04-28 10:51 ` Sakari Ailus
0 siblings, 0 replies; 5+ messages in thread
From: Sakari Ailus @ 2022-04-28 10:51 UTC (permalink / raw)
To: Mike Pagano; +Cc: linux-media
Hi Mike,
Thanks for the update.
On Wed, Apr 27, 2022 at 05:59:23PM -0400, Mike Pagano wrote:
> Add V4L2_ASYNC as a dependency to match other drivers and prevent failures when compile testing.
The commit message should be wrapped at 75 characters or earlier.
>
> Fixes: ff3cc65cadb5 ("media: v4l: async, fwnode: Improve module organisation")
>
No newline needed here.
I'll address these when merging it.
> Signed-off-by: Mike Pagano <mpagano@gentoo.org>
> ---
> drivers/media/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index fae2baabb773..2b20aa6c37b1 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -372,6 +372,7 @@ config VIDEO_OV13B10
> config VIDEO_OV2640
> tristate "OmniVision OV2640 sensor support"
> depends on VIDEO_DEV && I2C
> + select V4L2_ASYNC
> help
> This is a Video4Linux2 sensor driver for the OmniVision
> OV2640 camera.
--
Sakari Ailus
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-28 10:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-27 20:20 [PATCH 1/1] media: i2c: ov2640: Depend on V4L2_FWNODE Mike Pagano
2022-04-27 20:54 ` Sakari Ailus
2022-04-27 20:56 ` Mike Pagano
2022-04-27 21:59 ` [PATCH 1/1 v2] media: i2c: ov2640: Depend on V4L2_ASYNC Mike Pagano
2022-04-28 10:51 ` Sakari Ailus
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.