Re: [PATCH 2/2] net/ark: report hardware status during PMD init

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 4/10/2017 1:26 PM, Ed Czeck wrote:
> Expose additional fpga status registers and report
> conditions during PMD init
> 
> Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
> ---
>  drivers/net/ark/ark_ethdev.c | 9 +++++++++
>  drivers/net/ark/ark_rqp.c    | 6 ++++++
>  drivers/net/ark/ark_rqp.h    | 4 +++-
>  3 files changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
> index 93721a0..1a6c71c 100644
> --- a/drivers/net/ark/ark_ethdev.c
> +++ b/drivers/net/ark/ark_ethdev.c
> @@ -297,6 +297,15 @@ eth_ark_dev_init(struct rte_eth_dev *dev)
>  			    ark->sysctrl.t32[4], __func__);
>  		return -1;
>  	}
> +	if (ark->sysctrl.t32[3] != 0) {
> +		if (ark_rqp_lasped(ark->rqpacing))
> +			PMD_DRV_LOG(INFO, "Arkville Evaluation System - "

Is this should be "info" level or debug, is end user interested if timer
expired or not?

> +				    "Timer has Expired\n");
> +		else
> +			PMD_DRV_LOG(INFO, "Arkville Evaluation System - "

btw, what is the logic in pmd, when to use PMD_DRV_LOG and when to use
PMD_DEBUG_LOG?

> +				    "Timer is Running\n");
> +	}
> +
>  

Extra line.

>  	PMD_DRV_LOG(INFO,
>  		    "HW Sanity test has PASSED, expected constant"
<...>