Re: [PATCH 2/2] net/ark: report hardware status during PMD init

[Ed Czeck <ed.czeck@atomicrules.com>]

On Mon, Apr 10, 2017 at 11:01 AM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:

> On 4/10/2017 1:26 PM, Ed Czeck wrote:
> > Expose additional fpga status registers and report
> > conditions during PMD init
> >
>
> > +     if (ark->sysctrl.t32[3] != 0) {
> > +             if (ark_rqp_lasped(ark->rqpacing))
> > +                     PMD_DRV_LOG(INFO, "Arkville Evaluation System - "
>
> Is this should be "info" level or debug, is end user interested if timer
> expired or not?
>
> These messages are intended for the user.  After internal discussion we
promoted them to warning and error.



> > +                                 "Timer has Expired\n");
> > +             else
> > +                     PMD_DRV_LOG(INFO, "Arkville Evaluation System - "
>
> btw, what is the logic in pmd, when to use PMD_DRV_LOG and when to use
> PMD_DEBUG_LOG?


The  PMD_DRV_LOG macro is a local wrapper on RTE_LOG, while the
PMD_DEBUG_LOG macro is a compile-time conditional macro to the same
RTE_LOG.  The DEBUG_LOG macro is conditionalize on the configuration
RTE_LIBRTE_ARK_DEBUG_TRACE.


> > +                                 "Timer is Running\n");
> > +     }
> > +
> >
>
> Extra line.
>
Removed.

Thank you