[Buildroot] [git commit] system/skeleton: remove password expiration from shadow

[Buildroot] [git commit] system/skeleton: remove password expiration from shadow

[Arnout Vandecappelle]

commit: https://git.buildroot.net/buildroot/commit/?id=be8d11c7e55d8dfe395774c04a7a35b949aa6d97
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

The fields in /etc/shadow were set as follows:

root::10933:0:99999:7:::

This sets the date of last password change to Jan 1, 2000, the minimum
password age to 0 days, the maximum password age to near-infinity, and a
warning period of 7 days. In practice, this means the password never
expires. So all of this is quite useless.

On the other hand, mkusers creates lines without all of these options.
It just sets ::::: which disables password expiration completely.

To make things consistent, do the same for the skeleton entries.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 system/skeleton/etc/shadow | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/system/skeleton/etc/shadow b/system/skeleton/etc/shadow
index 06778f13f9..37de977cba 100644
--- a/system/skeleton/etc/shadow
+++ b/system/skeleton/etc/shadow
@@ -1,9 +1,9 @@
-root::10933:0:99999:7:::
-daemon:*:10933:0:99999:7:::
-bin:*:10933:0:99999:7:::
-sys:*:10933:0:99999:7:::
-sync:*:10933:0:99999:7:::
-mail:*:10933:0:99999:7:::
-www-data:*:10933:0:99999:7:::
-operator:*:10933:0:99999:7:::
-nobody:*:10933:0:99999:7:::
+root::::::::
+daemon:*:::::::
+bin:*:::::::
+sys:*:::::::
+sync:*:::::::
+mail:*:::::::
+www-data:*:::::::
+operator:*:::::::
+nobody:*:::::::

[Buildroot] [git commit] system/skeleton: remove password expiration from shadow

[Thomas Petazzoni]

Hello Arnout,

On Wed, 20 Mar 2019 23:06:29 +0100
Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> wrote:

> commit: https://git.buildroot.net/buildroot/commit/?id=be8d11c7e55d8dfe395774c04a7a35b949aa6d97
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> 
> The fields in /etc/shadow were set as follows:
> 
> root::10933:0:99999:7:::
> 
> This sets the date of last password change to Jan 1, 2000, the minimum
> password age to 0 days, the maximum password age to near-infinity, and a
> warning period of 7 days. In practice, this means the password never
> expires. So all of this is quite useless.
> 
> On the other hand, mkusers creates lines without all of these options.
> It just sets ::::: which disables password expiration completely.
> 
> To make things consistent, do the same for the skeleton entries.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

It seems like you applied your own patch here, but without replying to
your original e-mail to say it was applied, and the patch state in
patchwork was also not set to Accepted. Seems like you perhaps pushed
it by mistake.

Anyway, no big deal, I was about to apply it, and that's what made me
discover that it was already applied :)

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [git commit] system/skeleton: remove password expiration from shadow

[Arnout Vandecappelle]

On 31/03/2019 15:17, Thomas Petazzoni wrote:
> Hello Arnout,
> 
> On Wed, 20 Mar 2019 23:06:29 +0100
> Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> wrote:
> 
>> commit: https://git.buildroot.net/buildroot/commit/?id=be8d11c7e55d8dfe395774c04a7a35b949aa6d97
>> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>>
>> The fields in /etc/shadow were set as follows:
>>
>> root::10933:0:99999:7:::
>>
>> This sets the date of last password change to Jan 1, 2000, the minimum
>> password age to 0 days, the maximum password age to near-infinity, and a
>> warning period of 7 days. In practice, this means the password never
>> expires. So all of this is quite useless.
>>
>> On the other hand, mkusers creates lines without all of these options.
>> It just sets ::::: which disables password expiration completely.
>>
>> To make things consistent, do the same for the skeleton entries.
>>
>> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> 
> It seems like you applied your own patch here, but without replying to
> your original e-mail to say it was applied, and the patch state in
> patchwork was also not set to Accepted. Seems like you perhaps pushed
> it by mistake.

 I don't remember intentionally applying that patch... I guess it was still in
my repo and I failed to check what I was pushing... Sorry for that.

 Regards,
 Arnout

> 
> Anyway, no big deal, I was about to apply it, and that's what made me
> discover that it was already applied :)
> 
> Best regards,
> 
> Thomas
>