* [PATCH v2] drivers/scsi/fnic/fnic_trace.c: Use vzalloc
@ 2018-11-14 16:54 Sabyasachi Gupta
2018-11-23 14:43 ` Sabyasachi Gupta
2018-12-08 2:29 ` Martin K. Petersen
0 siblings, 2 replies; 5+ messages in thread
From: Sabyasachi Gupta @ 2018-11-14 16:54 UTC (permalink / raw)
To: satishkh, sebaddel, kartilak, jejb, martin.petersen
Cc: jrdr.linux, linux-scsi, linux-kernel, brajeswar.linux
Replaced vmalloc + memset with vzalloc
Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
---
v2: Removed additional braces
drivers/scsi/fnic/fnic_trace.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c
index 8271785..bf0fd2a 100644
--- a/drivers/scsi/fnic/fnic_trace.c
+++ b/drivers/scsi/fnic/fnic_trace.c
@@ -468,14 +468,13 @@ int fnic_trace_buf_init(void)
fnic_max_trace_entries = (trace_max_pages * PAGE_SIZE)/
FNIC_ENTRY_SIZE_BYTES;
- fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE));
+ fnic_trace_buf_p = (unsigned long)vzalloc(trace_max_pages * PAGE_SIZE);
if (!fnic_trace_buf_p) {
printk(KERN_ERR PFX "Failed to allocate memory "
"for fnic_trace_buf_p\n");
err = -ENOMEM;
goto err_fnic_trace_buf_init;
}
- memset((void *)fnic_trace_buf_p, 0, (trace_max_pages * PAGE_SIZE));
fnic_trace_entries.page_offset =
vmalloc(array_size(fnic_max_trace_entries,
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] drivers/scsi/fnic/fnic_trace.c: Use vzalloc
2018-11-14 16:54 [PATCH v2] drivers/scsi/fnic/fnic_trace.c: Use vzalloc Sabyasachi Gupta
@ 2018-11-23 14:43 ` Sabyasachi Gupta
2018-12-05 4:37 ` Sabyasachi Gupta
2018-12-08 2:29 ` Martin K. Petersen
1 sibling, 1 reply; 5+ messages in thread
From: Sabyasachi Gupta @ 2018-11-23 14:43 UTC (permalink / raw)
To: satishkh, sebaddel, kartilak, jejb, martin.petersen
Cc: Souptick Joarder, linux-scsi, linux-kernel, Brajeswar Ghosh
On Wed, Nov 14, 2018 at 10:24 PM Sabyasachi Gupta
<sabyasachi.linux@gmail.com> wrote:
>
> Replaced vmalloc + memset with vzalloc
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
Any comment on this patch?
> ---
> v2: Removed additional braces
>
> drivers/scsi/fnic/fnic_trace.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c
> index 8271785..bf0fd2a 100644
> --- a/drivers/scsi/fnic/fnic_trace.c
> +++ b/drivers/scsi/fnic/fnic_trace.c
> @@ -468,14 +468,13 @@ int fnic_trace_buf_init(void)
> fnic_max_trace_entries = (trace_max_pages * PAGE_SIZE)/
> FNIC_ENTRY_SIZE_BYTES;
>
> - fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE));
> + fnic_trace_buf_p = (unsigned long)vzalloc(trace_max_pages * PAGE_SIZE);
> if (!fnic_trace_buf_p) {
> printk(KERN_ERR PFX "Failed to allocate memory "
> "for fnic_trace_buf_p\n");
> err = -ENOMEM;
> goto err_fnic_trace_buf_init;
> }
> - memset((void *)fnic_trace_buf_p, 0, (trace_max_pages * PAGE_SIZE));
>
> fnic_trace_entries.page_offset =
> vmalloc(array_size(fnic_max_trace_entries,
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] drivers/scsi/fnic/fnic_trace.c: Use vzalloc
2018-11-23 14:43 ` Sabyasachi Gupta
@ 2018-12-05 4:37 ` Sabyasachi Gupta
2018-12-05 6:30 ` Sesidhar Baddela (sebaddel)
0 siblings, 1 reply; 5+ messages in thread
From: Sabyasachi Gupta @ 2018-12-05 4:37 UTC (permalink / raw)
To: satishkh, sebaddel, kartilak, jejb, martin.petersen
Cc: Souptick Joarder, linux-scsi, linux-kernel, Brajeswar Ghosh
On Fri, Nov 23, 2018 at 8:13 PM Sabyasachi Gupta
<sabyasachi.linux@gmail.com> wrote:
>
> On Wed, Nov 14, 2018 at 10:24 PM Sabyasachi Gupta
> <sabyasachi.linux@gmail.com> wrote:
> >
> > Replaced vmalloc + memset with vzalloc
> >
> > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
>
> Any comment on this patch?
Any comment on this patch?
>
> > ---
> > v2: Removed additional braces
> >
> > drivers/scsi/fnic/fnic_trace.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c
> > index 8271785..bf0fd2a 100644
> > --- a/drivers/scsi/fnic/fnic_trace.c
> > +++ b/drivers/scsi/fnic/fnic_trace.c
> > @@ -468,14 +468,13 @@ int fnic_trace_buf_init(void)
> > fnic_max_trace_entries = (trace_max_pages * PAGE_SIZE)/
> > FNIC_ENTRY_SIZE_BYTES;
> >
> > - fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE));
> > + fnic_trace_buf_p = (unsigned long)vzalloc(trace_max_pages * PAGE_SIZE);
> > if (!fnic_trace_buf_p) {
> > printk(KERN_ERR PFX "Failed to allocate memory "
> > "for fnic_trace_buf_p\n");
> > err = -ENOMEM;
> > goto err_fnic_trace_buf_init;
> > }
> > - memset((void *)fnic_trace_buf_p, 0, (trace_max_pages * PAGE_SIZE));
> >
> > fnic_trace_entries.page_offset =
> > vmalloc(array_size(fnic_max_trace_entries,
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] drivers/scsi/fnic/fnic_trace.c: Use vzalloc
2018-12-05 4:37 ` Sabyasachi Gupta
@ 2018-12-05 6:30 ` Sesidhar Baddela (sebaddel)
0 siblings, 0 replies; 5+ messages in thread
From: Sesidhar Baddela (sebaddel) @ 2018-12-05 6:30 UTC (permalink / raw)
To: Sabyasachi Gupta, Satish Kharat (satishkh),
Karan Tilak Kumar (kartilak),
jejb, martin.petersen
Cc: Souptick Joarder, linux-scsi, linux-kernel, Brajeswar Ghosh
Looks good. Apologize for the delay in acknowledging the patch.
Acked-by: Sesidhar Baddela <sebaddel@cisco.com>
On 12/4/18, 8:37 PM, "Sabyasachi Gupta" <sabyasachi.linux@gmail.com> wrote:
On Fri, Nov 23, 2018 at 8:13 PM Sabyasachi Gupta
<sabyasachi.linux@gmail.com> wrote:
>
> On Wed, Nov 14, 2018 at 10:24 PM Sabyasachi Gupta
> <sabyasachi.linux@gmail.com> wrote:
> >
> > Replaced vmalloc + memset with vzalloc
> >
> > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
>
> Any comment on this patch?
Any comment on this patch?
>
> > ---
> > v2: Removed additional braces
> >
> > drivers/scsi/fnic/fnic_trace.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c
> > index 8271785..bf0fd2a 100644
> > --- a/drivers/scsi/fnic/fnic_trace.c
> > +++ b/drivers/scsi/fnic/fnic_trace.c
> > @@ -468,14 +468,13 @@ int fnic_trace_buf_init(void)
> > fnic_max_trace_entries = (trace_max_pages * PAGE_SIZE)/
> > FNIC_ENTRY_SIZE_BYTES;
> >
> > - fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE));
> > + fnic_trace_buf_p = (unsigned long)vzalloc(trace_max_pages * PAGE_SIZE);
> > if (!fnic_trace_buf_p) {
> > printk(KERN_ERR PFX "Failed to allocate memory "
> > "for fnic_trace_buf_p\n");
> > err = -ENOMEM;
> > goto err_fnic_trace_buf_init;
> > }
> > - memset((void *)fnic_trace_buf_p, 0, (trace_max_pages * PAGE_SIZE));
> >
> > fnic_trace_entries.page_offset =
> > vmalloc(array_size(fnic_max_trace_entries,
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drivers/scsi/fnic/fnic_trace.c: Use vzalloc
2018-11-14 16:54 [PATCH v2] drivers/scsi/fnic/fnic_trace.c: Use vzalloc Sabyasachi Gupta
2018-11-23 14:43 ` Sabyasachi Gupta
@ 2018-12-08 2:29 ` Martin K. Petersen
1 sibling, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2018-12-08 2:29 UTC (permalink / raw)
To: Sabyasachi Gupta
Cc: satishkh, sebaddel, kartilak, jejb, martin.petersen, jrdr.linux,
linux-scsi, linux-kernel, brajeswar.linux
Sabyasachi,
> Replaced vmalloc + memset with vzalloc
Applied to 4.21/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-12-08 2:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-14 16:54 [PATCH v2] drivers/scsi/fnic/fnic_trace.c: Use vzalloc Sabyasachi Gupta
2018-11-23 14:43 ` Sabyasachi Gupta
2018-12-05 4:37 ` Sabyasachi Gupta
2018-12-05 6:30 ` Sesidhar Baddela (sebaddel)
2018-12-08 2:29 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.