All of lore.kernel.org
 help / color / mirror / Atom feed
* [pull] amdgpu drm-fixes-4.14
@ 2017-10-12 15:58 Alex Deucher
       [not found] ` <1507823900-2785-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
  0 siblings, 1 reply; 13+ messages in thread
From: Alex Deucher @ 2017-10-12 15:58 UTC (permalink / raw)
  To: amd-gfx, dri-devel, airlied; +Cc: Alex Deucher

Hi Dave,

One memory management regression fix.

The following changes since commit 545036a9944e9d6e50fed4ca03117147c880ff71:

  Merge tag 'drm-misc-fixes-2017-10-11' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-10-12 10:38:09 +1000)

are available in the git repository at:

  git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14

for you to fetch changes up to 27b94b4f1386c3a8181f5a0277434a32e24e7dd7:

  drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-12 10:34:42 -0400)

----------------------------------------------------------------
Christian König (1):
      drm/amdgpu: fix placement flags in amdgpu_ttm_bind

 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [pull] amdgpu drm-fixes-4.14
       [not found] ` <1507823900-2785-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
@ 2017-10-12 16:20   ` Michel Dänzer
       [not found]     ` <dfb5a003-f9a1-24f4-90aa-e9f43fdb4e1c-otUistvHUpPR7s880joybQ@public.gmane.org>
  0 siblings, 1 reply; 13+ messages in thread
From: Michel Dänzer @ 2017-10-12 16:20 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Alex Deucher, airlied-Re5JQEeQqe8AvxtiuMwx3w,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

On 12/10/17 05:58 PM, Alex Deucher wrote:
> Hi Dave,
> 
> One memory management regression fix.
> 
> The following changes since commit 545036a9944e9d6e50fed4ca03117147c880ff71:
> 
>   Merge tag 'drm-misc-fixes-2017-10-11' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-10-12 10:38:09 +1000)
> 
> are available in the git repository at:
> 
>   git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14
> 
> for you to fetch changes up to 27b94b4f1386c3a8181f5a0277434a32e24e7dd7:
> 
>   drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-12 10:34:42 -0400)
> 
> ----------------------------------------------------------------
> Christian König (1):
>       drm/amdgpu: fix placement flags in amdgpu_ttm_bind

Thanks Alex, but there's another piglit hang regression in 4.14, caused
by commit 6af0883ed977 "drm/amdgpu: discard commands of killed
processes", fixed by five commits 6b37d03280a4..318d85de9c20 in
amd-staging-drm-next. Either the latter need to be backported to 4.14,
or the former needs to be reverted from it.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 13+ messages in thread

* RE: [pull] amdgpu drm-fixes-4.14
       [not found]     ` <dfb5a003-f9a1-24f4-90aa-e9f43fdb4e1c-otUistvHUpPR7s880joybQ@public.gmane.org>
@ 2017-10-12 16:53       ` Deucher, Alexander
  2017-10-12 17:02       ` Christian König
  1 sibling, 0 replies; 13+ messages in thread
From: Deucher, Alexander @ 2017-10-12 16:53 UTC (permalink / raw)
  To: 'Michel Dänzer', Alex Deucher
  Cc: airlied-Re5JQEeQqe8AvxtiuMwx3w,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

> -----Original Message-----
> From: Michel Dänzer [mailto:michel@daenzer.net]
> Sent: Thursday, October 12, 2017 12:21 PM
> To: Alex Deucher
> Cc: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org;
> airlied@gmail.com; Deucher, Alexander
> Subject: Re: [pull] amdgpu drm-fixes-4.14
> 
> On 12/10/17 05:58 PM, Alex Deucher wrote:
> > Hi Dave,
> >
> > One memory management regression fix.
> >
> > The following changes since commit
> 545036a9944e9d6e50fed4ca03117147c880ff71:
> >
> >   Merge tag 'drm-misc-fixes-2017-10-11' of
> git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-10-12
> 10:38:09 +1000)
> >
> > are available in the git repository at:
> >
> >   git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14
> >
> > for you to fetch changes up to
> 27b94b4f1386c3a8181f5a0277434a32e24e7dd7:
> >
> >   drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-12
> 10:34:42 -0400)
> >
> > ----------------------------------------------------------------
> > Christian König (1):
> >       drm/amdgpu: fix placement flags in amdgpu_ttm_bind
> 
> Thanks Alex, but there's another piglit hang regression in 4.14, caused
> by commit 6af0883ed977 "drm/amdgpu: discard commands of killed
> processes", fixed by five commits 6b37d03280a4..318d85de9c20 in
> amd-staging-drm-next. Either the latter need to be backported to 4.14,
> or the former needs to be reverted from it.

Sorting that out seemed like more effort, so I opted to just send this out.  Once we get that fixed up, I can send another fixes pull.

Alex

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [pull] amdgpu drm-fixes-4.14
       [not found]     ` <dfb5a003-f9a1-24f4-90aa-e9f43fdb4e1c-otUistvHUpPR7s880joybQ@public.gmane.org>
  2017-10-12 16:53       ` Deucher, Alexander
@ 2017-10-12 17:02       ` Christian König
       [not found]         ` <996c1073-5832-0f3c-91e9-67fac0be6071-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  1 sibling, 1 reply; 13+ messages in thread
From: Christian König @ 2017-10-12 17:02 UTC (permalink / raw)
  To: Michel Dänzer, Alex Deucher
  Cc: Alex Deucher, airlied-Re5JQEeQqe8AvxtiuMwx3w,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

Am 12.10.2017 um 18:20 schrieb Michel Dänzer:
> On 12/10/17 05:58 PM, Alex Deucher wrote:
>> Hi Dave,
>>
>> One memory management regression fix.
>>
>> The following changes since commit 545036a9944e9d6e50fed4ca03117147c880ff71:
>>
>>    Merge tag 'drm-misc-fixes-2017-10-11' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-10-12 10:38:09 +1000)
>>
>> are available in the git repository at:
>>
>>    git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14
>>
>> for you to fetch changes up to 27b94b4f1386c3a8181f5a0277434a32e24e7dd7:
>>
>>    drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-12 10:34:42 -0400)
>>
>> ----------------------------------------------------------------
>> Christian König (1):
>>        drm/amdgpu: fix placement flags in amdgpu_ttm_bind
> Thanks Alex, but there's another piglit hang regression in 4.14, caused
> by commit 6af0883ed977 "drm/amdgpu: discard commands of killed
> processes", fixed by five commits 6b37d03280a4..318d85de9c20 in
> amd-staging-drm-next. Either the latter need to be backported to 4.14,
> or the former needs to be reverted from it.

The revert is probably easier to handle at this point.

So to answer your question from the other thread I vote for that.

Christian.

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [pull] amdgpu drm-fixes-4.14
       [not found]         ` <996c1073-5832-0f3c-91e9-67fac0be6071-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2017-10-12 17:49           ` Alex Deucher
  2017-10-13  7:41             ` Michel Dänzer
  0 siblings, 1 reply; 13+ messages in thread
From: Alex Deucher @ 2017-10-12 17:49 UTC (permalink / raw)
  To: Christian Koenig
  Cc: Alex Deucher, Michel Dänzer, Dave Airlie, amd-gfx list,
	Maling list - DRI developers

On Thu, Oct 12, 2017 at 1:02 PM, Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
> Am 12.10.2017 um 18:20 schrieb Michel Dänzer:
>>
>> On 12/10/17 05:58 PM, Alex Deucher wrote:
>>>
>>> Hi Dave,
>>>
>>> One memory management regression fix.
>>>
>>> The following changes since commit
>>> 545036a9944e9d6e50fed4ca03117147c880ff71:
>>>
>>>    Merge tag 'drm-misc-fixes-2017-10-11' of
>>> git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-10-12
>>> 10:38:09 +1000)
>>>
>>> are available in the git repository at:
>>>
>>>    git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14
>>>
>>> for you to fetch changes up to 27b94b4f1386c3a8181f5a0277434a32e24e7dd7:
>>>
>>>    drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-12
>>> 10:34:42 -0400)
>>>
>>> ----------------------------------------------------------------
>>> Christian König (1):
>>>        drm/amdgpu: fix placement flags in amdgpu_ttm_bind
>>
>> Thanks Alex, but there's another piglit hang regression in 4.14, caused
>> by commit 6af0883ed977 "drm/amdgpu: discard commands of killed
>> processes", fixed by five commits 6b37d03280a4..318d85de9c20 in
>> amd-staging-drm-next. Either the latter need to be backported to 4.14,
>> or the former needs to be reverted from it.
>
>
> The revert is probably easier to handle at this point.
>
> So to answer your question from the other thread I vote for that.

Nicolai's patches apply cleanly and I think they change about the same
amount of code and we don't have to worry about any problems down the
road when the revert gets merged into drm-next.

Alex
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [pull] amdgpu drm-fixes-4.14
  2017-10-12 17:49           ` Alex Deucher
@ 2017-10-13  7:41             ` Michel Dänzer
  2017-10-13  8:19               ` Christian König
  0 siblings, 1 reply; 13+ messages in thread
From: Michel Dänzer @ 2017-10-13  7:41 UTC (permalink / raw)
  To: Alex Deucher, Christian Koenig
  Cc: Alex Deucher, Maling list - DRI developers, amd-gfx list

On 12/10/17 07:49 PM, Alex Deucher wrote:
> On Thu, Oct 12, 2017 at 1:02 PM, Christian König
> <ckoenig.leichtzumerken@gmail.com> wrote:
>> Am 12.10.2017 um 18:20 schrieb Michel Dänzer:
>>> On 12/10/17 05:58 PM, Alex Deucher wrote:
>>>>
>>>> Hi Dave,
>>>>
>>>> One memory management regression fix.
>>>>
>>>> The following changes since commit
>>>> 545036a9944e9d6e50fed4ca03117147c880ff71:
>>>>
>>>>    Merge tag 'drm-misc-fixes-2017-10-11' of
>>>> git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-10-12
>>>> 10:38:09 +1000)
>>>>
>>>> are available in the git repository at:
>>>>
>>>>    git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14
>>>>
>>>> for you to fetch changes up to 27b94b4f1386c3a8181f5a0277434a32e24e7dd7:
>>>>
>>>>    drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-12
>>>> 10:34:42 -0400)
>>>>
>>>> ----------------------------------------------------------------
>>>> Christian König (1):
>>>>        drm/amdgpu: fix placement flags in amdgpu_ttm_bind
>>>
>>> Thanks Alex, but there's another piglit hang regression in 4.14, caused
>>> by commit 6af0883ed977 "drm/amdgpu: discard commands of killed
>>> processes", fixed by five commits 6b37d03280a4..318d85de9c20 in
>>> amd-staging-drm-next. Either the latter need to be backported to 4.14,
>>> or the former needs to be reverted from it.
>>
>>
>> The revert is probably easier to handle at this point.
>>
>> So to answer your question from the other thread I vote for that.
> 
> Nicolai's patches apply cleanly and I think they change about the same
> amount of code and we don't have to worry about any problems down the
> road when the revert gets merged into drm-next.

That's basically why I asked which way to go. However, Monk just
reported a potential regression in one of Nicolai's changes, so
reverting seems safer for 4.14.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [pull] amdgpu drm-fixes-4.14
  2017-10-13  7:41             ` Michel Dänzer
@ 2017-10-13  8:19               ` Christian König
       [not found]                 ` <b4e9aec8-e69c-e5b2-15d1-c75d9c7dc0f3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 13+ messages in thread
From: Christian König @ 2017-10-13  8:19 UTC (permalink / raw)
  To: Michel Dänzer, Alex Deucher, Christian Koenig
  Cc: Alex Deucher, amd-gfx list, Maling list - DRI developers

Am 13.10.2017 um 09:41 schrieb Michel Dänzer:
> On 12/10/17 07:49 PM, Alex Deucher wrote:
>> On Thu, Oct 12, 2017 at 1:02 PM, Christian König
>> <ckoenig.leichtzumerken@gmail.com> wrote:
>>> Am 12.10.2017 um 18:20 schrieb Michel Dänzer:
>>>> On 12/10/17 05:58 PM, Alex Deucher wrote:
>>>>> Hi Dave,
>>>>>
>>>>> One memory management regression fix.
>>>>>
>>>>> The following changes since commit
>>>>> 545036a9944e9d6e50fed4ca03117147c880ff71:
>>>>>
>>>>>     Merge tag 'drm-misc-fixes-2017-10-11' of
>>>>> git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-10-12
>>>>> 10:38:09 +1000)
>>>>>
>>>>> are available in the git repository at:
>>>>>
>>>>>     git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14
>>>>>
>>>>> for you to fetch changes up to 27b94b4f1386c3a8181f5a0277434a32e24e7dd7:
>>>>>
>>>>>     drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-12
>>>>> 10:34:42 -0400)
>>>>>
>>>>> ----------------------------------------------------------------
>>>>> Christian König (1):
>>>>>         drm/amdgpu: fix placement flags in amdgpu_ttm_bind
>>>> Thanks Alex, but there's another piglit hang regression in 4.14, caused
>>>> by commit 6af0883ed977 "drm/amdgpu: discard commands of killed
>>>> processes", fixed by five commits 6b37d03280a4..318d85de9c20 in
>>>> amd-staging-drm-next. Either the latter need to be backported to 4.14,
>>>> or the former needs to be reverted from it.
>>>
>>> The revert is probably easier to handle at this point.
>>>
>>> So to answer your question from the other thread I vote for that.
>> Nicolai's patches apply cleanly and I think they change about the same
>> amount of code and we don't have to worry about any problems down the
>> road when the revert gets merged into drm-next.
> That's basically why I asked which way to go. However, Monk just
> reported a potential regression in one of Nicolai's changes, so
> reverting seems safer for 4.14.

I agree that reverting the original offending patch is probably the 
better approach.

Regards,
Christian.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [pull] amdgpu drm-fixes-4.14
       [not found]                 ` <b4e9aec8-e69c-e5b2-15d1-c75d9c7dc0f3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2017-10-18 16:05                   ` Michel Dänzer
  2017-10-18 16:58                     ` Deucher, Alexander
  0 siblings, 1 reply; 13+ messages in thread
From: Michel Dänzer @ 2017-10-18 16:05 UTC (permalink / raw)
  To: christian.koenig-5C7GfCeVMHo, Alex Deucher
  Cc: Alex Deucher, Dave Airlie, Maling list - DRI developers, amd-gfx list

On 13/10/17 10:19 AM, Christian König wrote:
> Am 13.10.2017 um 09:41 schrieb Michel Dänzer:
>> On 12/10/17 07:49 PM, Alex Deucher wrote:
>>> On Thu, Oct 12, 2017 at 1:02 PM, Christian König
>>> <ckoenig.leichtzumerken@gmail.com> wrote:
>>>> Am 12.10.2017 um 18:20 schrieb Michel Dänzer:
>>>>> On 12/10/17 05:58 PM, Alex Deucher wrote:
>>>>>> Hi Dave,
>>>>>>
>>>>>> One memory management regression fix.
>>>>>>
>>>>>> The following changes since commit
>>>>>> 545036a9944e9d6e50fed4ca03117147c880ff71:
>>>>>>
>>>>>>     Merge tag 'drm-misc-fixes-2017-10-11' of
>>>>>> git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-10-12
>>>>>> 10:38:09 +1000)
>>>>>>
>>>>>> are available in the git repository at:
>>>>>>
>>>>>>     git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14
>>>>>>
>>>>>> for you to fetch changes up to
>>>>>> 27b94b4f1386c3a8181f5a0277434a32e24e7dd7:
>>>>>>
>>>>>>     drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-12
>>>>>> 10:34:42 -0400)
>>>>>>
>>>>>> ----------------------------------------------------------------
>>>>>> Christian König (1):
>>>>>>         drm/amdgpu: fix placement flags in amdgpu_ttm_bind
>>>>> Thanks Alex, but there's another piglit hang regression in 4.14,
>>>>> caused
>>>>> by commit 6af0883ed977 "drm/amdgpu: discard commands of killed
>>>>> processes", fixed by five commits 6b37d03280a4..318d85de9c20 in
>>>>> amd-staging-drm-next. Either the latter need to be backported to 4.14,
>>>>> or the former needs to be reverted from it.
>>>>
>>>> The revert is probably easier to handle at this point.
>>>>
>>>> So to answer your question from the other thread I vote for that.
>>> Nicolai's patches apply cleanly and I think they change about the same
>>> amount of code and we don't have to worry about any problems down the
>>> road when the revert gets merged into drm-next.
>> That's basically why I asked which way to go. However, Monk just
>> reported a potential regression in one of Nicolai's changes, so
>> reverting seems safer for 4.14.
> 
> I agree that reverting the original offending patch is probably the
> better approach.

Alex, are you planning to send a pull request for the revert? Let me
know if there's anything I can do to help.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 13+ messages in thread

* RE: [pull] amdgpu drm-fixes-4.14
  2017-10-18 16:05                   ` Michel Dänzer
@ 2017-10-18 16:58                     ` Deucher, Alexander
       [not found]                       ` <BN6PR12MB165211DF4F5CB3B9DF33464FF74D0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
  0 siblings, 1 reply; 13+ messages in thread
From: Deucher, Alexander @ 2017-10-18 16:58 UTC (permalink / raw)
  To: 'Michel Dänzer', Koenig, Christian, Alex Deucher
  Cc: Maling list - DRI developers, amd-gfx list

> -----Original Message-----
> From: Michel Dänzer [mailto:michel@daenzer.net]
> Sent: Wednesday, October 18, 2017 12:06 PM
> To: Koenig, Christian; Alex Deucher
> Cc: Deucher, Alexander; Dave Airlie; amd-gfx list; Maling list - DRI developers
> Subject: Re: [pull] amdgpu drm-fixes-4.14
> 
> On 13/10/17 10:19 AM, Christian König wrote:
> > Am 13.10.2017 um 09:41 schrieb Michel Dänzer:
> >> On 12/10/17 07:49 PM, Alex Deucher wrote:
> >>> On Thu, Oct 12, 2017 at 1:02 PM, Christian König
> >>> <ckoenig.leichtzumerken@gmail.com> wrote:
> >>>> Am 12.10.2017 um 18:20 schrieb Michel Dänzer:
> >>>>> On 12/10/17 05:58 PM, Alex Deucher wrote:
> >>>>>> Hi Dave,
> >>>>>>
> >>>>>> One memory management regression fix.
> >>>>>>
> >>>>>> The following changes since commit
> >>>>>> 545036a9944e9d6e50fed4ca03117147c880ff71:
> >>>>>>
> >>>>>>     Merge tag 'drm-misc-fixes-2017-10-11' of
> >>>>>> git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-
> 10-12
> >>>>>> 10:38:09 +1000)
> >>>>>>
> >>>>>> are available in the git repository at:
> >>>>>>
> >>>>>>     git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14
> >>>>>>
> >>>>>> for you to fetch changes up to
> >>>>>> 27b94b4f1386c3a8181f5a0277434a32e24e7dd7:
> >>>>>>
> >>>>>>     drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-
> 12
> >>>>>> 10:34:42 -0400)
> >>>>>>
> >>>>>> ----------------------------------------------------------------
> >>>>>> Christian König (1):
> >>>>>>         drm/amdgpu: fix placement flags in amdgpu_ttm_bind
> >>>>> Thanks Alex, but there's another piglit hang regression in 4.14,
> >>>>> caused
> >>>>> by commit 6af0883ed977 "drm/amdgpu: discard commands of killed
> >>>>> processes", fixed by five commits 6b37d03280a4..318d85de9c20 in
> >>>>> amd-staging-drm-next. Either the latter need to be backported to
> 4.14,
> >>>>> or the former needs to be reverted from it.
> >>>>
> >>>> The revert is probably easier to handle at this point.
> >>>>
> >>>> So to answer your question from the other thread I vote for that.
> >>> Nicolai's patches apply cleanly and I think they change about the same
> >>> amount of code and we don't have to worry about any problems down
> the
> >>> road when the revert gets merged into drm-next.
> >> That's basically why I asked which way to go. However, Monk just
> >> reported a potential regression in one of Nicolai's changes, so
> >> reverting seems safer for 4.14.
> >
> > I agree that reverting the original offending patch is probably the
> > better approach.
> 
> Alex, are you planning to send a pull request for the revert? Let me
> know if there's anything I can do to help.


Yeah, I'll send it out shortly.

Alex

> 
> 
> --
> Earthling Michel Dänzer               |               http://www.amd.com
> Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [pull] amdgpu drm-fixes-4.14
       [not found]                       ` <BN6PR12MB165211DF4F5CB3B9DF33464FF74D0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
@ 2017-10-19  8:00                         ` Christian König
  0 siblings, 0 replies; 13+ messages in thread
From: Christian König @ 2017-10-19  8:00 UTC (permalink / raw)
  To: Deucher, Alexander, 'Michel Dänzer',
	Koenig, Christian, Alex Deucher
  Cc: Dave Airlie, amd-gfx list, Maling list - DRI developers

Am 18.10.2017 um 18:58 schrieb Deucher, Alexander:
>> -----Original Message-----
>> From: Michel Dänzer [mailto:michel@daenzer.net]
>> Sent: Wednesday, October 18, 2017 12:06 PM
>> To: Koenig, Christian; Alex Deucher
>> Cc: Deucher, Alexander; Dave Airlie; amd-gfx list; Maling list - DRI developers
>> Subject: Re: [pull] amdgpu drm-fixes-4.14
>>
>> On 13/10/17 10:19 AM, Christian König wrote:
>>> Am 13.10.2017 um 09:41 schrieb Michel Dänzer:
>>>> On 12/10/17 07:49 PM, Alex Deucher wrote:
>>>>> On Thu, Oct 12, 2017 at 1:02 PM, Christian König
>>>>> <ckoenig.leichtzumerken@gmail.com> wrote:
>>>>>> Am 12.10.2017 um 18:20 schrieb Michel Dänzer:
>>>>>>> On 12/10/17 05:58 PM, Alex Deucher wrote:
>>>>>>>> Hi Dave,
>>>>>>>>
>>>>>>>> One memory management regression fix.
>>>>>>>>
>>>>>>>> The following changes since commit
>>>>>>>> 545036a9944e9d6e50fed4ca03117147c880ff71:
>>>>>>>>
>>>>>>>>      Merge tag 'drm-misc-fixes-2017-10-11' of
>>>>>>>> git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-
>> 10-12
>>>>>>>> 10:38:09 +1000)
>>>>>>>>
>>>>>>>> are available in the git repository at:
>>>>>>>>
>>>>>>>>      git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14
>>>>>>>>
>>>>>>>> for you to fetch changes up to
>>>>>>>> 27b94b4f1386c3a8181f5a0277434a32e24e7dd7:
>>>>>>>>
>>>>>>>>      drm/amdgpu: fix placement flags in amdgpu_ttm_bind (2017-10-
>> 12
>>>>>>>> 10:34:42 -0400)
>>>>>>>>
>>>>>>>> ----------------------------------------------------------------
>>>>>>>> Christian König (1):
>>>>>>>>          drm/amdgpu: fix placement flags in amdgpu_ttm_bind
>>>>>>> Thanks Alex, but there's another piglit hang regression in 4.14,
>>>>>>> caused
>>>>>>> by commit 6af0883ed977 "drm/amdgpu: discard commands of killed
>>>>>>> processes", fixed by five commits 6b37d03280a4..318d85de9c20 in
>>>>>>> amd-staging-drm-next. Either the latter need to be backported to
>> 4.14,
>>>>>>> or the former needs to be reverted from it.
>>>>>> The revert is probably easier to handle at this point.
>>>>>>
>>>>>> So to answer your question from the other thread I vote for that.
>>>>> Nicolai's patches apply cleanly and I think they change about the same
>>>>> amount of code and we don't have to worry about any problems down
>> the
>>>>> road when the revert gets merged into drm-next.
>>>> That's basically why I asked which way to go. However, Monk just
>>>> reported a potential regression in one of Nicolai's changes, so
>>>> reverting seems safer for 4.14.
>>> I agree that reverting the original offending patch is probably the
>>> better approach.
>> Alex, are you planning to send a pull request for the revert? Let me
>> know if there's anything I can do to help.
>
> Yeah, I'll send it out shortly.

Sorry for the delay. I wanted to send a revert on Monday, but somehow 
forgot it over the weekend. Thanks for taking care of this Alex.

Christian.

>
> Alex
>
>>
>> --
>> Earthling Michel Dänzer               |               http://www.amd.com
>> Libre software enthusiast             |             Mesa and X developer
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [pull] amdgpu drm-fixes-4.14
@ 2017-11-02  4:08 Alex Deucher
  0 siblings, 0 replies; 13+ messages in thread
From: Alex Deucher @ 2017-11-02  4:08 UTC (permalink / raw)
  To: amd-gfx, dri-devel, airlied; +Cc: Alex Deucher

Hi Dave,

Just two small patches for stable to fix the driver failing to load on polaris
cards with harvested VCE or UVD blocks.

The following changes since commit d3daa2c7865cbfa830651b11c8ad1df23465b46e:

  drm/amd/amdgpu: Remove workaround check for UVD6 on APUs (2017-10-25 09:32:14 -0400)

are available in the git repository at:

  git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14

for you to fetch changes up to 32bec2afa525149288e6696079bc85f747fa2138:

  drm/amdgpu: allow harvesting check for Polaris VCE (2017-11-01 23:37:16 -0400)

----------------------------------------------------------------
Leo Liu (2):
      drm/amdgpu: return -ENOENT from uvd 6.0 early init for harvesting
      drm/amdgpu: allow harvesting check for Polaris VCE

 drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c |  4 ++++
 drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 12 ++++++------
 2 files changed, 10 insertions(+), 6 deletions(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [pull] amdgpu drm-fixes-4.14
@ 2017-10-25 13:38 Alex Deucher
  0 siblings, 0 replies; 13+ messages in thread
From: Alex Deucher @ 2017-10-25 13:38 UTC (permalink / raw)
  To: amd-gfx, dri-devel, airlied; +Cc: Alex Deucher

Hi Dave,

Just two small patches for suspend/resume regressions.

The following changes since commit 2cb3a34abd035756f9ba3cde12f44f4b3e4c234b:

  Merge tag 'drm-intel-fixes-2017-10-18-1' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes (2017-10-19 15:00:47 +1000)

are available in the git repository at:

  git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14

for you to fetch changes up to d3daa2c7865cbfa830651b11c8ad1df23465b46e:

  drm/amd/amdgpu: Remove workaround check for UVD6 on APUs (2017-10-25 09:32:14 -0400)

----------------------------------------------------------------
Rex Zhu (1):
      drm/amd/powerplay: fix uninitialized variable

Tom St Denis (1):
      drm/amd/amdgpu: Remove workaround check for UVD6 on APUs

 drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c            | 16 +++++-----------
 drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c |  6 +++---
 2 files changed, 8 insertions(+), 14 deletions(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [pull] amdgpu drm-fixes-4.14
@ 2017-10-18 19:38 Alex Deucher
  0 siblings, 0 replies; 13+ messages in thread
From: Alex Deucher @ 2017-10-18 19:38 UTC (permalink / raw)
  To: amd-gfx, dri-devel, airlied; +Cc: Alex Deucher

Hi Dave,

Just one revert to fix a stability regression.

The following changes since commit 2de0307323fc42c6395d0eafec9879d55e042c85:

  Merge tag 'exynos-drm-fixes-for-v4.14-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos into drm-fixes (2017-10-17 10:14:56 +1000)

are available in the git repository at:

  git://people.freedesktop.org/~agd5f/linux drm-fixes-4.14

for you to fetch changes up to c94501279bb191ccf204f496e9576ce036f81bcd:

  Revert "drm/amdgpu: discard commands of killed processes" (2017-10-18 12:57:47 -0400)

----------------------------------------------------------------
Alex Deucher (1):
      Revert "drm/amdgpu: discard commands of killed processes"

 drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 23 ++++-------------------
 1 file changed, 4 insertions(+), 19 deletions(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2017-11-02  4:08 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-12 15:58 [pull] amdgpu drm-fixes-4.14 Alex Deucher
     [not found] ` <1507823900-2785-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-10-12 16:20   ` Michel Dänzer
     [not found]     ` <dfb5a003-f9a1-24f4-90aa-e9f43fdb4e1c-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-10-12 16:53       ` Deucher, Alexander
2017-10-12 17:02       ` Christian König
     [not found]         ` <996c1073-5832-0f3c-91e9-67fac0be6071-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-12 17:49           ` Alex Deucher
2017-10-13  7:41             ` Michel Dänzer
2017-10-13  8:19               ` Christian König
     [not found]                 ` <b4e9aec8-e69c-e5b2-15d1-c75d9c7dc0f3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-18 16:05                   ` Michel Dänzer
2017-10-18 16:58                     ` Deucher, Alexander
     [not found]                       ` <BN6PR12MB165211DF4F5CB3B9DF33464FF74D0-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-10-19  8:00                         ` Christian König
2017-10-18 19:38 Alex Deucher
2017-10-25 13:38 Alex Deucher
2017-11-02  4:08 Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.