[PATCH] tools: xenalyze.c fix format-truncation

[PATCH] tools: xenalyze.c fix format-truncation

[John Thomson]

With gcc optimization enabled by:
tools: detect appropriate debug optimization level
b43501451733193b265de30fd79a764363a2a473

-Wformat-truncation throws warnings

gcc version 7.3.0

xenalyze.c: In function 'find_symbol':
xenalyze.c:382:36: error: 'snprintf' output may be truncated before the last format character [-Werror=format-truncation=]
     snprintf(name, 128, "(%s +%llx)",
                                    ^
xenalyze.c:382:5: note: 'snprintf' output between 6 and 144 bytes into a destination of size 128
     snprintf(name, 128, "(%s +%llx)",
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
              lastname, offset);
              ~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Signed-off-by: John Thomson <git@johnthomson.fastmail.com.au>
---
 tools/xentrace/xenalyze.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c
index 5768b54f86..5ed0a12327 100644
--- a/tools/xentrace/xenalyze.c
+++ b/tools/xentrace/xenalyze.c
@@ -358,7 +358,7 @@ char * find_symbol(unsigned long long addr) {
     int i;
     char * lastname="ZERO";
     unsigned long long offset=addr;
-    static char name[128];
+    static char name[144];
 
     if(!p) {
         name[0]=0;
@@ -379,7 +379,7 @@ char * find_symbol(unsigned long long addr) {
         p=p->next;
     }
  finish:
-    snprintf(name, 128, "(%s +%llx)",
+    snprintf(name, 144, "(%s +%llx)",
              lastname, offset);
     return name;
 }
-- 
2.16.2


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] tools: xenalyze.c fix format-truncation

[George Dunlap]

On 03/14/2018 08:21 AM, John Thomson wrote:
> With gcc optimization enabled by:
> tools: detect appropriate debug optimization level
> b43501451733193b265de30fd79a764363a2a473
> 
> -Wformat-truncation throws warnings
> 
> gcc version 7.3.0
> 
> xenalyze.c: In function 'find_symbol':
> xenalyze.c:382:36: error: 'snprintf' output may be truncated before the last format character [-Werror=format-truncation=]
>      snprintf(name, 128, "(%s +%llx)",
>                                     ^
> xenalyze.c:382:5: note: 'snprintf' output between 6 and 144 bytes into a destination of size 128
>      snprintf(name, 128, "(%s +%llx)",
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>               lastname, offset);
>               ~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> Signed-off-by: John Thomson <git@johnthomson.fastmail.com.au>

It probably really wants to include SYMBOL_NAME_SIZE somewhere, but
that's a minor clean-up for another day. :-)

Thanks!

Reviewed-by: George Dunlap <george.dunlap@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel