* [PATCH v2 0/4] drm/panel: Add Novatek NT35596 panel
@ 2019-03-21 13:59 Jagan Teki
2019-03-21 13:59 ` [PATCH v2 1/4] dt-bindings: Add vendor prefix for novatek Jagan Teki
` (3 more replies)
0 siblings, 4 replies; 14+ messages in thread
From: Jagan Teki @ 2019-03-21 13:59 UTC (permalink / raw)
To: Thierry Reding, David Airlie, Daniel Vetter, Sam Ravnborg,
Rob Herring, Mark Rutland
Cc: Michael Trimarchi, Ryan Pannell, dri-devel, linux-kernel,
linux-amarula, devicetree, Jagan Teki
This is v2 series for Novatek NT35596 panel driver. here is previous
series set[2]
Since there is no proper programming guide for NT35596 IC, the driver
init sequence is referenced from [1] but analyzed based on datasheet.
NT35596 support several regulators on the chip, among those ony 4
regulators like VCI, VDDI/DVDD, AVDD, AVEE are used during power-on
sequence. Right now driver added code for 3-regulator based power-on
sequence since MTF050FHDI-03 panel support. This power-on sequence may
be moved to panel_desc in future, if there is any new panel would come
up with other type of sequence.
Changes for v2:
- control enable/disable calls using enable, prepare flags
- comment on delays
- move 120ms delay on power-on since it is part of power-on sequence
- fix driver name as novatek-nt35596
[2] https://patchwork.freedesktop.org/series/57490/#rev1
[1] https://android.googlesource.com/kernel/msm/+/android-msm-shamu-3.10-lollipop-mr1/arch/arm/boot/dts/qcom/dsi-panel-nt35596-1080p-video.dtsi
Any inputs?
Jagan.
Jagan Teki (4):
dt-bindings: Add vendor prefix for novatek
dt-bindings: Add vendor prefix for microtech
dt-bindings: display: Add Novatek NT35596 panel documentation
drm/panel: Add Novatek NT35596 panel driver
.../display/panel/novatek,nt35596.txt | 32 +
.../devicetree/bindings/vendor-prefixes.txt | 2 +
MAINTAINERS | 6 +
drivers/gpu/drm/panel/Kconfig | 13 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-novatek-nt35596.c | 895 ++++++++++++++++++
6 files changed, 949 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt
create mode 100644 drivers/gpu/drm/panel/panel-novatek-nt35596.c
--
2.18.0.321.gffc6fa0e3
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH v2 1/4] dt-bindings: Add vendor prefix for novatek 2019-03-21 13:59 [PATCH v2 0/4] drm/panel: Add Novatek NT35596 panel Jagan Teki @ 2019-03-21 13:59 ` Jagan Teki 2019-03-31 6:41 ` Rob Herring 2019-03-21 13:59 ` [PATCH v2 2/4] dt-bindings: Add vendor prefix for microtech Jagan Teki ` (2 subsequent siblings) 3 siblings, 1 reply; 14+ messages in thread From: Jagan Teki @ 2019-03-21 13:59 UTC (permalink / raw) To: Thierry Reding, David Airlie, Daniel Vetter, Sam Ravnborg, Rob Herring, Mark Rutland Cc: Michael Trimarchi, Ryan Pannell, dri-devel, linux-kernel, linux-amarula, devicetree, Jagan Teki Add vendor prefix for novatek. Novatek Microelectronics Corp. is a leading fabless chip design company specializing in the design, development and sales of a wide range of display driver ICs & SoC solutions. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index e32d460408dc..caa7dbae750b 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -281,6 +281,7 @@ nintendo Nintendo nlt NLT Technologies, Ltd. nokia Nokia nordic Nordic Semiconductor +novatek Novatek Microelectronics Corp. novtech NovTech, Inc. nutsboard NutsBoard nuvoton Nuvoton Technology Corporation -- 2.18.0.321.gffc6fa0e3 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/4] dt-bindings: Add vendor prefix for novatek 2019-03-21 13:59 ` [PATCH v2 1/4] dt-bindings: Add vendor prefix for novatek Jagan Teki @ 2019-03-31 6:41 ` Rob Herring 0 siblings, 0 replies; 14+ messages in thread From: Rob Herring @ 2019-03-31 6:41 UTC (permalink / raw) To: Jagan Teki Cc: Thierry Reding, David Airlie, Daniel Vetter, Sam Ravnborg, Mark Rutland, Michael Trimarchi, Ryan Pannell, dri-devel, linux-kernel, linux-amarula, devicetree, Jagan Teki On Thu, 21 Mar 2019 19:29:52 +0530, Jagan Teki wrote: > Add vendor prefix for novatek. > > Novatek Microelectronics Corp. is a leading fabless chip design > company specializing in the design, development and sales of a > wide range of display driver ICs & SoC solutions. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/4] dt-bindings: Add vendor prefix for novatek @ 2019-03-31 6:41 ` Rob Herring 0 siblings, 0 replies; 14+ messages in thread From: Rob Herring @ 2019-03-31 6:41 UTC (permalink / raw) Cc: Mark Rutland, Ryan Pannell, devicetree, David Airlie, linux-amarula, linux-kernel, dri-devel, Thierry Reding, Jagan Teki, Michael Trimarchi, Sam Ravnborg On Thu, 21 Mar 2019 19:29:52 +0530, Jagan Teki wrote: > Add vendor prefix for novatek. > > Novatek Microelectronics Corp. is a leading fabless chip design > company specializing in the design, development and sales of a > wide range of display driver ICs & SoC solutions. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 2/4] dt-bindings: Add vendor prefix for microtech 2019-03-21 13:59 [PATCH v2 0/4] drm/panel: Add Novatek NT35596 panel Jagan Teki 2019-03-21 13:59 ` [PATCH v2 1/4] dt-bindings: Add vendor prefix for novatek Jagan Teki @ 2019-03-21 13:59 ` Jagan Teki 2019-03-31 6:41 ` Rob Herring 2019-03-21 13:59 ` Jagan Teki 2019-03-21 13:59 ` [PATCH v2 4/4] drm/panel: Add Novatek NT35596 panel driver Jagan Teki 3 siblings, 1 reply; 14+ messages in thread From: Jagan Teki @ 2019-03-21 13:59 UTC (permalink / raw) To: Thierry Reding, David Airlie, Daniel Vetter, Sam Ravnborg, Rob Herring, Mark Rutland Cc: Michael Trimarchi, Ryan Pannell, dri-devel, linux-kernel, linux-amarula, devicetree, Jagan Teki Add vendor prefix for microtech, known as Microtech Technology Company Limited. a known producer for Liquid Crytal Display modules and Touch Panels. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index caa7dbae750b..9e0b83e61414 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -249,6 +249,7 @@ micrel Micrel Inc. microchip Microchip Technology Inc. microcrystal Micro Crystal AG micron Micron Technology Inc. +microtech Microtech Technology Company Limited mikroe MikroElektronika d.o.o. minix MINIX Technology Ltd. miramems MiraMEMS Sensing Technology Co., Ltd. -- 2.18.0.321.gffc6fa0e3 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/4] dt-bindings: Add vendor prefix for microtech 2019-03-21 13:59 ` [PATCH v2 2/4] dt-bindings: Add vendor prefix for microtech Jagan Teki @ 2019-03-31 6:41 ` Rob Herring 0 siblings, 0 replies; 14+ messages in thread From: Rob Herring @ 2019-03-31 6:41 UTC (permalink / raw) To: Jagan Teki Cc: Thierry Reding, David Airlie, Daniel Vetter, Sam Ravnborg, Mark Rutland, Michael Trimarchi, Ryan Pannell, dri-devel, linux-kernel, linux-amarula, devicetree, Jagan Teki On Thu, 21 Mar 2019 19:29:53 +0530, Jagan Teki wrote: > Add vendor prefix for microtech, known as > Microtech Technology Company Limited. a known producer for > Liquid Crytal Display modules and Touch Panels. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/4] dt-bindings: Add vendor prefix for microtech @ 2019-03-31 6:41 ` Rob Herring 0 siblings, 0 replies; 14+ messages in thread From: Rob Herring @ 2019-03-31 6:41 UTC (permalink / raw) To: Jagan Teki Cc: Thierry Reding, David Airlie, Daniel Vetter, Sam Ravnborg, Mark Rutland, Michael Trimarchi, Ryan Pannell, dri-devel, linux-kernel, linux-amarula, devicetree On Thu, 21 Mar 2019 19:29:53 +0530, Jagan Teki wrote: > Add vendor prefix for microtech, known as > Microtech Technology Company Limited. a known producer for > Liquid Crytal Display modules and Touch Panels. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 3/4] dt-bindings: display: Add Novatek NT35596 panel documentation 2019-03-21 13:59 [PATCH v2 0/4] drm/panel: Add Novatek NT35596 panel Jagan Teki @ 2019-03-21 13:59 ` Jagan Teki 2019-03-21 13:59 ` [PATCH v2 2/4] dt-bindings: Add vendor prefix for microtech Jagan Teki ` (2 subsequent siblings) 3 siblings, 0 replies; 14+ messages in thread From: Jagan Teki @ 2019-03-21 13:59 UTC (permalink / raw) To: Thierry Reding, David Airlie, Daniel Vetter, Sam Ravnborg, Rob Herring, Mark Rutland Cc: Michael Trimarchi, Ryan Pannell, dri-devel, linux-kernel, linux-amarula, devicetree, Jagan Teki Novatek NT35596 is a single-chip IC solution for small or medium-sized LTPS TFT LCD panels. NT35596 provides several system interfaces like MIPI/SPI/I2C. Microtech MTF050FHDI-03 is 1080x1920, 4-lane MIPI DSI LCD panel which has inbuilt NT35596 IC chip. NT35596 support several regulators on the chip, among those only 4 regulators like VCI, VDDI/DVDD, AVDD, AVEE are used during power-on sequence. Out of four regulators MTF050FHDI-03 panel do support 3-regulator based power-on sequence, so this patch documented these 3 needful regulators and rest can be add while supporting new panels on the similar chip IC. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- .../display/panel/novatek,nt35596.txt | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt b/Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt new file mode 100644 index 000000000000..d336cd41e177 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt @@ -0,0 +1,32 @@ +Novatek NT35596 based LCD panels + +Novatek NT35596 is a single-chip IC solution for small or medium-sized +LTPS TFT LCD panels. NT35596 provides several system interfaces like +MIPI/SPI/I2C. + +Microtech MTF050FHDI-03 is 1080x1920, 4-lane MIPI DSI LCD panel which +has inbuilt NT35596 IC chip. + +Required properties: +- compatible: must be "novatek,nt35596" and one of + * "microtech,mtf050fhdi-03" +- reset-gpios: a GPIO phandle for the reset pin + +Required properties for microtech,mtf050fhdi-03: +- reg: DSI virtual channel used by that screen +- dvdd-supply: I/O system regulator +- avdd-supply: analog regulator for MIPI circuit +- avee-supply: analog regulator for MIPI circuit + +Optional properties: +- backlight: phandle for the backlight control. + +panel@0 { + compatible = "microtech,mtf050fhdi-03", "novatek,nt35596"; + reg = <0>; + dvdd-supply = <®_dldo2>; /* VCC-MIPI */ + avdd-supply = <®_dc1sw>; /* AVDD_5V0 */ + avee-supply = <®_dc1sw>; /* AVEE_5V */ + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */ + backlight = <&backlight>; +}; -- 2.18.0.321.gffc6fa0e3 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 3/4] dt-bindings: display: Add Novatek NT35596 panel documentation @ 2019-03-21 13:59 ` Jagan Teki 0 siblings, 0 replies; 14+ messages in thread From: Jagan Teki @ 2019-03-21 13:59 UTC (permalink / raw) To: Thierry Reding, David Airlie, Daniel Vetter, Sam Ravnborg, Rob Herring, Mark Rutland Cc: devicetree, Ryan Pannell, linux-kernel, dri-devel, Jagan Teki, Michael Trimarchi, linux-amarula Novatek NT35596 is a single-chip IC solution for small or medium-sized LTPS TFT LCD panels. NT35596 provides several system interfaces like MIPI/SPI/I2C. Microtech MTF050FHDI-03 is 1080x1920, 4-lane MIPI DSI LCD panel which has inbuilt NT35596 IC chip. NT35596 support several regulators on the chip, among those only 4 regulators like VCI, VDDI/DVDD, AVDD, AVEE are used during power-on sequence. Out of four regulators MTF050FHDI-03 panel do support 3-regulator based power-on sequence, so this patch documented these 3 needful regulators and rest can be add while supporting new panels on the similar chip IC. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- .../display/panel/novatek,nt35596.txt | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt b/Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt new file mode 100644 index 000000000000..d336cd41e177 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt @@ -0,0 +1,32 @@ +Novatek NT35596 based LCD panels + +Novatek NT35596 is a single-chip IC solution for small or medium-sized +LTPS TFT LCD panels. NT35596 provides several system interfaces like +MIPI/SPI/I2C. + +Microtech MTF050FHDI-03 is 1080x1920, 4-lane MIPI DSI LCD panel which +has inbuilt NT35596 IC chip. + +Required properties: +- compatible: must be "novatek,nt35596" and one of + * "microtech,mtf050fhdi-03" +- reset-gpios: a GPIO phandle for the reset pin + +Required properties for microtech,mtf050fhdi-03: +- reg: DSI virtual channel used by that screen +- dvdd-supply: I/O system regulator +- avdd-supply: analog regulator for MIPI circuit +- avee-supply: analog regulator for MIPI circuit + +Optional properties: +- backlight: phandle for the backlight control. + +panel@0 { + compatible = "microtech,mtf050fhdi-03", "novatek,nt35596"; + reg = <0>; + dvdd-supply = <®_dldo2>; /* VCC-MIPI */ + avdd-supply = <®_dc1sw>; /* AVDD_5V0 */ + avee-supply = <®_dc1sw>; /* AVEE_5V */ + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */ + backlight = <&backlight>; +}; -- 2.18.0.321.gffc6fa0e3 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 3/4] dt-bindings: display: Add Novatek NT35596 panel documentation 2019-03-21 13:59 ` Jagan Teki @ 2019-03-31 6:41 ` Rob Herring -1 siblings, 0 replies; 14+ messages in thread From: Rob Herring @ 2019-03-31 6:41 UTC (permalink / raw) To: Jagan Teki Cc: Thierry Reding, David Airlie, Daniel Vetter, Sam Ravnborg, Mark Rutland, Michael Trimarchi, Ryan Pannell, dri-devel, linux-kernel, linux-amarula, devicetree, Jagan Teki On Thu, 21 Mar 2019 19:29:54 +0530, Jagan Teki wrote: > Novatek NT35596 is a single-chip IC solution for small or medium-sized > LTPS TFT LCD panels. NT35596 provides several system interfaces like > MIPI/SPI/I2C. > > Microtech MTF050FHDI-03 is 1080x1920, 4-lane MIPI DSI LCD panel which > has inbuilt NT35596 IC chip. > > NT35596 support several regulators on the chip, among those only 4 regulators > like VCI, VDDI/DVDD, AVDD, AVEE are used during power-on sequence. > > Out of four regulators MTF050FHDI-03 panel do support 3-regulator based > power-on sequence, so this patch documented these 3 needful regulators > and rest can be add while supporting new panels on the similar chip IC. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > .../display/panel/novatek,nt35596.txt | 32 +++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 3/4] dt-bindings: display: Add Novatek NT35596 panel documentation @ 2019-03-31 6:41 ` Rob Herring 0 siblings, 0 replies; 14+ messages in thread From: Rob Herring @ 2019-03-31 6:41 UTC (permalink / raw) Cc: Mark Rutland, Ryan Pannell, devicetree, David Airlie, linux-amarula, linux-kernel, dri-devel, Thierry Reding, Jagan Teki, Michael Trimarchi, Sam Ravnborg On Thu, 21 Mar 2019 19:29:54 +0530, Jagan Teki wrote: > Novatek NT35596 is a single-chip IC solution for small or medium-sized > LTPS TFT LCD panels. NT35596 provides several system interfaces like > MIPI/SPI/I2C. > > Microtech MTF050FHDI-03 is 1080x1920, 4-lane MIPI DSI LCD panel which > has inbuilt NT35596 IC chip. > > NT35596 support several regulators on the chip, among those only 4 regulators > like VCI, VDDI/DVDD, AVDD, AVEE are used during power-on sequence. > > Out of four regulators MTF050FHDI-03 panel do support 3-regulator based > power-on sequence, so this patch documented these 3 needful regulators > and rest can be add while supporting new panels on the similar chip IC. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > .../display/panel/novatek,nt35596.txt | 32 +++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt > Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 4/4] drm/panel: Add Novatek NT35596 panel driver 2019-03-21 13:59 [PATCH v2 0/4] drm/panel: Add Novatek NT35596 panel Jagan Teki ` (2 preceding siblings ...) 2019-03-21 13:59 ` Jagan Teki @ 2019-03-21 13:59 ` Jagan Teki 2019-03-31 7:23 ` Sam Ravnborg 3 siblings, 1 reply; 14+ messages in thread From: Jagan Teki @ 2019-03-21 13:59 UTC (permalink / raw) To: Thierry Reding, David Airlie, Daniel Vetter, Sam Ravnborg, Rob Herring, Mark Rutland Cc: Michael Trimarchi, Ryan Pannell, dri-devel, linux-kernel, linux-amarula, devicetree, Jagan Teki Novatek NT35596 is a single-chip IC solution for small or medium-sized LTPS TFT LCD panels. NT35596 provides several system interfaces like MIPI/SPI/I2C. Currently added support for Microtech MTF050FHDI-03 is 1080x1920, 4-lane MIPI DSI LCD panel which has inbuilt NT35596 IC chip. NT35596 support several regulators on the chip, among those only 4 regulators like VCI, VDDI/DVDD, AVDD, AVEE are used for power-on sequence. This driver added code for 3-regulator based power-on sequence as of now since MTF050FHDI-03 panel support it. This power-on sequence may be moved to panel_desc in future, if any new panel would come up with other type of sequence. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 13 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-novatek-nt35596.c | 895 ++++++++++++++++++ 4 files changed, 915 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-novatek-nt35596.c diff --git a/MAINTAINERS b/MAINTAINERS index a6d18acda78a..4de80222cffb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4922,6 +4922,12 @@ S: Maintained F: drivers/gpu/drm/tinydrm/hx8357d.c F: Documentation/devicetree/bindings/display/himax,hx8357d.txt +DRM DRIVER FOR NOVATEK NT35596 MIPI-DSI LCD PANELS +M: Jagan Teki <jagan@amarulasolutions.com> +S: Maintained +F: drivers/gpu/drm/panel/panel-novatek-nt35596.c +F: Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt + DRM DRIVER FOR INTEL I810 VIDEO CARDS S: Orphan / Obsolete F: drivers/gpu/drm/i810/ diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 5c2c7e8e6ade..c39aaf40445c 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -119,6 +119,19 @@ config DRM_PANEL_LG_LG4573 Say Y here if you want to enable support for LG4573 RGB panel. To compile this driver as a module, choose M here. +config DRM_PANEL_NOVATEK_NT35596 + tristate "Novatek NT35596 panel driver" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y here if you want to enable support for the Novatek NT35596 + panel controller driver. + + Novatek NT35596 is a single-chip IC solution for small or medium + sized LTPS TFT LCD panels. NT35596 provides several system interfaces + like MIPI/SPI/I2C. + config DRM_PANEL_OLIMEX_LCD_OLINUXINO tristate "Olimex LCD-OLinuXino panel" depends on OF diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index 3a853ea5cff9..05bc93348345 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -10,6 +10,7 @@ obj-$(CONFIG_DRM_PANEL_INNOLUX_P079ZCA) += panel-innolux-p079zca.o obj-$(CONFIG_DRM_PANEL_JDI_LT070ME05000) += panel-jdi-lt070me05000.o obj-$(CONFIG_DRM_PANEL_KINGDISPLAY_KD097D04) += panel-kingdisplay-kd097d04.o obj-$(CONFIG_DRM_PANEL_LG_LG4573) += panel-lg-lg4573.o +obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35596) += panel-novatek-nt35596.o obj-$(CONFIG_DRM_PANEL_OLIMEX_LCD_OLINUXINO) += panel-olimex-lcd-olinuxino.o obj-$(CONFIG_DRM_PANEL_ORISETECH_OTM8009A) += panel-orisetech-otm8009a.o obj-$(CONFIG_DRM_PANEL_PANASONIC_VVX10F034N00) += panel-panasonic-vvx10f034n00.o diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35596.c b/drivers/gpu/drm/panel/panel-novatek-nt35596.c new file mode 100644 index 000000000000..433508330321 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-novatek-nt35596.c @@ -0,0 +1,895 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (C) 2018 Amarula Solutions + * Author: Jagan Teki <jagan@amarulasolutions.com> + */ + +#include <drm/drm_mipi_dsi.h> +#include <drm/drm_modes.h> +#include <drm/drm_panel.h> +#include <drm/drm_print.h> + +#include <linux/backlight.h> +#include <linux/gpio/consumer.h> +#include <linux/delay.h> +#include <linux/module.h> +#include <linux/of_device.h> +#include <linux/regulator/consumer.h> + +#include <video/mipi_display.h> + +#define NT35596_CMD_LEN 2 + +struct nt35596_panel_desc { + const struct drm_display_mode *mode; + unsigned int lanes; + unsigned long flags; + enum mipi_dsi_pixel_format format; + const struct nt35596_init_cmd *panel_cmds; + unsigned int num_panel_cmds; +}; + +struct nt35596 { + struct drm_panel panel; + struct mipi_dsi_device *dsi; + const struct nt35596_panel_desc *desc; + + struct backlight_device *backlight; + struct regulator *dvdd; + struct regulator *avdd; + struct regulator *avee; + struct gpio_desc *reset; + + bool prepared; + bool enabled; +}; + +static inline struct nt35596 *panel_to_nt35596(struct drm_panel *panel) +{ + return container_of(panel, struct nt35596, panel); +} + +struct nt35596_init_cmd { + u8 data[NT35596_CMD_LEN]; +}; + +static const struct nt35596_init_cmd microtech_mtf050fhdi_cmds[] = { + { .data = { 0xFF, 0xEE } }, + { .data = { 0xFB, 0x01 } }, + { .data = { 0x1F, 0x45 } }, + { .data = { 0x24, 0x4F } }, + { .data = { 0x38, 0xC8 } }, + { .data = { 0x39, 0x2C } }, + { .data = { 0x1E, 0xBB } }, + { .data = { 0x1D, 0x0F } }, + { .data = { 0x7E, 0xB1 } }, + + /* Enter CMD1, Turn-on Tear ON */ + { .data = { 0xFF, 0x00 } }, + { .data = { 0xFB, 0x01 } }, + { .data = { 0x35, 0x01 } }, + { .data = { 0xBA, 0x03 } }, + + /* CMD2 Page0 */ + { .data = { 0xFF, 0x01 } }, + { .data = { 0xFB, 0x01 } }, + { .data = { 0x00, 0x01 } }, + { .data = { 0x01, 0x55 } }, + { .data = { 0x02, 0x40 } }, + { .data = { 0x05, 0x00 } }, + { .data = { 0x06, 0x1B } }, + { .data = { 0x07, 0x24 } }, + { .data = { 0x08, 0x0C } }, + { .data = { 0x0B, 0x87 } }, + { .data = { 0x0C, 0x87 } }, + { .data = { 0x0E, 0xB0 } }, + { .data = { 0x0F, 0xB3 } }, + { .data = { 0x11, 0x10 } }, + { .data = { 0x12, 0x10 } }, + { .data = { 0x13, 0x05 } }, + { .data = { 0x14, 0x4A } }, + { .data = { 0x15, 0x18 } }, + { .data = { 0x16, 0x18 } }, + { .data = { 0x18, 0x00 } }, + { .data = { 0x19, 0x77 } }, + { .data = { 0x1A, 0x55 } }, + { .data = { 0x1B, 0x13 } }, + { .data = { 0x1C, 0x00 } }, + { .data = { 0x1D, 0x00 } }, + { .data = { 0x1E, 0x13 } }, + { .data = { 0x1F, 0x00 } }, + { .data = { 0x23, 0x00 } }, + { .data = { 0x24, 0x00 } }, + { .data = { 0x25, 0x00 } }, + { .data = { 0x26, 0x00 } }, + { .data = { 0x27, 0x00 } }, + { .data = { 0x28, 0x00 } }, + { .data = { 0x35, 0x00 } }, + { .data = { 0x66, 0x00 } }, + { .data = { 0x58, 0x82 } }, + { .data = { 0x59, 0x02 } }, + { .data = { 0x5A, 0x02 } }, + { .data = { 0x5B, 0x02 } }, + { .data = { 0x5C, 0x82 } }, + { .data = { 0x5D, 0x82 } }, + { .data = { 0x5E, 0x02 } }, + { .data = { 0x5F, 0x02 } }, + { .data = { 0x72, 0x31 } }, + + /* CMD2 Page4 */ + { .data = { 0xFF, 0x05 } }, + { .data = { 0xFB, 0x01 } }, + { .data = { 0x00, 0x01 } }, + { .data = { 0x01, 0x0B } }, + { .data = { 0x02, 0x0C } }, + { .data = { 0x03, 0x09 } }, + { .data = { 0x04, 0x0A } }, + { .data = { 0x05, 0x00 } }, + { .data = { 0x06, 0x0F } }, + { .data = { 0x07, 0x10 } }, + { .data = { 0x08, 0x00 } }, + { .data = { 0x09, 0x00 } }, + { .data = { 0x0A, 0x00 } }, + { .data = { 0x0B, 0x00 } }, + { .data = { 0x0C, 0x00 } }, + { .data = { 0x0D, 0x13 } }, + { .data = { 0x0E, 0x15 } }, + { .data = { 0x0F, 0x17 } }, + { .data = { 0x10, 0x01 } }, + { .data = { 0x11, 0x0B } }, + { .data = { 0x12, 0x0C } }, + { .data = { 0x13, 0x09 } }, + { .data = { 0x14, 0x0A } }, + { .data = { 0x15, 0x00 } }, + { .data = { 0x16, 0x0F } }, + { .data = { 0x17, 0x10 } }, + { .data = { 0x18, 0x00 } }, + { .data = { 0x19, 0x00 } }, + { .data = { 0x1A, 0x00 } }, + { .data = { 0x1B, 0x00 } }, + { .data = { 0x1C, 0x00 } }, + { .data = { 0x1D, 0x13 } }, + { .data = { 0x1E, 0x15 } }, + { .data = { 0x1F, 0x17 } }, + { .data = { 0x20, 0x00 } }, + { .data = { 0x21, 0x03 } }, + { .data = { 0x22, 0x01 } }, + { .data = { 0x23, 0x40 } }, + { .data = { 0x24, 0x40 } }, + { .data = { 0x25, 0xED } }, + { .data = { 0x29, 0x58 } }, + { .data = { 0x2A, 0x12 } }, + { .data = { 0x2B, 0x01 } }, + { .data = { 0x4B, 0x06 } }, + { .data = { 0x4C, 0x11 } }, + { .data = { 0x4D, 0x20 } }, + { .data = { 0x4E, 0x02 } }, + { .data = { 0x4F, 0x02 } }, + { .data = { 0x50, 0x20 } }, + { .data = { 0x51, 0x61 } }, + { .data = { 0x52, 0x01 } }, + { .data = { 0x53, 0x63 } }, + { .data = { 0x54, 0x77 } }, + { .data = { 0x55, 0xED } }, + { .data = { 0x5B, 0x00 } }, + { .data = { 0x5C, 0x00 } }, + { .data = { 0x5D, 0x00 } }, + { .data = { 0x5E, 0x00 } }, + { .data = { 0x5F, 0x15 } }, + { .data = { 0x60, 0x75 } }, + { .data = { 0x61, 0x00 } }, + { .data = { 0x62, 0x00 } }, + { .data = { 0x63, 0x00 } }, + { .data = { 0x64, 0x00 } }, + { .data = { 0x65, 0x00 } }, + { .data = { 0x66, 0x00 } }, + { .data = { 0x67, 0x00 } }, + { .data = { 0x68, 0x04 } }, + { .data = { 0x69, 0x00 } }, + { .data = { 0x6A, 0x00 } }, + { .data = { 0x6C, 0x40 } }, + { .data = { 0x75, 0x01 } }, + { .data = { 0x76, 0x01 } }, + { .data = { 0x7A, 0x80 } }, + { .data = { 0x7B, 0xC5 } }, + { .data = { 0x7C, 0xD8 } }, + { .data = { 0x7D, 0x60 } }, + { .data = { 0x7F, 0x10 } }, + { .data = { 0x80, 0x81 } }, + { .data = { 0x83, 0x05 } }, + { .data = { 0x93, 0x08 } }, + { .data = { 0x94, 0x10 } }, + { .data = { 0x8A, 0x00 } }, + { .data = { 0x9B, 0x0F } }, + { .data = { 0xEA, 0xFF } }, + { .data = { 0xEC, 0x00 } }, + + /* CMD2 Page0 */ + { .data = { 0xFF, 0x01 } }, + { .data = { 0xFB, 0x01 } }, + { .data = { 0x75, 0x00 } }, + { .data = { 0x76, 0x8E } }, + { .data = { 0x77, 0x00 } }, + { .data = { 0x78, 0x90 } }, + { .data = { 0x79, 0x00 } }, + { .data = { 0x7A, 0xB2 } }, + { .data = { 0x7B, 0x00 } }, + { .data = { 0x7C, 0xC7 } }, + { .data = { 0x7D, 0x00 } }, + { .data = { 0x7E, 0xD7 } }, + { .data = { 0x7F, 0x00 } }, + { .data = { 0x80, 0xE9 } }, + { .data = { 0x81, 0x00 } }, + { .data = { 0x82, 0xF9 } }, + { .data = { 0x83, 0x01 } }, + { .data = { 0x84, 0x01 } }, + { .data = { 0x85, 0x01 } }, + { .data = { 0x86, 0x0B } }, + { .data = { 0x87, 0x01 } }, + { .data = { 0x88, 0x3A } }, + { .data = { 0x89, 0x01 } }, + { .data = { 0x8A, 0x5D } }, + { .data = { 0x8B, 0x01 } }, + { .data = { 0x8C, 0x94 } }, + { .data = { 0x8D, 0x01 } }, + { .data = { 0x8E, 0xBC } }, + { .data = { 0x8F, 0x02 } }, + { .data = { 0x90, 0x00 } }, + { .data = { 0x91, 0x02 } }, + { .data = { 0x92, 0x39 } }, + { .data = { 0x93, 0x02 } }, + { .data = { 0x94, 0x3A } }, + { .data = { 0x95, 0x02 } }, + { .data = { 0x96, 0x6B } }, + { .data = { 0x97, 0x02 } }, + { .data = { 0x98, 0xA2 } }, + { .data = { 0x99, 0x02 } }, + { .data = { 0x9A, 0xC7 } }, + { .data = { 0x9B, 0x02 } }, + { .data = { 0x9C, 0xFB } }, + { .data = { 0x9D, 0x03 } }, + { .data = { 0x9E, 0x20 } }, + { .data = { 0x9F, 0x03 } }, + { .data = { 0xA0, 0x54 } }, + { .data = { 0xA2, 0x03 } }, + { .data = { 0xA3, 0x6D } }, + { .data = { 0xA4, 0x03 } }, + { .data = { 0xA5, 0x80 } }, + { .data = { 0xA6, 0x03 } }, + { .data = { 0xA7, 0x81 } }, + { .data = { 0xA9, 0x03 } }, + { .data = { 0xAA, 0xC7 } }, + { .data = { 0xAB, 0x03 } }, + { .data = { 0xAC, 0xF0 } }, + { .data = { 0xAD, 0x03 } }, + { .data = { 0xAE, 0xF8 } }, + { .data = { 0xAF, 0x03 } }, + { .data = { 0xB0, 0xFD } }, + { .data = { 0xB1, 0x03 } }, + { .data = { 0xB2, 0xFE } }, + { .data = { 0xB3, 0x00 } }, + { .data = { 0xB4, 0x8E } }, + { .data = { 0xB5, 0x00 } }, + { .data = { 0xB6, 0x90 } }, + { .data = { 0xB7, 0x00 } }, + { .data = { 0xB8, 0xB2 } }, + { .data = { 0xB9, 0x00 } }, + { .data = { 0xBA, 0xC7 } }, + { .data = { 0xBB, 0x00 } }, + { .data = { 0xBC, 0xD7 } }, + { .data = { 0xBD, 0x00 } }, + { .data = { 0xBE, 0xE9 } }, + { .data = { 0xBF, 0x00 } }, + { .data = { 0xC0, 0xF9 } }, + { .data = { 0xC1, 0x01 } }, + { .data = { 0xC2, 0x01 } }, + { .data = { 0xC3, 0x01 } }, + { .data = { 0xC4, 0x0B } }, + { .data = { 0xC5, 0x01 } }, + { .data = { 0xC6, 0x3A } }, + { .data = { 0xC7, 0x01 } }, + { .data = { 0xC8, 0x5D } }, + { .data = { 0xC9, 0x01 } }, + { .data = { 0xCA, 0x94 } }, + { .data = { 0xCB, 0x01 } }, + { .data = { 0xCC, 0xBC } }, + { .data = { 0xCD, 0x02 } }, + { .data = { 0xCE, 0x00 } }, + { .data = { 0xCF, 0x02 } }, + { .data = { 0xD0, 0x39 } }, + { .data = { 0xD1, 0x02 } }, + { .data = { 0xD2, 0x3A } }, + { .data = { 0xD3, 0x02 } }, + { .data = { 0xD4, 0x6B } }, + { .data = { 0xD5, 0x02 } }, + { .data = { 0xD6, 0xA2 } }, + { .data = { 0xD7, 0x02 } }, + { .data = { 0xD8, 0xC7 } }, + { .data = { 0xD9, 0x02 } }, + { .data = { 0xDA, 0xFB } }, + { .data = { 0xDB, 0x03 } }, + { .data = { 0xDC, 0x20 } }, + { .data = { 0xDD, 0x03 } }, + { .data = { 0xDE, 0x54 } }, + { .data = { 0xDF, 0x03 } }, + { .data = { 0xE0, 0x6D } }, + { .data = { 0xE1, 0x03 } }, + { .data = { 0xE2, 0x80 } }, + { .data = { 0xE3, 0x03 } }, + { .data = { 0xE4, 0x81 } }, + { .data = { 0xE5, 0x03 } }, + { .data = { 0xE6, 0xC7 } }, + { .data = { 0xE7, 0x03 } }, + { .data = { 0xE8, 0xF0 } }, + { .data = { 0xE9, 0x03 } }, + { .data = { 0xEA, 0xF8 } }, + { .data = { 0xEB, 0x03 } }, + { .data = { 0xEC, 0xFD } }, + { .data = { 0xED, 0x03 } }, + { .data = { 0xEE, 0xFE } }, + { .data = { 0xEF, 0x00 } }, + { .data = { 0xF0, 0x03 } }, + { .data = { 0xF1, 0x00 } }, + { .data = { 0xF2, 0x0B } }, + { .data = { 0xF3, 0x00 } }, + { .data = { 0xF4, 0x0D } }, + { .data = { 0xF5, 0x00 } }, + { .data = { 0xF6, 0x4A } }, + { .data = { 0xF7, 0x00 } }, + { .data = { 0xF8, 0x71 } }, + { .data = { 0xF9, 0x00 } }, + { .data = { 0xFA, 0x8C } }, + + /* CMD2 Page1 */ + { .data = { 0xFF, 0x02 } }, + { .data = { 0xFB, 0x01 } }, + { .data = { 0x00, 0x00 } }, + { .data = { 0x01, 0xA1 } }, + { .data = { 0x02, 0x00 } }, + { .data = { 0x03, 0xB6 } }, + { .data = { 0x04, 0x00 } }, + { .data = { 0x05, 0xC9 } }, + { .data = { 0x06, 0x00 } }, + { .data = { 0x07, 0xFD } }, + { .data = { 0x08, 0x01 } }, + { .data = { 0x09, 0x29 } }, + { .data = { 0x0A, 0x01 } }, + { .data = { 0x0B, 0x6B } }, + { .data = { 0x0C, 0x01 } }, + { .data = { 0x0D, 0x9E } }, + { .data = { 0x0E, 0x01 } }, + { .data = { 0x0F, 0xEB } }, + { .data = { 0x10, 0x02 } }, + { .data = { 0x11, 0x25 } }, + { .data = { 0x12, 0x02 } }, + { .data = { 0x13, 0x27 } }, + { .data = { 0x14, 0x02 } }, + { .data = { 0x15, 0x5C } }, + { .data = { 0x16, 0x02 } }, + { .data = { 0x17, 0x95 } }, + { .data = { 0x18, 0x02 } }, + { .data = { 0x19, 0xBA } }, + { .data = { 0x1A, 0x02 } }, + { .data = { 0x1B, 0xEC } }, + { .data = { 0x1C, 0x03 } }, + { .data = { 0x1D, 0x0C } }, + { .data = { 0x1E, 0x03 } }, + { .data = { 0x1F, 0x34 } }, + { .data = { 0x20, 0x03 } }, + { .data = { 0x21, 0x3F } }, + { .data = { 0x22, 0x03 } }, + { .data = { 0x23, 0x48 } }, + { .data = { 0x24, 0x03 } }, + { .data = { 0x25, 0x49 } }, + { .data = { 0x26, 0x03 } }, + { .data = { 0x27, 0x6B } }, + { .data = { 0x28, 0x03 } }, + { .data = { 0x29, 0x7E } }, + { .data = { 0x2A, 0x03 } }, + { .data = { 0x2B, 0x8F } }, + { .data = { 0x2D, 0x03 } }, + { .data = { 0x2F, 0x9E } }, + { .data = { 0x30, 0x03 } }, + { .data = { 0x31, 0xA0 } }, + { .data = { 0x32, 0x00 } }, + { .data = { 0x33, 0x03 } }, + { .data = { 0x34, 0x00 } }, + { .data = { 0x35, 0x0B } }, + { .data = { 0x36, 0x00 } }, + { .data = { 0x37, 0x0D } }, + { .data = { 0x38, 0x00 } }, + { .data = { 0x39, 0x4A } }, + { .data = { 0x3A, 0x00 } }, + { .data = { 0x3B, 0x71 } }, + { .data = { 0x3D, 0x00 } }, + { .data = { 0x3F, 0x8C } }, + { .data = { 0x40, 0x00 } }, + { .data = { 0x41, 0xA1 } }, + { .data = { 0x42, 0x00 } }, + { .data = { 0x43, 0xB6 } }, + { .data = { 0x44, 0x00 } }, + { .data = { 0x45, 0xC9 } }, + { .data = { 0x46, 0x00 } }, + { .data = { 0x47, 0xFD } }, + { .data = { 0x48, 0x01 } }, + { .data = { 0x49, 0x29 } }, + { .data = { 0x4A, 0x01 } }, + { .data = { 0x4B, 0x6B } }, + { .data = { 0x4C, 0x01 } }, + { .data = { 0x4D, 0x9E } }, + { .data = { 0x4E, 0x01 } }, + { .data = { 0x4F, 0xEB } }, + { .data = { 0x50, 0x02 } }, + { .data = { 0x51, 0x25 } }, + { .data = { 0x52, 0x02 } }, + { .data = { 0x53, 0x27 } }, + { .data = { 0x54, 0x02 } }, + { .data = { 0x55, 0x5C } }, + { .data = { 0x56, 0x02 } }, + { .data = { 0x58, 0x95 } }, + { .data = { 0x59, 0x02 } }, + { .data = { 0x5A, 0xBA } }, + { .data = { 0x5B, 0x02 } }, + { .data = { 0x5C, 0xEC } }, + { .data = { 0x5D, 0x03 } }, + { .data = { 0x5E, 0x0C } }, + { .data = { 0x5F, 0x03 } }, + { .data = { 0x60, 0x34 } }, + { .data = { 0x61, 0x03 } }, + { .data = { 0x62, 0x3F } }, + { .data = { 0x63, 0x03 } }, + { .data = { 0x64, 0x48 } }, + { .data = { 0x65, 0x03 } }, + { .data = { 0x66, 0x49 } }, + { .data = { 0x67, 0x03 } }, + { .data = { 0x68, 0x6B } }, + { .data = { 0x69, 0x03 } }, + { .data = { 0x6A, 0x7E } }, + { .data = { 0x6B, 0x03 } }, + { .data = { 0x6C, 0x8F } }, + { .data = { 0x6D, 0x03 } }, + { .data = { 0x6E, 0x9E } }, + { .data = { 0x6F, 0x03 } }, + { .data = { 0x70, 0xA0 } }, + { .data = { 0x71, 0x00 } }, + { .data = { 0x72, 0xFB } }, + { .data = { 0x73, 0x00 } }, + { .data = { 0x74, 0xFD } }, + { .data = { 0x75, 0x01 } }, + { .data = { 0x76, 0x05 } }, + { .data = { 0x77, 0x01 } }, + { .data = { 0x78, 0x0D } }, + { .data = { 0x79, 0x01 } }, + { .data = { 0x7A, 0x17 } }, + { .data = { 0x7B, 0x01 } }, + { .data = { 0x7C, 0x1F } }, + { .data = { 0x7D, 0x01 } }, + { .data = { 0x7E, 0x28 } }, + { .data = { 0x7F, 0x01 } }, + { .data = { 0x80, 0x32 } }, + { .data = { 0x81, 0x01 } }, + { .data = { 0x82, 0x38 } }, + { .data = { 0x83, 0x01 } }, + { .data = { 0x84, 0x53 } }, + { .data = { 0x85, 0x01 } }, + { .data = { 0x86, 0x72 } }, + { .data = { 0x87, 0x01 } }, + { .data = { 0x88, 0x9B } }, + { .data = { 0x89, 0x01 } }, + { .data = { 0x8A, 0xC3 } }, + { .data = { 0x8B, 0x02 } }, + { .data = { 0x8C, 0x01 } }, + { .data = { 0x8D, 0x02 } }, + { .data = { 0x8E, 0x36 } }, + { .data = { 0x8F, 0x02 } }, + { .data = { 0x90, 0x37 } }, + { .data = { 0x91, 0x02 } }, + { .data = { 0x92, 0x69 } }, + { .data = { 0x93, 0x02 } }, + { .data = { 0x94, 0xA1 } }, + { .data = { 0x95, 0x02 } }, + { .data = { 0x96, 0xC8 } }, + { .data = { 0x97, 0x02 } }, + { .data = { 0x98, 0xFF } }, + { .data = { 0x99, 0x03 } }, + { .data = { 0x9A, 0x26 } }, + { .data = { 0x9B, 0x03 } }, + { .data = { 0x9C, 0x69 } }, + { .data = { 0x9D, 0x03 } }, + { .data = { 0x9E, 0x88 } }, + { .data = { 0x9F, 0x03 } }, + { .data = { 0xA0, 0xF8 } }, + { .data = { 0xA2, 0x03 } }, + { .data = { 0xA3, 0xF9 } }, + { .data = { 0xA4, 0x03 } }, + { .data = { 0xA5, 0xFE } }, + { .data = { 0xA6, 0x03 } }, + { .data = { 0xA7, 0xFE } }, + { .data = { 0xA9, 0x03 } }, + { .data = { 0xAA, 0xFE } }, + { .data = { 0xAB, 0x03 } }, + { .data = { 0xAC, 0xFE } }, + { .data = { 0xAD, 0x03 } }, + { .data = { 0xAE, 0xFE } }, + { .data = { 0xAF, 0x00 } }, + { .data = { 0xB0, 0xFB } }, + { .data = { 0xB1, 0x00 } }, + { .data = { 0xB2, 0xFD } }, + { .data = { 0xB3, 0x01 } }, + { .data = { 0xB4, 0x05 } }, + { .data = { 0xB5, 0x01 } }, + { .data = { 0xB6, 0x0D } }, + { .data = { 0xB7, 0x01 } }, + { .data = { 0xB8, 0x17 } }, + { .data = { 0xB9, 0x01 } }, + { .data = { 0xBA, 0x1F } }, + { .data = { 0xBB, 0x01 } }, + { .data = { 0xBC, 0x28 } }, + { .data = { 0xBD, 0x01 } }, + { .data = { 0xBE, 0x32 } }, + { .data = { 0xBF, 0x01 } }, + { .data = { 0xC0, 0x38 } }, + { .data = { 0xC1, 0x01 } }, + { .data = { 0xC2, 0x53 } }, + { .data = { 0xC3, 0x01 } }, + { .data = { 0xC4, 0x72 } }, + { .data = { 0xC5, 0x01 } }, + { .data = { 0xC6, 0x9B } }, + { .data = { 0xC7, 0x01 } }, + { .data = { 0xC8, 0xC3 } }, + { .data = { 0xC9, 0x02 } }, + { .data = { 0xCA, 0x01 } }, + { .data = { 0xCB, 0x02 } }, + { .data = { 0xCC, 0x36 } }, + { .data = { 0xCD, 0x02 } }, + { .data = { 0xCE, 0x37 } }, + { .data = { 0xCF, 0x02 } }, + { .data = { 0xD0, 0x69 } }, + { .data = { 0xD1, 0x02 } }, + { .data = { 0xD2, 0xA1 } }, + { .data = { 0xD3, 0x02 } }, + { .data = { 0xD4, 0xC8 } }, + { .data = { 0xD5, 0x02 } }, + { .data = { 0xD6, 0xFF } }, + { .data = { 0xD7, 0x03 } }, + { .data = { 0xD8, 0x26 } }, + { .data = { 0xD9, 0x03 } }, + { .data = { 0xDA, 0x69 } }, + { .data = { 0xDB, 0x03 } }, + { .data = { 0xDC, 0x88 } }, + { .data = { 0xDD, 0x03 } }, + { .data = { 0xDE, 0xF8 } }, + { .data = { 0xDF, 0x03 } }, + { .data = { 0xE0, 0xF9 } }, + { .data = { 0xE1, 0x03 } }, + { .data = { 0xE2, 0xFE } }, + { .data = { 0xE3, 0x03 } }, + { .data = { 0xE4, 0xFE } }, + { .data = { 0xE5, 0x03 } }, + { .data = { 0xE6, 0xFE } }, + { .data = { 0xE7, 0x03 } }, + { .data = { 0xE8, 0xFE } }, + { .data = { 0xE9, 0x03 } }, + { .data = { 0xEA, 0xFE } }, + + /* CMD1, VBP/VFP settings */ + { .data = { 0xFF, 0x00 } }, + { .data = { 0xD3, 0x14 } }, + { .data = { 0xD4, 0x14 } }, + + /* Exit CMD1, Turn-off Tear ON */ + { .data = { 0xFF, 0x00 } }, + { .data = { 0x35, 0x00 } }, +}; + +static int nt35596_power_on(struct nt35596 *nt35596) +{ + int ret; + + ret = regulator_enable(nt35596->dvdd); + if (ret) + return ret; + + /* T_power_ramp_up for VDDI */ + msleep(2); + + ret = regulator_enable(nt35596->avdd); + if (ret) + return ret; + + /* T_power_ramp_up for AVDD/AVEE */ + msleep(5); + + ret = regulator_enable(nt35596->avee); + if (ret) + return ret; + + msleep(10); + + gpiod_set_value(nt35596->reset, 0); + + msleep(120); + + gpiod_set_value(nt35596->reset, 1); + + /* wait for 120ms after reset deassert */ + msleep(120); + + return 0; +} + +static int nt35596_power_off(struct nt35596 *nt35596) +{ + gpiod_set_value(nt35596->reset, 0); + + msleep(10); + + regulator_disable(nt35596->avee); + + /* T_power_ramp_down for AVEE/AVDD */ + msleep(5); + + regulator_disable(nt35596->avdd); + + /* T_power_ramp_down for VDDI */ + msleep(2); + + regulator_disable(nt35596->dvdd); + + return 0; +} + +static int nt35596_prepare(struct drm_panel *panel) +{ + struct nt35596 *nt35596 = panel_to_nt35596(panel); + struct mipi_dsi_device *dsi = nt35596->dsi; + const struct nt35596_panel_desc *desc = nt35596->desc; + int ret, i; + + if (nt35596->prepared) + return 0; + + ret = nt35596_power_on(nt35596); + if (ret) + return ret; + + for (i = 0; i < desc->num_panel_cmds; i++) { + const struct nt35596_init_cmd *cmd = &desc->panel_cmds[i]; + + ret = mipi_dsi_dcs_write_buffer(dsi, cmd->data, + NT35596_CMD_LEN); + if (ret < 0) { + DRM_DEV_ERROR(panel->dev, + "failed to write cmd %d: %d\n", i, ret); + goto power_off; + } + } + + ret = mipi_dsi_dcs_exit_sleep_mode(dsi); + if (ret < 0) { + DRM_DEV_ERROR(panel->dev, + "failed to exit from sleep mode: %d\n", ret); + goto power_off; + } + + /* wait for 120ms after sending exit sleep mode */ + msleep(120); + + ret = mipi_dsi_dcs_set_display_on(dsi); + if (ret < 0) { + DRM_DEV_ERROR(panel->dev, + "failed to set display on: %d\n", ret); + goto power_off; + } + + nt35596->prepared = true; + + return 0; + +power_off: + if (nt35596_power_off(nt35596)) + DRM_DEV_ERROR(panel->dev, "failed to power off\n"); + return ret; +} + +static int nt35596_enable(struct drm_panel *panel) +{ + struct nt35596 *nt35596 = panel_to_nt35596(panel); + + if (nt35596->enabled) + return 0; + + backlight_enable(nt35596->backlight); + + nt35596->enabled = true; + + return 0; +} + +static int nt35596_disable(struct drm_panel *panel) +{ + struct nt35596 *nt35596 = panel_to_nt35596(panel); + + if (!nt35596->enabled) + return 0; + + backlight_disable(nt35596->backlight); + + nt35596->enabled = false; + + return 0; +} + +static int nt35596_unprepare(struct drm_panel *panel) +{ + struct nt35596 *nt35596 = panel_to_nt35596(panel); + + if (!nt35596->prepared) + return 0; + + mipi_dsi_dcs_set_display_off(nt35596->dsi); + + mipi_dsi_dcs_enter_sleep_mode(nt35596->dsi); + + /* wait for 120ms after sending enter sleep mode */ + msleep(120); + + nt35596_power_off(nt35596); + + nt35596->prepared = false; + + return 0; +} + +static int nt35596_get_modes(struct drm_panel *panel) +{ + struct nt35596 *nt35596 = panel_to_nt35596(panel); + const struct drm_display_mode *desc_mode = nt35596->desc->mode; + struct drm_display_mode *mode; + + mode = drm_mode_duplicate(panel->drm, desc_mode); + if (!mode) { + DRM_DEV_ERROR(&nt35596->dsi->dev, + "failed to add mode %ux%ux@%u\n", + desc_mode->hdisplay, + desc_mode->vdisplay, + desc_mode->vrefresh); + return -ENOMEM; + } + + drm_mode_set_name(mode); + drm_mode_probed_add(panel->connector, mode); + + panel->connector->display_info.width_mm = desc_mode->width_mm; + panel->connector->display_info.height_mm = desc_mode->height_mm; + + return 1; +} + +static const struct drm_panel_funcs nt35596_funcs = { + .disable = nt35596_disable, + .unprepare = nt35596_unprepare, + .prepare = nt35596_prepare, + .enable = nt35596_enable, + .get_modes = nt35596_get_modes, +}; + +static const struct drm_display_mode microtech_mtf050fhdi_mode = { + .clock = 147000, + + .hdisplay = 1080, + .hsync_start = 1080 + 408, + .hsync_end = 1080 + 408 + 4, + .htotal = 1080 + 408 + 4 + 38, + + .vdisplay = 1920, + .vsync_start = 1920 + 9, + .vsync_end = 1920 + 9 + 12, + .vtotal = 1920 + 9 + 12 + 9, + .vrefresh = 50, + + .width_mm = 64, + .height_mm = 118, + + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, +}; + +static const struct nt35596_panel_desc microtech_mtf050fhdi_desc = { + .mode = µtech_mtf050fhdi_mode, + .lanes = 4, + .flags = MIPI_DSI_MODE_VIDEO_BURST, + .format = MIPI_DSI_FMT_RGB888, + .panel_cmds = microtech_mtf050fhdi_cmds, + .num_panel_cmds = ARRAY_SIZE(microtech_mtf050fhdi_cmds), +}; + +static int nt35596_dsi_probe(struct mipi_dsi_device *dsi) +{ + const struct nt35596_panel_desc *desc; + struct nt35596 *nt35596; + int ret; + + nt35596 = devm_kzalloc(&dsi->dev, sizeof(*nt35596), GFP_KERNEL); + if (!nt35596) + return -ENOMEM; + + desc = of_device_get_match_data(&dsi->dev); + dsi->mode_flags = desc->flags; + dsi->format = desc->format; + dsi->lanes = desc->lanes; + + drm_panel_init(&nt35596->panel); + nt35596->panel.dev = &dsi->dev; + nt35596->panel.funcs = &nt35596_funcs; + + nt35596->dvdd = devm_regulator_get(&dsi->dev, "dvdd"); + if (IS_ERR(nt35596->dvdd)) { + DRM_DEV_ERROR(&dsi->dev, "Couldn't get dvdd regulator\n"); + return PTR_ERR(nt35596->dvdd); + } + + nt35596->avdd = devm_regulator_get(&dsi->dev, "avdd"); + if (IS_ERR(nt35596->avdd)) { + DRM_DEV_ERROR(&dsi->dev, "Couldn't get avdd regulator\n"); + return PTR_ERR(nt35596->avdd); + } + + nt35596->avee = devm_regulator_get(&dsi->dev, "avee"); + if (IS_ERR(nt35596->avee)) { + DRM_DEV_ERROR(&dsi->dev, "Couldn't get avee regulator\n"); + return PTR_ERR(nt35596->avee); + } + + nt35596->reset = devm_gpiod_get(&dsi->dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(nt35596->reset)) { + DRM_DEV_ERROR(&dsi->dev, "Couldn't get our reset GPIO\n"); + return PTR_ERR(nt35596->reset); + } + + nt35596->backlight = devm_of_find_backlight(&dsi->dev); + if (IS_ERR(nt35596->backlight)) + return PTR_ERR(nt35596->backlight); + + ret = drm_panel_add(&nt35596->panel); + if (ret < 0) + return ret; + + mipi_dsi_set_drvdata(dsi, nt35596); + nt35596->dsi = dsi; + nt35596->desc = desc; + + return mipi_dsi_attach(dsi); +} + +static int nt35596_dsi_remove(struct mipi_dsi_device *dsi) +{ + struct nt35596 *nt35596 = mipi_dsi_get_drvdata(dsi); + + mipi_dsi_detach(dsi); + drm_panel_remove(&nt35596->panel); + + return 0; +} + +static const struct of_device_id nt35596_of_match[] = { + { + .compatible = "microtech,mtf050fhdi-03", + .data = µtech_mtf050fhdi_desc, + }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, nt35596_of_match); + +static struct mipi_dsi_driver nt35596_driver = { + .probe = nt35596_dsi_probe, + .remove = nt35596_dsi_remove, + .driver = { + .name = "novatek-nt35596", + .of_match_table = nt35596_of_match, + }, +}; +module_mipi_dsi_driver(nt35596_driver); + +MODULE_AUTHOR("Jagan Teki <jagan@amarulasolutions.com>"); +MODULE_DESCRIPTION("Novatek NT35596 MIPI-DSI LCD panel"); +MODULE_LICENSE("GPL"); -- 2.18.0.321.gffc6fa0e3 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 4/4] drm/panel: Add Novatek NT35596 panel driver 2019-03-21 13:59 ` [PATCH v2 4/4] drm/panel: Add Novatek NT35596 panel driver Jagan Teki @ 2019-03-31 7:23 ` Sam Ravnborg 0 siblings, 0 replies; 14+ messages in thread From: Sam Ravnborg @ 2019-03-31 7:23 UTC (permalink / raw) To: Jagan Teki Cc: Thierry Reding, David Airlie, Daniel Vetter, Rob Herring, Mark Rutland, devicetree, Ryan Pannell, linux-kernel, dri-devel, Michael Trimarchi, linux-amarula Hi Jagan. Thanks for this new panel driver. A few notes, please see inline comments below. On Thu, Mar 21, 2019 at 07:29:55PM +0530, Jagan Teki wrote: > Novatek NT35596 is a single-chip IC solution for small or medium-sized > LTPS TFT LCD panels. NT35596 provides several system interfaces like > MIPI/SPI/I2C. > > Currently added support for Microtech MTF050FHDI-03 is 1080x1920, > 4-lane MIPI DSI LCD panel which has inbuilt NT35596 IC chip. > > NT35596 support several regulators on the chip, among those only 4 > regulators like VCI, VDDI/DVDD, AVDD, AVEE are used for power-on > sequence. > > This driver added code for 3-regulator based power-on sequence as > of now since MTF050FHDI-03 panel support it. This power-on sequence > may be moved to panel_desc in future, if any new panel would come > up with other type of sequence. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > diff --git a/MAINTAINERS b/MAINTAINERS > index a6d18acda78a..4de80222cffb 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4922,6 +4922,12 @@ S: Maintained > F: drivers/gpu/drm/tinydrm/hx8357d.c > F: Documentation/devicetree/bindings/display/himax,hx8357d.txt > > +DRM DRIVER FOR NOVATEK NT35596 MIPI-DSI LCD PANELS > +M: Jagan Teki <jagan@amarulasolutions.com> > +S: Maintained > +F: drivers/gpu/drm/panel/panel-novatek-nt35596.c > +F: Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt > + I recall the entries in MAINTAINERS come in alphabetic order based on their headline. So this is the wrong order as "I" comes before "N": DRM DRIVER FOR NOVATEK NT35596 MIPI-DSI LCD PANELS DRM DRIVER FOR INTEL I810 VIDEO CARDS Please move > +#define NT35596_CMD_LEN 2 > + > +struct nt35596_panel_desc { > + const struct drm_display_mode *mode; > + unsigned int lanes; > + unsigned long flags; > + enum mipi_dsi_pixel_format format; > + const struct nt35596_init_cmd *panel_cmds; > + unsigned int num_panel_cmds; > +}; > + > +struct nt35596 { > + struct drm_panel panel; > + struct mipi_dsi_device *dsi; > + const struct nt35596_panel_desc *desc; > + > + struct backlight_device *backlight; > + struct regulator *dvdd; > + struct regulator *avdd; > + struct regulator *avee; > + struct gpio_desc *reset; > + > + bool prepared; > + bool enabled; We should move these flags to the core as more and more drivers seems to neeed them. Something you could take a shot at? > +}; > + > +static inline struct nt35596 *panel_to_nt35596(struct drm_panel *panel) > +{ > + return container_of(panel, struct nt35596, panel); > +} > + > +struct nt35596_init_cmd { > + u8 data[NT35596_CMD_LEN]; > +}; > + > +static const struct nt35596_init_cmd microtech_mtf050fhdi_cmds[] = { > + { .data = { 0xFF, 0xEE } }, ... > + /* Exit CMD1, Turn-off Tear ON */ > + { .data = { 0xFF, 0x00 } }, > + { .data = { 0x35, 0x00 } }, > +}; > + > +static int nt35596_power_on(struct nt35596 *nt35596) > +{ > + int ret; > + > + ret = regulator_enable(nt35596->dvdd); > + if (ret) > + return ret; > + > + /* T_power_ramp_up for VDDI */ > + msleep(2); > + > + ret = regulator_enable(nt35596->avdd); > + if (ret) > + return ret; > + > + /* T_power_ramp_up for AVDD/AVEE */ > + msleep(5); > + > + ret = regulator_enable(nt35596->avee); > + if (ret) > + return ret; > + > + msleep(10); > + > + gpiod_set_value(nt35596->reset, 0); > + > + msleep(120); > + > + gpiod_set_value(nt35596->reset, 1); > + > + /* wait for 120ms after reset deassert */ > + msleep(120); > + > + return 0; > +} > + > +static int nt35596_power_off(struct nt35596 *nt35596) This function never fails. Should you check regulator_disable()? (Mst drivers skips check of regulator_disable() and it seems safe to skip it here too. Make it a void function if it cannot error out. > +{ > + gpiod_set_value(nt35596->reset, 0); > + > + msleep(10); > + > + regulator_disable(nt35596->avee); > + > + /* T_power_ramp_down for AVEE/AVDD */ > + msleep(5); > + > + regulator_disable(nt35596->avdd); > + > + /* T_power_ramp_down for VDDI */ > + msleep(2); > + > + regulator_disable(nt35596->dvdd); > + > + return 0; > +} > + > +static int nt35596_prepare(struct drm_panel *panel) > +{ > + struct nt35596 *nt35596 = panel_to_nt35596(panel); > + struct mipi_dsi_device *dsi = nt35596->dsi; > + const struct nt35596_panel_desc *desc = nt35596->desc; > + int ret, i; > + > + if (nt35596->prepared) > + return 0; > + > + ret = nt35596_power_on(nt35596); > + if (ret) > + return ret; > + > + for (i = 0; i < desc->num_panel_cmds; i++) { > + const struct nt35596_init_cmd *cmd = &desc->panel_cmds[i]; > + > + ret = mipi_dsi_dcs_write_buffer(dsi, cmd->data, > + NT35596_CMD_LEN); > + if (ret < 0) { > + DRM_DEV_ERROR(panel->dev, > + "failed to write cmd %d: %d\n", i, ret); > + goto power_off; > + } > + } > + > + ret = mipi_dsi_dcs_exit_sleep_mode(dsi); > + if (ret < 0) { > + DRM_DEV_ERROR(panel->dev, > + "failed to exit from sleep mode: %d\n", ret); > + goto power_off; > + } > + > + /* wait for 120ms after sending exit sleep mode */ > + msleep(120); > + > + ret = mipi_dsi_dcs_set_display_on(dsi); > + if (ret < 0) { > + DRM_DEV_ERROR(panel->dev, > + "failed to set display on: %d\n", ret); > + goto power_off; In the unprepare function we take care to exter sellp mode before we power off. Should we not do the same here in this error case. We managed to exit sleep mode just above (or so we think at least). > + } > + > + nt35596->prepared = true; > + > + return 0; > + > +power_off: > + if (nt35596_power_off(nt35596)) > + DRM_DEV_ERROR(panel->dev, "failed to power off\n"); > + return ret; > +} > + > +static int nt35596_enable(struct drm_panel *panel) > +{ > + struct nt35596 *nt35596 = panel_to_nt35596(panel); > + > + if (nt35596->enabled) > + return 0; > + > + backlight_enable(nt35596->backlight); > + > + nt35596->enabled = true; > + > + return 0; > +} > + > +static int nt35596_disable(struct drm_panel *panel) > +{ > + struct nt35596 *nt35596 = panel_to_nt35596(panel); > + > + if (!nt35596->enabled) > + return 0; > + > + backlight_disable(nt35596->backlight); > + > + nt35596->enabled = false; > + > + return 0; > +} > + > +static int nt35596_unprepare(struct drm_panel *panel) > +{ > + struct nt35596 *nt35596 = panel_to_nt35596(panel); > + > + if (!nt35596->prepared) > + return 0; > + > + mipi_dsi_dcs_set_display_off(nt35596->dsi); > + > + mipi_dsi_dcs_enter_sleep_mode(nt35596->dsi); > + > + /* wait for 120ms after sending enter sleep mode */ > + msleep(120); > + > + nt35596_power_off(nt35596); > + > + nt35596->prepared = false; > + > + return 0; > +} > + > +static int nt35596_get_modes(struct drm_panel *panel) > +{ > + struct nt35596 *nt35596 = panel_to_nt35596(panel); > + const struct drm_display_mode *desc_mode = nt35596->desc->mode; > + struct drm_display_mode *mode; > + > + mode = drm_mode_duplicate(panel->drm, desc_mode); > + if (!mode) { > + DRM_DEV_ERROR(&nt35596->dsi->dev, > + "failed to add mode %ux%ux@%u\n", Please remove the extra "x" here ^ We want it to print "failed to add mode 1080x1920@50" and not "failed to add mode 1080x1920x@50". > + desc_mode->hdisplay, > + desc_mode->vdisplay, > + desc_mode->vrefresh); > + return -ENOMEM; > + } > + > + drm_mode_set_name(mode); > + drm_mode_probed_add(panel->connector, mode); > + > + panel->connector->display_info.width_mm = desc_mode->width_mm; > + panel->connector->display_info.height_mm = desc_mode->height_mm; > + > + return 1; > +} > + > +static const struct drm_panel_funcs nt35596_funcs = { > + .disable = nt35596_disable, > + .unprepare = nt35596_unprepare, > + .prepare = nt35596_prepare, > + .enable = nt35596_enable, > + .get_modes = nt35596_get_modes, > +}; > + > +static const struct drm_display_mode microtech_mtf050fhdi_mode = { > + .clock = 147000, > + > + .hdisplay = 1080, > + .hsync_start = 1080 + 408, > + .hsync_end = 1080 + 408 + 4, > + .htotal = 1080 + 408 + 4 + 38, > + > + .vdisplay = 1920, > + .vsync_start = 1920 + 9, > + .vsync_end = 1920 + 9 + 12, > + .vtotal = 1920 + 9 + 12 + 9, > + .vrefresh = 50, > + > + .width_mm = 64, > + .height_mm = 118, > + > + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, > +}; > + > +static const struct nt35596_panel_desc microtech_mtf050fhdi_desc = { > + .mode = µtech_mtf050fhdi_mode, > + .lanes = 4, > + .flags = MIPI_DSI_MODE_VIDEO_BURST, > + .format = MIPI_DSI_FMT_RGB888, > + .panel_cmds = microtech_mtf050fhdi_cmds, > + .num_panel_cmds = ARRAY_SIZE(microtech_mtf050fhdi_cmds), > +}; > + > +static int nt35596_dsi_probe(struct mipi_dsi_device *dsi) > +{ > + const struct nt35596_panel_desc *desc; > + struct nt35596 *nt35596; > + int ret; > + > + nt35596 = devm_kzalloc(&dsi->dev, sizeof(*nt35596), GFP_KERNEL); > + if (!nt35596) > + return -ENOMEM; > + > + desc = of_device_get_match_data(&dsi->dev); > + dsi->mode_flags = desc->flags; > + dsi->format = desc->format; > + dsi->lanes = desc->lanes; > + > + drm_panel_init(&nt35596->panel); > + nt35596->panel.dev = &dsi->dev; > + nt35596->panel.funcs = &nt35596_funcs; > + > + nt35596->dvdd = devm_regulator_get(&dsi->dev, "dvdd"); > + if (IS_ERR(nt35596->dvdd)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get dvdd regulator\n"); > + return PTR_ERR(nt35596->dvdd); > + } It would be nive to have the error code in the above error logging. Same goes for the remaining get operatiosn below. > + > + nt35596->avdd = devm_regulator_get(&dsi->dev, "avdd"); > + if (IS_ERR(nt35596->avdd)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get avdd regulator\n"); > + return PTR_ERR(nt35596->avdd); > + } > + > + nt35596->avee = devm_regulator_get(&dsi->dev, "avee"); > + if (IS_ERR(nt35596->avee)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get avee regulator\n"); > + return PTR_ERR(nt35596->avee); > + } > + > + nt35596->reset = devm_gpiod_get(&dsi->dev, "reset", GPIOD_OUT_LOW); > + if (IS_ERR(nt35596->reset)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get our reset GPIO\n"); > + return PTR_ERR(nt35596->reset); > + } > + > + nt35596->backlight = devm_of_find_backlight(&dsi->dev); > + if (IS_ERR(nt35596->backlight)) > + return PTR_ERR(nt35596->backlight); > + > + ret = drm_panel_add(&nt35596->panel); > + if (ret < 0) > + return ret; > + > + mipi_dsi_set_drvdata(dsi, nt35596); > + nt35596->dsi = dsi; > + nt35596->desc = desc; > + > + return mipi_dsi_attach(dsi); > +} > + > +static int nt35596_dsi_remove(struct mipi_dsi_device *dsi) > +{ > + struct nt35596 *nt35596 = mipi_dsi_get_drvdata(dsi); > + > + mipi_dsi_detach(dsi); > + drm_panel_remove(&nt35596->panel); > + > + return 0; > +} > + > +static const struct of_device_id nt35596_of_match[] = { > + { > + .compatible = "microtech,mtf050fhdi-03", > + .data = µtech_mtf050fhdi_desc, > + }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, nt35596_of_match); > + > +static struct mipi_dsi_driver nt35596_driver = { > + .probe = nt35596_dsi_probe, > + .remove = nt35596_dsi_remove, > + .driver = { > + .name = "novatek-nt35596", > + .of_match_table = nt35596_of_match, > + }, > +}; > +module_mipi_dsi_driver(nt35596_driver); > + > +MODULE_AUTHOR("Jagan Teki <jagan@amarulasolutions.com>"); > +MODULE_DESCRIPTION("Novatek NT35596 MIPI-DSI LCD panel"); > +MODULE_LICENSE("GPL"); Please check that this license mathes your SPDX identifier. Sam ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 4/4] drm/panel: Add Novatek NT35596 panel driver @ 2019-03-31 7:23 ` Sam Ravnborg 0 siblings, 0 replies; 14+ messages in thread From: Sam Ravnborg @ 2019-03-31 7:23 UTC (permalink / raw) To: Jagan Teki Cc: Mark Rutland, devicetree, Ryan Pannell, David Airlie, linux-kernel, dri-devel, Rob Herring, Thierry Reding, Michael Trimarchi, linux-amarula Hi Jagan. Thanks for this new panel driver. A few notes, please see inline comments below. On Thu, Mar 21, 2019 at 07:29:55PM +0530, Jagan Teki wrote: > Novatek NT35596 is a single-chip IC solution for small or medium-sized > LTPS TFT LCD panels. NT35596 provides several system interfaces like > MIPI/SPI/I2C. > > Currently added support for Microtech MTF050FHDI-03 is 1080x1920, > 4-lane MIPI DSI LCD panel which has inbuilt NT35596 IC chip. > > NT35596 support several regulators on the chip, among those only 4 > regulators like VCI, VDDI/DVDD, AVDD, AVEE are used for power-on > sequence. > > This driver added code for 3-regulator based power-on sequence as > of now since MTF050FHDI-03 panel support it. This power-on sequence > may be moved to panel_desc in future, if any new panel would come > up with other type of sequence. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > diff --git a/MAINTAINERS b/MAINTAINERS > index a6d18acda78a..4de80222cffb 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4922,6 +4922,12 @@ S: Maintained > F: drivers/gpu/drm/tinydrm/hx8357d.c > F: Documentation/devicetree/bindings/display/himax,hx8357d.txt > > +DRM DRIVER FOR NOVATEK NT35596 MIPI-DSI LCD PANELS > +M: Jagan Teki <jagan@amarulasolutions.com> > +S: Maintained > +F: drivers/gpu/drm/panel/panel-novatek-nt35596.c > +F: Documentation/devicetree/bindings/display/panel/novatek,nt35596.txt > + I recall the entries in MAINTAINERS come in alphabetic order based on their headline. So this is the wrong order as "I" comes before "N": DRM DRIVER FOR NOVATEK NT35596 MIPI-DSI LCD PANELS DRM DRIVER FOR INTEL I810 VIDEO CARDS Please move > +#define NT35596_CMD_LEN 2 > + > +struct nt35596_panel_desc { > + const struct drm_display_mode *mode; > + unsigned int lanes; > + unsigned long flags; > + enum mipi_dsi_pixel_format format; > + const struct nt35596_init_cmd *panel_cmds; > + unsigned int num_panel_cmds; > +}; > + > +struct nt35596 { > + struct drm_panel panel; > + struct mipi_dsi_device *dsi; > + const struct nt35596_panel_desc *desc; > + > + struct backlight_device *backlight; > + struct regulator *dvdd; > + struct regulator *avdd; > + struct regulator *avee; > + struct gpio_desc *reset; > + > + bool prepared; > + bool enabled; We should move these flags to the core as more and more drivers seems to neeed them. Something you could take a shot at? > +}; > + > +static inline struct nt35596 *panel_to_nt35596(struct drm_panel *panel) > +{ > + return container_of(panel, struct nt35596, panel); > +} > + > +struct nt35596_init_cmd { > + u8 data[NT35596_CMD_LEN]; > +}; > + > +static const struct nt35596_init_cmd microtech_mtf050fhdi_cmds[] = { > + { .data = { 0xFF, 0xEE } }, ... > + /* Exit CMD1, Turn-off Tear ON */ > + { .data = { 0xFF, 0x00 } }, > + { .data = { 0x35, 0x00 } }, > +}; > + > +static int nt35596_power_on(struct nt35596 *nt35596) > +{ > + int ret; > + > + ret = regulator_enable(nt35596->dvdd); > + if (ret) > + return ret; > + > + /* T_power_ramp_up for VDDI */ > + msleep(2); > + > + ret = regulator_enable(nt35596->avdd); > + if (ret) > + return ret; > + > + /* T_power_ramp_up for AVDD/AVEE */ > + msleep(5); > + > + ret = regulator_enable(nt35596->avee); > + if (ret) > + return ret; > + > + msleep(10); > + > + gpiod_set_value(nt35596->reset, 0); > + > + msleep(120); > + > + gpiod_set_value(nt35596->reset, 1); > + > + /* wait for 120ms after reset deassert */ > + msleep(120); > + > + return 0; > +} > + > +static int nt35596_power_off(struct nt35596 *nt35596) This function never fails. Should you check regulator_disable()? (Mst drivers skips check of regulator_disable() and it seems safe to skip it here too. Make it a void function if it cannot error out. > +{ > + gpiod_set_value(nt35596->reset, 0); > + > + msleep(10); > + > + regulator_disable(nt35596->avee); > + > + /* T_power_ramp_down for AVEE/AVDD */ > + msleep(5); > + > + regulator_disable(nt35596->avdd); > + > + /* T_power_ramp_down for VDDI */ > + msleep(2); > + > + regulator_disable(nt35596->dvdd); > + > + return 0; > +} > + > +static int nt35596_prepare(struct drm_panel *panel) > +{ > + struct nt35596 *nt35596 = panel_to_nt35596(panel); > + struct mipi_dsi_device *dsi = nt35596->dsi; > + const struct nt35596_panel_desc *desc = nt35596->desc; > + int ret, i; > + > + if (nt35596->prepared) > + return 0; > + > + ret = nt35596_power_on(nt35596); > + if (ret) > + return ret; > + > + for (i = 0; i < desc->num_panel_cmds; i++) { > + const struct nt35596_init_cmd *cmd = &desc->panel_cmds[i]; > + > + ret = mipi_dsi_dcs_write_buffer(dsi, cmd->data, > + NT35596_CMD_LEN); > + if (ret < 0) { > + DRM_DEV_ERROR(panel->dev, > + "failed to write cmd %d: %d\n", i, ret); > + goto power_off; > + } > + } > + > + ret = mipi_dsi_dcs_exit_sleep_mode(dsi); > + if (ret < 0) { > + DRM_DEV_ERROR(panel->dev, > + "failed to exit from sleep mode: %d\n", ret); > + goto power_off; > + } > + > + /* wait for 120ms after sending exit sleep mode */ > + msleep(120); > + > + ret = mipi_dsi_dcs_set_display_on(dsi); > + if (ret < 0) { > + DRM_DEV_ERROR(panel->dev, > + "failed to set display on: %d\n", ret); > + goto power_off; In the unprepare function we take care to exter sellp mode before we power off. Should we not do the same here in this error case. We managed to exit sleep mode just above (or so we think at least). > + } > + > + nt35596->prepared = true; > + > + return 0; > + > +power_off: > + if (nt35596_power_off(nt35596)) > + DRM_DEV_ERROR(panel->dev, "failed to power off\n"); > + return ret; > +} > + > +static int nt35596_enable(struct drm_panel *panel) > +{ > + struct nt35596 *nt35596 = panel_to_nt35596(panel); > + > + if (nt35596->enabled) > + return 0; > + > + backlight_enable(nt35596->backlight); > + > + nt35596->enabled = true; > + > + return 0; > +} > + > +static int nt35596_disable(struct drm_panel *panel) > +{ > + struct nt35596 *nt35596 = panel_to_nt35596(panel); > + > + if (!nt35596->enabled) > + return 0; > + > + backlight_disable(nt35596->backlight); > + > + nt35596->enabled = false; > + > + return 0; > +} > + > +static int nt35596_unprepare(struct drm_panel *panel) > +{ > + struct nt35596 *nt35596 = panel_to_nt35596(panel); > + > + if (!nt35596->prepared) > + return 0; > + > + mipi_dsi_dcs_set_display_off(nt35596->dsi); > + > + mipi_dsi_dcs_enter_sleep_mode(nt35596->dsi); > + > + /* wait for 120ms after sending enter sleep mode */ > + msleep(120); > + > + nt35596_power_off(nt35596); > + > + nt35596->prepared = false; > + > + return 0; > +} > + > +static int nt35596_get_modes(struct drm_panel *panel) > +{ > + struct nt35596 *nt35596 = panel_to_nt35596(panel); > + const struct drm_display_mode *desc_mode = nt35596->desc->mode; > + struct drm_display_mode *mode; > + > + mode = drm_mode_duplicate(panel->drm, desc_mode); > + if (!mode) { > + DRM_DEV_ERROR(&nt35596->dsi->dev, > + "failed to add mode %ux%ux@%u\n", Please remove the extra "x" here ^ We want it to print "failed to add mode 1080x1920@50" and not "failed to add mode 1080x1920x@50". > + desc_mode->hdisplay, > + desc_mode->vdisplay, > + desc_mode->vrefresh); > + return -ENOMEM; > + } > + > + drm_mode_set_name(mode); > + drm_mode_probed_add(panel->connector, mode); > + > + panel->connector->display_info.width_mm = desc_mode->width_mm; > + panel->connector->display_info.height_mm = desc_mode->height_mm; > + > + return 1; > +} > + > +static const struct drm_panel_funcs nt35596_funcs = { > + .disable = nt35596_disable, > + .unprepare = nt35596_unprepare, > + .prepare = nt35596_prepare, > + .enable = nt35596_enable, > + .get_modes = nt35596_get_modes, > +}; > + > +static const struct drm_display_mode microtech_mtf050fhdi_mode = { > + .clock = 147000, > + > + .hdisplay = 1080, > + .hsync_start = 1080 + 408, > + .hsync_end = 1080 + 408 + 4, > + .htotal = 1080 + 408 + 4 + 38, > + > + .vdisplay = 1920, > + .vsync_start = 1920 + 9, > + .vsync_end = 1920 + 9 + 12, > + .vtotal = 1920 + 9 + 12 + 9, > + .vrefresh = 50, > + > + .width_mm = 64, > + .height_mm = 118, > + > + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, > +}; > + > +static const struct nt35596_panel_desc microtech_mtf050fhdi_desc = { > + .mode = µtech_mtf050fhdi_mode, > + .lanes = 4, > + .flags = MIPI_DSI_MODE_VIDEO_BURST, > + .format = MIPI_DSI_FMT_RGB888, > + .panel_cmds = microtech_mtf050fhdi_cmds, > + .num_panel_cmds = ARRAY_SIZE(microtech_mtf050fhdi_cmds), > +}; > + > +static int nt35596_dsi_probe(struct mipi_dsi_device *dsi) > +{ > + const struct nt35596_panel_desc *desc; > + struct nt35596 *nt35596; > + int ret; > + > + nt35596 = devm_kzalloc(&dsi->dev, sizeof(*nt35596), GFP_KERNEL); > + if (!nt35596) > + return -ENOMEM; > + > + desc = of_device_get_match_data(&dsi->dev); > + dsi->mode_flags = desc->flags; > + dsi->format = desc->format; > + dsi->lanes = desc->lanes; > + > + drm_panel_init(&nt35596->panel); > + nt35596->panel.dev = &dsi->dev; > + nt35596->panel.funcs = &nt35596_funcs; > + > + nt35596->dvdd = devm_regulator_get(&dsi->dev, "dvdd"); > + if (IS_ERR(nt35596->dvdd)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get dvdd regulator\n"); > + return PTR_ERR(nt35596->dvdd); > + } It would be nive to have the error code in the above error logging. Same goes for the remaining get operatiosn below. > + > + nt35596->avdd = devm_regulator_get(&dsi->dev, "avdd"); > + if (IS_ERR(nt35596->avdd)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get avdd regulator\n"); > + return PTR_ERR(nt35596->avdd); > + } > + > + nt35596->avee = devm_regulator_get(&dsi->dev, "avee"); > + if (IS_ERR(nt35596->avee)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get avee regulator\n"); > + return PTR_ERR(nt35596->avee); > + } > + > + nt35596->reset = devm_gpiod_get(&dsi->dev, "reset", GPIOD_OUT_LOW); > + if (IS_ERR(nt35596->reset)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get our reset GPIO\n"); > + return PTR_ERR(nt35596->reset); > + } > + > + nt35596->backlight = devm_of_find_backlight(&dsi->dev); > + if (IS_ERR(nt35596->backlight)) > + return PTR_ERR(nt35596->backlight); > + > + ret = drm_panel_add(&nt35596->panel); > + if (ret < 0) > + return ret; > + > + mipi_dsi_set_drvdata(dsi, nt35596); > + nt35596->dsi = dsi; > + nt35596->desc = desc; > + > + return mipi_dsi_attach(dsi); > +} > + > +static int nt35596_dsi_remove(struct mipi_dsi_device *dsi) > +{ > + struct nt35596 *nt35596 = mipi_dsi_get_drvdata(dsi); > + > + mipi_dsi_detach(dsi); > + drm_panel_remove(&nt35596->panel); > + > + return 0; > +} > + > +static const struct of_device_id nt35596_of_match[] = { > + { > + .compatible = "microtech,mtf050fhdi-03", > + .data = µtech_mtf050fhdi_desc, > + }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, nt35596_of_match); > + > +static struct mipi_dsi_driver nt35596_driver = { > + .probe = nt35596_dsi_probe, > + .remove = nt35596_dsi_remove, > + .driver = { > + .name = "novatek-nt35596", > + .of_match_table = nt35596_of_match, > + }, > +}; > +module_mipi_dsi_driver(nt35596_driver); > + > +MODULE_AUTHOR("Jagan Teki <jagan@amarulasolutions.com>"); > +MODULE_DESCRIPTION("Novatek NT35596 MIPI-DSI LCD panel"); > +MODULE_LICENSE("GPL"); Please check that this license mathes your SPDX identifier. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-03-31 7:23 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-03-21 13:59 [PATCH v2 0/4] drm/panel: Add Novatek NT35596 panel Jagan Teki 2019-03-21 13:59 ` [PATCH v2 1/4] dt-bindings: Add vendor prefix for novatek Jagan Teki 2019-03-31 6:41 ` Rob Herring 2019-03-31 6:41 ` Rob Herring 2019-03-21 13:59 ` [PATCH v2 2/4] dt-bindings: Add vendor prefix for microtech Jagan Teki 2019-03-31 6:41 ` Rob Herring 2019-03-31 6:41 ` Rob Herring 2019-03-21 13:59 ` [PATCH v2 3/4] dt-bindings: display: Add Novatek NT35596 panel documentation Jagan Teki 2019-03-21 13:59 ` Jagan Teki 2019-03-31 6:41 ` Rob Herring 2019-03-31 6:41 ` Rob Herring 2019-03-21 13:59 ` [PATCH v2 4/4] drm/panel: Add Novatek NT35596 panel driver Jagan Teki 2019-03-31 7:23 ` Sam Ravnborg 2019-03-31 7:23 ` Sam Ravnborg
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.