* [PATCH v2] net: axi_emac: Use reg property for DMA registers
@ 2023-11-16 16:40 Mayuresh Chitale
2023-11-21 14:29 ` Michal Simek
0 siblings, 1 reply; 5+ messages in thread
From: Mayuresh Chitale @ 2023-11-16 16:40 UTC (permalink / raw)
To: Joe Hershberger, Ramon Fried, Michal Simek
Cc: Mayuresh Chitale, u-boot, Simon Glass, Tom Rini
As per the xlnx,axi-ethernet-1.00.a DT documentation in linux, the AXI
DMA registers can be obtained via the reg property or via a separate
node for the axistream DMA controller. Currently only the latter is
supported, so add support to fetch the DMA controller registers from the
"reg" property.
Signed-off-by: Mayuresh Chitale <mchitale@ventanamicro.com>
Reviewed-by: Michal Simek <michal.simek@amd.com>
---
Changes in v2:
====
Add Reviewed-by Tag.
drivers/net/xilinx_axi_emac.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net/xilinx_axi_emac.c b/drivers/net/xilinx_axi_emac.c
index 54f2232768..ef151ee51b 100644
--- a/drivers/net/xilinx_axi_emac.c
+++ b/drivers/net/xilinx_axi_emac.c
@@ -903,12 +903,11 @@ static int axi_emac_of_to_plat(struct udevice *dev)
ret = dev_read_phandle_with_args(dev, "axistream-connected", NULL, 0, 0,
&axistream_node);
- if (ret) {
- printf("%s: axistream is not found\n", __func__);
- return -EINVAL;
- }
+ if (!ret)
+ plat->dmatx = (struct axidma_reg *)ofnode_get_addr(axistream_node.node);
+ else
+ plat->dmatx = (struct axidma_reg *)dev_read_addr_index(dev, 1);
- plat->dmatx = (struct axidma_reg *)ofnode_get_addr(axistream_node.node);
if (!plat->dmatx) {
printf("%s: axi_dma register space not found\n", __func__);
return -EINVAL;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] net: axi_emac: Use reg property for DMA registers
2023-11-16 16:40 [PATCH v2] net: axi_emac: Use reg property for DMA registers Mayuresh Chitale
@ 2023-11-21 14:29 ` Michal Simek
0 siblings, 0 replies; 5+ messages in thread
From: Michal Simek @ 2023-11-21 14:29 UTC (permalink / raw)
To: Mayuresh Chitale, Joe Hershberger, Ramon Fried
Cc: u-boot, Simon Glass, Tom Rini
On 11/16/23 17:40, Mayuresh Chitale wrote:
> As per the xlnx,axi-ethernet-1.00.a DT documentation in linux, the AXI
> DMA registers can be obtained via the reg property or via a separate
> node for the axistream DMA controller. Currently only the latter is
> supported, so add support to fetch the DMA controller registers from the
> "reg" property.
>
> Signed-off-by: Mayuresh Chitale <mchitale@ventanamicro.com>
> Reviewed-by: Michal Simek <michal.simek@amd.com>
> ---
> Changes in v2:
> ====
> Add Reviewed-by Tag.
>
> drivers/net/xilinx_axi_emac.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/xilinx_axi_emac.c b/drivers/net/xilinx_axi_emac.c
> index 54f2232768..ef151ee51b 100644
> --- a/drivers/net/xilinx_axi_emac.c
> +++ b/drivers/net/xilinx_axi_emac.c
> @@ -903,12 +903,11 @@ static int axi_emac_of_to_plat(struct udevice *dev)
>
> ret = dev_read_phandle_with_args(dev, "axistream-connected", NULL, 0, 0,
> &axistream_node);
> - if (ret) {
> - printf("%s: axistream is not found\n", __func__);
> - return -EINVAL;
> - }
> + if (!ret)
> + plat->dmatx = (struct axidma_reg *)ofnode_get_addr(axistream_node.node);
> + else
> + plat->dmatx = (struct axidma_reg *)dev_read_addr_index(dev, 1);
>
> - plat->dmatx = (struct axidma_reg *)ofnode_get_addr(axistream_node.node);
> if (!plat->dmatx) {
> printf("%s: axi_dma register space not found\n", __func__);
> return -EINVAL;
Applied.
M
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] net: axi_emac: Use reg property for DMA registers
2023-11-13 9:10 ` Michal Simek
@ 2023-11-16 13:22 ` mchitale
0 siblings, 0 replies; 5+ messages in thread
From: mchitale @ 2023-11-16 13:22 UTC (permalink / raw)
To: Michal Simek, Joe Hershberger, Ramon Fried; +Cc: u-boot, Simon Glass, Tom Rini
Hi Michal,
On Mon, 2023-11-13 at 10:10 +0100, Michal Simek wrote:
>
> On 11/11/23 18:36, Mayuresh Chitale wrote:
> > As per the xlnx,axi-ethernet-1.00.a DT documentation in linux, the
> > AXI
> > DMA registers can be obtained via the reg property or via a
> > separate
> > node for the axistream DMA controller. Currently only the latter is
> > supported, so add support to fetch the DMA controller registers
> > from the
> > "reg" property.
> >
> > Signed-off-by: Mayuresh Chitale <mchitale@ventanamicro.com>
> > Reviewed-by: Michal Simek <michal.simek@amd.com>
> > ---
> > Changes in v2:
> > ====
> > Add Reviewed-by Tag.
> >
> > drivers/net/xilinx_axi_emac.c | 9 ++++-----
> > 1 file changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/xilinx_axi_emac.c
> > b/drivers/net/xilinx_axi_emac.c
> > index 54f2232768..ef151ee51b 100644
> > --- a/drivers/net/xilinx_axi_emac.c
> > +++ b/drivers/net/xilinx_axi_emac.c
> > @@ -903,12 +903,11 @@ static int axi_emac_of_to_plat(struct udevice
> > *dev)
> >
> > ret = dev_read_phandle_with_args(dev, "axistream-connected",
> > NULL, 0, 0,
> > &axistream_node);
> > - if (ret) {
> > - printf("%s: axistream is not found\n", __func__);
> > - return -EINVAL;
> > - }
> > + if (!ret)
> > + plat->dmatx = (struct axidma_reg
> > *)ofnode_get_addr(axistream_node.node);
> > + else
> > + plat->dmatx = (struct axidma_reg
> > *)dev_read_addr_index(dev, 1);
> >
> > - plat->dmatx = (struct axidma_reg
> > *)ofnode_get_addr(axistream_node.node);
> > if (!plat->dmatx) {
> > printf("%s: axi_dma register space not found\n",
> > __func__);
> > return -EINVAL;
>
> This is the part of pcie series but it has nothing to do with it. Can
> you please
> send it separately?
Yes, actually I intended to send this patch as well as the PCIe patches
as individual patches but the way I invoked send-email caused those to
become a series.
>
> M
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] net: axi_emac: Use reg property for DMA registers
2023-11-11 17:36 ` [PATCH v2] net: axi_emac: Use reg property for DMA registers Mayuresh Chitale
@ 2023-11-13 9:10 ` Michal Simek
2023-11-16 13:22 ` mchitale
0 siblings, 1 reply; 5+ messages in thread
From: Michal Simek @ 2023-11-13 9:10 UTC (permalink / raw)
To: Mayuresh Chitale, Joe Hershberger, Ramon Fried
Cc: u-boot, Simon Glass, Tom Rini
On 11/11/23 18:36, Mayuresh Chitale wrote:
> As per the xlnx,axi-ethernet-1.00.a DT documentation in linux, the AXI
> DMA registers can be obtained via the reg property or via a separate
> node for the axistream DMA controller. Currently only the latter is
> supported, so add support to fetch the DMA controller registers from the
> "reg" property.
>
> Signed-off-by: Mayuresh Chitale <mchitale@ventanamicro.com>
> Reviewed-by: Michal Simek <michal.simek@amd.com>
> ---
> Changes in v2:
> ====
> Add Reviewed-by Tag.
>
> drivers/net/xilinx_axi_emac.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/xilinx_axi_emac.c b/drivers/net/xilinx_axi_emac.c
> index 54f2232768..ef151ee51b 100644
> --- a/drivers/net/xilinx_axi_emac.c
> +++ b/drivers/net/xilinx_axi_emac.c
> @@ -903,12 +903,11 @@ static int axi_emac_of_to_plat(struct udevice *dev)
>
> ret = dev_read_phandle_with_args(dev, "axistream-connected", NULL, 0, 0,
> &axistream_node);
> - if (ret) {
> - printf("%s: axistream is not found\n", __func__);
> - return -EINVAL;
> - }
> + if (!ret)
> + plat->dmatx = (struct axidma_reg *)ofnode_get_addr(axistream_node.node);
> + else
> + plat->dmatx = (struct axidma_reg *)dev_read_addr_index(dev, 1);
>
> - plat->dmatx = (struct axidma_reg *)ofnode_get_addr(axistream_node.node);
> if (!plat->dmatx) {
> printf("%s: axi_dma register space not found\n", __func__);
> return -EINVAL;
This is the part of pcie series but it has nothing to do with it. Can you please
send it separately?
M
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] net: axi_emac: Use reg property for DMA registers
2023-11-11 17:36 [PATCH v2] drivers: pcie_xilinx: Fix "reg" not found error Mayuresh Chitale
@ 2023-11-11 17:36 ` Mayuresh Chitale
2023-11-13 9:10 ` Michal Simek
0 siblings, 1 reply; 5+ messages in thread
From: Mayuresh Chitale @ 2023-11-11 17:36 UTC (permalink / raw)
To: Joe Hershberger, Ramon Fried, Michal Simek
Cc: Mayuresh Chitale, u-boot, Simon Glass, Tom Rini
As per the xlnx,axi-ethernet-1.00.a DT documentation in linux, the AXI
DMA registers can be obtained via the reg property or via a separate
node for the axistream DMA controller. Currently only the latter is
supported, so add support to fetch the DMA controller registers from the
"reg" property.
Signed-off-by: Mayuresh Chitale <mchitale@ventanamicro.com>
Reviewed-by: Michal Simek <michal.simek@amd.com>
---
Changes in v2:
====
Add Reviewed-by Tag.
drivers/net/xilinx_axi_emac.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net/xilinx_axi_emac.c b/drivers/net/xilinx_axi_emac.c
index 54f2232768..ef151ee51b 100644
--- a/drivers/net/xilinx_axi_emac.c
+++ b/drivers/net/xilinx_axi_emac.c
@@ -903,12 +903,11 @@ static int axi_emac_of_to_plat(struct udevice *dev)
ret = dev_read_phandle_with_args(dev, "axistream-connected", NULL, 0, 0,
&axistream_node);
- if (ret) {
- printf("%s: axistream is not found\n", __func__);
- return -EINVAL;
- }
+ if (!ret)
+ plat->dmatx = (struct axidma_reg *)ofnode_get_addr(axistream_node.node);
+ else
+ plat->dmatx = (struct axidma_reg *)dev_read_addr_index(dev, 1);
- plat->dmatx = (struct axidma_reg *)ofnode_get_addr(axistream_node.node);
if (!plat->dmatx) {
printf("%s: axi_dma register space not found\n", __func__);
return -EINVAL;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-11-21 14:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-16 16:40 [PATCH v2] net: axi_emac: Use reg property for DMA registers Mayuresh Chitale
2023-11-21 14:29 ` Michal Simek
-- strict thread matches above, loose matches on Subject: below --
2023-11-11 17:36 [PATCH v2] drivers: pcie_xilinx: Fix "reg" not found error Mayuresh Chitale
2023-11-11 17:36 ` [PATCH v2] net: axi_emac: Use reg property for DMA registers Mayuresh Chitale
2023-11-13 9:10 ` Michal Simek
2023-11-16 13:22 ` mchitale
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.