From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: John Snow <jsnow@redhat.com>,
Kashyap Chamarthy <kchamart@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
libvir-list@redhat.com, eblake@redhat.com,
xiechanglong.d@gmail.com, wencongyang2@huawei.com,
nshirokovskiy@virtuozzo.com, pkrempa@redhat.com, den@openvz.org,
yur@virtuozzo.com, dim@virtuozzo.com, berrange@redhat.com
Subject: Re: [PATCH v2 3/3] qapi: deprecate drive-backup
Date: Mon, 24 May 2021 17:06:17 +0300 [thread overview]
Message-ID: <5cbaa5bb-65cf-82cd-7f8e-8227a5f50b6d@virtuozzo.com> (raw)
In-Reply-To: <d3207955-794e-2859-14c2-80fa6767a13d@redhat.com>
15.05.2021 01:38, John Snow wrote:
> On 5/6/21 5:57 AM, Kashyap Chamarthy wrote:
>> TODO: We also need to deprecate drive-backup transaction action..
>> But union members in QAPI doesn't support 'deprecated' feature. I tried
>> to dig a bit, but failed :/ Markus, could you please help with it? At
>> least by advice?
>
> Oho, I see.
>
> OK, I'm not Markus, but I've been getting into lots of trouble in the QAPI generator lately, so let me see if I can help get you started...
>
> https://gitlab.com/jsnow/qemu/-/commits/hack-deprecate-union-branches/
>
> Here's a quick hack that might expose that feature. I suppose we can discuss this with Markus and turn these into real patches if that's the direction we wanna head.
>
Hi! Markus is silent.. Maybe, you'll send patches ? )
--
Best regards,
Vladimir
next prev parent reply other threads:[~2021-05-24 14:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 13:58 [PATCH v2 0/3] qapi & doc: deprecate drive-backup Vladimir Sementsov-Ogievskiy
2021-05-05 13:58 ` [PATCH v2 1/3] docs/block-replication: use blockdev-backup Vladimir Sementsov-Ogievskiy
2021-05-14 20:23 ` John Snow
2021-05-05 13:58 ` [PATCH v2 2/3] docs/interop/bitmaps: " Vladimir Sementsov-Ogievskiy
2021-05-06 9:34 ` Kashyap Chamarthy
2021-05-14 20:27 ` John Snow
2021-05-05 13:58 ` [PATCH v2 3/3] qapi: deprecate drive-backup Vladimir Sementsov-Ogievskiy
2021-05-06 9:57 ` Kashyap Chamarthy
2021-05-14 22:38 ` John Snow
2021-05-24 14:06 ` Vladimir Sementsov-Ogievskiy [this message]
2021-05-24 18:37 ` John Snow
2021-09-01 13:29 ` Vladimir Sementsov-Ogievskiy
2021-09-01 14:33 ` Markus Armbruster
2021-06-08 11:12 ` Markus Armbruster
2021-06-08 11:46 ` Vladimir Sementsov-Ogievskiy
2021-06-09 10:49 ` Markus Armbruster
2021-07-05 19:12 ` Vladimir Sementsov-Ogievskiy
2021-09-15 19:25 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cbaa5bb-65cf-82cd-7f8e-8227a5f50b6d@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=den@openvz.org \
--cc=dim@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kchamart@redhat.com \
--cc=libvir-list@redhat.com \
--cc=nshirokovskiy@virtuozzo.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wencongyang2@huawei.com \
--cc=xiechanglong.d@gmail.com \
--cc=yur@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.