meta-freescale's eudev bbappend causing error during patching...

meta-freescale's eudev bbappend causing error during patching...

[Bob Cochran]

Hi,

Working with master branch of meta-freescale and poky this morning and 
meta-freescale's eudev_%.bbappend is adding a patch file that errors 
when trying to apply: skip-rules-for-mmc-rpmb-partition.patch

Patch is only applied for qoriq-ppc machines.

Is this patch still needed?  It mentions SDK1.6, which is pretty old now.

It's trying to add

+KERNEL=="mmcblk*rpmb", GOTO="persistent_storage_end"

to

https://github.com/gentoo/eudev/blob/master/rules/60-persistent-storage.rules


So, is it better to update skip-rules-for-mmc-rpmb-partition.patch or 
just remove eudev_%.bbappend from recipes-core/udev?


BTW, I searched through NXP's SDK 2.0 manual for "rpmb" & "replay 
protected", and it can up dry.


Bob

Re: meta-freescale's eudev bbappend causing error during patching...

[Zhenhua Luo]

Hi Bob, 

> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> bounces@yoctoproject.org] On Behalf Of Bob Cochran
> Sent: Sunday, March 05, 2017 11:32 PM
> 
> It's trying to add
> 
> +KERNEL=="mmcblk*rpmb", GOTO="persistent_storage_end"
> 
> to
> 
> https://github.com/gentoo/eudev/blob/master/rules/60-persistent-
> storage.rules
> 
> 
> So, is it better to update skip-rules-for-mmc-rpmb-partition.patch or just remove
> eudev_%.bbappend from recipes-core/udev?
[Zhenhua Luo] my suggestion is to update skip-rules-for-mmc-rpmb-partition.patch, do you mind to send a patch? 


Best Regards, 

Zhenhua 

Re: meta-freescale's eudev bbappend causing error during patching...

[Bob Cochran]

On 03/08/2017 04:26 AM, Zhenhua Luo wrote:
> Hi Bob,
>
>> -----Original Message-----
>> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
>> bounces@yoctoproject.org] On Behalf Of Bob Cochran
>> Sent: Sunday, March 05, 2017 11:32 PM
>>
>> It's trying to add
>>
>> +KERNEL=="mmcblk*rpmb", GOTO="persistent_storage_end"
>>
>> to
>>
>> https://github.com/gentoo/eudev/blob/master/rules/60-persistent-
>> storage.rules
>>
>>
>> So, is it better to update skip-rules-for-mmc-rpmb-partition.patch or just remove
>> eudev_%.bbappend from recipes-core/udev?
> [Zhenhua Luo] my suggestion is to update skip-rules-for-mmc-rpmb-partition.patch, do you mind to send a patch?

Will do, but I'm going to try to understand the need for it first and 
why it doesn't apply to QoriQ ARM.

>
>
> Best Regards,
>
> Zhenhua
>

Re: meta-freescale's eudev bbappend causing error during patching...

[Bob Cochran]

[-- Attachment #1: Type: text/plain, Size: 2724 bytes --]

On 03/10/2017 02:30 PM, Bob Cochran wrote:
> On 03/08/2017 04:26 AM, Zhenhua Luo wrote:
>> Hi Bob,
>>
>>> -----Original Message-----
>>> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
>>> bounces@yoctoproject.org] On Behalf Of Bob Cochran
>>> Sent: Sunday, March 05, 2017 11:32 PM
>>>
>>> It's trying to add
>>>
>>> +KERNEL=="mmcblk*rpmb", GOTO="persistent_storage_end"
>>>
>>> to
>>>
>>> https://github.com/gentoo/eudev/blob/master/rules/60-persistent-
>>> storage.rules
>>>
>>>
>>> So, is it better to update skip-rules-for-mmc-rpmb-partition.patch 
>>> or just remove
>>> eudev_%.bbappend from recipes-core/udev?
>> [Zhenhua Luo] my suggestion is to update 
>> skip-rules-for-mmc-rpmb-partition.patch, do you mind to send a patch?
>
> Will do, but I'm going to try to understand the need for it first and 
> why it doesn't apply to QoriQ ARM.


I think we should get rid of the eudev_%.bbappend file and related patch 
because it's no longer needed.

At one point eudev/systemd had a similar patch as what meta-freescale 
has, but it was replaced by commit d2313434  (rules: storage - replace 
blacklist with explicit whitelist)

$ git log -p d2313434

commit d2313434acc1cf5387637e72f76c2ebe36d523e1
Author: Kay Sievers <kay@vrfy.org>
Date:   Thu Mar 12 15:03:30 2015 +0100

     rules: storage - relace blacklist with explicit whitelist

     Newly added kernel drivers repeatedly pass our blacklist and
     cause trouble for the devices, because they do not expect to
     be examined by udev's default rules which include blkid.

     This turns the blacklist into a whitelist. Device type which
     need support for additional symlinks need to be added to the
     whitelist now.

<snip>

--- a/rules/60-persistent-storage.rules
+++ b/rules/60-persistent-storage.rules
@@ -12,9 +12,7 @@ ACTION=="remove", GOTO="persistent_storage_end"
  ACTION=="add", SUBSYSTEM=="module", KERNEL=="block", 
ATTR{parameters/events_dfl_poll_msecs}=="0", 
ATTR{parameters/events_dfl_poll_msecs}="2000"

  SUBSYSTEM!="block", GOTO="persistent_storage_end"
-
-# skip rules for inappropriate block devices
-KERNEL=="fd*|mtd*|nbd*|gnbd*|btibm*|dm-*|md*|zram*|mmcblk[0-9]*rpmb", 
GOTO="persistent_storage_end"
+KERNEL!="loop*|mmcblk[0-9]|mspblk[0-9]|nvme*|sd*|sr*|vd*", 
GOTO="persistent_storage_end"

<snip>

Also, I tested this morning a 4.51 eMMC card with RPMB on a LS1021A-TWR 
with a Yocto built image and no eudev patch. It behaved properly - udev 
ignored mmcblk0rpmb.

Zhenhua, if you agree, I'll submit a patch that removes eudev_%.bbappend 
and its patch.


Bob




>
>>
>>
>> Best Regards,
>>
>> Zhenhua
>>
>


[-- Attachment #2: Type: text/html, Size: 4615 bytes --]

Re: meta-freescale's eudev bbappend causing error during patching...

[Otavio Salvador]

On Wed, Mar 15, 2017 at 12:33 PM, Bob Cochran <yocto@mindchasers.com> wrote:
> On 03/10/2017 02:30 PM, Bob Cochran wrote:
>
> On 03/08/2017 04:26 AM, Zhenhua Luo wrote:
>
> Hi Bob,
>
> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> bounces@yoctoproject.org] On Behalf Of Bob Cochran
> Sent: Sunday, March 05, 2017 11:32 PM
>
> It's trying to add
>
> +KERNEL=="mmcblk*rpmb", GOTO="persistent_storage_end"
>
> to
>
> https://github.com/gentoo/eudev/blob/master/rules/60-persistent-
> storage.rules
>
>
> So, is it better to update skip-rules-for-mmc-rpmb-partition.patch or just
> remove
> eudev_%.bbappend from recipes-core/udev?
>
> [Zhenhua Luo] my suggestion is to update
> skip-rules-for-mmc-rpmb-partition.patch, do you mind to send a patch?
>
>
> Will do, but I'm going to try to understand the need for it first and why it
> doesn't apply to QoriQ ARM.
>
>
>
> I think we should get rid of the eudev_%.bbappend file and related patch
> because it's no longer needed.

Agreed. Please prepare the patch so we can clean up our metadata :-)

> At one point eudev/systemd had a similar patch as what meta-freescale has,
> but it was replaced by commit d2313434  (rules: storage - replace blacklist
> with explicit whitelist)
>
> $ git log -p d2313434
>
> commit d2313434acc1cf5387637e72f76c2ebe36d523e1
> Author: Kay Sievers <kay@vrfy.org>
> Date:   Thu Mar 12 15:03:30 2015 +0100
>
>     rules: storage - relace blacklist with explicit whitelist
>
>     Newly added kernel drivers repeatedly pass our blacklist and
>     cause trouble for the devices, because they do not expect to
>     be examined by udev's default rules which include blkid.
>
>     This turns the blacklist into a whitelist. Device type which
>     need support for additional symlinks need to be added to the
>     whitelist now.
>

Thank you for your in depth analysis :-)


-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750