* [PATCH] fbdev: omap2: fix warnings in dss core @ 2019-02-13 8:47 ` Anders Roxell 0 siblings, 0 replies; 4+ messages in thread From: Anders Roxell @ 2019-02-13 8:47 UTC (permalink / raw) To: b.zolnierkie Cc: linux-omap, linux-fbdev, dri-devel, linux-kernel, Anders Roxell Commit 60d2fa0dad06 ("fbdev: omap2: no need to check return value of debugfs_create functions") changed the declaration of the return value of function dss_debugfs_create_file() and the following two warnings appeared: drivers/video/fbdev/omap2/omapfb/dss/core.c: In function ‘dss_debugfs_create_file’: drivers/video/fbdev/omap2/omapfb/dss/core.c:139:9: warning: ‘return’ with a value, in function returning void return 0; ^ drivers/video/fbdev/omap2/omapfb/dss/core.c: In function ‘omap_dss_probe’: drivers/video/fbdev/omap2/omapfb/dss/core.c:172:6: warning: unused variable ‘r’ [-Wunused-variable] int r; ^ Rework so function dss_debugfs_create_file() that is declared to return void don't 'return 0' and remove the declaration of the unused variable 'r'. Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- drivers/video/fbdev/omap2/omapfb/dss/core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c index 7e6a3eb266d0..b5956a1a30d4 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c @@ -136,7 +136,6 @@ static inline void dss_uninitialize_debugfs(void) } void dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) { - return 0; } #endif /* CONFIG_FB_OMAP2_DSS_DEBUGFS */ @@ -169,8 +168,6 @@ static struct notifier_block omap_dss_pm_notif_block = { static int __init omap_dss_probe(struct platform_device *pdev) { - int r; - core.pdev = pdev; dss_features_init(omapdss_get_version()); -- 2.19.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] fbdev: omap2: fix warnings in dss core @ 2019-02-13 8:47 ` Anders Roxell 0 siblings, 0 replies; 4+ messages in thread From: Anders Roxell @ 2019-02-13 8:47 UTC (permalink / raw) To: b.zolnierkie Cc: linux-omap, linux-fbdev, dri-devel, linux-kernel, Anders Roxell Commit 60d2fa0dad06 ("fbdev: omap2: no need to check return value of debugfs_create functions") changed the declaration of the return value of function dss_debugfs_create_file() and the following two warnings appeared: drivers/video/fbdev/omap2/omapfb/dss/core.c: In function ‘dss_debugfs_create_file’: drivers/video/fbdev/omap2/omapfb/dss/core.c:139:9: warning: ‘return’ with a value, in function returning void return 0; ^ drivers/video/fbdev/omap2/omapfb/dss/core.c: In function ‘omap_dss_probe’: drivers/video/fbdev/omap2/omapfb/dss/core.c:172:6: warning: unused variable ‘r’ [-Wunused-variable] int r; ^ Rework so function dss_debugfs_create_file() that is declared to return void don't 'return 0' and remove the declaration of the unused variable 'r'. Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- drivers/video/fbdev/omap2/omapfb/dss/core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c index 7e6a3eb266d0..b5956a1a30d4 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c @@ -136,7 +136,6 @@ static inline void dss_uninitialize_debugfs(void) } void dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) { - return 0; } #endif /* CONFIG_FB_OMAP2_DSS_DEBUGFS */ @@ -169,8 +168,6 @@ static struct notifier_block omap_dss_pm_notif_block = { static int __init omap_dss_probe(struct platform_device *pdev) { - int r; - core.pdev = pdev; dss_features_init(omapdss_get_version()); -- 2.19.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fbdev: omap2: fix warnings in dss core 2019-02-13 8:47 ` Anders Roxell @ 2019-03-01 14:45 ` Bartlomiej Zolnierkiewicz -1 siblings, 0 replies; 4+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2019-03-01 14:45 UTC (permalink / raw) To: Anders Roxell; +Cc: linux-omap, linux-fbdev, dri-devel, linux-kernel On 02/13/2019 09:47 AM, Anders Roxell wrote: > Commit 60d2fa0dad06 ("fbdev: omap2: no need to check return value of > debugfs_create functions") changed the declaration of the return value > of function dss_debugfs_create_file() and the following two warnings > appeared: > > drivers/video/fbdev/omap2/omapfb/dss/core.c: In function ‘dss_debugfs_create_file’: > drivers/video/fbdev/omap2/omapfb/dss/core.c:139:9: warning: ‘return’ with a value, > in function returning void > return 0; > ^ > drivers/video/fbdev/omap2/omapfb/dss/core.c: In function ‘omap_dss_probe’: > drivers/video/fbdev/omap2/omapfb/dss/core.c:172:6: warning: unused variable ‘r’ > [-Wunused-variable] > int r; > ^ > > Rework so function dss_debugfs_create_file() that is declared to return > void don't 'return 0' and remove the declaration of the unused variable > 'r'. > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> Patch queued for v5.1, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fbdev: omap2: fix warnings in dss core @ 2019-03-01 14:45 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 4+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2019-03-01 14:45 UTC (permalink / raw) To: Anders Roxell; +Cc: linux-omap, linux-fbdev, dri-devel, linux-kernel On 02/13/2019 09:47 AM, Anders Roxell wrote: > Commit 60d2fa0dad06 ("fbdev: omap2: no need to check return value of > debugfs_create functions") changed the declaration of the return value > of function dss_debugfs_create_file() and the following two warnings > appeared: > > drivers/video/fbdev/omap2/omapfb/dss/core.c: In function ‘dss_debugfs_create_file’: > drivers/video/fbdev/omap2/omapfb/dss/core.c:139:9: warning: ‘return’ with a value, > in function returning void > return 0; > ^ > drivers/video/fbdev/omap2/omapfb/dss/core.c: In function ‘omap_dss_probe’: > drivers/video/fbdev/omap2/omapfb/dss/core.c:172:6: warning: unused variable ‘r’ > [-Wunused-variable] > int r; > ^ > > Rework so function dss_debugfs_create_file() that is declared to return > void don't 'return 0' and remove the declaration of the unused variable > 'r'. > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> Patch queued for v5.1, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-01 14:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190213084828epcas3p2d7f70d63c5e267197de5513ae96b4fc2@epcas3p2.samsung.com>
2019-02-13 8:47 ` [PATCH] fbdev: omap2: fix warnings in dss core Anders Roxell
2019-02-13 8:47 ` Anders Roxell
2019-03-01 14:45 ` Bartlomiej Zolnierkiewicz
2019-03-01 14:45 ` Bartlomiej Zolnierkiewicz
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.