From: Sinan Kaya <okaya@codeaurora.org> To: Joerg Roedel <joro@8bytes.org> Cc: Gil Kupfer <gilkup@gmail.com>, dwmw2@infradead.org, bhelgaas@google.com, iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, nadav.amit@gmail.com, Gil Kupfer <gilkup@cs.technion.ac.il>, Will Deacon <will.deacon@arm.com>, Bjorn Helgaas <helgaas@kernel.org> Subject: Re: [RFC/RFT] Add noats flag to boot parameters Date: Thu, 3 May 2018 10:23:02 -0400 [thread overview] Message-ID: <5cf699f1-90c1-5ad8-07fe-a65042395d05@codeaurora.org> (raw) In-Reply-To: <20180503135920.o2rdh3exai7qmkvu@8bytes.org> +Bjorn, On 5/3/2018 9:59 AM, Joerg Roedel wrote: > On Thu, May 03, 2018 at 09:46:34AM -0400, Sinan Kaya wrote: >> I also like the idea in general. >> Minor nit.. >> >> Shouldn't this be an iommu parameter rather than a PCI kernel command line parameter? >> We now have an iommu.passthrough argument that prevents page translation. >> >> Doesn't this fit into the same category especially when it is the IOMMU drivers that >> call ATS functions for enablement not the PCI drivers. > > ATS is a bit of a grey area between PCI and IOMMU, but since ATS is > PCI-specific and the code to enable/disable it is in PCI as well, I > think the parameter makes sense for PCI too. > OK. Bjorn was interested in having a command line driven feature enables in driver/pci directory with bitmasks for each optional PCI spec capability rather than noXYZ feature. This would allow us to troubleshoot code breakage as well as the platform bring up to turn off all optional features. Sounds like this would be a good match for that work. > > Joerg > > -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
WARNING: multiple messages have this Message-ID (diff)
From: Sinan Kaya <okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> To: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> Cc: Gil Kupfer <gilkup-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Bjorn Helgaas <helgaas-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org Subject: Re: [RFC/RFT] Add noats flag to boot parameters Date: Thu, 3 May 2018 10:23:02 -0400 [thread overview] Message-ID: <5cf699f1-90c1-5ad8-07fe-a65042395d05@codeaurora.org> (raw) In-Reply-To: <20180503135920.o2rdh3exai7qmkvu-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> +Bjorn, On 5/3/2018 9:59 AM, Joerg Roedel wrote: > On Thu, May 03, 2018 at 09:46:34AM -0400, Sinan Kaya wrote: >> I also like the idea in general. >> Minor nit.. >> >> Shouldn't this be an iommu parameter rather than a PCI kernel command line parameter? >> We now have an iommu.passthrough argument that prevents page translation. >> >> Doesn't this fit into the same category especially when it is the IOMMU drivers that >> call ATS functions for enablement not the PCI drivers. > > ATS is a bit of a grey area between PCI and IOMMU, but since ATS is > PCI-specific and the code to enable/disable it is in PCI as well, I > think the parameter makes sense for PCI too. > OK. Bjorn was interested in having a command line driven feature enables in driver/pci directory with bitmasks for each optional PCI spec capability rather than noXYZ feature. This would allow us to troubleshoot code breakage as well as the platform bring up to turn off all optional features. Sounds like this would be a good match for that work. > > Joerg > > -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-05-03 14:23 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-29 18:16 [RFC/RFT] Add noats flag to boot parameters Gil Kupfer 2018-05-03 13:35 ` Joerg Roedel 2018-05-03 13:46 ` Sinan Kaya 2018-05-03 13:46 ` Sinan Kaya 2018-05-03 13:59 ` Joerg Roedel 2018-05-03 13:59 ` Joerg Roedel 2018-05-03 14:23 ` Sinan Kaya [this message] 2018-05-03 14:23 ` Sinan Kaya 2018-05-03 22:15 ` Nadav Amit 2018-05-03 22:15 ` Nadav Amit 2018-05-03 22:15 ` Nadav Amit 2018-05-03 22:52 ` Bjorn Helgaas 2018-05-03 22:52 ` Bjorn Helgaas 2018-05-10 23:09 ` Bjorn Helgaas 2018-05-10 23:09 ` Bjorn Helgaas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5cf699f1-90c1-5ad8-07fe-a65042395d05@codeaurora.org \ --to=okaya@codeaurora.org \ --cc=bhelgaas@google.com \ --cc=dwmw2@infradead.org \ --cc=gilkup@cs.technion.ac.il \ --cc=gilkup@gmail.com \ --cc=helgaas@kernel.org \ --cc=iommu@lists.linux-foundation.org \ --cc=joro@8bytes.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=nadav.amit@gmail.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.