From: Lucas Stach <l.stach@pengutronix.de> To: Laurentiu Palcu <laurentiu.palcu@nxp.com>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com> Cc: agx@sigxcpu.org, lukas@mntmn.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/4] arm64: dts: imx8mq: add DCSS node Date: Mon, 24 Feb 2020 18:23:51 +0100 [thread overview] Message-ID: <5d0f20b76e31360372a410983b013551062e9a91.camel@pengutronix.de> (raw) In-Reply-To: <1575625964-27102-5-git-send-email-laurentiu.palcu@nxp.com> On Fr, 2019-12-06 at 11:52 +0200, Laurentiu Palcu wrote: > This patch adds the node for iMX8MQ Display Controller Subsystem. > > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index f6e840c..da7e485 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -981,6 +981,31 @@ > interrupt-controller; > #interrupt-cells = <1>; > }; > + > + dcss: display-controller@32e00000 { Node address is lower than the irqsteer node, so the dcss node should be added before, not after the irqsteer node in the DT. > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "nxp,imx8mq-dcss"; > + reg = <0x32e00000 0x2d000>, <0x32e2f000 0x1000>; > + interrupts = <6>, <8>, <9>; > + interrupt-names = "ctx_ld", "ctxld_kick", "vblank"; > + interrupt-parent = <&irqsteer>; > + clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>, > + <&clk IMX8MQ_CLK_DISP_AXI_ROOT>, > + <&clk IMX8MQ_CLK_DISP_RTRM_ROOT>, > + <&clk IMX8MQ_VIDEO2_PLL_OUT>, > + <&clk IMX8MQ_CLK_DISP_DTRC>; > + clock-names = "apb", "axi", "rtrm", "pix", "dtrc"; > + assigned-clocks = <&clk IMX8MQ_CLK_DISP_AXI>, > + <&clk IMX8MQ_CLK_DISP_RTRM>, > + <&clk IMX8MQ_VIDEO2_PLL1_REF_SEL>; > + assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_800M>, > + <&clk IMX8MQ_SYS1_PLL_800M>, > + <&clk IMX8MQ_CLK_27M>; > + assigned-clock-rates = <800000000>, > + <400000000>; Second line is not aligned to the first one. > + status = "disabled"; > + }; > }; > > gpu: gpu@38000000 {
WARNING: multiple messages have this Message-ID (diff)
From: Lucas Stach <l.stach@pengutronix.de> To: Laurentiu Palcu <laurentiu.palcu@nxp.com>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com> Cc: devicetree@vger.kernel.org, agx@sigxcpu.org, lukas@mntmn.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 4/4] arm64: dts: imx8mq: add DCSS node Date: Mon, 24 Feb 2020 18:23:51 +0100 [thread overview] Message-ID: <5d0f20b76e31360372a410983b013551062e9a91.camel@pengutronix.de> (raw) In-Reply-To: <1575625964-27102-5-git-send-email-laurentiu.palcu@nxp.com> On Fr, 2019-12-06 at 11:52 +0200, Laurentiu Palcu wrote: > This patch adds the node for iMX8MQ Display Controller Subsystem. > > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index f6e840c..da7e485 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -981,6 +981,31 @@ > interrupt-controller; > #interrupt-cells = <1>; > }; > + > + dcss: display-controller@32e00000 { Node address is lower than the irqsteer node, so the dcss node should be added before, not after the irqsteer node in the DT. > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "nxp,imx8mq-dcss"; > + reg = <0x32e00000 0x2d000>, <0x32e2f000 0x1000>; > + interrupts = <6>, <8>, <9>; > + interrupt-names = "ctx_ld", "ctxld_kick", "vblank"; > + interrupt-parent = <&irqsteer>; > + clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>, > + <&clk IMX8MQ_CLK_DISP_AXI_ROOT>, > + <&clk IMX8MQ_CLK_DISP_RTRM_ROOT>, > + <&clk IMX8MQ_VIDEO2_PLL_OUT>, > + <&clk IMX8MQ_CLK_DISP_DTRC>; > + clock-names = "apb", "axi", "rtrm", "pix", "dtrc"; > + assigned-clocks = <&clk IMX8MQ_CLK_DISP_AXI>, > + <&clk IMX8MQ_CLK_DISP_RTRM>, > + <&clk IMX8MQ_VIDEO2_PLL1_REF_SEL>; > + assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_800M>, > + <&clk IMX8MQ_SYS1_PLL_800M>, > + <&clk IMX8MQ_CLK_27M>; > + assigned-clock-rates = <800000000>, > + <400000000>; Second line is not aligned to the first one. > + status = "disabled"; > + }; > }; > > gpu: gpu@38000000 { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-24 17:23 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-06 9:52 [PATCH v3 0/4] Add support for iMX8MQ Display Controller Subsystem Laurentiu Palcu 2019-12-06 9:52 ` Laurentiu Palcu 2019-12-06 9:52 ` Laurentiu Palcu 2019-12-06 9:52 ` [PATCH v3 1/4] drm/imx: compile imx directory by default Laurentiu Palcu 2019-12-06 9:52 ` Laurentiu Palcu 2019-12-06 9:52 ` [PATCH v3 2/4] drm/imx: Add initial support for DCSS on iMX8MQ Laurentiu Palcu 2019-12-06 9:52 ` Laurentiu Palcu 2020-02-24 17:27 ` Lucas Stach 2020-02-24 17:27 ` Lucas Stach 2020-02-24 17:27 ` Lucas Stach 2020-02-26 7:52 ` Laurentiu Palcu 2020-02-26 7:52 ` Laurentiu Palcu 2020-02-26 7:52 ` Laurentiu Palcu 2020-02-26 13:19 ` Lucas Stach 2020-02-26 13:19 ` Lucas Stach 2020-03-06 9:58 ` Laurentiu Palcu 2020-03-06 9:58 ` Laurentiu Palcu 2020-03-06 10:20 ` Philipp Zabel 2020-03-06 10:20 ` Philipp Zabel 2020-03-06 10:20 ` Philipp Zabel 2020-03-06 11:12 ` Laurentiu Palcu 2020-03-06 11:12 ` Laurentiu Palcu 2020-03-06 11:12 ` Laurentiu Palcu 2019-12-06 9:52 ` [PATCH v3 3/4] dt-bindings: display: imx: add bindings for DCSS Laurentiu Palcu 2019-12-06 9:52 ` Laurentiu Palcu 2019-12-06 9:52 ` Laurentiu Palcu 2020-02-24 17:21 ` Lucas Stach 2020-02-24 17:21 ` Lucas Stach 2020-02-24 17:21 ` Lucas Stach 2020-02-26 7:58 ` Laurentiu Palcu 2020-02-26 7:58 ` Laurentiu Palcu 2020-02-26 7:58 ` Laurentiu Palcu 2020-02-27 11:52 ` Philipp Zabel 2020-02-27 11:52 ` Philipp Zabel 2020-02-27 11:52 ` Philipp Zabel 2019-12-06 9:52 ` [PATCH v3 4/4] arm64: dts: imx8mq: add DCSS node Laurentiu Palcu 2019-12-06 9:52 ` Laurentiu Palcu 2020-02-24 17:23 ` Lucas Stach [this message] 2020-02-24 17:23 ` Lucas Stach 2020-02-26 8:02 ` Laurentiu Palcu 2020-02-26 8:02 ` Laurentiu Palcu 2019-12-11 20:16 ` [PATCH v3 0/4] Add support for iMX8MQ Display Controller Subsystem Lukas Hartmann 2020-02-21 12:15 ` Guido Günther 2020-02-21 12:15 ` Guido Günther 2020-02-21 12:15 ` Guido Günther
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5d0f20b76e31360372a410983b013551062e9a91.camel@pengutronix.de \ --to=l.stach@pengutronix.de \ --cc=agx@sigxcpu.org \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=laurentiu.palcu@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lukas@mntmn.com \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.