From: Ahmad Fatoum <a.fatoum@pengutronix.de> To: Jarkko Sakkinen <jarkko@kernel.org> Cc: "Alasdair Kergon" <agk@redhat.com>, "Mike Snitzer" <snitzer@redhat.com>, dm-devel@redhat.com, "Song Liu" <song@kernel.org>, kernel@pengutronix.de, "Jan Lübbe" <jlu@pengutronix.de>, linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, "Dmitry Baryshkov" <dbaryshkov@gmail.com>, "Jonathan Corbet" <corbet@lwn.net>, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, "Sumit Garg" <sumit.garg@linaro.org> Subject: Re: [PATCH 2/2] dm crypt: support using trusted keys Date: Fri, 22 Jan 2021 20:04:46 +0100 [thread overview] Message-ID: <5d44e50e-4309-830b-79f6-f5d888b1ef69@pengutronix.de> (raw) In-Reply-To: <YAsW8DAt3vc68rLA@kernel.org> Hello Jarkko, On 22.01.21 19:18, Jarkko Sakkinen wrote: > On Fri, Jan 22, 2021 at 08:05:51PM +0200, Jarkko Sakkinen wrote: >> On Fri, Jan 22, 2021 at 09:43:21AM +0100, Ahmad Fatoum wrote: >>> Commit 27f5411a718c ("dm crypt: support using encrypted keys") extended >>> dm-crypt to allow use of "encrypted" keys along with "user" and "logon". >>> >>> Along the same lines, teach dm-crypt to support "trusted" keys as well. >>> >>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> >>> --- >> >> Is it possible to test run this with tmpfs? Would be a good test >> target for Sumit's ARM-TEE trusted keys patches. I tested these on top of Sumit's patches with TPM and a CAAM blobifier backend, I am preparing. The system I am developing these patches against doesn't have a TEE. Steps to test these changes: #!/bin/sh DEV=/dev/loop0 ALGO=aes-cbc-essiv:sha256 KEYNAME=kmk BLOCKS=20 fallocate -l $((BLOCKS*512)) /tmp/loop0.img losetup -P $DEV /tmp/loop0.img mount -o remount,rw / KEY="$(keyctl add trusted $KEYNAME 'new 32' @s)" keyctl pipe $KEY >$HOME/kmk.blob TABLE="0 $BLOCKS crypt $ALGO :32:trusted:$KEYNAME 0 $DEV 0 1 allow_discards" echo $TABLE | dmsetup create mydev echo $TABLE | dmsetup load mydev dd if=/dev/zero of=/dev/mapper/mydev echo "It works!" 1<> /dev/mapper/mydev cryptsetup close mydev reboot DEV=/dev/loop0 ALGO=aes-cbc-essiv:sha256 KEYNAME=kmk BLOCKS=20 losetup -P $DEV $HOME/loop0.img keyctl add trusted $KEYNAME "load $(cat $HOME/kmk.blob)" @s TABLE="0 $BLOCKS crypt $ALGO :32:trusted:$KEYNAME 0 $DEV 0 1 allow_discards" echo $TABLE | dmsetup create mydev echo $TABLE | dmsetup load mydev # should print that It works! hexdump -C /dev/mapper/mydev >> https://lore.kernel.org/linux-integrity/1604419306-26105-1-git-send-email-sumit.garg@linaro.org/ > > Also, I would hold merging *this* patch up until we are able to > test TEE trusted keys with TEE trusted keys. Which blocks which? I tested this with TPM-Trusted keys, so it's usable as is. For convenient usage, it would be nice to have cryptsetup support for trusted and encrypted keys. I intended to look at this next week. Cheers, Ahmad > > /Jarkko > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Ahmad Fatoum <a.fatoum@pengutronix.de> To: Jarkko Sakkinen <jarkko@kernel.org> Cc: "Sumit Garg" <sumit.garg@linaro.org>, "Jan Lübbe" <jlu@pengutronix.de>, "Mike Snitzer" <snitzer@redhat.com>, "Jonathan Corbet" <corbet@lwn.net>, "Dmitry Baryshkov" <dbaryshkov@gmail.com>, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, "Song Liu" <song@kernel.org>, dm-devel@redhat.com, keyrings@vger.kernel.org, kernel@pengutronix.de, linux-integrity@vger.kernel.org, "Alasdair Kergon" <agk@redhat.com> Subject: Re: [dm-devel] [PATCH 2/2] dm crypt: support using trusted keys Date: Fri, 22 Jan 2021 20:04:46 +0100 [thread overview] Message-ID: <5d44e50e-4309-830b-79f6-f5d888b1ef69@pengutronix.de> (raw) In-Reply-To: <YAsW8DAt3vc68rLA@kernel.org> Hello Jarkko, On 22.01.21 19:18, Jarkko Sakkinen wrote: > On Fri, Jan 22, 2021 at 08:05:51PM +0200, Jarkko Sakkinen wrote: >> On Fri, Jan 22, 2021 at 09:43:21AM +0100, Ahmad Fatoum wrote: >>> Commit 27f5411a718c ("dm crypt: support using encrypted keys") extended >>> dm-crypt to allow use of "encrypted" keys along with "user" and "logon". >>> >>> Along the same lines, teach dm-crypt to support "trusted" keys as well. >>> >>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> >>> --- >> >> Is it possible to test run this with tmpfs? Would be a good test >> target for Sumit's ARM-TEE trusted keys patches. I tested these on top of Sumit's patches with TPM and a CAAM blobifier backend, I am preparing. The system I am developing these patches against doesn't have a TEE. Steps to test these changes: #!/bin/sh DEV=/dev/loop0 ALGO=aes-cbc-essiv:sha256 KEYNAME=kmk BLOCKS=20 fallocate -l $((BLOCKS*512)) /tmp/loop0.img losetup -P $DEV /tmp/loop0.img mount -o remount,rw / KEY="$(keyctl add trusted $KEYNAME 'new 32' @s)" keyctl pipe $KEY >$HOME/kmk.blob TABLE="0 $BLOCKS crypt $ALGO :32:trusted:$KEYNAME 0 $DEV 0 1 allow_discards" echo $TABLE | dmsetup create mydev echo $TABLE | dmsetup load mydev dd if=/dev/zero of=/dev/mapper/mydev echo "It works!" 1<> /dev/mapper/mydev cryptsetup close mydev reboot DEV=/dev/loop0 ALGO=aes-cbc-essiv:sha256 KEYNAME=kmk BLOCKS=20 losetup -P $DEV $HOME/loop0.img keyctl add trusted $KEYNAME "load $(cat $HOME/kmk.blob)" @s TABLE="0 $BLOCKS crypt $ALGO :32:trusted:$KEYNAME 0 $DEV 0 1 allow_discards" echo $TABLE | dmsetup create mydev echo $TABLE | dmsetup load mydev # should print that It works! hexdump -C /dev/mapper/mydev >> https://lore.kernel.org/linux-integrity/1604419306-26105-1-git-send-email-sumit.garg@linaro.org/ > > Also, I would hold merging *this* patch up until we are able to > test TEE trusted keys with TEE trusted keys. Which blocks which? I tested this with TPM-Trusted keys, so it's usable as is. For convenient usage, it would be nice to have cryptsetup support for trusted and encrypted keys. I intended to look at this next week. Cheers, Ahmad > > /Jarkko > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-01-22 19:20 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-22 8:43 [PATCH 1/2] dm crypt: replaced #if defined with IS_ENABLED Ahmad Fatoum 2021-01-22 8:43 ` [dm-devel] " Ahmad Fatoum 2021-01-22 8:43 ` [PATCH 2/2] dm crypt: support using trusted keys Ahmad Fatoum 2021-01-22 8:43 ` [dm-devel] " Ahmad Fatoum 2021-01-22 18:05 ` Jarkko Sakkinen 2021-01-22 18:05 ` [dm-devel] " Jarkko Sakkinen 2021-01-22 18:18 ` Jarkko Sakkinen 2021-01-22 18:18 ` [dm-devel] " Jarkko Sakkinen 2021-01-22 19:04 ` Ahmad Fatoum [this message] 2021-01-22 19:04 ` Ahmad Fatoum 2021-02-02 15:12 ` Ahmad Fatoum 2021-02-02 15:12 ` [dm-devel] " Ahmad Fatoum 2021-02-02 18:10 ` [PATCH 1/2] dm crypt: replaced #if defined with IS_ENABLED Mike Snitzer 2021-02-02 18:10 ` [dm-devel] " Mike Snitzer 2021-02-02 18:19 ` Ahmad Fatoum 2021-02-02 18:19 ` [dm-devel] " Ahmad Fatoum 2021-02-03 0:33 ` Dmitry Baryshkov 2021-02-03 0:33 ` [dm-devel] " Dmitry Baryshkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5d44e50e-4309-830b-79f6-f5d888b1ef69@pengutronix.de \ --to=a.fatoum@pengutronix.de \ --cc=agk@redhat.com \ --cc=corbet@lwn.net \ --cc=dbaryshkov@gmail.com \ --cc=dm-devel@redhat.com \ --cc=jarkko@kernel.org \ --cc=jlu@pengutronix.de \ --cc=kernel@pengutronix.de \ --cc=keyrings@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-integrity@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-raid@vger.kernel.org \ --cc=snitzer@redhat.com \ --cc=song@kernel.org \ --cc=sumit.garg@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.