All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/libid3tag: needs autoreconf
@ 2018-11-25 14:45 Yann E. MORIN
  2018-11-27 22:32 ` Arnout Vandecappelle
  2018-12-03 21:51 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Yann E. MORIN @ 2018-11-25 14:45 UTC (permalink / raw)
  To: buildroot

libid3tag uses a very old configure script.

When the toolchain lacks C++ and the build machine lacks /lib/cpp, this
old configure script fails because it can't find a C++ preprocessor that
is valid:

    checking for arm-buildroot-linux-uclibcgnueabi-g++... no
    checking whether we are using the GNU C++ compiler... no
    checking whether no accepts -g... no
    checking dependency style of no... none
    checking how to run the C++ preprocessor... /lib/cpp
    configure: error: C++ preprocessor "/lib/cpp" fails sanity check
    See `config.log' for more details.

This is yet another case that was tentatively fixed by bd39d11d2e
(core/infra: fix build on toolchain without C++), further amended by
4cd1ab15886 (core: alternate solution to disable C++).

However, this only works on libtool scripts that are recent enough, and
thus we need to autoreconf to get it.

We also need to patch configure.ac so that it does not fail on the
missing, GNU-specific files: NEWS, AUTHORS, and Changelog.

Fixes:
    http://autobuild.buildroot.org/results/ac3/ac3870208aab6001db6b790b6c5dde64d08f7669/
    http://autobuild.buildroot.org/results/cc1/cc18397f38dfd4f1e6605f7a6f58edab49b396ac/

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/libid3tag/0001-configure-automake-foreign.patch | 16 ++++++++++++++++
 package/libid3tag/libid3tag.mk                          |  5 ++++-
 2 files changed, 20 insertions(+), 1 deletion(-)
 create mode 100644 package/libid3tag/0001-configure-automake-foreign.patch

diff --git a/package/libid3tag/0001-configure-automake-foreign.patch b/package/libid3tag/0001-configure-automake-foreign.patch
new file mode 100644
index 0000000000..8521d559f2
--- /dev/null
+++ b/package/libid3tag/0001-configure-automake-foreign.patch
@@ -0,0 +1,16 @@
+configure: don't require GNU-specific files when running automake
+
+Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
+
+diff -durN libid3tag-0.15.1b.orig/configure.ac libid3tag-0.15.1b/configure.ac
+--- libid3tag-0.15.1b.orig/configure.ac	2004-01-24 00:22:46.000000000 +0100
++++ libid3tag-0.15.1b/configure.ac	2018-11-25 15:31:04.184342212 +0100
+@@ -26,7 +26,7 @@
+ 
+ AC_CONFIG_SRCDIR([id3tag.h])
+ 
+-AM_INIT_AUTOMAKE
++AM_INIT_AUTOMAKE([foreign])
+ 
+ AM_CONFIG_HEADER([config.h])
+ 
diff --git a/package/libid3tag/libid3tag.mk b/package/libid3tag/libid3tag.mk
index 951ae09c77..402e154ae1 100644
--- a/package/libid3tag/libid3tag.mk
+++ b/package/libid3tag/libid3tag.mk
@@ -10,6 +10,9 @@ LIBID3TAG_LICENSE = GPL-2.0+
 LIBID3TAG_LICENSE_FILES = COPYING COPYRIGHT
 LIBID3TAG_INSTALL_STAGING = YES
 LIBID3TAG_DEPENDENCIES = zlib
-LIBID3TAG_LIBTOOL_PATCH = NO
+
+# Force autoreconf to be able to use a more recent libtool script, that
+# is able to properly behave in the face of a missing C++ compiler.
+LIBID3TAG_AUTORECONF = YES
 
 $(eval $(autotools-package))
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/libid3tag: needs autoreconf
  2018-11-25 14:45 [Buildroot] [PATCH] package/libid3tag: needs autoreconf Yann E. MORIN
@ 2018-11-27 22:32 ` Arnout Vandecappelle
  2018-12-03 21:51 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2018-11-27 22:32 UTC (permalink / raw)
  To: buildroot



On 25/11/2018 15:45, Yann E. MORIN wrote:
> libid3tag uses a very old configure script.
> 
> When the toolchain lacks C++ and the build machine lacks /lib/cpp, this
> old configure script fails because it can't find a C++ preprocessor that
> is valid:
> 
>     checking for arm-buildroot-linux-uclibcgnueabi-g++... no
>     checking whether we are using the GNU C++ compiler... no
>     checking whether no accepts -g... no
>     checking dependency style of no... none
>     checking how to run the C++ preprocessor... /lib/cpp
>     configure: error: C++ preprocessor "/lib/cpp" fails sanity check
>     See `config.log' for more details.
> 
> This is yet another case that was tentatively fixed by bd39d11d2e
> (core/infra: fix build on toolchain without C++), further amended by
> 4cd1ab15886 (core: alternate solution to disable C++).
> 
> However, this only works on libtool scripts that are recent enough, and
> thus we need to autoreconf to get it.
> 
> We also need to patch configure.ac so that it does not fail on the
> missing, GNU-specific files: NEWS, AUTHORS, and Changelog.
> 
> Fixes:
>     http://autobuild.buildroot.org/results/ac3/ac3870208aab6001db6b790b6c5dde64d08f7669/
>     http://autobuild.buildroot.org/results/cc1/cc18397f38dfd4f1e6605f7a6f58edab49b396ac/
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

 Applied to master, thanks.

> ---
>  package/libid3tag/0001-configure-automake-foreign.patch | 16 ++++++++++++++++
>  package/libid3tag/libid3tag.mk                          |  5 ++++-
>  2 files changed, 20 insertions(+), 1 deletion(-)
>  create mode 100644 package/libid3tag/0001-configure-automake-foreign.patch
> 
> diff --git a/package/libid3tag/0001-configure-automake-foreign.patch b/package/libid3tag/0001-configure-automake-foreign.patch
> new file mode 100644
> index 0000000000..8521d559f2
> --- /dev/null
> +++ b/package/libid3tag/0001-configure-automake-foreign.patch
> @@ -0,0 +1,16 @@
> +configure: don't require GNU-specific files when running automake

 It's a bit unfortunate that we need to patch, since upstream is pretty much dead...

 Regards,
 Arnout

> +
> +Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> +
> +diff -durN libid3tag-0.15.1b.orig/configure.ac libid3tag-0.15.1b/configure.ac
> +--- libid3tag-0.15.1b.orig/configure.ac	2004-01-24 00:22:46.000000000 +0100
> ++++ libid3tag-0.15.1b/configure.ac	2018-11-25 15:31:04.184342212 +0100
> +@@ -26,7 +26,7 @@
> + 
> + AC_CONFIG_SRCDIR([id3tag.h])
> + 
> +-AM_INIT_AUTOMAKE
> ++AM_INIT_AUTOMAKE([foreign])
> + 
> + AM_CONFIG_HEADER([config.h])
> + 
> diff --git a/package/libid3tag/libid3tag.mk b/package/libid3tag/libid3tag.mk
> index 951ae09c77..402e154ae1 100644
> --- a/package/libid3tag/libid3tag.mk
> +++ b/package/libid3tag/libid3tag.mk
> @@ -10,6 +10,9 @@ LIBID3TAG_LICENSE = GPL-2.0+
>  LIBID3TAG_LICENSE_FILES = COPYING COPYRIGHT
>  LIBID3TAG_INSTALL_STAGING = YES
>  LIBID3TAG_DEPENDENCIES = zlib
> -LIBID3TAG_LIBTOOL_PATCH = NO
> +
> +# Force autoreconf to be able to use a more recent libtool script, that
> +# is able to properly behave in the face of a missing C++ compiler.
> +LIBID3TAG_AUTORECONF = YES
>  
>  $(eval $(autotools-package))
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/libid3tag: needs autoreconf
  2018-11-25 14:45 [Buildroot] [PATCH] package/libid3tag: needs autoreconf Yann E. MORIN
  2018-11-27 22:32 ` Arnout Vandecappelle
@ 2018-12-03 21:51 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2018-12-03 21:51 UTC (permalink / raw)
  To: buildroot

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > libid3tag uses a very old configure script.
 > When the toolchain lacks C++ and the build machine lacks /lib/cpp, this
 > old configure script fails because it can't find a C++ preprocessor that
 > is valid:

 >     checking for arm-buildroot-linux-uclibcgnueabi-g++... no
 >     checking whether we are using the GNU C++ compiler... no
 >     checking whether no accepts -g... no
 >     checking dependency style of no... none
 >     checking how to run the C++ preprocessor... /lib/cpp
 >     configure: error: C++ preprocessor "/lib/cpp" fails sanity check
 >     See `config.log' for more details.

 > This is yet another case that was tentatively fixed by bd39d11d2e
 > (core/infra: fix build on toolchain without C++), further amended by
 > 4cd1ab15886 (core: alternate solution to disable C++).

 > However, this only works on libtool scripts that are recent enough, and
 > thus we need to autoreconf to get it.

 > We also need to patch configure.ac so that it does not fail on the
 > missing, GNU-specific files: NEWS, AUTHORS, and Changelog.

 > Fixes:
 >     http://autobuild.buildroot.org/results/ac3/ac3870208aab6001db6b790b6c5dde64d08f7669/
 >     http://autobuild.buildroot.org/results/cc1/cc18397f38dfd4f1e6605f7a6f58edab49b396ac/

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Committed to 2018.02.x and 2018.08.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-03 21:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-25 14:45 [Buildroot] [PATCH] package/libid3tag: needs autoreconf Yann E. MORIN
2018-11-27 22:32 ` Arnout Vandecappelle
2018-12-03 21:51 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.