Re: [PATCH v2 5/7] dt-bindings: net: dsa: mediatek,mt7530: remove unnecesary lines

From: "Arınç ÜNAL" <arinc.unal@arinc9.com>
To: Rob Herring <robh@kernel.org>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
	"Vivien Didelot" <vivien.didelot@gmail.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Sean Wang" <sean.wang@mediatek.com>,
	"Landen Chao" <Landen.Chao@mediatek.com>,
	"DENG Qingfang" <dqfext@gmail.com>,
	"Frank Wunderlich" <frank-w@public-files.de>,
	"Luiz Angelo Daros de Luca" <luizluca@gmail.com>,
	"Sander Vanheule" <sander@svanheule.net>,
	"René van Dorst" <opensource@vdorst.com>,
	"Daniel Golle" <daniel@makrotopia.org>,
	erkin.bozoglu@xeront.com,
	"Sergio Paracuellos" <sergio.paracuellos@gmail.com>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/7] dt-bindings: net: dsa: mediatek,mt7530: remove unnecesary lines
Date: Wed, 17 Aug 2022 01:21:09 +0300	[thread overview]
Message-ID: <5d51394b-cef2-6bb2-763c-e801994f67ea@arinc9.com> (raw)
In-Reply-To: <20220816211454.GA2734299-robh@kernel.org>

On 17.08.2022 00:14, Rob Herring wrote:
> On Sat, Aug 13, 2022 at 06:44:13PM +0300, Arınç ÜNAL wrote:
>> Remove unnecessary lines as they are already included from the referred
>> dsa.yaml.
> 
> You are duplicating the schema and then removing parts twice. I would
> combine patches 4 and 5 or reverse the order.

Will combine.

> 
>>
>> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
>> ---
>>   .../bindings/net/dsa/mediatek,mt7530.yaml     | 27 -------------------
>>   1 file changed, 27 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
>> index ff51a2f6875f..a27cb4fa490f 100644
>> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
>> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
>> @@ -162,15 +162,8 @@ allOf:
>>   
>>         patternProperties:
>>           "^(ethernet-)?ports$":
>> -          type: object
>> -
>>             patternProperties:
>>               "^(ethernet-)?port@[0-9]+$":
>> -              type: object
>> -              description: Ethernet switch ports
>> -
>> -              unevaluatedProperties: false
>> -
>>                 properties:
>>                   reg:
>>                     description:
>> @@ -178,7 +171,6 @@ allOf:
>>                       0 to 5 for user ports.
>>   
>>                 allOf:
>> -                - $ref: dsa-port.yaml#
>>                   - if:
> 
> This 'if' schema is the only part you need actually (though you have to
> create the node structure).

Do you mean that I should take "if:" out of allOf?

> 
>>                       properties:
>>                         label:
>> @@ -186,7 +178,6 @@ allOf:
>>                             - const: cpu
>>                     then:
>>                       required:
>> -                      - reg
>>                         - phy-mode
>>   
>>     - if:
>> @@ -200,15 +191,8 @@ allOf:
>>   
>>         patternProperties:
>>           "^(ethernet-)?ports$":
>> -          type: object
>> -
>>             patternProperties:
>>               "^(ethernet-)?port@[0-9]+$":
>> -              type: object
>> -              description: Ethernet switch ports
>> -
>> -              unevaluatedProperties: false
>> -
>>                 properties:
>>                   reg:
>>                     description:
>> @@ -216,7 +200,6 @@ allOf:
>>                       0 to 5 for user ports.
>>   
>>                 allOf:
>> -                - $ref: dsa-port.yaml#
>>                   - if:
>>                       properties:
>>                         label:
>> @@ -224,7 +207,6 @@ allOf:
>>                             - const: cpu
>>                     then:
>>                       required:
>> -                      - reg
>>                         - phy-mode
>>   
>>     - if:
>> @@ -238,15 +220,8 @@ allOf:
>>   
>>         patternProperties:
>>           "^(ethernet-)?ports$":
>> -          type: object
>> -
>>             patternProperties:
>>               "^(ethernet-)?port@[0-9]+$":
>> -              type: object
>> -              description: Ethernet switch ports
>> -
>> -              unevaluatedProperties: false
>> -
>>                 properties:
>>                   reg:
>>                     description:
>> @@ -254,7 +229,6 @@ allOf:
>>                       0 to 5 for user ports.
>>   
>>                 allOf:
>> -                - $ref: dsa-port.yaml#
>>                   - if:
>>                       properties:
>>                         label:
>> @@ -262,7 +236,6 @@ allOf:
>>                             - const: cpu
>>                     then:
>>                       required:
>> -                      - reg
>>                         - phy-mode
>>   
>>   unevaluatedProperties: false
>> -- 
>> 2.34.1
>>
>>