All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Damien Le Moal <damien.lemoal@wdc.com>,
	dm-devel@redhat.com, Mike Snitzer <snitzer@redhat.com>,
	linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v2 09/11] dm: rearrange core declarations
Date: Thu, 20 May 2021 07:59:38 +0200	[thread overview]
Message-ID: <5d5447dc-6e07-63af-9cc6-c7bf68c99e52@suse.de> (raw)
In-Reply-To: <20210520042228.974083-10-damien.lemoal@wdc.com>

On 5/20/21 6:22 AM, Damien Le Moal wrote:
> Move the definitions of struct dm_target_io, struct dm_io and of the
> bits of the flags field of struct mapped_device from dm.c to dm-core.h
> to make them usable from dm-zone.c.
> For the same reason, declare dec_pending() in dm-core.h after renaming
> it to dm_io_dec_pending(). And for symmetry of the function names,
> introduce the inline helper dm_io_inc_pending() instead of directly
> using atomic_inc() calls.
> 
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
>   drivers/md/dm-core.h | 52 ++++++++++++++++++++++++++++++++++++++
>   drivers/md/dm.c      | 59 ++++++--------------------------------------
>   2 files changed, 59 insertions(+), 52 deletions(-)
> I've never been a fan of private structures.

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

WARNING: multiple messages have this Message-ID (diff)
From: Hannes Reinecke <hare@suse.de>
To: Damien Le Moal <damien.lemoal@wdc.com>,
	dm-devel@redhat.com, Mike Snitzer <snitzer@redhat.com>,
	linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [dm-devel] [PATCH v2 09/11] dm: rearrange core declarations
Date: Thu, 20 May 2021 07:59:38 +0200	[thread overview]
Message-ID: <5d5447dc-6e07-63af-9cc6-c7bf68c99e52@suse.de> (raw)
In-Reply-To: <20210520042228.974083-10-damien.lemoal@wdc.com>

On 5/20/21 6:22 AM, Damien Le Moal wrote:
> Move the definitions of struct dm_target_io, struct dm_io and of the
> bits of the flags field of struct mapped_device from dm.c to dm-core.h
> to make them usable from dm-zone.c.
> For the same reason, declare dec_pending() in dm-core.h after renaming
> it to dm_io_dec_pending(). And for symmetry of the function names,
> introduce the inline helper dm_io_inc_pending() instead of directly
> using atomic_inc() calls.
> 
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
>   drivers/md/dm-core.h | 52 ++++++++++++++++++++++++++++++++++++++
>   drivers/md/dm.c      | 59 ++++++--------------------------------------
>   2 files changed, 59 insertions(+), 52 deletions(-)
> I've never been a fan of private structures.

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer


--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

  reply	other threads:[~2021-05-20  5:59 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20  4:22 [PATCH v2 00/11] dm: Improve zoned block device support Damien Le Moal
2021-05-20  4:22 ` [dm-devel] " Damien Le Moal
2021-05-20  4:22 ` [PATCH v2 01/11] block: improve handling of all zones reset operation Damien Le Moal
2021-05-20  4:22   ` [dm-devel] " Damien Le Moal
2021-05-20  5:49   ` Hannes Reinecke
2021-05-20  5:49     ` [dm-devel] " Hannes Reinecke
2021-05-20  4:22 ` [PATCH v2 02/11] block: introduce bio zone helpers Damien Le Moal
2021-05-20  4:22   ` [dm-devel] " Damien Le Moal
2021-05-20  5:50   ` Hannes Reinecke
2021-05-20  5:50     ` [dm-devel] " Hannes Reinecke
2021-05-20  4:22 ` [PATCH v2 03/11] block: introduce BIO_ZONE_WRITE_LOCKED bio flag Damien Le Moal
2021-05-20  4:22   ` [dm-devel] " Damien Le Moal
2021-05-20  5:52   ` Hannes Reinecke
2021-05-20  5:52     ` [dm-devel] " Hannes Reinecke
2021-05-20  4:22 ` [PATCH v2 04/11] dm: Fix dm_accept_partial_bio() Damien Le Moal
2021-05-20  4:22   ` [dm-devel] " Damien Le Moal
2021-05-20  5:53   ` Hannes Reinecke
2021-05-20  5:53     ` [dm-devel] " Hannes Reinecke
2021-05-20  4:22 ` [PATCH v2 05/11] dm: cleanup device_area_is_invalid() Damien Le Moal
2021-05-20  4:22   ` [dm-devel] " Damien Le Moal
2021-05-20  5:53   ` Hannes Reinecke
2021-05-20  5:53     ` [dm-devel] " Hannes Reinecke
2021-05-20  4:22 ` [PATCH v2 06/11] dm: move zone related code to dm-zone.c Damien Le Moal
2021-05-20  4:22   ` [dm-devel] " Damien Le Moal
2021-05-20  5:54   ` Hannes Reinecke
2021-05-20  5:54     ` [dm-devel] " Hannes Reinecke
2021-05-20  4:22 ` [PATCH v2 07/11] dm: Introduce dm_report_zones() Damien Le Moal
2021-05-20  4:22   ` [dm-devel] " Damien Le Moal
2021-05-20  5:56   ` Hannes Reinecke
2021-05-20  5:56     ` [dm-devel] " Hannes Reinecke
2021-05-20  4:22 ` [PATCH v2 08/11] dm: Forbid requeue of writes to zones Damien Le Moal
2021-05-20  4:22   ` [dm-devel] " Damien Le Moal
2021-05-20  5:57   ` Hannes Reinecke
2021-05-20  5:57     ` [dm-devel] " Hannes Reinecke
2021-05-20  4:22 ` [PATCH v2 09/11] dm: rearrange core declarations Damien Le Moal
2021-05-20  4:22   ` [dm-devel] " Damien Le Moal
2021-05-20  5:59   ` Hannes Reinecke [this message]
2021-05-20  5:59     ` Hannes Reinecke
2021-05-20  4:22 ` [PATCH v2 10/11] dm: introduce zone append emulation Damien Le Moal
2021-05-20  4:22   ` [dm-devel] " Damien Le Moal
2021-05-20  6:10   ` Hannes Reinecke
2021-05-20  6:10     ` [dm-devel] " Hannes Reinecke
2021-05-20  6:25     ` Damien Le Moal
2021-05-20  6:25       ` [dm-devel] " Damien Le Moal
2021-05-20  6:47       ` Hannes Reinecke
2021-05-20  6:47         ` [dm-devel] " Hannes Reinecke
2021-05-20  6:57         ` Damien Le Moal
2021-05-20  6:57           ` [dm-devel] " Damien Le Moal
2021-05-20  4:22 ` [PATCH v2 11/11] dm crypt: Fix zoned block device support Damien Le Moal
2021-05-20  4:22   ` [dm-devel] " Damien Le Moal
2021-05-20  6:11   ` Hannes Reinecke
2021-05-20  6:11     ` [dm-devel] " Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d5447dc-6e07-63af-9cc6-c7bf68c99e52@suse.de \
    --to=hare@suse.de \
    --cc=axboe@kernel.dk \
    --cc=damien.lemoal@wdc.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.