From: Philipp Zabel <p.zabel@pengutronix.de> To: Billy Tsai <billy_tsai@aspeedtech.com>, lee.jones@linaro.org, robh+dt@kernel.org, joel@jms.id.au, andrew@aj.id.au, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org Cc: BMC-SW@aspeedtech.com Subject: Re: [v11 2/2] pwm: Add Aspeed ast2600 PWM support Date: Fri, 13 Aug 2021 12:02:15 +0200 [thread overview] Message-ID: <5da35c2030e57621fa56795cd193e727f53205fe.camel@pengutronix.de> (raw) In-Reply-To: <20210812040942.5365-3-billy_tsai@aspeedtech.com> Hi Billy, On Thu, 2021-08-12 at 12:09 +0800, Billy Tsai wrote: > This patch add the support of PWM controller which can be found at aspeed > ast2600 soc. The pwm supoorts up to 16 channels and it's part function > of multi-function device "pwm-tach controller". > > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> > --- [...] > diff --git a/drivers/pwm/pwm-aspeed-ast2600.c b/drivers/pwm/pwm-aspeed-ast2600.c > new file mode 100644 > index 000000000000..f89ce1d4cd67 > --- /dev/null > +++ b/drivers/pwm/pwm-aspeed-ast2600.c > @@ -0,0 +1,327 @@ [...] > +static int aspeed_pwm_probe(struct platform_device *pdev) > +{ [...] > + priv->clk = devm_clk_get(&parent_dev->dev, 0); > + if (IS_ERR(priv->clk)) > + return dev_err_probe(dev, PTR_ERR(priv->clk), > + "Couldn't get clock\n"); > + > + ret = clk_prepare_enable(priv->clk); > + if (ret) > + return dev_err_probe(dev, ret, "Couldn't enable clock\n"); > + > + priv->reset = devm_reset_control_get_shared(&parent_dev->dev, NULL); > + if (IS_ERR(priv->reset)) { > + ret = dev_err_probe(dev, PTR_ERR(priv->reset), > + "Get reset failed\n"); > + goto err_disable_clk; > + } I suggest to request the reset control before enabling the clock. That way you can simplify the error path and avoid enabling the clock in case of reset_control_get failure. regards Philipp
WARNING: multiple messages have this Message-ID (diff)
From: Philipp Zabel <p.zabel@pengutronix.de> To: Billy Tsai <billy_tsai@aspeedtech.com>, lee.jones@linaro.org, robh+dt@kernel.org, joel@jms.id.au, andrew@aj.id.au, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org Cc: BMC-SW@aspeedtech.com Subject: Re: [v11 2/2] pwm: Add Aspeed ast2600 PWM support Date: Fri, 13 Aug 2021 12:02:15 +0200 [thread overview] Message-ID: <5da35c2030e57621fa56795cd193e727f53205fe.camel@pengutronix.de> (raw) In-Reply-To: <20210812040942.5365-3-billy_tsai@aspeedtech.com> Hi Billy, On Thu, 2021-08-12 at 12:09 +0800, Billy Tsai wrote: > This patch add the support of PWM controller which can be found at aspeed > ast2600 soc. The pwm supoorts up to 16 channels and it's part function > of multi-function device "pwm-tach controller". > > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> > --- [...] > diff --git a/drivers/pwm/pwm-aspeed-ast2600.c b/drivers/pwm/pwm-aspeed-ast2600.c > new file mode 100644 > index 000000000000..f89ce1d4cd67 > --- /dev/null > +++ b/drivers/pwm/pwm-aspeed-ast2600.c > @@ -0,0 +1,327 @@ [...] > +static int aspeed_pwm_probe(struct platform_device *pdev) > +{ [...] > + priv->clk = devm_clk_get(&parent_dev->dev, 0); > + if (IS_ERR(priv->clk)) > + return dev_err_probe(dev, PTR_ERR(priv->clk), > + "Couldn't get clock\n"); > + > + ret = clk_prepare_enable(priv->clk); > + if (ret) > + return dev_err_probe(dev, ret, "Couldn't enable clock\n"); > + > + priv->reset = devm_reset_control_get_shared(&parent_dev->dev, NULL); > + if (IS_ERR(priv->reset)) { > + ret = dev_err_probe(dev, PTR_ERR(priv->reset), > + "Get reset failed\n"); > + goto err_disable_clk; > + } I suggest to request the reset control before enabling the clock. That way you can simplify the error path and avoid enabling the clock in case of reset_control_get failure. regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-13 10:03 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-12 4:09 [v11 0/2] Support pwm driver for aspeed ast26xx Billy Tsai 2021-08-12 4:09 ` Billy Tsai 2021-08-12 4:09 ` [v11 1/2] dt-bindings: Add bindings for aspeed pwm-tach Billy Tsai 2021-08-12 4:09 ` Billy Tsai 2021-08-12 4:09 ` [v11 2/2] pwm: Add Aspeed ast2600 PWM support Billy Tsai 2021-08-12 4:09 ` Billy Tsai 2021-08-13 10:02 ` Philipp Zabel [this message] 2021-08-13 10:02 ` Philipp Zabel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5da35c2030e57621fa56795cd193e727f53205fe.camel@pengutronix.de \ --to=p.zabel@pengutronix.de \ --cc=BMC-SW@aspeedtech.com \ --cc=andrew@aj.id.au \ --cc=billy_tsai@aspeedtech.com \ --cc=devicetree@vger.kernel.org \ --cc=joel@jms.id.au \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=thierry.reding@gmail.com \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.