* [PATCH] Makefile inclusion of Paths.mk should be conditional
@ 2014-08-04 13:29 Ian Campbell
2014-08-04 15:56 ` Ian Jackson
0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2014-08-04 13:29 UTC (permalink / raw)
To: xen-devel, ian.jackson; +Cc: Ian Campbell, Luis R. Rodriguez
Since it may not exist when doing e.g. "make clean". There is
existing logic in the makefiles which will raise an error if an
actual build target is invoked without having run configure.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Cc: Luis R. Rodriguez <mcgrof@do-not-panic.com>
---
Luis, any reason why config/Stubdom.mk.in in one case and
tools/Rules.mk in the other?
---
config/Stubdom.mk.in | 2 +-
tools/Rules.mk | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/config/Stubdom.mk.in b/config/Stubdom.mk.in
index 6bce206..c1c83bc 100644
--- a/config/Stubdom.mk.in
+++ b/config/Stubdom.mk.in
@@ -1,5 +1,5 @@
# Prefix and install folder
-include $(XEN_ROOT)/config/Paths.mk
+-include $(XEN_ROOT)/config/Paths.mk
prefix := @prefix@
PREFIX := $(prefix)
exec_prefix := @exec_prefix@
diff --git a/tools/Rules.mk b/tools/Rules.mk
index 0aa1e6b..5bac700 100644
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -5,7 +5,7 @@ all:
-include $(XEN_ROOT)/config/Tools.mk
include $(XEN_ROOT)/Config.mk
-include $(XEN_ROOT)/config/Paths.mk
+-include $(XEN_ROOT)/config/Paths.mk
export _INSTALL := $(INSTALL)
INSTALL = $(XEN_ROOT)/tools/cross-install
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Makefile inclusion of Paths.mk should be conditional
2014-08-04 13:29 [PATCH] Makefile inclusion of Paths.mk should be conditional Ian Campbell
@ 2014-08-04 15:56 ` Ian Jackson
2014-08-04 16:13 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Ian Jackson @ 2014-08-04 15:56 UTC (permalink / raw)
To: Ian Campbell; +Cc: Luis R. Rodriguez, xen-devel
Ian Campbell writes ("[PATCH] Makefile inclusion of Paths.mk should be conditional"):
> Since it may not exist when doing e.g. "make clean". There is
> existing logic in the makefiles which will raise an error if an
> actual build target is invoked without having run configure.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Makefile inclusion of Paths.mk should be conditional
2014-08-04 15:56 ` Ian Jackson
@ 2014-08-04 16:13 ` Ian Campbell
0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2014-08-04 16:13 UTC (permalink / raw)
To: Ian Jackson; +Cc: Luis R. Rodriguez, xen-devel
On Mon, 2014-08-04 at 16:56 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH] Makefile inclusion of Paths.mk should be conditional"):
> > Since it may not exist when doing e.g. "make clean". There is
> > existing logic in the makefiles which will raise an error if an
> > actual build target is invoked without having run configure.
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Thanks, applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-04 16:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-04 13:29 [PATCH] Makefile inclusion of Paths.mk should be conditional Ian Campbell
2014-08-04 15:56 ` Ian Jackson
2014-08-04 16:13 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.