All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thor Thayer <thor.thayer@linux.intel.com>
To: Dalon Westergreen <dalon.westergreen@linux.intel.com>,
	dinguyen@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] ARM: dts: arria10: Add stmmac ptp_ref clock
Date: Mon, 20 May 2019 11:10:55 -0500	[thread overview]
Message-ID: <5de0520a-d29a-3994-5441-047060ad9aa9@linux.intel.com> (raw)
In-Reply-To: <20190515162058.32368-2-dalon.westergreen@linux.intel.com>

On 5/15/19 11:20 AM, Dalon Westergreen wrote:
> Add the default stmmac ptp_ref clock for arria10.  The stmmac
> driver defaults the ptp_ref clock to the main stmmac clock
> if the ptp_ref clock is not set in the devicetree.  This is inappropriate
> for the arria10 device.  The default ptp_ref clock is peri_emac_ptp_clk.
> 
> Signed-off-by: Dalon Westergreen <dalon.westergreen@linux.intel.com>
> ---
>   arch/arm/boot/dts/socfpga_arria10.dtsi | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/socfpga_arria10.dtsi b/arch/arm/boot/dts/socfpga_arria10.dtsi
> index 0017bac7f96c..6591def7b225 100644
> --- a/arch/arm/boot/dts/socfpga_arria10.dtsi
> +++ b/arch/arm/boot/dts/socfpga_arria10.dtsi
> @@ -426,8 +426,8 @@
>   			snps,perfect-filter-entries = <128>;
>   			tx-fifo-depth = <4096>;
>   			rx-fifo-depth = <16384>;
> -			clocks = <&l4_mp_clk>;
> -			clock-names = "stmmaceth";
> +			clocks = <&l4_mp_clk>, <&peri_emac_ptp_clk>;
> +			clock-names = "stmmaceth", "ptp_ref";
>   			resets = <&rst EMAC0_RESET>;
>   			reset-names = "stmmaceth";
>   			snps,axi-config = <&socfpga_axi_setup>;
> @@ -446,8 +446,8 @@
>   			snps,perfect-filter-entries = <128>;
>   			tx-fifo-depth = <4096>;
>   			rx-fifo-depth = <16384>;
> -			clocks = <&l4_mp_clk>;
> -			clock-names = "stmmaceth";
> +			clocks = <&l4_mp_clk>, <&peri_emac_ptp_clk>;
> +			clock-names = "stmmaceth", "ptp_ref";
>   			resets = <&rst EMAC1_RESET>;
>   			reset-names = "stmmaceth";
>   			snps,axi-config = <&socfpga_axi_setup>;
> @@ -466,8 +466,8 @@
>   			snps,perfect-filter-entries = <128>;
>   			tx-fifo-depth = <4096>;
>   			rx-fifo-depth = <16384>;
> -			clocks = <&l4_mp_clk>;
> -			clock-names = "stmmaceth";
> +			clocks = <&l4_mp_clk>, <&peri_emac_ptp_clk>;
> +			clock-names = "stmmaceth", "ptp_ref";
>   			snps,axi-config = <&socfpga_axi_setup>;
>   			status = "disabled";
>   		};
> 

Reviewed-by: Thor Thayer <thor.thayer@linux.intel.com>

  reply	other threads:[~2019-05-20 16:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15 16:20 [PATCH 1/3] ARM: dts: cyclone5: Add stmmac ptp_ref clock Dalon Westergreen
2019-05-15 16:20 ` [PATCH 2/3] ARM: dts: arria10: " Dalon Westergreen
2019-05-20 16:10   ` Thor Thayer [this message]
2019-05-15 16:20 ` [PATCH 3/3] ARM64: dts: stratix10: " Dalon Westergreen
2019-05-20 16:39   ` Thor Thayer
2019-05-21 13:09     ` Dalon L Westergreen
2019-05-21 20:27       ` Dinh Nguyen
2019-05-22 14:47         ` Dalon L Westergreen
2019-05-20 16:09 ` [PATCH 1/3] ARM: dts: cyclone5: " Thor Thayer
  -- strict thread matches above, loose matches on Subject: below --
2018-12-13 23:03 dwesterg
2018-12-13 23:03 ` [PATCH 2/3] ARM: dts: arria10: " dwesterg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5de0520a-d29a-3994-5441-047060ad9aa9@linux.intel.com \
    --to=thor.thayer@linux.intel.com \
    --cc=dalon.westergreen@linux.intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.