Problems removing ramdisk backed luns

Problems removing ramdisk backed luns

[Dennis Dalessandro]

Hi Folks,

The commit:
d72d827f2f26 ("scsi: target: Add iscsi/cpus_allowed_list in configfs")

Seems to be causing problems when I try to delete ramdisk backed LUNSs. I
bisected the failure to this commit. Reverting restores functionality to 5.17
levels.

The error that I get is:
# targetcli /backstores/ramdisk delete iscsi_ib0_0
[Errno 20] Not a directory: '/sys/kernel/config/target/iscsi/cpus_allowed_list'

Looking through our automation looks like this is the gist of how things are setup:

targetcli /iscsi set global auto_add_default_portal=false
targetcli /iscsi create wwn=${wwn}
targetcli /iscsi/${wwn}/tpg1/portals create ${addr}

For each LUN:
targetcli /backstores/ramdisk create ${lun_prefix}_${x} ${lun_size}
targetcli /iscsi/${wwn}/tpg1/luns create /backstores/ramdisk/${lun_prefix}_${x}
targetcli /iscsi/${wwn}/tpg1 set attribute authentication=0 \
demo_mode_write_protect=0 generate_node_acls=1 cache_dynamic_acls=1

This all seems to work OK and it appears I can do I/O to the LUNs. Then when we
go to tear things down:

targetcli /iscsi delete ${wwn}
targetcli /backstores/ramdisk delete ${lun_prefix}_${lun} <-- ERROR

Any thoughts/ideas appreciated.

-Denny

Re: Problems removing ramdisk backed luns

[Mike Christie]

Ccing Maurizio.

On 4/14/22 1:05 PM, Dennis Dalessandro wrote:
> This all seems to work OK and it appears I can do I/O to the LUNs. Then when we
> go to tear things down:
> 
> targetcli /iscsi delete ${wwn}
> targetcli /backstores/ramdisk delete ${lun_prefix}_${lun} <-- ERROR
> 

Zou fixed this in the current rtslib tree:

https://github.com/open-iscsi/rtslib-fb/commit/8d2543c4da62e962661011fea5b19252b9660822

If you grab that patch and are running the upstream kernel you
probably also want:

https://github.com/open-iscsi/rtslib-fb/pull/184

which should fix a warning you might see after you apply Zou's fix.

Re: Problems removing ramdisk backed luns

[Dennis Dalessandro]

On 4/14/22 5:14 PM, Mike Christie wrote:
> Ccing Maurizio.
> 
> On 4/14/22 1:05 PM, Dennis Dalessandro wrote:
>> This all seems to work OK and it appears I can do I/O to the LUNs. Then when we
>> go to tear things down:
>>
>> targetcli /iscsi delete ${wwn}
>> targetcli /backstores/ramdisk delete ${lun_prefix}_${lun} <-- ERROR
>>
> 
> Zou fixed this in the current rtslib tree:
> 
> https://github.com/open-iscsi/rtslib-fb/commit/8d2543c4da62e962661011fea5b19252b9660822
> 
> If you grab that patch and are running the upstream kernel you
> probably also want:
> 
> https://github.com/open-iscsi/rtslib-fb/pull/184
> 
> which should fix a warning you might see after you apply Zou's fix.

Ah great. Will grab those patches. Is there documentation somewhere on how to
build/install the package? I'm not seeing anything in the README. Looks like the
Makefile creates a tarball, not sure how to install from that.

-Denny

Re: Problems removing ramdisk backed luns

[Maurizio Lombardi]

čt 14. 4. 2022 v 23:14 odesílatel Mike Christie
<michael.christie@oracle.com> napsal:
>
> Zou fixed this in the current rtslib tree:
>
> https://github.com/open-iscsi/rtslib-fb/commit/8d2543c4da62e962661011fea5b19252b9660822
>
> If you grab that patch and are running the upstream kernel you
> probably also want:
>
> https://github.com/open-iscsi/rtslib-fb/pull/184
>
> which should fix a warning you might see after you apply Zou's fix

I will release a new version of rtslib tomorrow, so the distros can
update their packages.

Maurizio