From: Auger Eric <eric.auger@redhat.com> To: Andre Przywara <andre.przywara@arm.com>, eric.auger.pro@gmail.com, marc.zyngier@arm.com, christoffer.dall@linaro.org, vijayak@caviumnetworks.com, Vijaya.Kumar@cavium.com, peter.maydell@linaro.org, linux-arm-kernel@lists.infradead.org, drjones@redhat.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org Cc: Prasun.Kapoor@cavium.com, quintela@redhat.com, dgilbert@redhat.com, pbonzini@redhat.com Subject: Re: [PATCH v3 16/19] KVM: arm64: ITS: vgic_its_check_id returns the entry's GPA Date: Wed, 22 Mar 2017 15:11:05 +0100 [thread overview] Message-ID: <5e14fa1c-2eb6-6746-968b-4ecc18dd7cdd@redhat.com> (raw) In-Reply-To: <be79d92f-2522-a754-f006-66901d26e94c@arm.com> Hi, On 21/03/2017 19:12, Andre Przywara wrote: > Hi, > > On 06/03/17 11:34, Eric Auger wrote: >> As vgic_its_check_id() computes the device/collection entry's >> GPA, let's return it so that new callers can retrieve it easily. >> >> Signed-off-by: Eric Auger <eric.auger@redhat.com> >> >> --- >> >> v2: new >> --- >> virt/kvm/arm/vgic/vgic-its.c | 11 ++++++++--- >> 1 file changed, 8 insertions(+), 3 deletions(-) >> >> diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c >> index ad67759..1060125 100644 >> --- a/virt/kvm/arm/vgic/vgic-its.c >> +++ b/virt/kvm/arm/vgic/vgic-its.c >> @@ -637,7 +637,8 @@ static int vgic_its_cmd_handle_movi(struct kvm *kvm, struct vgic_its *its, >> * is actually valid (covered by a memslot and guest accessible). >> * For this we have to read the respective first level entry. >> */ >> -static bool vgic_its_check_id(struct vgic_its *its, u64 baser, int id) >> +static bool vgic_its_check_id(struct vgic_its *its, u64 baser, int id, >> + gpa_t *eaddr) >> { >> int l1_tbl_size = GITS_BASER_NR_PAGES(baser) * SZ_64K; >> int index; >> @@ -657,6 +658,7 @@ static bool vgic_its_check_id(struct vgic_its *its, u64 baser, int id) >> addr = BASER_ADDRESS(baser) + id * esz; >> gfn = addr >> PAGE_SHIFT; >> >> + *eaddr = addr; > > If you check that eaddr is not NULL before writing to it, you can save > the dummy variable in the two callers below (which doesn't hurt, but > does not help readability either). done Thanks Eric > > Cheers, > Andre. > >> return kvm_is_visible_gfn(its->dev->kvm, gfn); >> } >> >> @@ -689,6 +691,7 @@ static bool vgic_its_check_id(struct vgic_its *its, u64 baser, int id) >> indirect_ptr += index * esz; >> gfn = indirect_ptr >> PAGE_SHIFT; >> >> + *eaddr = indirect_ptr; >> return kvm_is_visible_gfn(its->dev->kvm, gfn); >> } >> >> @@ -697,8 +700,9 @@ static int vgic_its_alloc_collection(struct vgic_its *its, >> u32 coll_id) >> { >> struct its_collection *collection; >> + gpa_t eaddr; >> >> - if (!vgic_its_check_id(its, its->baser_coll_table, coll_id)) >> + if (!vgic_its_check_id(its, its->baser_coll_table, coll_id, &eaddr)) >> return E_ITS_MAPC_COLLECTION_OOR; >> >> collection = kzalloc(sizeof(*collection), GFP_KERNEL); >> @@ -910,8 +914,9 @@ static int vgic_its_cmd_handle_mapd(struct kvm *kvm, struct vgic_its *its, >> size_t size = its_cmd_get_size(its_cmd); >> gpa_t itt_addr = its_cmd_get_ittaddr(its_cmd); >> struct its_device *device; >> + gpa_t eaddr; >> >> - if (!vgic_its_check_id(its, its->baser_device_table, device_id)) >> + if (!vgic_its_check_id(its, its->baser_device_table, device_id, &eaddr)) >> return E_ITS_MAPD_DEVICE_OOR; >> >> if (valid && size > VITS_TYPER_IDBITS) >>
WARNING: multiple messages have this Message-ID (diff)
From: eric.auger@redhat.com (Auger Eric) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 16/19] KVM: arm64: ITS: vgic_its_check_id returns the entry's GPA Date: Wed, 22 Mar 2017 15:11:05 +0100 [thread overview] Message-ID: <5e14fa1c-2eb6-6746-968b-4ecc18dd7cdd@redhat.com> (raw) In-Reply-To: <be79d92f-2522-a754-f006-66901d26e94c@arm.com> Hi, On 21/03/2017 19:12, Andre Przywara wrote: > Hi, > > On 06/03/17 11:34, Eric Auger wrote: >> As vgic_its_check_id() computes the device/collection entry's >> GPA, let's return it so that new callers can retrieve it easily. >> >> Signed-off-by: Eric Auger <eric.auger@redhat.com> >> >> --- >> >> v2: new >> --- >> virt/kvm/arm/vgic/vgic-its.c | 11 ++++++++--- >> 1 file changed, 8 insertions(+), 3 deletions(-) >> >> diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c >> index ad67759..1060125 100644 >> --- a/virt/kvm/arm/vgic/vgic-its.c >> +++ b/virt/kvm/arm/vgic/vgic-its.c >> @@ -637,7 +637,8 @@ static int vgic_its_cmd_handle_movi(struct kvm *kvm, struct vgic_its *its, >> * is actually valid (covered by a memslot and guest accessible). >> * For this we have to read the respective first level entry. >> */ >> -static bool vgic_its_check_id(struct vgic_its *its, u64 baser, int id) >> +static bool vgic_its_check_id(struct vgic_its *its, u64 baser, int id, >> + gpa_t *eaddr) >> { >> int l1_tbl_size = GITS_BASER_NR_PAGES(baser) * SZ_64K; >> int index; >> @@ -657,6 +658,7 @@ static bool vgic_its_check_id(struct vgic_its *its, u64 baser, int id) >> addr = BASER_ADDRESS(baser) + id * esz; >> gfn = addr >> PAGE_SHIFT; >> >> + *eaddr = addr; > > If you check that eaddr is not NULL before writing to it, you can save > the dummy variable in the two callers below (which doesn't hurt, but > does not help readability either). done Thanks Eric > > Cheers, > Andre. > >> return kvm_is_visible_gfn(its->dev->kvm, gfn); >> } >> >> @@ -689,6 +691,7 @@ static bool vgic_its_check_id(struct vgic_its *its, u64 baser, int id) >> indirect_ptr += index * esz; >> gfn = indirect_ptr >> PAGE_SHIFT; >> >> + *eaddr = indirect_ptr; >> return kvm_is_visible_gfn(its->dev->kvm, gfn); >> } >> >> @@ -697,8 +700,9 @@ static int vgic_its_alloc_collection(struct vgic_its *its, >> u32 coll_id) >> { >> struct its_collection *collection; >> + gpa_t eaddr; >> >> - if (!vgic_its_check_id(its, its->baser_coll_table, coll_id)) >> + if (!vgic_its_check_id(its, its->baser_coll_table, coll_id, &eaddr)) >> return E_ITS_MAPC_COLLECTION_OOR; >> >> collection = kzalloc(sizeof(*collection), GFP_KERNEL); >> @@ -910,8 +914,9 @@ static int vgic_its_cmd_handle_mapd(struct kvm *kvm, struct vgic_its *its, >> size_t size = its_cmd_get_size(its_cmd); >> gpa_t itt_addr = its_cmd_get_ittaddr(its_cmd); >> struct its_device *device; >> + gpa_t eaddr; >> >> - if (!vgic_its_check_id(its, its->baser_device_table, device_id)) >> + if (!vgic_its_check_id(its, its->baser_device_table, device_id, &eaddr)) >> return E_ITS_MAPD_DEVICE_OOR; >> >> if (valid && size > VITS_TYPER_IDBITS) >>
next prev parent reply other threads:[~2017-03-22 14:11 UTC|newest] Thread overview: 132+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-06 11:34 [PATCH v3 00/19] vITS save/restore Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-06 11:34 ` [PATCH v3 01/19] KVM: arm/arm64: Add vITS save/restore API documentation Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-13 13:08 ` Peter Maydell 2017-03-13 13:08 ` Peter Maydell 2017-03-13 14:42 ` Auger Eric 2017-03-13 14:42 ` Auger Eric 2017-03-13 17:38 ` Peter Maydell 2017-03-13 17:38 ` Peter Maydell 2017-03-16 15:25 ` Auger Eric 2017-03-16 15:25 ` Auger Eric 2017-03-06 11:34 ` [PATCH v3 02/19] KVM: arm/arm64: rename itte into ite Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-06 11:34 ` [PATCH v3 03/19] arm/arm64: vgic: turn vgic_find_mmio_region into public Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-17 14:38 ` Andre Przywara 2017-03-17 14:38 ` Andre Przywara 2017-03-21 17:38 ` Auger Eric 2017-03-21 17:38 ` Auger Eric 2017-03-06 11:34 ` [PATCH v3 04/19] KVM: arm64: ITS: KVM_DEV_ARM_VGIC_GRP_ITS_REGS group Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-20 18:12 ` Andre Przywara 2017-03-20 18:12 ` Andre Przywara 2017-03-06 11:34 ` [PATCH v3 05/19] KVM: arm64: ITS: Implement vgic_its_has_attr_regs and attr_regs_access Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-20 18:13 ` Andre Przywara 2017-03-20 18:13 ` Andre Przywara 2017-03-22 14:15 ` Auger Eric 2017-03-22 14:15 ` Auger Eric 2017-03-06 11:34 ` [PATCH v3 06/19] KVM: arm64: ITS: Implement vgic_mmio_uaccess_write_its_creadr Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-20 18:14 ` Andre Przywara 2017-03-20 18:14 ` Andre Przywara 2017-03-24 10:38 ` Auger Eric 2017-03-24 10:38 ` Auger Eric 2017-03-06 11:34 ` [PATCH v3 07/19] KVM: arm64: ITS: Report the ITE size in GITS_TYPER Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-17 14:39 ` Andre Przywara 2017-03-17 14:39 ` Andre Przywara 2017-03-21 17:38 ` Auger Eric 2017-03-21 17:38 ` Auger Eric 2017-03-06 11:34 ` [PATCH v3 08/19] KVM: arm64: ITS: Interpret MAPD Size field and check related errors Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-17 15:03 ` Andre Przywara 2017-03-17 15:03 ` Andre Przywara 2017-03-21 17:40 ` Auger Eric 2017-03-21 17:40 ` Auger Eric 2017-03-21 17:57 ` Andre Przywara 2017-03-21 17:57 ` Andre Przywara 2017-03-06 11:34 ` [PATCH v3 09/19] KVM: arm64: ITS: Interpret MAPD ITT_addr field Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-17 15:19 ` Andre Przywara 2017-03-17 15:19 ` Andre Przywara 2017-03-21 17:41 ` Auger Eric 2017-03-21 17:41 ` Auger Eric 2017-03-06 11:34 ` [PATCH v3 10/19] KVM: arm64: ITS: Check the device id matches TYPER DEVBITS range Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-17 15:41 ` Andre Przywara 2017-03-17 15:41 ` Andre Przywara 2017-03-21 17:42 ` Auger Eric 2017-03-21 17:42 ` Auger Eric 2017-03-06 11:34 ` [PATCH v3 11/19] KVM: arm64: ITS: KVM_DEV_ARM_VGIC_GRP_ITS_TABLES group Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-20 18:14 ` Andre Przywara 2017-03-20 18:14 ` Andre Przywara 2017-03-22 14:29 ` Auger Eric 2017-03-22 14:29 ` Auger Eric 2017-03-06 11:34 ` [PATCH v3 12/19] KVM: arm64: ITS: vgic_its_alloc_ite/device Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-17 17:01 ` Andre Przywara 2017-03-17 17:01 ` Andre Przywara 2017-03-21 17:42 ` Auger Eric 2017-03-21 17:42 ` Auger Eric 2017-03-06 11:34 ` [PATCH v3 13/19] KVM: arm64: ITS: Sort the device and ITE lists Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-20 18:14 ` Andre Przywara 2017-03-20 18:14 ` Andre Przywara 2017-03-06 11:34 ` [PATCH v3 14/19] KVM: arm64: ITS: Add infrastructure for table lookup Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-21 18:12 ` Andre Przywara 2017-03-21 18:12 ` Andre Przywara 2017-03-22 14:40 ` Auger Eric 2017-03-22 14:40 ` Auger Eric 2017-03-06 11:34 ` [PATCH v3 15/19] KVM: arm64: ITS: Collection table save/restore Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-21 18:13 ` Andre Przywara 2017-03-21 18:13 ` Andre Przywara 2017-03-22 14:12 ` Auger Eric 2017-03-22 14:12 ` Auger Eric 2017-03-06 11:34 ` [PATCH v3 16/19] KVM: arm64: ITS: vgic_its_check_id returns the entry's GPA Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-21 18:12 ` Andre Przywara 2017-03-21 18:12 ` Andre Przywara 2017-03-22 14:11 ` Auger Eric [this message] 2017-03-22 14:11 ` Auger Eric 2017-03-22 14:22 ` Auger Eric 2017-03-22 14:22 ` Auger Eric 2017-03-06 11:34 ` [PATCH v3 17/19] KVM: arm64: ITS: ITT flush and restore Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-21 18:13 ` Andre Przywara 2017-03-21 18:13 ` Andre Przywara 2017-03-22 14:17 ` Auger Eric 2017-03-22 14:17 ` Auger Eric 2017-03-06 11:34 ` [PATCH v3 18/19] KVM: arm64: ITS: Device table save/restore Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-22 14:39 ` Andre Przywara 2017-03-22 14:39 ` Andre Przywara 2017-03-24 10:38 ` Auger Eric 2017-03-24 10:38 ` Auger Eric 2017-03-24 10:45 ` Auger Eric 2017-03-24 10:45 ` Auger Eric 2017-03-24 11:12 ` Andre Przywara 2017-03-24 11:12 ` Andre Przywara 2017-03-24 11:27 ` Auger Eric 2017-03-24 11:27 ` Auger Eric 2017-03-24 11:14 ` Andre Przywara 2017-03-24 11:14 ` Andre Przywara 2017-03-24 11:28 ` Auger Eric 2017-03-24 11:28 ` Auger Eric 2017-03-06 11:34 ` [PATCH v3 19/19] KVM: arm64: ITS: Pending " Eric Auger 2017-03-06 11:34 ` Eric Auger 2017-03-20 18:21 ` Andre Przywara 2017-03-20 18:21 ` Andre Przywara 2017-03-22 15:12 ` Auger Eric 2017-03-22 15:12 ` Auger Eric 2017-03-22 16:22 ` André Przywara 2017-03-22 16:22 ` André Przywara 2017-03-22 14:39 ` Andre Przywara 2017-03-22 14:39 ` Andre Przywara 2017-03-24 11:20 ` Auger Eric 2017-03-24 11:20 ` Auger Eric
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5e14fa1c-2eb6-6746-968b-4ecc18dd7cdd@redhat.com \ --to=eric.auger@redhat.com \ --cc=Prasun.Kapoor@cavium.com \ --cc=Vijaya.Kumar@cavium.com \ --cc=andre.przywara@arm.com \ --cc=christoffer.dall@linaro.org \ --cc=dgilbert@redhat.com \ --cc=drjones@redhat.com \ --cc=eric.auger.pro@gmail.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=marc.zyngier@arm.com \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=quintela@redhat.com \ --cc=vijayak@caviumnetworks.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.