[PATCH] thermal/intel/intel_soc_dts_iosf: Fix reporting wrong temperatures

[PATCH] thermal/intel/intel_soc_dts_iosf: Fix reporting wrong temperatures

[Hans de Goede]

Since commit 955fb8719efb ("thermal/intel/intel_soc_dts_iosf: Use Intel
TCC library") intel_soc_dts_iosf is reporting the wrong temperature.

The driver expects tj_max to be in milli-degrees-celcius but after
the switch to the TCC library this is now in degrees celcius so
instead of e.g. 90000 it is set to 90 causing a temperature 45
degrees below tj_max to be reported as -44910 milli-degrees
instead of as 45000 milli-degrees.

Fix this by adding back the lost factor of 1000.

Fixes: 955fb8719efb ("thermal/intel/intel_soc_dts_iosf: Use Intel TCC library")
Reported-by: Bernhard Krug <b.krug@elektronenpumpe.de>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
Note reported by private email, so no Closes: tag
---
 drivers/thermal/intel/intel_soc_dts_iosf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/intel/intel_soc_dts_iosf.c b/drivers/thermal/intel/intel_soc_dts_iosf.c
index f99dc7e4ae89..db97499f4f0a 100644
--- a/drivers/thermal/intel/intel_soc_dts_iosf.c
+++ b/drivers/thermal/intel/intel_soc_dts_iosf.c
@@ -398,7 +398,7 @@ struct intel_soc_dts_sensors *intel_soc_dts_iosf_init(
 	spin_lock_init(&sensors->intr_notify_lock);
 	mutex_init(&sensors->dts_update_lock);
 	sensors->intr_type = intr_type;
-	sensors->tj_max = tj_max;
+	sensors->tj_max = tj_max * 1000;
 	if (intr_type == INTEL_SOC_DTS_INTERRUPT_NONE)
 		notification = false;
 	else
-- 
2.40.1

Re: [PATCH] thermal/intel/intel_soc_dts_iosf: Fix reporting wrong temperatures

[Zhang, Rui]

On Wed, 2023-06-14 at 12:07 +0200, Hans de Goede wrote:
> Since commit 955fb8719efb ("thermal/intel/intel_soc_dts_iosf: Use
> Intel
> TCC library") intel_soc_dts_iosf is reporting the wrong temperature.
> 
> The driver expects tj_max to be in milli-degrees-celcius but after
> the switch to the TCC library this is now in degrees celcius so
> instead of e.g. 90000 it is set to 90 causing a temperature 45
> degrees below tj_max to be reported as -44910 milli-degrees
> instead of as 45000 milli-degrees.
> 
> Fix this by adding back the lost factor of 1000.
> 
> Fixes: 955fb8719efb ("thermal/intel/intel_soc_dts_iosf: Use Intel TCC
> library")
> Reported-by: Bernhard Krug <b.krug@elektronenpumpe.de>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Zhang Rui <rui.zhang@intel.com>

thanks,
rui

> ---
> Note reported by private email, so no Closes: tag
> ---
>  drivers/thermal/intel/intel_soc_dts_iosf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/intel/intel_soc_dts_iosf.c
> b/drivers/thermal/intel/intel_soc_dts_iosf.c
> index f99dc7e4ae89..db97499f4f0a 100644
> --- a/drivers/thermal/intel/intel_soc_dts_iosf.c
> +++ b/drivers/thermal/intel/intel_soc_dts_iosf.c
> @@ -398,7 +398,7 @@ struct intel_soc_dts_sensors
> *intel_soc_dts_iosf_init(
>         spin_lock_init(&sensors->intr_notify_lock);
>         mutex_init(&sensors->dts_update_lock);
>         sensors->intr_type = intr_type;
> -       sensors->tj_max = tj_max;
> +       sensors->tj_max = tj_max * 1000;
>         if (intr_type == INTEL_SOC_DTS_INTERRUPT_NONE)
>                 notification = false;
>         else

Re: [PATCH] thermal/intel/intel_soc_dts_iosf: Fix reporting wrong temperatures

[Rafael J. Wysocki]

On Thu, Jun 15, 2023 at 4:35 AM Zhang, Rui <rui.zhang@intel.com> wrote:
>
> On Wed, 2023-06-14 at 12:07 +0200, Hans de Goede wrote:
> > Since commit 955fb8719efb ("thermal/intel/intel_soc_dts_iosf: Use
> > Intel
> > TCC library") intel_soc_dts_iosf is reporting the wrong temperature.
> >
> > The driver expects tj_max to be in milli-degrees-celcius but after
> > the switch to the TCC library this is now in degrees celcius so
> > instead of e.g. 90000 it is set to 90 causing a temperature 45
> > degrees below tj_max to be reported as -44910 milli-degrees
> > instead of as 45000 milli-degrees.
> >
> > Fix this by adding back the lost factor of 1000.
> >
> > Fixes: 955fb8719efb ("thermal/intel/intel_soc_dts_iosf: Use Intel TCC
> > library")
> > Reported-by: Bernhard Krug <b.krug@elektronenpumpe.de>
> > Cc: Zhang Rui <rui.zhang@intel.com>
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Acked-by: Zhang Rui <rui.zhang@intel.com>

Applied as 6.4-rc material, thanks!

> > ---
> > Note reported by private email, so no Closes: tag
> > ---
> >  drivers/thermal/intel/intel_soc_dts_iosf.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/intel/intel_soc_dts_iosf.c
> > b/drivers/thermal/intel/intel_soc_dts_iosf.c
> > index f99dc7e4ae89..db97499f4f0a 100644
> > --- a/drivers/thermal/intel/intel_soc_dts_iosf.c
> > +++ b/drivers/thermal/intel/intel_soc_dts_iosf.c
> > @@ -398,7 +398,7 @@ struct intel_soc_dts_sensors
> > *intel_soc_dts_iosf_init(
> >         spin_lock_init(&sensors->intr_notify_lock);
> >         mutex_init(&sensors->dts_update_lock);
> >         sensors->intr_type = intr_type;
> > -       sensors->tj_max = tj_max;
> > +       sensors->tj_max = tj_max * 1000;
> >         if (intr_type == INTEL_SOC_DTS_INTERRUPT_NONE)
> >                 notification = false;
> >         else
>