From: Marek Szyprowski <m.szyprowski@samsung.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Alim Akhtar <alim.akhtar@samsung.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: replicant@osuosl.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, "Martin Jücker" <martin.juecker@gmail.com>, "Henrik Grimler" <henrik@grimler.se>, "Sam Protsenko" <semen.protsenko@linaro.org>, "Chanho Park" <chanho61.park@samsung.com>, "Chanwoo Choi" <cw00.choi@samsung.com> Subject: Re: [RFT PATCH v3 1/4] ARM: dts: exynos: add unit address to DWC3 node wrapper in Exynos5250 Date: Fri, 27 Jan 2023 23:01:57 +0100 [thread overview] Message-ID: <5e2a7c3e-b2cc-746f-81b1-13adfddf1c62@samsung.com> (raw) In-Reply-To: <20230127212713.267014-1-krzysztof.kozlowski@linaro.org> On 27.01.2023 22:27, Krzysztof Kozlowski wrote: > Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node > which do not have unit address. Therefore usethe address space > of child device (actual DWC3 Controller) as the wrapper's address to > fix: > > exynos5250-smdk5250.dtb: soc: usb3: {'compatible': ['samsung,exynos5250-dwusb3'], > ... } should not be valid under {'type': 'object'} > > exynos5250.dtsi:638.16-653.5: Warning (simple_bus_reg): /soc/usb3: missing or empty reg/ranges property > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > > Changes since v1: > 1. Use ranges with values and drop reg from usb-wrapper node. > 2. Keep "usb" as wrapper's node name. > --- > arch/arm/boot/dts/exynos5250.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi > index 97e89859ba3d..a5db4ac213d5 100644 > --- a/arch/arm/boot/dts/exynos5250.dtsi > +++ b/arch/arm/boot/dts/exynos5250.dtsi > @@ -635,17 +635,17 @@ i2s2: i2s@12d70000 { > #sound-dai-cells = <1>; > }; > > - usbdrd: usb3 { > + usbdrd: usb@12000000 { > compatible = "samsung,exynos5250-dwusb3"; > clocks = <&clock CLK_USB3>; > clock-names = "usbdrd30"; > #address-cells = <1>; > #size-cells = <1>; > - ranges; > + ranges = <0x0 0x12000000 0x10000>; > > - usbdrd_dwc3: usb@12000000 { > + usbdrd_dwc3: usb@0 { > compatible = "snps,dwc3"; > - reg = <0x12000000 0x10000>; > + reg = <0x0 0x10000>; > interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; > phys = <&usbdrd_phy 0>, <&usbdrd_phy 1>; > phy-names = "usb2-phy", "usb3-phy"; Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
WARNING: multiple messages have this Message-ID (diff)
From: Marek Szyprowski <m.szyprowski@samsung.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Alim Akhtar <alim.akhtar@samsung.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: replicant@osuosl.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, "Martin Jücker" <martin.juecker@gmail.com>, "Henrik Grimler" <henrik@grimler.se>, "Sam Protsenko" <semen.protsenko@linaro.org>, "Chanho Park" <chanho61.park@samsung.com>, "Chanwoo Choi" <cw00.choi@samsung.com> Subject: Re: [RFT PATCH v3 1/4] ARM: dts: exynos: add unit address to DWC3 node wrapper in Exynos5250 Date: Fri, 27 Jan 2023 23:01:57 +0100 [thread overview] Message-ID: <5e2a7c3e-b2cc-746f-81b1-13adfddf1c62@samsung.com> (raw) In-Reply-To: <20230127212713.267014-1-krzysztof.kozlowski@linaro.org> On 27.01.2023 22:27, Krzysztof Kozlowski wrote: > Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node > which do not have unit address. Therefore usethe address space > of child device (actual DWC3 Controller) as the wrapper's address to > fix: > > exynos5250-smdk5250.dtb: soc: usb3: {'compatible': ['samsung,exynos5250-dwusb3'], > ... } should not be valid under {'type': 'object'} > > exynos5250.dtsi:638.16-653.5: Warning (simple_bus_reg): /soc/usb3: missing or empty reg/ranges property > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > > Changes since v1: > 1. Use ranges with values and drop reg from usb-wrapper node. > 2. Keep "usb" as wrapper's node name. > --- > arch/arm/boot/dts/exynos5250.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi > index 97e89859ba3d..a5db4ac213d5 100644 > --- a/arch/arm/boot/dts/exynos5250.dtsi > +++ b/arch/arm/boot/dts/exynos5250.dtsi > @@ -635,17 +635,17 @@ i2s2: i2s@12d70000 { > #sound-dai-cells = <1>; > }; > > - usbdrd: usb3 { > + usbdrd: usb@12000000 { > compatible = "samsung,exynos5250-dwusb3"; > clocks = <&clock CLK_USB3>; > clock-names = "usbdrd30"; > #address-cells = <1>; > #size-cells = <1>; > - ranges; > + ranges = <0x0 0x12000000 0x10000>; > > - usbdrd_dwc3: usb@12000000 { > + usbdrd_dwc3: usb@0 { > compatible = "snps,dwc3"; > - reg = <0x12000000 0x10000>; > + reg = <0x0 0x10000>; > interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>; > phys = <&usbdrd_phy 0>, <&usbdrd_phy 1>; > phy-names = "usb2-phy", "usb3-phy"; Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-27 22:02 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20230127212728eucas1p124a7a0cdd785cfc7edd53b7a6fe1a2d0@eucas1p1.samsung.com> 2023-01-27 21:27 ` [RFT PATCH v3 1/4] ARM: dts: exynos: add unit address to DWC3 node wrapper in Exynos5250 Krzysztof Kozlowski 2023-01-27 21:27 ` Krzysztof Kozlowski 2023-01-27 21:27 ` [RFT PATCH v3 2/4] ARM: dts: exynos: add unit address to DWC3 node wrapper in Exynos54xx Krzysztof Kozlowski 2023-01-27 21:27 ` Krzysztof Kozlowski 2023-01-27 22:02 ` Marek Szyprowski 2023-01-27 22:02 ` Marek Szyprowski 2023-01-27 21:27 ` [RFT PATCH v3 3/4] arm64: dts: exynos: add unit address to DWC3 node wrapper in Exynos5433 Krzysztof Kozlowski 2023-01-27 21:27 ` Krzysztof Kozlowski 2023-01-27 22:02 ` Marek Szyprowski 2023-01-27 22:02 ` Marek Szyprowski 2023-01-27 21:27 ` [RFT PATCH v3 4/4] arm64: dts: exynos: add unit address to DWC3 node wrapper in Exynos7 Krzysztof Kozlowski 2023-01-27 21:27 ` Krzysztof Kozlowski 2023-01-28 8:06 ` Alim Akhtar 2023-01-28 8:06 ` Alim Akhtar 2023-01-27 22:01 ` Marek Szyprowski [this message] 2023-01-27 22:01 ` [RFT PATCH v3 1/4] ARM: dts: exynos: add unit address to DWC3 node wrapper in Exynos5250 Marek Szyprowski 2023-01-29 10:40 ` Krzysztof Kozlowski 2023-01-29 10:40 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5e2a7c3e-b2cc-746f-81b1-13adfddf1c62@samsung.com \ --to=m.szyprowski@samsung.com \ --cc=alim.akhtar@samsung.com \ --cc=chanho61.park@samsung.com \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=henrik@grimler.se \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=martin.juecker@gmail.com \ --cc=phone-devel@vger.kernel.org \ --cc=replicant@osuosl.org \ --cc=robh+dt@kernel.org \ --cc=semen.protsenko@linaro.org \ --cc=~postmarketos/upstreaming@lists.sr.ht \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.