* [PATCH (TRIVIAL)] xfs: fix up inode validation failure message
@ 2017-03-17 15:47 Eric Sandeen
2017-03-17 16:35 ` Alex Elder
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Eric Sandeen @ 2017-03-17 15:47 UTC (permalink / raw)
To: linux-xfs
"xfs_iread: validation failed for inode 96 failed"
One "failed" seems like enough.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
Yo dawg, I heard you like failed so I put failed in your
failed so you can fail while you fail.
diff --git a/fs/xfs/libxfs/xfs_inode_buf.c b/fs/xfs/libxfs/xfs_inode_buf.c
index d93f9d9..09c3d1a 100644
--- a/fs/xfs/libxfs/xfs_inode_buf.c
+++ b/fs/xfs/libxfs/xfs_inode_buf.c
@@ -508,7 +508,7 @@
/* even unallocated inodes are verified */
if (!xfs_dinode_verify(mp, ip->i_ino, dip)) {
- xfs_alert(mp, "%s: validation failed for inode %lld failed",
+ xfs_alert(mp, "%s: validation failed for inode %lld",
__func__, ip->i_ino);
XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp, dip);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH (TRIVIAL)] xfs: fix up inode validation failure message
2017-03-17 15:47 [PATCH (TRIVIAL)] xfs: fix up inode validation failure message Eric Sandeen
@ 2017-03-17 16:35 ` Alex Elder
2017-03-17 20:29 ` Bill O'Donnell
2017-03-27 15:21 ` Darrick J. Wong
2 siblings, 0 replies; 4+ messages in thread
From: Alex Elder @ 2017-03-17 16:35 UTC (permalink / raw)
To: Eric Sandeen, linux-xfs
On 03/17/2017 10:47 AM, Eric Sandeen wrote:
> "xfs_iread: validation failed for inode 96 failed"
>
> One "failed" seems like enough.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
>
> Yo dawg, I heard you like failed so I put failed in your
> failed so you can fail while you fail.
>
> diff --git a/fs/xfs/libxfs/xfs_inode_buf.c b/fs/xfs/libxfs/xfs_inode_buf.c
> index d93f9d9..09c3d1a 100644
> --- a/fs/xfs/libxfs/xfs_inode_buf.c
> +++ b/fs/xfs/libxfs/xfs_inode_buf.c
> @@ -508,7 +508,7 @@
>
> /* even unallocated inodes are verified */
> if (!xfs_dinode_verify(mp, ip->i_ino, dip)) {
> - xfs_alert(mp, "%s: validation failed for inode %lld failed",
> + xfs_alert(mp, "%s: validation failed for inode %lld",
> __func__, ip->i_ino);
>
> XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp, dip);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH (TRIVIAL)] xfs: fix up inode validation failure message
2017-03-17 15:47 [PATCH (TRIVIAL)] xfs: fix up inode validation failure message Eric Sandeen
2017-03-17 16:35 ` Alex Elder
@ 2017-03-17 20:29 ` Bill O'Donnell
2017-03-27 15:21 ` Darrick J. Wong
2 siblings, 0 replies; 4+ messages in thread
From: Bill O'Donnell @ 2017-03-17 20:29 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Fri, Mar 17, 2017 at 08:47:38AM -0700, Eric Sandeen wrote:
> "xfs_iread: validation failed for inode 96 failed"
>
> One "failed" seems like enough.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> ---
>
> Yo dawg, I heard you like failed so I put failed in your
> failed so you can fail while you fail.
>
> diff --git a/fs/xfs/libxfs/xfs_inode_buf.c b/fs/xfs/libxfs/xfs_inode_buf.c
> index d93f9d9..09c3d1a 100644
> --- a/fs/xfs/libxfs/xfs_inode_buf.c
> +++ b/fs/xfs/libxfs/xfs_inode_buf.c
> @@ -508,7 +508,7 @@
>
> /* even unallocated inodes are verified */
> if (!xfs_dinode_verify(mp, ip->i_ino, dip)) {
> - xfs_alert(mp, "%s: validation failed for inode %lld failed",
> + xfs_alert(mp, "%s: validation failed for inode %lld",
> __func__, ip->i_ino);
>
> XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp, dip);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH (TRIVIAL)] xfs: fix up inode validation failure message
2017-03-17 15:47 [PATCH (TRIVIAL)] xfs: fix up inode validation failure message Eric Sandeen
2017-03-17 16:35 ` Alex Elder
2017-03-17 20:29 ` Bill O'Donnell
@ 2017-03-27 15:21 ` Darrick J. Wong
2 siblings, 0 replies; 4+ messages in thread
From: Darrick J. Wong @ 2017-03-27 15:21 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Fri, Mar 17, 2017 at 08:47:38AM -0700, Eric Sandeen wrote:
> "xfs_iread: validation failed for inode 96 failed"
>
> One "failed" seems like enough.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> Yo dawg, I heard you like failed so I put failed in your
> failed so you can fail while you fail.
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Will queue for 4.12.
--D
>
> diff --git a/fs/xfs/libxfs/xfs_inode_buf.c b/fs/xfs/libxfs/xfs_inode_buf.c
> index d93f9d9..09c3d1a 100644
> --- a/fs/xfs/libxfs/xfs_inode_buf.c
> +++ b/fs/xfs/libxfs/xfs_inode_buf.c
> @@ -508,7 +508,7 @@
>
> /* even unallocated inodes are verified */
> if (!xfs_dinode_verify(mp, ip->i_ino, dip)) {
> - xfs_alert(mp, "%s: validation failed for inode %lld failed",
> + xfs_alert(mp, "%s: validation failed for inode %lld",
> __func__, ip->i_ino);
>
> XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp, dip);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-27 15:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-17 15:47 [PATCH (TRIVIAL)] xfs: fix up inode validation failure message Eric Sandeen
2017-03-17 16:35 ` Alex Elder
2017-03-17 20:29 ` Bill O'Donnell
2017-03-27 15:21 ` Darrick J. Wong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.