[PATCH] drm/amd/powerplay: warn on smu interface version mismatch

[PATCH] drm/amd/powerplay: warn on smu interface version mismatch

[Yuan, Xiaojie]

Signed-off-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
---
 drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
index c3f48fae6f32..339d063e24ff 100644
--- a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
+++ b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
@@ -272,8 +272,7 @@ static int smu_v11_0_check_fw_version(struct smu_context *smu)
 			"smu fw version = 0x%08x (%d.%d.%d)\n",
 			smu->smc_if_version, if_version,
 			smu_version, smu_major, smu_minor, smu_debug);
-		pr_err("SMU driver if version not matched\n");
-		ret = -EINVAL;
+		pr_warn("SMU driver if version not matched\n");
 	}
 
 	return ret;
-- 
2.20.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amd/powerplay: warn on smu interface version mismatch

[Yuan, Xiaojie]

Current SMU IF version check is too strict, driver with old smu11_driver_if.h sometimes works fine with new SMU firmware. We prefer to see a warning instead a error for debug purposes.

BR,
Xiaojie

________________________________________
From: Yuan, Xiaojie
Sent: Wednesday, June 26, 2019 2:24:19 PM
To: amd-gfx@lists.freedesktop.org
Cc: Wang, Kevin(Yang); Yuan, Xiaojie
Subject: [PATCH] drm/amd/powerplay: warn on smu interface version mismatch

Signed-off-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
---
 drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
index c3f48fae6f32..339d063e24ff 100644
--- a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
+++ b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
@@ -272,8 +272,7 @@ static int smu_v11_0_check_fw_version(struct smu_context *smu)
                        "smu fw version = 0x%08x (%d.%d.%d)\n",
                        smu->smc_if_version, if_version,
                        smu_version, smu_major, smu_minor, smu_debug);
-               pr_err("SMU driver if version not matched\n");
-               ret = -EINVAL;
+               pr_warn("SMU driver if version not matched\n");
        }

        return ret;
--
2.20.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amd/powerplay: warn on smu interface version mismatch

[Kevin Wang]

please add this message in patch commit. after
Reviewed-by: Kevin Wang <kevin1.wang@amd.com>

Best Regards,
Kevin

On 6/26/19 2:34 PM, Yuan, Xiaojie wrote:
> Current SMU IF version check is too strict, driver with old smu11_driver_if.h sometimes works fine with new SMU firmware. We prefer to see a warning instead a error for debug purposes.
>
> BR,
> Xiaojie
>
> ________________________________________
> From: Yuan, Xiaojie
> Sent: Wednesday, June 26, 2019 2:24:19 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Wang, Kevin(Yang); Yuan, Xiaojie
> Subject: [PATCH] drm/amd/powerplay: warn on smu interface version mismatch
>
> Signed-off-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
> ---
>   drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> index c3f48fae6f32..339d063e24ff 100644
> --- a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> +++ b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> @@ -272,8 +272,7 @@ static int smu_v11_0_check_fw_version(struct smu_context *smu)
>                          "smu fw version = 0x%08x (%d.%d.%d)\n",
>                          smu->smc_if_version, if_version,
>                          smu_version, smu_major, smu_minor, smu_debug);
> -               pr_err("SMU driver if version not matched\n");
> -               ret = -EINVAL;
> +               pr_warn("SMU driver if version not matched\n");
>          }
>
>          return ret;
> --
> 2.20.1
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amd/powerplay: warn on smu interface version mismatch

[Quan, Evan]

I do not think this is a good idea.
As there is still some cases that version mismatch will cause unexpected  issues. And they will be hard to debug.
If this is for debug purpose only, I would suggest to keep this in your custom branch only.

Regards,
Evan
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Yuan, Xiaojie
> Sent: Wednesday, June 26, 2019 2:34 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Wang, Kevin(Yang) <Kevin1.Wang@amd.com>
> Subject: Re: [PATCH] drm/amd/powerplay: warn on smu interface version
> mismatch
> 
> Current SMU IF version check is too strict, driver with old smu11_driver_if.h
> sometimes works fine with new SMU firmware. We prefer to see a warning
> instead a error for debug purposes.
> 
> BR,
> Xiaojie
> 
> ________________________________________
> From: Yuan, Xiaojie
> Sent: Wednesday, June 26, 2019 2:24:19 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Wang, Kevin(Yang); Yuan, Xiaojie
> Subject: [PATCH] drm/amd/powerplay: warn on smu interface version
> mismatch
> 
> Signed-off-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
> ---
>  drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> index c3f48fae6f32..339d063e24ff 100644
> --- a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> +++ b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> @@ -272,8 +272,7 @@ static int smu_v11_0_check_fw_version(struct
> smu_context *smu)
>                         "smu fw version = 0x%08x (%d.%d.%d)\n",
>                         smu->smc_if_version, if_version,
>                         smu_version, smu_major, smu_minor, smu_debug);
> -               pr_err("SMU driver if version not matched\n");
> -               ret = -EINVAL;
> +               pr_warn("SMU driver if version not matched\n");
>         }
> 
>         return ret;
> --
> 2.20.1
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amd/powerplay: warn on smu interface version mismatch

[Yuan, Xiaojie]

Thanks Evan, got your point. Then I'll keep the patch only in our bring up branch.

BR,
Xiaojie

________________________________________
From: Quan, Evan
Sent: Thursday, June 27, 2019 9:51:22 AM
To: Yuan, Xiaojie; amd-gfx@lists.freedesktop.org
Cc: Wang, Kevin(Yang)
Subject: RE: [PATCH] drm/amd/powerplay: warn on smu interface version mismatch

I do not think this is a good idea.
As there is still some cases that version mismatch will cause unexpected  issues. And they will be hard to debug.
If this is for debug purpose only, I would suggest to keep this in your custom branch only.

Regards,
Evan
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Yuan, Xiaojie
> Sent: Wednesday, June 26, 2019 2:34 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Wang, Kevin(Yang) <Kevin1.Wang@amd.com>
> Subject: Re: [PATCH] drm/amd/powerplay: warn on smu interface version
> mismatch
>
> Current SMU IF version check is too strict, driver with old smu11_driver_if.h
> sometimes works fine with new SMU firmware. We prefer to see a warning
> instead a error for debug purposes.
>
> BR,
> Xiaojie
>
> ________________________________________
> From: Yuan, Xiaojie
> Sent: Wednesday, June 26, 2019 2:24:19 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Wang, Kevin(Yang); Yuan, Xiaojie
> Subject: [PATCH] drm/amd/powerplay: warn on smu interface version
> mismatch
>
> Signed-off-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
> ---
>  drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> index c3f48fae6f32..339d063e24ff 100644
> --- a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> +++ b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
> @@ -272,8 +272,7 @@ static int smu_v11_0_check_fw_version(struct
> smu_context *smu)
>                         "smu fw version = 0x%08x (%d.%d.%d)\n",
>                         smu->smc_if_version, if_version,
>                         smu_version, smu_major, smu_minor, smu_debug);
> -               pr_err("SMU driver if version not matched\n");
> -               ret = -EINVAL;
> +               pr_warn("SMU driver if version not matched\n");
>         }
>
>         return ret;
> --
> 2.20.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx