* [U-Boot] [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO @ 2015-03-10 1:12 Simon Glass 2015-03-10 1:12 ` [U-Boot] [PATCH 2/2] tegra: seaboard: Correct the gpio_request() call Simon Glass 2015-03-10 2:49 ` [U-Boot] [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO Stephen Warren 0 siblings, 2 replies; 10+ messages in thread From: Simon Glass @ 2015-03-10 1:12 UTC (permalink / raw) To: u-boot This CONFIG is not used, so drop it. Signed-off-by: Simon Glass <sjg@chromium.org> --- include/configs/seaboard.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/configs/seaboard.h b/include/configs/seaboard.h index 5f77051..44daadc 100644 --- a/include/configs/seaboard.h +++ b/include/configs/seaboard.h @@ -27,9 +27,6 @@ #define CONFIG_TEGRA_ENABLE_UARTD #define CONFIG_SYS_NS16550_COM1 NV_PA_APB_UARTD_BASE -/* On Seaboard: GPIO_PI3 = Port I = 8, bit = 3 */ -#define CONFIG_UART_DISABLE_GPIO GPIO_PI3 - #define CONFIG_MACH_TYPE MACH_TYPE_SEABOARD #define CONFIG_BOARD_EARLY_INIT_F -- 2.2.0.rc0.207.ga3a616c ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 2/2] tegra: seaboard: Correct the gpio_request() call 2015-03-10 1:12 [U-Boot] [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO Simon Glass @ 2015-03-10 1:12 ` Simon Glass 2015-03-10 1:16 ` Simon Glass 2015-03-10 2:49 ` [U-Boot] [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO Stephen Warren 1 sibling, 1 reply; 10+ messages in thread From: Simon Glass @ 2015-03-10 1:12 UTC (permalink / raw) To: u-boot Requesting a GPIO without a name is not supposed anymore. This causes the request to fail. Add a name so that the serial console works on seaboard. Signed-off-by: Simon Glass <sjg@chromium.org> --- board/nvidia/seaboard/seaboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/nvidia/seaboard/seaboard.c b/board/nvidia/seaboard/seaboard.c index 25480e4..2d07001 100644 --- a/board/nvidia/seaboard/seaboard.c +++ b/board/nvidia/seaboard/seaboard.c @@ -20,7 +20,7 @@ void gpio_early_init_uart(void) { /* Enable UART via GPIO_PI3 (port 8, bit 3) so serial console works */ - gpio_request(GPIO_PI3, NULL); + gpio_request(GPIO_PI3, "uart_en"); gpio_direction_output(GPIO_PI3, 0); } #endif -- 2.2.0.rc0.207.ga3a616c ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 2/2] tegra: seaboard: Correct the gpio_request() call 2015-03-10 1:12 ` [U-Boot] [PATCH 2/2] tegra: seaboard: Correct the gpio_request() call Simon Glass @ 2015-03-10 1:16 ` Simon Glass 2015-03-29 13:10 ` Simon Glass 0 siblings, 1 reply; 10+ messages in thread From: Simon Glass @ 2015-03-10 1:16 UTC (permalink / raw) To: u-boot Let's try this: Reported-by: Stephen Warren <swarren@nvidia.com> On 9 March 2015 at 19:12, Simon Glass <sjg@chromium.org> wrote: > Requesting a GPIO without a name is not supposed anymore. This causes the > request to fail. Add a name so that the serial console works on seaboard. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > board/nvidia/seaboard/seaboard.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/nvidia/seaboard/seaboard.c b/board/nvidia/seaboard/seaboard.c > index 25480e4..2d07001 100644 > --- a/board/nvidia/seaboard/seaboard.c > +++ b/board/nvidia/seaboard/seaboard.c > @@ -20,7 +20,7 @@ > void gpio_early_init_uart(void) > { > /* Enable UART via GPIO_PI3 (port 8, bit 3) so serial console works */ > - gpio_request(GPIO_PI3, NULL); > + gpio_request(GPIO_PI3, "uart_en"); > gpio_direction_output(GPIO_PI3, 0); > } > #endif > -- > 2.2.0.rc0.207.ga3a616c > ^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 2/2] tegra: seaboard: Correct the gpio_request() call 2015-03-10 1:16 ` Simon Glass @ 2015-03-29 13:10 ` Simon Glass 0 siblings, 0 replies; 10+ messages in thread From: Simon Glass @ 2015-03-29 13:10 UTC (permalink / raw) To: u-boot Hi Tom, On 9 March 2015 at 19:16, Simon Glass <sjg@chromium.org> wrote: > Let's try this: > > Reported-by: Stephen Warren <swarren@nvidia.com> > > > On 9 March 2015 at 19:12, Simon Glass <sjg@chromium.org> wrote: >> Requesting a GPIO without a name is not supposed anymore. This causes the >> request to fail. Add a name so that the serial console works on seaboard. >> >> Signed-off-by: Simon Glass <sjg@chromium.org> Can you please apply this fix? >> --- >> >> board/nvidia/seaboard/seaboard.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/board/nvidia/seaboard/seaboard.c b/board/nvidia/seaboard/seaboard.c >> index 25480e4..2d07001 100644 >> --- a/board/nvidia/seaboard/seaboard.c >> +++ b/board/nvidia/seaboard/seaboard.c >> @@ -20,7 +20,7 @@ >> void gpio_early_init_uart(void) >> { >> /* Enable UART via GPIO_PI3 (port 8, bit 3) so serial console works */ >> - gpio_request(GPIO_PI3, NULL); >> + gpio_request(GPIO_PI3, "uart_en"); >> gpio_direction_output(GPIO_PI3, 0); >> } >> #endif >> -- >> 2.2.0.rc0.207.ga3a616c >> Regards, Simon ^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO 2015-03-10 1:12 [U-Boot] [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO Simon Glass 2015-03-10 1:12 ` [U-Boot] [PATCH 2/2] tegra: seaboard: Correct the gpio_request() call Simon Glass @ 2015-03-10 2:49 ` Stephen Warren 2015-03-29 13:10 ` Simon Glass 1 sibling, 1 reply; 10+ messages in thread From: Stephen Warren @ 2015-03-10 2:49 UTC (permalink / raw) To: u-boot On 03/09/2015 07:12 PM, Simon Glass wrote: > This CONFIG is not used, so drop it. The series, Tested-by: Stephen Warren <swarren@wwwdotorg.org> Acked-by: Stephen Warren <swarren@wwwdotorg.org> ^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO 2015-03-10 2:49 ` [U-Boot] [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO Stephen Warren @ 2015-03-29 13:10 ` Simon Glass 2015-03-30 17:02 ` Tom Warren 0 siblings, 1 reply; 10+ messages in thread From: Simon Glass @ 2015-03-29 13:10 UTC (permalink / raw) To: u-boot Hi Tom, On 9 March 2015 at 20:49, Stephen Warren <swarren@wwwdotorg.org> wrote: > On 03/09/2015 07:12 PM, Simon Glass wrote: >> This CONFIG is not used, so drop it. > > The series, > Tested-by: Stephen Warren <swarren@wwwdotorg.org> > Acked-by: Stephen Warren <swarren@wwwdotorg.org> Can you please apply this fix? Regards, Simon ^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO 2015-03-29 13:10 ` Simon Glass @ 2015-03-30 17:02 ` Tom Warren 2015-03-30 17:14 ` Simon Glass 0 siblings, 1 reply; 10+ messages in thread From: Tom Warren @ 2015-03-30 17:02 UTC (permalink / raw) To: u-boot Simon, This series applied to u-boot-tegra/next locally. I've got to look at some patches from Marcel to see if they've been ACK'd. Once I've collected any other pending patches, I'll push a new /next to Denx. Tom > -----Original Message----- > From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass > Sent: Sunday, March 29, 2015 6:10 AM > To: Stephen Warren > Cc: U-Boot Mailing List; Tom Warren; Stephen Warren > Subject: Re: [PATCH 1/2] tegra: seaboard: Remove unused > CONFIG_UART_DISABLE_GPIO > > Hi Tom, > > On 9 March 2015 at 20:49, Stephen Warren <swarren@wwwdotorg.org> > wrote: > > On 03/09/2015 07:12 PM, Simon Glass wrote: > >> This CONFIG is not used, so drop it. > > > > The series, > > Tested-by: Stephen Warren <swarren@wwwdotorg.org> > > Acked-by: Stephen Warren <swarren@wwwdotorg.org> > > Can you please apply this fix? > > Regards, > Simon ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- ^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO 2015-03-30 17:02 ` Tom Warren @ 2015-03-30 17:14 ` Simon Glass 2015-03-30 18:05 ` Tom Warren 0 siblings, 1 reply; 10+ messages in thread From: Simon Glass @ 2015-03-30 17:14 UTC (permalink / raw) To: u-boot Hi Tom, On 30 March 2015 at 11:02, Tom Warren <TWarren@nvidia.com> wrote: > > Simon, > > This series applied to u-boot-tegra/next locally. I've got to look at some patches from Marcel to see if they've been ACK'd. Once I've collected any other pending patches, I'll push a new /next to Denx. Thanks - also what do you think about applying the Nyan display patches? They work fine on my board, but apparently they are not perfect. Still it might be better than letting them sit. I can rebase and resend. Regards, Simon > > Tom > > > -----Original Message----- > > From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass > > Sent: Sunday, March 29, 2015 6:10 AM > > To: Stephen Warren > > Cc: U-Boot Mailing List; Tom Warren; Stephen Warren > > Subject: Re: [PATCH 1/2] tegra: seaboard: Remove unused > > CONFIG_UART_DISABLE_GPIO > > > > Hi Tom, > > > > On 9 March 2015 at 20:49, Stephen Warren <swarren@wwwdotorg.org> > > wrote: > > > On 03/09/2015 07:12 PM, Simon Glass wrote: > > >> This CONFIG is not used, so drop it. > > > > > > The series, > > > Tested-by: Stephen Warren <swarren@wwwdotorg.org> > > > Acked-by: Stephen Warren <swarren@wwwdotorg.org> > > > > Can you please apply this fix? > > > > Regards, > > Simon > > ----------------------------------------------------------------------------------- > This email message is for the sole use of the intended recipient(s) and may contain > confidential information. Any unauthorized review, use, disclosure or distribution > is prohibited. If you are not the intended recipient, please contact the sender by > reply email and destroy all copies of the original message. > ----------------------------------------------------------------------------------- ^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO 2015-03-30 17:14 ` Simon Glass @ 2015-03-30 18:05 ` Tom Warren 2015-03-30 23:48 ` Simon Glass 0 siblings, 1 reply; 10+ messages in thread From: Tom Warren @ 2015-03-30 18:05 UTC (permalink / raw) To: u-boot If you want to rework them against current u-boot-tegra/master and resend, I'll apply them, and maybe get a chance later this week to test them on my Nyan. Thanks. > -----Original Message----- > From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass > Sent: Monday, March 30, 2015 10:15 AM > To: Tom Warren > Cc: Stephen Warren; U-Boot Mailing List; Stephen Warren > Subject: Re: [PATCH 1/2] tegra: seaboard: Remove unused > CONFIG_UART_DISABLE_GPIO > > Hi Tom, > > On 30 March 2015 at 11:02, Tom Warren <TWarren@nvidia.com> wrote: > > > > Simon, > > > > This series applied to u-boot-tegra/next locally. I've got to look at some > patches from Marcel to see if they've been ACK'd. Once I've collected any > other pending patches, I'll push a new /next to Denx. > > Thanks - also what do you think about applying the Nyan display patches? > They work fine on my board, but apparently they are not perfect. Still it > might be better than letting them sit. I can rebase and resend. > > Regards, > Simon > > > > > Tom > > > > > -----Original Message----- > > > From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon > > > Glass > > > Sent: Sunday, March 29, 2015 6:10 AM > > > To: Stephen Warren > > > Cc: U-Boot Mailing List; Tom Warren; Stephen Warren > > > Subject: Re: [PATCH 1/2] tegra: seaboard: Remove unused > > > CONFIG_UART_DISABLE_GPIO > > > > > > Hi Tom, > > > > > > On 9 March 2015 at 20:49, Stephen Warren <swarren@wwwdotorg.org> > > > wrote: > > > > On 03/09/2015 07:12 PM, Simon Glass wrote: > > > >> This CONFIG is not used, so drop it. > > > > > > > > The series, > > > > Tested-by: Stephen Warren <swarren@wwwdotorg.org> > > > > Acked-by: Stephen Warren <swarren@wwwdotorg.org> > > > > > > Can you please apply this fix? > > > > > > Regards, > > > Simon > > > > ---------------------------------------------------------------------- > > ------------- This email message is for the sole use of the intended > > recipient(s) and may contain confidential information. Any > > unauthorized review, use, disclosure or distribution is prohibited. > > If you are not the intended recipient, please contact the sender by > > reply email and destroy all copies of the original message. > > ---------------------------------------------------------------------- > > ------------- ^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO 2015-03-30 18:05 ` Tom Warren @ 2015-03-30 23:48 ` Simon Glass 0 siblings, 0 replies; 10+ messages in thread From: Simon Glass @ 2015-03-30 23:48 UTC (permalink / raw) To: u-boot Hi Tom, On 30 March 2015 at 12:05, Tom Warren <TWarren@nvidia.com> wrote: > > If you want to rework them against current u-boot-tegra/master and resend, I'll apply them, and maybe get a chance later this week to test them on my Nyan. Thanks. Thanks - I'm rebasing this now and waiting for buildman. Regards, Simon > > > > -----Original Message----- > > From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass > > Sent: Monday, March 30, 2015 10:15 AM > > To: Tom Warren > > Cc: Stephen Warren; U-Boot Mailing List; Stephen Warren > > Subject: Re: [PATCH 1/2] tegra: seaboard: Remove unused > > CONFIG_UART_DISABLE_GPIO > > > > Hi Tom, > > > > On 30 March 2015 at 11:02, Tom Warren <TWarren@nvidia.com> wrote: > > > > > > Simon, > > > > > > This series applied to u-boot-tegra/next locally. I've got to look at some > > patches from Marcel to see if they've been ACK'd. Once I've collected any > > other pending patches, I'll push a new /next to Denx. > > > > Thanks - also what do you think about applying the Nyan display patches? > > They work fine on my board, but apparently they are not perfect. Still it > > might be better than letting them sit. I can rebase and resend. > > > > Regards, > > Simon > > > > > > > > Tom > > > > > > > -----Original Message----- > > > > From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon > > > > Glass > > > > Sent: Sunday, March 29, 2015 6:10 AM > > > > To: Stephen Warren > > > > Cc: U-Boot Mailing List; Tom Warren; Stephen Warren > > > > Subject: Re: [PATCH 1/2] tegra: seaboard: Remove unused > > > > CONFIG_UART_DISABLE_GPIO > > > > > > > > Hi Tom, > > > > > > > > On 9 March 2015 at 20:49, Stephen Warren <swarren@wwwdotorg.org> > > > > wrote: > > > > > On 03/09/2015 07:12 PM, Simon Glass wrote: > > > > >> This CONFIG is not used, so drop it. > > > > > > > > > > The series, > > > > > Tested-by: Stephen Warren <swarren@wwwdotorg.org> > > > > > Acked-by: Stephen Warren <swarren@wwwdotorg.org> > > > > > > > > Can you please apply this fix? > > > > > > > > Regards, > > > > Simon > > > > > > ---------------------------------------------------------------------- > > > ------------- This email message is for the sole use of the intended > > > recipient(s) and may contain confidential information. Any > > > unauthorized review, use, disclosure or distribution is prohibited. > > > If you are not the intended recipient, please contact the sender by > > > reply email and destroy all copies of the original message. > > > ---------------------------------------------------------------------- > > > ------------- ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-03-30 23:48 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-03-10 1:12 [U-Boot] [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO Simon Glass 2015-03-10 1:12 ` [U-Boot] [PATCH 2/2] tegra: seaboard: Correct the gpio_request() call Simon Glass 2015-03-10 1:16 ` Simon Glass 2015-03-29 13:10 ` Simon Glass 2015-03-10 2:49 ` [U-Boot] [PATCH 1/2] tegra: seaboard: Remove unused CONFIG_UART_DISABLE_GPIO Stephen Warren 2015-03-29 13:10 ` Simon Glass 2015-03-30 17:02 ` Tom Warren 2015-03-30 17:14 ` Simon Glass 2015-03-30 18:05 ` Tom Warren 2015-03-30 23:48 ` Simon Glass
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.