All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH QGit 1/2] Fix two typos in the "Toggle filter by tree" tooltip
@ 2009-06-12 12:07 Markus Heidelberg
  2009-06-12 12:07 ` [PATCH QGit 2/2] Remove non-working shortcut key 'f' for "Toggle filter by tree" Markus Heidelberg
  2009-06-12 16:52 ` [PATCH QGit 1/2] Fix two typos in the "Toggle filter by tree" tooltip Marco Costalba
  0 siblings, 2 replies; 3+ messages in thread
From: Markus Heidelberg @ 2009-06-12 12:07 UTC (permalink / raw)
  To: Marco Costalba; +Cc: git, Markus Heidelberg


Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
---
 src/mainview.ui |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mainview.ui b/src/mainview.ui
index 4ddf43d..b3a94a6 100644
--- a/src/mainview.ui
+++ b/src/mainview.ui
@@ -460,7 +460,7 @@
     <string>Filter by tree</string>
    </property>
    <property name="toolTip">
-    <string>Filter by tree selection, multple selection allowed</string>
+    <string>Filter by tree selection, multiple selections allowed</string>
    </property>
    <property name="shortcut">
     <string>F</string>
-- 
1.6.3.2.236.ge505d

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH QGit 2/2] Remove non-working shortcut key 'f' for "Toggle filter by tree"
  2009-06-12 12:07 [PATCH QGit 1/2] Fix two typos in the "Toggle filter by tree" tooltip Markus Heidelberg
@ 2009-06-12 12:07 ` Markus Heidelberg
  2009-06-12 16:52 ` [PATCH QGit 1/2] Fix two typos in the "Toggle filter by tree" tooltip Marco Costalba
  1 sibling, 0 replies; 3+ messages in thread
From: Markus Heidelberg @ 2009-06-12 12:07 UTC (permalink / raw)
  To: Marco Costalba; +Cc: git, Markus Heidelberg

It was introduced in commit cdb58c0 (Adding useful shortcuts,
2008-06-07), but didn't even work there, because the key 'f' was already
reserved for "Go to file page", which caused the following message on
stdout:

    QAction::eventFilter: Ambiguous shortcut overload: F

Now the shortcut works for jumping to the file view again.

Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
---
 src/mainview.ui |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/src/mainview.ui b/src/mainview.ui
index b3a94a6..3a257be 100644
--- a/src/mainview.ui
+++ b/src/mainview.ui
@@ -462,9 +462,6 @@
    <property name="toolTip">
     <string>Filter by tree selection, multiple selections allowed</string>
    </property>
-   <property name="shortcut">
-    <string>F</string>
-   </property>
   </action>
   <action name="ActShowTree">
    <property name="checkable">
-- 
1.6.3.2.236.ge505d

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH QGit 1/2] Fix two typos in the "Toggle filter by tree"  tooltip
  2009-06-12 12:07 [PATCH QGit 1/2] Fix two typos in the "Toggle filter by tree" tooltip Markus Heidelberg
  2009-06-12 12:07 ` [PATCH QGit 2/2] Remove non-working shortcut key 'f' for "Toggle filter by tree" Markus Heidelberg
@ 2009-06-12 16:52 ` Marco Costalba
  1 sibling, 0 replies; 3+ messages in thread
From: Marco Costalba @ 2009-06-12 16:52 UTC (permalink / raw)
  To: Markus Heidelberg; +Cc: git

On Fri, Jun 12, 2009 at 14:07, Markus
Heidelberg<markus.heidelberg@web.de> wrote:
>
> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
> ---

Thanks, all patches applied and pushed.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-06-12 16:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-12 12:07 [PATCH QGit 1/2] Fix two typos in the "Toggle filter by tree" tooltip Markus Heidelberg
2009-06-12 12:07 ` [PATCH QGit 2/2] Remove non-working shortcut key 'f' for "Toggle filter by tree" Markus Heidelberg
2009-06-12 16:52 ` [PATCH QGit 1/2] Fix two typos in the "Toggle filter by tree" tooltip Marco Costalba

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.