* [oe][meta-networking][PATCH] networkmanager: add missing readline depends
@ 2021-01-25 16:31 Adrian Freihofer
2021-01-25 17:09 ` Andreas Müller
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Freihofer @ 2021-01-25 16:31 UTC (permalink / raw)
To: openembedded-devel; +Cc: Adrian Freihofer
Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
---
.../recipes-connectivity/networkmanager/networkmanager_1.28.0.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.28.0.bb b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.28.0.bb
index 1053bdd42..7338290e1 100644
--- a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.28.0.bb
+++ b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.28.0.bb
@@ -17,6 +17,7 @@ DEPENDS = " \
libnewt \
jansson \
curl \
+ readline \
"
inherit gnomebase gettext update-rc.d systemd bash-completion vala gobject-introspection gtk-doc update-alternatives upstream-version-is-even
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [oe][meta-networking][PATCH] networkmanager: add missing readline depends
2021-01-25 16:31 [oe][meta-networking][PATCH] networkmanager: add missing readline depends Adrian Freihofer
@ 2021-01-25 17:09 ` Andreas Müller
2021-01-25 17:15 ` Andreas Müller
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Müller @ 2021-01-25 17:09 UTC (permalink / raw)
To: Adrian Freihofer; +Cc: openembeded-devel, Adrian Freihofer
On Mon, Jan 25, 2021 at 5:31 PM Adrian Freihofer
<adrian.freihofer@gmail.com> wrote:
>
> Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
> ---
> .../recipes-connectivity/networkmanager/networkmanager_1.28.0.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.28.0.bb b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.28.0.bb
> index 1053bdd42..7338290e1 100644
> --- a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.28.0.bb
> +++ b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.28.0.bb
> @@ -17,6 +17,7 @@ DEPENDS = " \
> libnewt \
> jansson \
> curl \
> + readline \
> "
>
> inherit gnomebase gettext update-rc.d systemd bash-completion vala gobject-introspection gtk-doc update-alternatives upstream-version-is-even
> --
> 2.26.2
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [oe][meta-networking][PATCH] networkmanager: add missing readline depends
2021-01-25 17:09 ` Andreas Müller
@ 2021-01-25 17:15 ` Andreas Müller
2021-01-26 20:17 ` Adrian Freihofer
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Müller @ 2021-01-25 17:15 UTC (permalink / raw)
To: Adrian Freihofer; +Cc: openembeded-devel, Adrian Freihofer
On Mon, Jan 25, 2021 at 6:09 PM Andreas Müller <schnitzeltony@gmail.com> wrote:
>
> On Mon, Jan 25, 2021 at 5:31 PM Adrian Freihofer
> <adrian.freihofer@gmail.com> wrote:
> >
> > Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
> > ---
> > .../recipes-connectivity/networkmanager/networkmanager_1.28.0.bb | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.28.0.bb b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.28.0.bb
> > index 1053bdd42..7338290e1 100644
> > --- a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.28.0.bb
> > +++ b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.28.0.bb
> > @@ -17,6 +17,7 @@ DEPENDS = " \
> > libnewt \
> > jansson \
> > curl \
> > + readline \
> > "
> >
Hi Adrian,
pressed 'send' accidentally...
readline is an optional dependency for nmcli. Since readline is GPLv3,
not everybody is happy having it in unconditionally, I suggest you
introduce a PACKAGECONFIG for that - default add or not is up to you
(or what do others think?)
Cheers
Andreas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [oe][meta-networking][PATCH] networkmanager: add missing readline depends
2021-01-25 17:15 ` Andreas Müller
@ 2021-01-26 20:17 ` Adrian Freihofer
2021-01-26 20:27 ` Alexander Kanavin
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Freihofer @ 2021-01-26 20:17 UTC (permalink / raw)
To: schnitzeltony; +Cc: openembedded-devel
Hi Andreas
On Mon, 2021-01-25 at 18:15 +0100, Andreas Müller wrote:
> On Mon, Jan 25, 2021 at 6:09 PM Andreas Müller <schnitzeltony@gmail.com> wrote:
> > On Mon, Jan 25, 2021 at 5:31 PM Adrian Freihofer
> > <adrian.freihofer@gmail.com> wrote:
> > > Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
> > > ---
> > > .../recipes-connectivity/networkmanager/networkmanager_1.28.0.bb | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.28.0.bb b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.28.0.bb
> > > index 1053bdd42..7338290e1 100644
> > > --- a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.28.0.bb
> > > +++ b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.28.0.bb
> > > @@ -17,6 +17,7 @@ DEPENDS = " \
> > > libnewt \
> > > jansson \
> > > curl \
> > > + readline \
> > > "
> > >
> Hi Adrian,
>
> pressed 'send' accidentally...
>
> readline is an optional dependency for nmcli. Since readline is GPLv3,
> not everybody is happy having it in unconditionally, I suggest you
> introduce a PACKAGECONFIG for that - default add or not is up to you
> (or what do others think?)
>
> Cheers
>
> Andreas
Hi Andreas
Thank you for the suggestion. I will send a v2 patch with a
PACKAGECONFIG[nmcli]. But since nmcli was split into a separate
package, its possible to compile nmcli but not install it into a
released firmware.
However I wonder a little bit how others are compiling NetworkManager.
At least in my configuration there is a build error without readline in
DEPENDS.
Regards,
Adrian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [oe][meta-networking][PATCH] networkmanager: add missing readline depends
2021-01-26 20:17 ` Adrian Freihofer
@ 2021-01-26 20:27 ` Alexander Kanavin
0 siblings, 0 replies; 5+ messages in thread
From: Alexander Kanavin @ 2021-01-26 20:27 UTC (permalink / raw)
To: Adrian Freihofer; +Cc: schnitzeltony, openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 2204 bytes --]
As you said, nmcli is already placed into its own package, so we (mbition.io)
simply do not install the package onto the product images.
Last time I looked it was not possible to enable/disable nmcli at buildtime
without extensive patching.
Alex
On Tue, 26 Jan 2021 at 21:17, Adrian Freihofer <adrian.freihofer@siemens.com>
wrote:
> Hi Andreas
>
> On Mon, 2021-01-25 at 18:15 +0100, Andreas Müller wrote:
> > On Mon, Jan 25, 2021 at 6:09 PM Andreas Müller <schnitzeltony@gmail.com>
> wrote:
> > > On Mon, Jan 25, 2021 at 5:31 PM Adrian Freihofer
> > > <adrian.freihofer@gmail.com> wrote:
> > > > Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
> > > > ---
> > > > .../recipes-connectivity/networkmanager/networkmanager_1.28.0.bb |
> 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/meta-networking/recipes-connectivity/networkmanager/
> networkmanager_1.28.0.bb
> b/meta-networking/recipes-connectivity/networkmanager/
> networkmanager_1.28.0.bb
> > > > index 1053bdd42..7338290e1 100644
> > > > --- a/meta-networking/recipes-connectivity/networkmanager/
> networkmanager_1.28.0.bb
> > > > +++ b/meta-networking/recipes-connectivity/networkmanager/
> networkmanager_1.28.0.bb
> > > > @@ -17,6 +17,7 @@ DEPENDS = " \
> > > > libnewt \
> > > > jansson \
> > > > curl \
> > > > + readline \
> > > > "
> > > >
> > Hi Adrian,
> >
> > pressed 'send' accidentally...
> >
> > readline is an optional dependency for nmcli. Since readline is GPLv3,
> > not everybody is happy having it in unconditionally, I suggest you
> > introduce a PACKAGECONFIG for that - default add or not is up to you
> > (or what do others think?)
> >
> > Cheers
> >
> > Andreas
>
> Hi Andreas
>
> Thank you for the suggestion. I will send a v2 patch with a
> PACKAGECONFIG[nmcli]. But since nmcli was split into a separate
> package, its possible to compile nmcli but not install it into a
> released firmware.
> However I wonder a little bit how others are compiling NetworkManager.
> At least in my configuration there is a build error without readline in
> DEPENDS.
>
> Regards,
> Adrian
>
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 3498 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-01-26 20:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 16:31 [oe][meta-networking][PATCH] networkmanager: add missing readline depends Adrian Freihofer
2021-01-25 17:09 ` Andreas Müller
2021-01-25 17:15 ` Andreas Müller
2021-01-26 20:17 ` Adrian Freihofer
2021-01-26 20:27 ` Alexander Kanavin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.