[Buildroot] [PATCH 1/1] package/alsa-utils: fix install rule for alsactl

[Buildroot] [PATCH 1/1] package/alsa-utils: fix install rule for alsactl

[Khoa Hoang]

The copy command for /usr/share/alsa missing an asterisk cause it to copy to
/usr/share/alsa/alsa instead of /usr/share/alsa where it should be.

Signed-off-by: Khoa Hoang <admin@khoahoang.com>
---
 package/alsa-utils/alsa-utils.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/alsa-utils/alsa-utils.mk b/package/alsa-utils/alsa-utils.mk
index 427280c1e6..2603e52f18 100644
--- a/package/alsa-utils/alsa-utils.mk
+++ b/package/alsa-utils/alsa-utils.mk
@@ -77,7 +77,7 @@ define ALSA_UTILS_INSTALL_TARGET_CMDS
 	fi
 	if [ -x "$(TARGET_DIR)/usr/sbin/alsactl" ]; then \
 		mkdir -p $(TARGET_DIR)/usr/share/; \
-		cp -rdpf $(STAGING_DIR)/usr/share/alsa/ $(TARGET_DIR)/usr/share/alsa/; \
+		cp -rdpf $(STAGING_DIR)/usr/share/alsa/* $(TARGET_DIR)/usr/share/alsa/; \
 	fi
 endef
 
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/alsa-utils: fix install rule for alsactl

[Arnout Vandecappelle]

On 11/12/2021 03:50, Khoa Hoang wrote:
> The copy command for /usr/share/alsa missing an asterisk cause it to copy to
> /usr/share/alsa/alsa instead of /usr/share/alsa where it should be.
> 
> Signed-off-by: Khoa Hoang <admin@khoahoang.com>
> ---
>   package/alsa-utils/alsa-utils.mk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/alsa-utils/alsa-utils.mk b/package/alsa-utils/alsa-utils.mk
> index 427280c1e6..2603e52f18 100644
> --- a/package/alsa-utils/alsa-utils.mk
> +++ b/package/alsa-utils/alsa-utils.mk
> @@ -77,7 +77,7 @@ define ALSA_UTILS_INSTALL_TARGET_CMDS
>   	fi
>   	if [ -x "$(TARGET_DIR)/usr/sbin/alsactl" ]; then \
>   		mkdir -p $(TARGET_DIR)/usr/share/; \
> -		cp -rdpf $(STAGING_DIR)/usr/share/alsa/ $(TARGET_DIR)/usr/share/alsa/; \
> +		cp -rdpf $(STAGING_DIR)/usr/share/alsa/* $(TARGET_DIR)/usr/share/alsa/; \

  I was going to suggest to use -t instead. However, this pattern is already 
used for two other copies above, so I guess it's OK.

  Applied to master, thanks.

  Regards,
  Arnout


>   	fi
>   endef
>   
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/alsa-utils: fix install rule for alsactl

[Peter Korsgaard]

>>>>> "Khoa" == Khoa Hoang <admin@khoahoang.com> writes:

 > The copy command for /usr/share/alsa missing an asterisk cause it to copy to
 > /usr/share/alsa/alsa instead of /usr/share/alsa where it should be.

 > Signed-off-by: Khoa Hoang <admin@khoahoang.com>

Committed to 2021.02.x and 2021.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot