All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Will Deacon <will@kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: <kvm@vger.kernel.org>, <jasowang@redhat.com>,
	<virtualization@lists.linux-foundation.org>,
	<christian.brauner@canonical.com>, <corbet@lwn.net>,
	<willy@infradead.org>, <hch@infradead.org>,
	Xie Yongji <xieyongji@bytedance.com>, <dan.carpenter@oracle.com>,
	<sgarzare@redhat.com>, <xiaodong.liu@intel.com>,
	<linux-fsdevel@vger.kernel.org>, <viro@zeniv.linux.org.uk>,
	<stefanha@redhat.com>, <songmuchun@bytedance.com>,
	<axboe@kernel.dk>, <zhe.he@windriver.com>,
	<gregkh@linuxfoundation.org>, <rdunlap@infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<iommu@lists.linux-foundation.org>, <bcrl@kvack.org>,
	<netdev@vger.kernel.org>, <joe@perches.com>,
	<robin.murphy@arm.com>, <mika.penttila@nextfour.com>
Subject: Re: [PATCH v11 01/12] iova: Export alloc_iova_fast() and free_iova_fast()
Date: Wed, 25 Aug 2021 11:39:22 +0100	[thread overview]
Message-ID: <5f4eadda-5500-9bac-4368-48cfca6d0a4d@huawei.com> (raw)
In-Reply-To: <20210825095540.GA24546@willie-the-truck>

On 25/08/2021 10:55, Will Deacon wrote:
> On Tue, Aug 24, 2021 at 02:08:33PM -0400, Michael S. Tsirkin wrote:
>> On Wed, Aug 18, 2021 at 08:06:31PM +0800, Xie Yongji wrote:
>>> Export alloc_iova_fast() and free_iova_fast() so that
>>> some modules can make use of the per-CPU cache to get
>>> rid of rbtree spinlock in alloc_iova() and free_iova()
>>> during IOVA allocation.
>>>
>>> Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
>>
>>
>> This needs ack from iommu maintainers. Guys?
> 
> Looks fine to me:
> 
> Acked-by: Will Deacon <will@kernel.org>
> 
> Will
> _______________________________________________
> iommu mailing list
> iommu@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
> .
> 

JFYI, There was a preliminary discussion to move the iova rcache code 
(which the iova fast alloc and free functions are based on) out of the 
iova code and maybe into dma-iommu (being the only user). There was 
other motivation.

https://lore.kernel.org/linux-iommu/83de3911-145d-77c8-17c1-981e4ff825d3@arm.com/

Having more users complicates that...

Thanks,
John

WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com>
To: Will Deacon <will@kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm@vger.kernel.org, jasowang@redhat.com,
	virtualization@lists.linux-foundation.org,
	christian.brauner@canonical.com, corbet@lwn.net,
	willy@infradead.org, hch@infradead.org,
	Xie Yongji <xieyongji@bytedance.com>,
	dan.carpenter@oracle.com, sgarzare@redhat.com,
	xiaodong.liu@intel.com, joe@perches.com, viro@zeniv.linux.org.uk,
	stefanha@redhat.com, songmuchun@bytedance.com, axboe@kernel.dk,
	zhe.he@windriver.com, gregkh@linuxfoundation.org,
	rdunlap@infradead.org, linux-kernel@vger.kernel.org,
	iommu@lists.linux-foundation.org, bcrl@kvack.org,
	netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	robin.murphy@arm.com, mika.penttila@nextfour.com
Subject: Re: [PATCH v11 01/12] iova: Export alloc_iova_fast() and free_iova_fast()
Date: Wed, 25 Aug 2021 11:39:22 +0100	[thread overview]
Message-ID: <5f4eadda-5500-9bac-4368-48cfca6d0a4d@huawei.com> (raw)
In-Reply-To: <20210825095540.GA24546@willie-the-truck>

On 25/08/2021 10:55, Will Deacon wrote:
> On Tue, Aug 24, 2021 at 02:08:33PM -0400, Michael S. Tsirkin wrote:
>> On Wed, Aug 18, 2021 at 08:06:31PM +0800, Xie Yongji wrote:
>>> Export alloc_iova_fast() and free_iova_fast() so that
>>> some modules can make use of the per-CPU cache to get
>>> rid of rbtree spinlock in alloc_iova() and free_iova()
>>> during IOVA allocation.
>>>
>>> Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
>>
>>
>> This needs ack from iommu maintainers. Guys?
> 
> Looks fine to me:
> 
> Acked-by: Will Deacon <will@kernel.org>
> 
> Will
> _______________________________________________
> iommu mailing list
> iommu@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
> .
> 

JFYI, There was a preliminary discussion to move the iova rcache code 
(which the iova fast alloc and free functions are based on) out of the 
iova code and maybe into dma-iommu (being the only user). There was 
other motivation.

https://lore.kernel.org/linux-iommu/83de3911-145d-77c8-17c1-981e4ff825d3@arm.com/

Having more users complicates that...

Thanks,
John
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2021-08-25 10:35 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18 12:06 [PATCH v11 00/12] Introduce VDUSE - vDPA Device in Userspace Xie Yongji
2021-08-18 12:06 ` Xie Yongji
2021-08-18 12:06 ` [PATCH v11 01/12] iova: Export alloc_iova_fast() and free_iova_fast() Xie Yongji
2021-08-18 12:06   ` Xie Yongji
2021-08-23  6:24   ` Jason Wang
2021-08-23  6:24     ` Jason Wang
2021-08-23  6:24     ` Jason Wang
2021-08-24 18:08   ` Michael S. Tsirkin
2021-08-24 18:08     ` Michael S. Tsirkin
2021-08-24 18:08     ` Michael S. Tsirkin
2021-08-25  9:55     ` Will Deacon
2021-08-25  9:55       ` Will Deacon
2021-08-25  9:55       ` Will Deacon
2021-08-25 10:39       ` John Garry [this message]
2021-08-25 10:39         ` John Garry
2021-08-25 12:17         ` Yongji Xie
2021-08-25 12:17           ` Yongji Xie
2021-08-27  9:03           ` John Garry
2021-08-27  9:03             ` John Garry
2021-08-18 12:06 ` [PATCH v11 02/12] file: Export receive_fd() to modules Xie Yongji
2021-08-18 12:06   ` Xie Yongji
2021-08-18 12:06 ` [PATCH v11 03/12] vdpa: Fix some coding style issues Xie Yongji
2021-08-18 12:06   ` Xie Yongji
2021-08-23  6:27   ` Jason Wang
2021-08-23  6:27     ` Jason Wang
2021-08-23  6:27     ` Jason Wang
2021-08-24 11:09   ` Stefano Garzarella
2021-08-24 11:09     ` Stefano Garzarella
2021-08-24 11:09     ` Stefano Garzarella
2021-08-18 12:06 ` [PATCH v11 04/12] vdpa: Add reset callback in vdpa_config_ops Xie Yongji
2021-08-18 12:06   ` Xie Yongji
2021-08-23  6:31   ` Jason Wang
2021-08-23  6:31     ` Jason Wang
2021-08-23  6:31     ` Jason Wang
2021-08-23  7:44     ` Yongji Xie
2021-08-23  7:44       ` Yongji Xie
2021-08-18 12:06 ` [PATCH v11 05/12] vhost-vdpa: Handle the failure of vdpa_reset() Xie Yongji
2021-08-18 12:06   ` Xie Yongji
2021-08-23  6:32   ` Jason Wang
2021-08-23  6:32     ` Jason Wang
2021-08-23  6:32     ` Jason Wang
2021-08-24 11:12   ` Stefano Garzarella
2021-08-24 11:12     ` Stefano Garzarella
2021-08-24 11:12     ` Stefano Garzarella
2021-08-18 12:06 ` [PATCH v11 06/12] vhost-iotlb: Add an opaque pointer for vhost IOTLB Xie Yongji
2021-08-18 12:06   ` Xie Yongji
2021-08-18 12:06 ` [PATCH v11 07/12] vdpa: Add an opaque pointer for vdpa_config_ops.dma_map() Xie Yongji
2021-08-18 12:06   ` Xie Yongji
2021-08-18 12:06 ` [PATCH v11 08/12] vdpa: factor out vhost_vdpa_pa_map() and vhost_vdpa_pa_unmap() Xie Yongji
2021-08-18 12:06   ` Xie Yongji
2021-08-18 12:06 ` [PATCH v11 09/12] vdpa: Support transferring virtual addressing during DMA mapping Xie Yongji
2021-08-18 12:06   ` Xie Yongji
2021-08-18 12:06 ` [PATCH v11 10/12] vduse: Implement an MMU-based software IOTLB Xie Yongji
2021-08-18 12:06   ` Xie Yongji
2021-08-27  8:57   ` John Garry
2021-08-27  8:57     ` John Garry
2021-08-27  9:25     ` Yongji Xie
2021-08-27  9:25       ` Yongji Xie
2021-08-18 12:06 ` [PATCH v11 11/12] vduse: Introduce VDUSE - vDPA Device in Userspace Xie Yongji
2021-08-18 12:06   ` Xie Yongji
2021-08-19  3:09   ` kernel test robot
2021-08-23  6:56   ` Jason Wang
2021-08-23  6:56     ` Jason Wang
2021-08-23  6:56     ` Jason Wang
2021-08-24 18:10   ` Michael S. Tsirkin
2021-08-24 18:10     ` Michael S. Tsirkin
2021-08-24 18:10     ` Michael S. Tsirkin
2021-08-25  5:37     ` Yongji Xie
2021-08-25  5:37       ` Yongji Xie
2021-08-18 12:06 ` [PATCH v11 12/12] Documentation: Add documentation for VDUSE Xie Yongji
2021-08-18 12:06   ` Xie Yongji
2021-08-23  6:57   ` Jason Wang
2021-08-23  6:57     ` Jason Wang
2021-08-23  6:57     ` Jason Wang
2021-08-23  7:54   ` Jason Wang
2021-08-23  7:54     ` Jason Wang
2021-08-23  7:54     ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f4eadda-5500-9bac-4368-48cfca6d0a4d@huawei.com \
    --to=john.garry@huawei.com \
    --cc=axboe@kernel.dk \
    --cc=bcrl@kvack.org \
    --cc=christian.brauner@canonical.com \
    --cc=corbet@lwn.net \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jasowang@redhat.com \
    --cc=joe@perches.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.penttila@nextfour.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=robin.murphy@arm.com \
    --cc=sgarzare@redhat.com \
    --cc=songmuchun@bytedance.com \
    --cc=stefanha@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=will@kernel.org \
    --cc=willy@infradead.org \
    --cc=xiaodong.liu@intel.com \
    --cc=xieyongji@bytedance.com \
    --cc=zhe.he@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.