* [PATCH] drm/tilcdc: add missing header dependencies
@ 2016-09-08 11:08 Baoyou Xie
2016-09-08 12:57 ` Jyri Sarha
0 siblings, 1 reply; 6+ messages in thread
From: Baoyou Xie @ 2016-09-08 11:08 UTC (permalink / raw)
To: jsarha, tomi.valkeinen, airlied
Cc: dri-devel, linux-kernel, arnd, baoyou.xie, xie.baoyou
We get 4 warnings when building kernel with W=1:
drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:393:12: warning: no previous prototype for 'tilcdc_tfp410_init' [-Wmissing-prototypes]
drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:398:13: warning: no previous prototype for 'tilcdc_tfp410_fini' [-Wmissing-prototypes]
drivers/gpu/drm/tilcdc/tilcdc_panel.c:443:12: warning: no previous prototype for 'tilcdc_panel_init' [-Wmissing-prototypes]
drivers/gpu/drm/tilcdc/tilcdc_panel.c:448:13: warning: no previous prototype for 'tilcdc_panel_fini' [-Wmissing-prototypes]
In fact, these functions are declared in
drivers/gpu/drm/tilcdc/tilcdc_tfp410.h,
drivers/gpu/drm/tilcdc/tilcdc_panel.h,
so this patch adds missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/tilcdc/tilcdc_panel.c | 1 +
drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
index ff7774c..979394d 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
@@ -24,6 +24,7 @@
#include <video/videomode.h>
#include "tilcdc_drv.h"
+#include "tilcdc_panel.h"
struct panel_module {
struct tilcdc_module base;
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
index 6b8c5b3..455f032 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
@@ -22,6 +22,7 @@
#include <linux/pinctrl/consumer.h>
#include "tilcdc_drv.h"
+#include "tilcdc_tfp410.h"
struct tfp410_module {
struct tilcdc_module base;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/tilcdc: add missing header dependencies
2016-09-08 11:08 [PATCH] drm/tilcdc: add missing header dependencies Baoyou Xie
@ 2016-09-08 12:57 ` Jyri Sarha
0 siblings, 0 replies; 6+ messages in thread
From: Jyri Sarha @ 2016-09-08 12:57 UTC (permalink / raw)
To: Baoyou Xie, tomi.valkeinen, airlied
Cc: dri-devel, linux-kernel, arnd, xie.baoyou
On 09/08/16 14:08, Baoyou Xie wrote:
> We get 4 warnings when building kernel with W=1:
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:393:12: warning: no previous prototype for 'tilcdc_tfp410_init' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:398:13: warning: no previous prototype for 'tilcdc_tfp410_fini' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_panel.c:443:12: warning: no previous prototype for 'tilcdc_panel_init' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_panel.c:448:13: warning: no previous prototype for 'tilcdc_panel_fini' [-Wmissing-prototypes]
>
> In fact, these functions are declared in
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.h,
> drivers/gpu/drm/tilcdc/tilcdc_panel.h,
> so this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
I'll pick this up.
Thanks,
Jyri
> ---
> drivers/gpu/drm/tilcdc/tilcdc_panel.c | 1 +
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index ff7774c..979394d 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -24,6 +24,7 @@
> #include <video/videomode.h>
>
> #include "tilcdc_drv.h"
> +#include "tilcdc_panel.h"
>
> struct panel_module {
> struct tilcdc_module base;
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> index 6b8c5b3..455f032 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> @@ -22,6 +22,7 @@
> #include <linux/pinctrl/consumer.h>
>
> #include "tilcdc_drv.h"
> +#include "tilcdc_tfp410.h"
>
> struct tfp410_module {
> struct tilcdc_module base;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/tilcdc: add missing header dependencies
@ 2016-09-08 12:57 ` Jyri Sarha
0 siblings, 0 replies; 6+ messages in thread
From: Jyri Sarha @ 2016-09-08 12:57 UTC (permalink / raw)
To: Baoyou Xie, tomi.valkeinen, airlied
Cc: xie.baoyou, arnd, linux-kernel, dri-devel
On 09/08/16 14:08, Baoyou Xie wrote:
> We get 4 warnings when building kernel with W=1:
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:393:12: warning: no previous prototype for 'tilcdc_tfp410_init' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:398:13: warning: no previous prototype for 'tilcdc_tfp410_fini' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_panel.c:443:12: warning: no previous prototype for 'tilcdc_panel_init' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_panel.c:448:13: warning: no previous prototype for 'tilcdc_panel_fini' [-Wmissing-prototypes]
>
> In fact, these functions are declared in
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.h,
> drivers/gpu/drm/tilcdc/tilcdc_panel.h,
> so this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
I'll pick this up.
Thanks,
Jyri
> ---
> drivers/gpu/drm/tilcdc/tilcdc_panel.c | 1 +
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index ff7774c..979394d 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -24,6 +24,7 @@
> #include <video/videomode.h>
>
> #include "tilcdc_drv.h"
> +#include "tilcdc_panel.h"
>
> struct panel_module {
> struct tilcdc_module base;
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> index 6b8c5b3..455f032 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> @@ -22,6 +22,7 @@
> #include <linux/pinctrl/consumer.h>
>
> #include "tilcdc_drv.h"
> +#include "tilcdc_tfp410.h"
>
> struct tfp410_module {
> struct tilcdc_module base;
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/tilcdc: add missing header dependencies
2016-09-21 5:12 Baoyou Xie
@ 2016-09-22 15:56 ` Jyri Sarha
0 siblings, 0 replies; 6+ messages in thread
From: Jyri Sarha @ 2016-09-22 15:56 UTC (permalink / raw)
To: Baoyou Xie, tomi.valkeinen, airlied
Cc: dri-devel, linux-kernel, arnd, xie.baoyou
Thanks,
But I have got this already:
https://lists.freedesktop.org/archives/dri-devel/2016-September/117900.html
I will send a pull request soon.
Best regards,
Jyri
On 09/21/16 08:12, Baoyou Xie wrote:
> We get 4 warnings when building kernel with W=1:
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:397:12: warning: no previous prototype for 'tilcdc_tfp410_init' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:402:13: warning: no previous prototype for 'tilcdc_tfp410_fini' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_panel.c:448:12: warning: no previous prototype for 'tilcdc_panel_init' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_panel.c:453:13: warning: no previous prototype for 'tilcdc_panel_fini' [-Wmissing-prototypes]
>
> In fact, these functions are declared in
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.h,
> drivers/gpu/drm/tilcdc/tilcdc_panel.h,
> so this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/gpu/drm/tilcdc/tilcdc_panel.c | 1 +
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index 4ac1d25..186cf23 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -25,6 +25,7 @@
> #include <drm/drm_atomic_helper.h>
>
> #include "tilcdc_drv.h"
> +#include "tilcdc_panel.h"
>
> struct panel_module {
> struct tilcdc_module base;
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> index 741c7b5..8692671 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> @@ -23,6 +23,7 @@
> #include <drm/drm_atomic_helper.h>
>
> #include "tilcdc_drv.h"
> +#include "tilcdc_tfp410.h"
>
> struct tfp410_module {
> struct tilcdc_module base;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/tilcdc: add missing header dependencies
@ 2016-09-22 15:56 ` Jyri Sarha
0 siblings, 0 replies; 6+ messages in thread
From: Jyri Sarha @ 2016-09-22 15:56 UTC (permalink / raw)
To: Baoyou Xie, tomi.valkeinen, airlied
Cc: dri-devel, linux-kernel, arnd, xie.baoyou
Thanks,
But I have got this already:
https://lists.freedesktop.org/archives/dri-devel/2016-September/117900.html
I will send a pull request soon.
Best regards,
Jyri
On 09/21/16 08:12, Baoyou Xie wrote:
> We get 4 warnings when building kernel with W=1:
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:397:12: warning: no previous prototype for 'tilcdc_tfp410_init' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:402:13: warning: no previous prototype for 'tilcdc_tfp410_fini' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_panel.c:448:12: warning: no previous prototype for 'tilcdc_panel_init' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_panel.c:453:13: warning: no previous prototype for 'tilcdc_panel_fini' [-Wmissing-prototypes]
>
> In fact, these functions are declared in
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.h,
> drivers/gpu/drm/tilcdc/tilcdc_panel.h,
> so this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/gpu/drm/tilcdc/tilcdc_panel.c | 1 +
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index 4ac1d25..186cf23 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -25,6 +25,7 @@
> #include <drm/drm_atomic_helper.h>
>
> #include "tilcdc_drv.h"
> +#include "tilcdc_panel.h"
>
> struct panel_module {
> struct tilcdc_module base;
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> index 741c7b5..8692671 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> @@ -23,6 +23,7 @@
> #include <drm/drm_atomic_helper.h>
>
> #include "tilcdc_drv.h"
> +#include "tilcdc_tfp410.h"
>
> struct tfp410_module {
> struct tilcdc_module base;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] drm/tilcdc: add missing header dependencies
@ 2016-09-21 5:12 Baoyou Xie
2016-09-22 15:56 ` Jyri Sarha
0 siblings, 1 reply; 6+ messages in thread
From: Baoyou Xie @ 2016-09-21 5:12 UTC (permalink / raw)
To: jsarha, tomi.valkeinen, airlied
Cc: dri-devel, linux-kernel, arnd, baoyou.xie, xie.baoyou
We get 4 warnings when building kernel with W=1:
drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:397:12: warning: no previous prototype for 'tilcdc_tfp410_init' [-Wmissing-prototypes]
drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:402:13: warning: no previous prototype for 'tilcdc_tfp410_fini' [-Wmissing-prototypes]
drivers/gpu/drm/tilcdc/tilcdc_panel.c:448:12: warning: no previous prototype for 'tilcdc_panel_init' [-Wmissing-prototypes]
drivers/gpu/drm/tilcdc/tilcdc_panel.c:453:13: warning: no previous prototype for 'tilcdc_panel_fini' [-Wmissing-prototypes]
In fact, these functions are declared in
drivers/gpu/drm/tilcdc/tilcdc_tfp410.h,
drivers/gpu/drm/tilcdc/tilcdc_panel.h,
so this patch adds missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/tilcdc/tilcdc_panel.c | 1 +
drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
index 4ac1d25..186cf23 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
@@ -25,6 +25,7 @@
#include <drm/drm_atomic_helper.h>
#include "tilcdc_drv.h"
+#include "tilcdc_panel.h"
struct panel_module {
struct tilcdc_module base;
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
index 741c7b5..8692671 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
@@ -23,6 +23,7 @@
#include <drm/drm_atomic_helper.h>
#include "tilcdc_drv.h"
+#include "tilcdc_tfp410.h"
struct tfp410_module {
struct tilcdc_module base;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-22 15:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-08 11:08 [PATCH] drm/tilcdc: add missing header dependencies Baoyou Xie
2016-09-08 12:57 ` Jyri Sarha
2016-09-08 12:57 ` Jyri Sarha
2016-09-21 5:12 Baoyou Xie
2016-09-22 15:56 ` Jyri Sarha
2016-09-22 15:56 ` Jyri Sarha
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.