* [Intel-gfx] [PATCH] i915/perf: Disable OA sseu config param for non-gen11 platforms
@ 2022-07-06 21:52 Nerlige Ramappa, Umesh
2022-07-07 0:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Nerlige Ramappa, Umesh @ 2022-07-06 21:52 UTC (permalink / raw)
To: intel-gfx
The global sseu config is applicable only to gen11 platforms where
concurrent media, render and OA use cases may cause some subslices to be
turned off and hence lose NOA configuration. Return ENODEV for non-gen11
platforms.
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
drivers/gpu/drm/i915/i915_perf.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index 1577ab6754db..512c163fdbeb 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -3706,6 +3706,12 @@ static int read_properties_unlocked(struct i915_perf *perf,
case DRM_I915_PERF_PROP_GLOBAL_SSEU: {
struct drm_i915_gem_context_param_sseu user_sseu;
+ if (GRAPHICS_VER(perf->i915) != 11) {
+ DRM_DEBUG("Global SSEU config not supported on gen%d\n",
+ GRAPHICS_VER(perf->i915));
+ return -ENODEV;
+ }
+
if (copy_from_user(&user_sseu,
u64_to_user_ptr(value),
sizeof(user_sseu))) {
--
2.35.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915/perf: Disable OA sseu config param for non-gen11 platforms
2022-07-06 21:52 [Intel-gfx] [PATCH] i915/perf: Disable OA sseu config param for non-gen11 platforms Nerlige Ramappa, Umesh
@ 2022-07-07 0:03 ` Patchwork
2022-07-07 0:26 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-07-07 7:56 ` [Intel-gfx] [PATCH] " Lionel Landwerlin
2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-07-07 0:03 UTC (permalink / raw)
To: Nerlige Ramappa, Umesh; +Cc: intel-gfx
== Series Details ==
Series: i915/perf: Disable OA sseu config param for non-gen11 platforms
URL : https://patchwork.freedesktop.org/series/105998/
State : warning
== Summary ==
Error: dim checkpatch failed
ba9ea66b787d i915/perf: Disable OA sseu config param for non-gen11 platforms
-:30: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: "Nerlige Ramappa, Umesh" <umesh.nerlige.ramappa@intel.com>' != 'Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>'
total: 0 errors, 1 warnings, 0 checks, 12 lines checked
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for i915/perf: Disable OA sseu config param for non-gen11 platforms
2022-07-06 21:52 [Intel-gfx] [PATCH] i915/perf: Disable OA sseu config param for non-gen11 platforms Nerlige Ramappa, Umesh
2022-07-07 0:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2022-07-07 0:26 ` Patchwork
2022-07-07 7:56 ` [Intel-gfx] [PATCH] " Lionel Landwerlin
2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-07-07 0:26 UTC (permalink / raw)
To: Nerlige Ramappa, Umesh; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 9089 bytes --]
== Series Details ==
Series: i915/perf: Disable OA sseu config param for non-gen11 platforms
URL : https://patchwork.freedesktop.org/series/105998/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11854 -> Patchwork_105998v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_105998v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_105998v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105998v1/index.html
Participating hosts (43 -> 41)
------------------------------
Additional (2): fi-hsw-4770 bat-dg2-9
Missing (4): fi-ctg-p8600 bat-rpls-1 fi-bdw-samus fi-snb-2600
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_105998v1:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_suspend@basic-s3@smem:
- fi-bsw-n3050: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11854/fi-bsw-n3050/igt@gem_exec_suspend@basic-s3@smem.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105998v1/fi-bsw-n3050/igt@gem_exec_suspend@basic-s3@smem.html
Known issues
------------
Here are the changes found in Patchwork_105998v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_softpin@allocator-basic-reserve:
- fi-hsw-4770: NOTRUN -> [SKIP][3] ([fdo#109271]) +9 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105998v1/fi-hsw-4770/igt@gem_softpin@allocator-basic-reserve.html
* igt@i915_pm_backlight@basic-brightness:
- fi-hsw-4770: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#3012])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105998v1/fi-hsw-4770/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rpm@module-reload:
- fi-bsw-n3050: [PASS][5] -> [FAIL][6] ([i915#6042])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11854/fi-bsw-n3050/igt@i915_pm_rpm@module-reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105998v1/fi-bsw-n3050/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@gem:
- fi-pnv-d510: [PASS][7] -> [DMESG-FAIL][8] ([i915#4528])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11854/fi-pnv-d510/igt@i915_selftest@live@gem.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105998v1/fi-pnv-d510/igt@i915_selftest@live@gem.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: NOTRUN -> [INCOMPLETE][9] ([i915#4785])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105998v1/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
- bat-dg1-6: [PASS][10] -> [DMESG-FAIL][11] ([i915#4494] / [i915#4957])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11854/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105998v1/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-blb-e6850: NOTRUN -> [SKIP][12] ([fdo#109271])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105998v1/fi-blb-e6850/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@dp-crc-fast:
- fi-hsw-4770: NOTRUN -> [SKIP][13] ([fdo#109271] / [fdo#111827]) +7 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105998v1/fi-hsw-4770/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_psr@sprite_plane_onoff:
- fi-hsw-4770: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#1072]) +3 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105998v1/fi-hsw-4770/igt@kms_psr@sprite_plane_onoff.html
* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][15] ([fdo#109271] / [i915#4312] / [i915#5594] / [i915#6246])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105998v1/fi-hsw-4770/igt@runner@aborted.html
- fi-pnv-d510: NOTRUN -> [FAIL][16] ([fdo#109271] / [i915#2403] / [i915#4312])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105998v1/fi-pnv-d510/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@gem:
- fi-blb-e6850: [DMESG-FAIL][17] ([i915#4528]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11854/fi-blb-e6850/igt@i915_selftest@live@gem.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105998v1/fi-blb-e6850/igt@i915_selftest@live@gem.html
* igt@kms_busy@basic@flip:
- {bat-adln-1}: [DMESG-WARN][19] ([i915#3576]) -> [PASS][20] +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11854/bat-adln-1/igt@kms_busy@basic@flip.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105998v1/bat-adln-1/igt@kms_busy@basic@flip.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [FAIL][21] ([i915#6298]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11854/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105998v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- {bat-adlp-6}: [DMESG-WARN][23] ([i915#3576]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11854/bat-adlp-6/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105998v1/bat-adlp-6/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#5174]: https://gitlab.freedesktop.org/drm/intel/issues/5174
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763
[i915#6042]: https://gitlab.freedesktop.org/drm/intel/issues/6042
[i915#6246]: https://gitlab.freedesktop.org/drm/intel/issues/6246
[i915#6297]: https://gitlab.freedesktop.org/drm/intel/issues/6297
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
Build changes
-------------
* Linux: CI_DRM_11854 -> Patchwork_105998v1
CI-20190529: 20190529
CI_DRM_11854: 3d395b052df9a8552e508d135cec45a97a589989 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6559: 6850e9fd9287a8d39ff0c4d9dc413767022342c1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_105998v1: 3d395b052df9a8552e508d135cec45a97a589989 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
d3170417ee3d i915/perf: Disable OA sseu config param for non-gen11 platforms
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105998v1/index.html
[-- Attachment #2: Type: text/html, Size: 9329 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] i915/perf: Disable OA sseu config param for non-gen11 platforms
2022-07-06 21:52 [Intel-gfx] [PATCH] i915/perf: Disable OA sseu config param for non-gen11 platforms Nerlige Ramappa, Umesh
2022-07-07 0:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-07-07 0:26 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2022-07-07 7:56 ` Lionel Landwerlin
2 siblings, 0 replies; 8+ messages in thread
From: Lionel Landwerlin @ 2022-07-07 7:56 UTC (permalink / raw)
To: Nerlige Ramappa, Umesh, intel-gfx
On 07/07/2022 00:52, Nerlige Ramappa, Umesh wrote:
> The global sseu config is applicable only to gen11 platforms where
> concurrent media, render and OA use cases may cause some subslices to be
> turned off and hence lose NOA configuration. Return ENODEV for non-gen11
> platforms.
>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
The problem is that we have gfx12 platforms shipped using this.
So I guess have to disable it on gfx12.5+ where it was never accepted.
-Lionel
> ---
> drivers/gpu/drm/i915/i915_perf.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> index 1577ab6754db..512c163fdbeb 100644
> --- a/drivers/gpu/drm/i915/i915_perf.c
> +++ b/drivers/gpu/drm/i915/i915_perf.c
> @@ -3706,6 +3706,12 @@ static int read_properties_unlocked(struct i915_perf *perf,
> case DRM_I915_PERF_PROP_GLOBAL_SSEU: {
> struct drm_i915_gem_context_param_sseu user_sseu;
>
> + if (GRAPHICS_VER(perf->i915) != 11) {
> + DRM_DEBUG("Global SSEU config not supported on gen%d\n",
> + GRAPHICS_VER(perf->i915));
> + return -ENODEV;
> + }
> +
> if (copy_from_user(&user_sseu,
> u64_to_user_ptr(value),
> sizeof(user_sseu))) {
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] i915/perf: Disable OA sseu config param for non-gen11 platforms
2022-07-07 18:49 ` Matt Roper
@ 2022-07-07 19:01 ` Umesh Nerlige Ramappa
0 siblings, 0 replies; 8+ messages in thread
From: Umesh Nerlige Ramappa @ 2022-07-07 19:01 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Thu, Jul 07, 2022 at 11:49:30AM -0700, Matt Roper wrote:
>On Thu, Jul 07, 2022 at 11:27:38AM -0700, Nerlige Ramappa, Umesh wrote:
>> The global sseu config is applicable only to gen11 platforms where
>> concurrent media, render and OA use cases may cause some subslices to be
>> turned off and hence lose NOA configuration. Return ENODEV for non-gen11
>> platforms.
>>
>> v2: gfx12 is already shipped with this, disable for gfx12.5+ (Lionel)
>
>The commit message doesn't really match reality anymore with v2; you
>might want to update the commit message a bit.
>
>Also, minor nitpick: although we write IP version numbers as
>"arc.release" in shorthand, we shouldn't make the mistake of treating
>those as fractional numbers since ".5" != ".50" the way they get handled
>in the driver. So this should say "12.50+" rather than "12.5+."
will do. I think I posted an updated patch before seeing your comments,
so ignore that one.
>
>>
>> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>> ---
>> drivers/gpu/drm/i915/i915_perf.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
>> index 1577ab6754db..0ba98f73f217 100644
>> --- a/drivers/gpu/drm/i915/i915_perf.c
>> +++ b/drivers/gpu/drm/i915/i915_perf.c
>> @@ -3706,6 +3706,12 @@ static int read_properties_unlocked(struct i915_perf *perf,
>> case DRM_I915_PERF_PROP_GLOBAL_SSEU: {
>> struct drm_i915_gem_context_param_sseu user_sseu;
>>
>> + if (GRAPHICS_VER_FULL(perf->i915) >= IP_VER(12, 50)) {
>> + DRM_DEBUG("SSEU config not supported on gfx %x\n",
>> + GRAPHICS_VER_FULL(perf->i915));
>
>This should probably be using the device-specific drm_dbg() call.
>
>Actually the perf code in general needs some updates to eliminate
>DRM_DEBUG throughout...not only do we want to avoid using the old
>non-device-aware interface in newer code, that's also the wrong old
>interface to call (DRM_DEBUG categorizes messages as DRM_UT_CORE,
>whereas DRM_DEBUG_DRIVER is the one that treats them as driver messages
>with DRM_UT_DRIVER).
will replace with drm_dbg()
Thanks,
Umesh
>
>
>Matt
>
>> + return -ENODEV;
>> + }
>> +
>> if (copy_from_user(&user_sseu,
>> u64_to_user_ptr(value),
>> sizeof(user_sseu))) {
>> --
>> 2.35.3
>>
>
>--
>Matt Roper
>Graphics Software Engineer
>VTT-OSGC Platform Enablement
>Intel Corporation
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] i915/perf: Disable OA sseu config param for non-gen11 platforms
2022-07-07 18:27 Nerlige Ramappa, Umesh
2022-07-07 18:45 ` Umesh Nerlige Ramappa
@ 2022-07-07 18:49 ` Matt Roper
2022-07-07 19:01 ` Umesh Nerlige Ramappa
1 sibling, 1 reply; 8+ messages in thread
From: Matt Roper @ 2022-07-07 18:49 UTC (permalink / raw)
To: Nerlige Ramappa, Umesh; +Cc: intel-gfx
On Thu, Jul 07, 2022 at 11:27:38AM -0700, Nerlige Ramappa, Umesh wrote:
> The global sseu config is applicable only to gen11 platforms where
> concurrent media, render and OA use cases may cause some subslices to be
> turned off and hence lose NOA configuration. Return ENODEV for non-gen11
> platforms.
>
> v2: gfx12 is already shipped with this, disable for gfx12.5+ (Lionel)
The commit message doesn't really match reality anymore with v2; you
might want to update the commit message a bit.
Also, minor nitpick: although we write IP version numbers as
"arc.release" in shorthand, we shouldn't make the mistake of treating
those as fractional numbers since ".5" != ".50" the way they get handled
in the driver. So this should say "12.50+" rather than "12.5+."
>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> ---
> drivers/gpu/drm/i915/i915_perf.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> index 1577ab6754db..0ba98f73f217 100644
> --- a/drivers/gpu/drm/i915/i915_perf.c
> +++ b/drivers/gpu/drm/i915/i915_perf.c
> @@ -3706,6 +3706,12 @@ static int read_properties_unlocked(struct i915_perf *perf,
> case DRM_I915_PERF_PROP_GLOBAL_SSEU: {
> struct drm_i915_gem_context_param_sseu user_sseu;
>
> + if (GRAPHICS_VER_FULL(perf->i915) >= IP_VER(12, 50)) {
> + DRM_DEBUG("SSEU config not supported on gfx %x\n",
> + GRAPHICS_VER_FULL(perf->i915));
This should probably be using the device-specific drm_dbg() call.
Actually the perf code in general needs some updates to eliminate
DRM_DEBUG throughout...not only do we want to avoid using the old
non-device-aware interface in newer code, that's also the wrong old
interface to call (DRM_DEBUG categorizes messages as DRM_UT_CORE,
whereas DRM_DEBUG_DRIVER is the one that treats them as driver messages
with DRM_UT_DRIVER).
Matt
> + return -ENODEV;
> + }
> +
> if (copy_from_user(&user_sseu,
> u64_to_user_ptr(value),
> sizeof(user_sseu))) {
> --
> 2.35.3
>
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] i915/perf: Disable OA sseu config param for non-gen11 platforms
2022-07-07 18:27 Nerlige Ramappa, Umesh
@ 2022-07-07 18:45 ` Umesh Nerlige Ramappa
2022-07-07 18:49 ` Matt Roper
1 sibling, 0 replies; 8+ messages in thread
From: Umesh Nerlige Ramappa @ 2022-07-07 18:45 UTC (permalink / raw)
To: intel-gfx, Lionel G Landwerlin, Matt Roper
On Thu, Jul 07, 2022 at 11:27:38AM -0700, Nerlige Ramappa, Umesh wrote:
>The global sseu config is applicable only to gen11 platforms where
>concurrent media, render and OA use cases may cause some subslices to be
>turned off and hence lose NOA configuration. Return ENODEV for non-gen11
>platforms.
>
>v2: gfx12 is already shipped with this, disable for gfx12.5+ (Lionel)
Pleas ignore, will post an update to this one with commit message
changes.
Umesh
>
>Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>---
> drivers/gpu/drm/i915/i915_perf.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
>index 1577ab6754db..0ba98f73f217 100644
>--- a/drivers/gpu/drm/i915/i915_perf.c
>+++ b/drivers/gpu/drm/i915/i915_perf.c
>@@ -3706,6 +3706,12 @@ static int read_properties_unlocked(struct i915_perf *perf,
> case DRM_I915_PERF_PROP_GLOBAL_SSEU: {
> struct drm_i915_gem_context_param_sseu user_sseu;
>
>+ if (GRAPHICS_VER_FULL(perf->i915) >= IP_VER(12, 50)) {
>+ DRM_DEBUG("SSEU config not supported on gfx %x\n",
>+ GRAPHICS_VER_FULL(perf->i915));
>+ return -ENODEV;
>+ }
>+
> if (copy_from_user(&user_sseu,
> u64_to_user_ptr(value),
> sizeof(user_sseu))) {
>--
>2.35.3
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH] i915/perf: Disable OA sseu config param for non-gen11 platforms
@ 2022-07-07 18:27 Nerlige Ramappa, Umesh
2022-07-07 18:45 ` Umesh Nerlige Ramappa
2022-07-07 18:49 ` Matt Roper
0 siblings, 2 replies; 8+ messages in thread
From: Nerlige Ramappa, Umesh @ 2022-07-07 18:27 UTC (permalink / raw)
To: intel-gfx, Lionel G Landwerlin, Matt Roper
The global sseu config is applicable only to gen11 platforms where
concurrent media, render and OA use cases may cause some subslices to be
turned off and hence lose NOA configuration. Return ENODEV for non-gen11
platforms.
v2: gfx12 is already shipped with this, disable for gfx12.5+ (Lionel)
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
drivers/gpu/drm/i915/i915_perf.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index 1577ab6754db..0ba98f73f217 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -3706,6 +3706,12 @@ static int read_properties_unlocked(struct i915_perf *perf,
case DRM_I915_PERF_PROP_GLOBAL_SSEU: {
struct drm_i915_gem_context_param_sseu user_sseu;
+ if (GRAPHICS_VER_FULL(perf->i915) >= IP_VER(12, 50)) {
+ DRM_DEBUG("SSEU config not supported on gfx %x\n",
+ GRAPHICS_VER_FULL(perf->i915));
+ return -ENODEV;
+ }
+
if (copy_from_user(&user_sseu,
u64_to_user_ptr(value),
sizeof(user_sseu))) {
--
2.35.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-07-07 19:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-06 21:52 [Intel-gfx] [PATCH] i915/perf: Disable OA sseu config param for non-gen11 platforms Nerlige Ramappa, Umesh
2022-07-07 0:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-07-07 0:26 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-07-07 7:56 ` [Intel-gfx] [PATCH] " Lionel Landwerlin
2022-07-07 18:27 Nerlige Ramappa, Umesh
2022-07-07 18:45 ` Umesh Nerlige Ramappa
2022-07-07 18:49 ` Matt Roper
2022-07-07 19:01 ` Umesh Nerlige Ramappa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.