From: Daniel Thompson <daniel.thompson@linaro.org> To: Lee Jones <lee.jones@linaro.org>, Olimpiu Dejeu <olimpiu@arcticsand.com> Cc: kbuild test robot <lkp@intel.com>, fengguang.wu@intel.com, kbuild-all@01.org, Rob Herring <robh@kernel.org>, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org, jingoohan1@gmail.com, Brian Dodge <bdodge@arcticsand.com>, joe@perches.com, "Matthew D'Asaro" <medasaro@arcticsand.com> Subject: Re: [PATCH] fix ptr_ret.cocci warnings Date: Mon, 24 Apr 2017 12:26:48 +0100 [thread overview] Message-ID: <5f719f78-2890-f9e0-dfc7-f7217432dad0@linaro.org> (raw) In-Reply-To: <20170424105756.im6hjljqvyktzh6n@dell> On 24/04/17 11:57, Lee Jones wrote: > On Mon, 17 Apr 2017, Olimpiu Dejeu wrote: > >> On Tue, Mar 21, 2017 at 11:07 AM, Daniel Thompson < >> daniel.thompson@linaro.org> wrote: >> >>> On 21/03/17 14:58, Olimpiu Dejeu wrote: >>> >>>> On Fri, Mar 17, 2017 at 10:48 AM, kbuild test robot <lkp@intel.com> >>>> wrote: >>>> >>>>> drivers/video/backlight/arcxcnn_bl.c:183:1-3: WARNING: PTR_ERR_OR_ZERO >>>>> can be used >>>>> >>>>> >>>>> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR >>>>> >>>>> Generated by: scripts/coccinelle/api/ptr_ret.cocci >>>>> >>>>> CC: Olimpiu Dejeu <olimpiu@arcticsand.com> >>>>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> >>>>> --- >>>>> >>>>> arcxcnn_bl.c | 5 +---- >>>>> 1 file changed, 1 insertion(+), 4 deletions(-) >>>>> >>>>> --- a/drivers/video/backlight/arcxcnn_bl.c >>>>> +++ b/drivers/video/backlight/arcxcnn_bl.c >>>>> @@ -180,10 +180,7 @@ static int arcxcnn_backlight_register(st >>>>> >>>>> lp->bl = devm_backlight_device_register(lp->dev, name, lp->dev, >>>>> lp, >>>>> &arcxcnn_bl_ops, props); >>>>> - if (IS_ERR(lp->bl)) >>>>> - return PTR_ERR(lp->bl); >>>>> - >>>>> - return 0; >>>>> + return PTR_ERR_OR_ZERO(lp->bl); >>>>> } >>>>> >>>>> static void arcxcnn_parse_dt(struct arcxcnn *lp) >>>>> >>>> >>>> Acked-by: Olimpiu Dejeu <olimpiu@arcticsand.com> >>>> >>> >>> Glad you approve! Could you apply this change and re-post the patch >>> series? Thanks. >>> >>> >>> Daniel. >>> >>> >> Applied change, re-posted series on March 21st. No sure what next. Please >> advise. Thanks. > > Yes you did. > > Daniel, do you see v9? Yep. All fine at my end... it has my Reviewed-by: which is an even more emphatic statement than my Acked-by: ;-) . I think from this point on I think I'll start posting "[vX-is-still-]Acked-by:" replies so you don't have to worry about whether I've seen new versions. > FYI, if this happens again, it's best to wait a couple of weeks then > send the patch again like "[RESEND v9] ..." to gain attention. RESENDs are a good way to go. Also, if there are questions about the code its better to reply to the code rather than the side discussion. Daniel.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org> To: Lee Jones <lee.jones@linaro.org>, Olimpiu Dejeu <olimpiu@arcticsand.com> Cc: kbuild test robot <lkp@intel.com>, fengguang.wu@intel.com, kbuild-all@01.org, Rob Herring <robh@kernel.org>, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, devicetree@vger.kernel.org, jingoohan1@gmail.com, Brian Dodge <bdodge@arcticsand.com>, joe@perches.com, Matthew D'Asaro <medasaro@arcticsand.com> Subject: Re: [PATCH] fix ptr_ret.cocci warnings Date: Mon, 24 Apr 2017 11:26:48 +0000 [thread overview] Message-ID: <5f719f78-2890-f9e0-dfc7-f7217432dad0@linaro.org> (raw) In-Reply-To: <20170424105756.im6hjljqvyktzh6n@dell> On 24/04/17 11:57, Lee Jones wrote: > On Mon, 17 Apr 2017, Olimpiu Dejeu wrote: > >> On Tue, Mar 21, 2017 at 11:07 AM, Daniel Thompson < >> daniel.thompson@linaro.org> wrote: >> >>> On 21/03/17 14:58, Olimpiu Dejeu wrote: >>> >>>> On Fri, Mar 17, 2017 at 10:48 AM, kbuild test robot <lkp@intel.com> >>>> wrote: >>>> >>>>> drivers/video/backlight/arcxcnn_bl.c:183:1-3: WARNING: PTR_ERR_OR_ZERO >>>>> can be used >>>>> >>>>> >>>>> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR >>>>> >>>>> Generated by: scripts/coccinelle/api/ptr_ret.cocci >>>>> >>>>> CC: Olimpiu Dejeu <olimpiu@arcticsand.com> >>>>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> >>>>> --- >>>>> >>>>> arcxcnn_bl.c | 5 +---- >>>>> 1 file changed, 1 insertion(+), 4 deletions(-) >>>>> >>>>> --- a/drivers/video/backlight/arcxcnn_bl.c >>>>> +++ b/drivers/video/backlight/arcxcnn_bl.c >>>>> @@ -180,10 +180,7 @@ static int arcxcnn_backlight_register(st >>>>> >>>>> lp->bl = devm_backlight_device_register(lp->dev, name, lp->dev, >>>>> lp, >>>>> &arcxcnn_bl_ops, props); >>>>> - if (IS_ERR(lp->bl)) >>>>> - return PTR_ERR(lp->bl); >>>>> - >>>>> - return 0; >>>>> + return PTR_ERR_OR_ZERO(lp->bl); >>>>> } >>>>> >>>>> static void arcxcnn_parse_dt(struct arcxcnn *lp) >>>>> >>>> >>>> Acked-by: Olimpiu Dejeu <olimpiu@arcticsand.com> >>>> >>> >>> Glad you approve! Could you apply this change and re-post the patch >>> series? Thanks. >>> >>> >>> Daniel. >>> >>> >> Applied change, re-posted series on March 21st. No sure what next. Please >> advise. Thanks. > > Yes you did. > > Daniel, do you see v9? Yep. All fine at my end... it has my Reviewed-by: which is an even more emphatic statement than my Acked-by: ;-) . I think from this point on I think I'll start posting "[vX-is-still-]Acked-by:" replies so you don't have to worry about whether I've seen new versions. > FYI, if this happens again, it's best to wait a couple of weeks then > send the patch again like "[RESEND v9] ..." to gain attention. RESENDs are a good way to go. Also, if there are questions about the code its better to reply to the code rather than the side discussion. Daniel.
next prev parent reply other threads:[~2017-04-24 11:27 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-15 19:45 [PATCH v8 1/3] backlight arcxcnn add arc to vendor prefix Olimpiu Dejeu 2017-03-15 19:45 ` Olimpiu Dejeu 2017-03-15 19:45 ` Olimpiu Dejeu 2017-03-15 19:45 ` [PATCH v8 2/3] backlight arcxcnn devicetree bindings for ArcticSand Olimpiu Dejeu 2017-03-15 19:45 ` Olimpiu Dejeu 2017-03-15 19:45 ` Olimpiu Dejeu 2017-04-25 8:17 ` Lee Jones 2017-04-25 8:17 ` Lee Jones 2017-04-25 8:17 ` Lee Jones 2017-03-15 19:45 ` [PATCH v8 3/3] backlight arcxcnn add support for ArcticSand devices Olimpiu Dejeu 2017-03-15 19:45 ` Olimpiu Dejeu 2017-03-17 14:48 ` kbuild test robot 2017-03-17 14:48 ` kbuild test robot 2017-03-17 14:48 ` kbuild test robot 2017-03-17 14:48 ` [PATCH] fix ptr_ret.cocci warnings kbuild test robot 2017-03-17 14:48 ` kbuild test robot 2017-03-17 14:48 ` kbuild test robot 2017-03-21 14:58 ` Olimpiu Dejeu 2017-03-21 14:58 ` Olimpiu Dejeu 2017-03-21 14:58 ` Olimpiu Dejeu 2017-03-21 15:07 ` Daniel Thompson 2017-03-21 15:07 ` Daniel Thompson 2017-03-21 15:07 ` Daniel Thompson 2017-04-17 12:57 ` Olimpiu Dejeu 2017-04-24 10:57 ` Lee Jones 2017-04-24 10:57 ` Lee Jones 2017-04-24 10:57 ` Lee Jones 2017-04-24 11:26 ` Daniel Thompson [this message] 2017-04-24 11:26 ` Daniel Thompson 2017-04-24 15:09 ` [PATCH v8 1/3] backlight arcxcnn add arc to vendor prefix Rob Herring 2017-04-24 15:09 ` Rob Herring 2017-04-24 15:09 ` Rob Herring 2017-04-24 17:56 ` Olimpiu Dejeu 2017-04-24 17:56 ` Olimpiu Dejeu 2017-04-24 17:56 ` Olimpiu Dejeu 2017-04-25 16:36 ` Jingoo Han 2017-04-25 16:36 ` Jingoo Han 2017-04-25 16:36 ` Jingoo Han 2017-04-27 12:36 ` Geert Uytterhoeven 2017-04-27 12:36 ` Geert Uytterhoeven 2017-04-27 12:36 ` Geert Uytterhoeven 2017-04-27 17:41 ` Jingoo Han 2017-04-27 17:41 ` Jingoo Han 2017-04-27 17:41 ` Jingoo Han 2017-04-28 15:04 ` Olimpiu Dejeu 2017-04-28 15:04 ` Olimpiu Dejeu 2017-04-28 15:04 ` Olimpiu Dejeu -- strict thread matches above, loose matches on Subject: below -- 2020-08-27 1:41 [ebiggers:cryptobench 1/1] crypto/benchmark.c:616:1-3: WARNING: PTR_ERR_OR_ZERO can be used kernel test robot 2020-08-27 1:41 ` [PATCH] fix ptr_ret.cocci warnings kernel test robot 2019-12-21 1:18 drivers/pci/controller/pcie-rockchip-host.c:628:1-3: WARNING: PTR_ERR_OR_ZERO can be used kbuild test robot 2019-12-21 1:18 ` [PATCH] fix ptr_ret.cocci warnings kbuild test robot 2019-12-21 1:18 ` kbuild test robot 2019-12-21 1:18 ` kbuild test robot 2019-10-09 11:32 [wsa:renesas/i2c/new_dummy 5/5] drivers/i2c/busses/i2c-nvidia-gpu.c:284:1-3: WARNING: PTR_ERR_OR_ZERO can be used kbuild test robot 2019-10-09 11:32 ` [PATCH] fix ptr_ret.cocci warnings kbuild test robot 2018-10-24 19:58 [PATCH v2 10/13] NFS inter ssc open Olga Kornievskaia 2018-10-25 1:31 ` [PATCH] fix ptr_ret.cocci warnings kbuild test robot 2017-05-15 10:52 Julia Lawall 2017-05-15 10:56 ` Stephan Müller 2015-06-24 15:00 [nfs:testing 41/50] fs/nfs/nfs42proc.c:191:1-3: WARNING: PTR_ERR_OR_ZERO can be used kbuild test robot 2015-06-24 15:00 ` [PATCH] fix ptr_ret.cocci warnings kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5f719f78-2890-f9e0-dfc7-f7217432dad0@linaro.org \ --to=daniel.thompson@linaro.org \ --cc=bdodge@arcticsand.com \ --cc=devicetree@vger.kernel.org \ --cc=fengguang.wu@intel.com \ --cc=jingoohan1@gmail.com \ --cc=joe@perches.com \ --cc=kbuild-all@01.org \ --cc=lee.jones@linaro.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lkp@intel.com \ --cc=medasaro@arcticsand.com \ --cc=olimpiu@arcticsand.com \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.