All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Guy Briggs <rgb@redhat.com>
To: Linux-Audit Mailing List <linux-audit@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>
Cc: Paul Moore <paul@paul-moore.com>, Eric Paris <eparis@redhat.com>,
	Steve Grubb <sgrubb@redhat.com>,
	Richard Guy Briggs <rgb@redhat.com>
Subject: [RFC PATCH 2/3] fixup! audit: remove arch_f pointer from struct audit_krule
Date: Mon, 12 Feb 2018 07:29:40 -0500	[thread overview]
Message-ID: <5f742621971f0267cf5854a6a5054746ef3ab95f.1518435853.git.rgb@redhat.com> (raw)
In-Reply-To: <cover.1518435853.git.rgb@redhat.com>
In-Reply-To: <cover.1518435853.git.rgb@redhat.com>

Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
---
 kernel/auditfilter.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
index 3343d1c..48dcb59 100644
--- a/kernel/auditfilter.c
+++ b/kernel/auditfilter.c
@@ -221,11 +221,13 @@ static inline int audit_match_class_bits(int class, u32 *mask)
 static int audit_match_signal(struct audit_entry *entry)
 {
 	int i;
+	u32 archval;
 	struct audit_field *arch;
 
 	for (i = 0; i < entry->rule.field_count; i++)
 		if (entry->rule.fields[i].type == AUDIT_ARCH) {
 			arch = &entry->rule.fields[i];
+			archval = arch->val;
 			break;
 		}
 
@@ -238,7 +240,7 @@ static int audit_match_signal(struct audit_entry *entry)
 					       entry->rule.mask));
 	}
 
-	switch(audit_classify_arch(arch->val)) {
+	switch(audit_classify_arch(archval)) {
 	case 0: /* native */
 		return (audit_match_class_bits(AUDIT_CLASS_SIGNAL,
 					       entry->rule.mask));
-- 
1.8.3.1

WARNING: multiple messages have this Message-ID (diff)
From: Richard Guy Briggs <rgb@redhat.com>
To: Linux-Audit Mailing List <linux-audit@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>
Cc: Richard Guy Briggs <rgb@redhat.com>
Subject: [RFC PATCH 2/3] fixup! audit: remove arch_f pointer from struct audit_krule
Date: Mon, 12 Feb 2018 07:29:40 -0500	[thread overview]
Message-ID: <5f742621971f0267cf5854a6a5054746ef3ab95f.1518435853.git.rgb@redhat.com> (raw)
In-Reply-To: <cover.1518435853.git.rgb@redhat.com>
In-Reply-To: <cover.1518435853.git.rgb@redhat.com>

Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
---
 kernel/auditfilter.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
index 3343d1c..48dcb59 100644
--- a/kernel/auditfilter.c
+++ b/kernel/auditfilter.c
@@ -221,11 +221,13 @@ static inline int audit_match_class_bits(int class, u32 *mask)
 static int audit_match_signal(struct audit_entry *entry)
 {
 	int i;
+	u32 archval;
 	struct audit_field *arch;
 
 	for (i = 0; i < entry->rule.field_count; i++)
 		if (entry->rule.fields[i].type == AUDIT_ARCH) {
 			arch = &entry->rule.fields[i];
+			archval = arch->val;
 			break;
 		}
 
@@ -238,7 +240,7 @@ static int audit_match_signal(struct audit_entry *entry)
 					       entry->rule.mask));
 	}
 
-	switch(audit_classify_arch(arch->val)) {
+	switch(audit_classify_arch(archval)) {
 	case 0: /* native */
 		return (audit_match_class_bits(AUDIT_CLASS_SIGNAL,
 					       entry->rule.mask));
-- 
1.8.3.1

  parent reply	other threads:[~2018-02-12 12:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 12:29 [RFC PATCH 0/3] simplify struct audit_krule reveals bug Richard Guy Briggs
2018-02-12 12:29 ` [RFC PATCH 1/3] audit: remove arch_f pointer from struct audit_krule Richard Guy Briggs
2018-02-12 12:29   ` Richard Guy Briggs
2018-02-15 20:42   ` Paul Moore
2018-02-16 11:17     ` Richard Guy Briggs
2018-11-25 17:11     ` Richard Guy Briggs
2018-11-26 16:37       ` Paul Moore
2018-11-26 19:21         ` Richard Guy Briggs
2018-11-26 21:43           ` Paul Moore
2018-02-12 12:29 ` Richard Guy Briggs [this message]
2018-02-12 12:29   ` [RFC PATCH 2/3] fixup! " Richard Guy Briggs
2018-02-15 20:43   ` Paul Moore
2018-02-15 23:12     ` Richard Guy Briggs
2018-02-12 12:29 ` [RFC PATCH 3/3] debug! " Richard Guy Briggs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f742621971f0267cf5854a6a5054746ef3ab95f.1518435853.git.rgb@redhat.com \
    --to=rgb@redhat.com \
    --cc=eparis@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=sgrubb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.