* [RFC] mips: ath79: clock:- Unmap region obtained by of_iomap
@ 2017-02-06 20:24 ` Marion & Christophe JAILLET
0 siblings, 0 replies; 3+ messages in thread
From: Marion & Christophe JAILLET @ 2017-02-06 20:24 UTC (permalink / raw)
To: antonynpavlov, antonynpavlov, albeu, hackpascal, Stephen Boyd
Cc: linux-mips, linux-kernel, Kernel Janitors
Hi,
I had a patch similar to:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/arch/mips/ath79/clock.c?id=b3d91db3f71d5f70ea60d900425a3f96aeb3d065
in my own tree.
However, mine was slightly different and was also freeing the memory
mapping in the normal case, when 'pll_base' seems to be no more useful.
Best regards,
CJ
=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+
diff --git a/arch/mips/ath79/clock.c b/arch/mips/ath79/clock.c
index c1102cffe37d..b5d81acb2d7a 100644
--- a/arch/mips/ath79/clock.c
+++ b/arch/mips/ath79/clock.c
@@ -508,9 +508,11 @@ static void __init ath79_clocks_init_dt_ng(struct
device_node *np)
ar9330_clk_init(ref_clk, pll_base);
else {
pr_err("%s: could not find any appropriate clk_init()\n", dnfn);
- goto err_clk;
+ goto err_unmap;
}
+ iounmap(pll_base);
+
if (of_clk_add_provider(np, of_clk_src_onecell_get, &clk_data)) {
pr_err("%s: could not register clk provider\n", dnfn);
goto err_clk;
@@ -518,6 +520,8 @@ static void __init ath79_clocks_init_dt_ng(struct
device_node *np)
return;
+err_unmap:
+ iounmap(pll_base);
err_clk:
clk_put(ref_clk);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [RFC] mips: ath79: clock:- Unmap region obtained by of_iomap
@ 2017-02-06 20:24 ` Marion & Christophe JAILLET
0 siblings, 0 replies; 3+ messages in thread
From: Marion & Christophe JAILLET @ 2017-02-06 20:24 UTC (permalink / raw)
To: antonynpavlov; +Cc: linux-mips, linux-kernel, Kernel Janitors
Hi,
I had a patch similar to:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/arch/mips/ath79/clock.c?id³d91db3f71d5f70ea60d900425a3f96aeb3d065
in my own tree.
However, mine was slightly different and was also freeing the memory
mapping in the normal case, when 'pll_base' seems to be no more useful.
Best regards,
CJ
=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+
diff --git a/arch/mips/ath79/clock.c b/arch/mips/ath79/clock.c
index c1102cffe37d..b5d81acb2d7a 100644
--- a/arch/mips/ath79/clock.c
+++ b/arch/mips/ath79/clock.c
@@ -508,9 +508,11 @@ static void __init ath79_clocks_init_dt_ng(struct
device_node *np)
ar9330_clk_init(ref_clk, pll_base);
else {
pr_err("%s: could not find any appropriate clk_init()\n", dnfn);
- goto err_clk;
+ goto err_unmap;
}
+ iounmap(pll_base);
+
if (of_clk_add_provider(np, of_clk_src_onecell_get, &clk_data)) {
pr_err("%s: could not register clk provider\n", dnfn);
goto err_clk;
@@ -518,6 +520,8 @@ static void __init ath79_clocks_init_dt_ng(struct
device_node *np)
return;
+err_unmap:
+ iounmap(pll_base);
err_clk:
clk_put(ref_clk);
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [RFC] mips: ath79: clock:- Unmap region obtained by of_iomap
@ 2017-02-06 20:24 ` Marion & Christophe JAILLET
0 siblings, 0 replies; 3+ messages in thread
From: Marion & Christophe JAILLET @ 2017-02-06 20:24 UTC (permalink / raw)
To: antonynpavlov; +Cc: linux-mips, linux-kernel, Kernel Janitors
Hi,
I had a patch similar to:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/arch/mips/ath79/clock.c?id=b3d91db3f71d5f70ea60d900425a3f96aeb3d065
in my own tree.
However, mine was slightly different and was also freeing the memory
mapping in the normal case, when 'pll_base' seems to be no more useful.
Best regards,
CJ
=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+
diff --git a/arch/mips/ath79/clock.c b/arch/mips/ath79/clock.c
index c1102cffe37d..b5d81acb2d7a 100644
--- a/arch/mips/ath79/clock.c
+++ b/arch/mips/ath79/clock.c
@@ -508,9 +508,11 @@ static void __init ath79_clocks_init_dt_ng(struct
device_node *np)
ar9330_clk_init(ref_clk, pll_base);
else {
pr_err("%s: could not find any appropriate clk_init()\n", dnfn);
- goto err_clk;
+ goto err_unmap;
}
+ iounmap(pll_base);
+
if (of_clk_add_provider(np, of_clk_src_onecell_get, &clk_data)) {
pr_err("%s: could not register clk provider\n", dnfn);
goto err_clk;
@@ -518,6 +520,8 @@ static void __init ath79_clocks_init_dt_ng(struct
device_node *np)
return;
+err_unmap:
+ iounmap(pll_base);
err_clk:
clk_put(ref_clk);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-06 20:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-06 20:24 [RFC] mips: ath79: clock:- Unmap region obtained by of_iomap Marion & Christophe JAILLET
2017-02-06 20:24 ` Marion & Christophe JAILLET
2017-02-06 20:24 ` Marion & Christophe JAILLET
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.