All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Junjie Chen <junjie.j.chen@intel.com>,
	jianfeng.tan@intel.com, mtetsuyah@gmail.com
Cc: dev@dpdk.org
Subject: Re: [PATCH v3] net/vhost: fix segfault when creating vdev dynamically
Date: Fri, 30 Mar 2018 09:35:28 +0200	[thread overview]
Message-ID: <5fae9b23-ab90-9dc0-56b6-999e639dac64@redhat.com> (raw)
In-Reply-To: <20180330065831.107558-1-junjie.j.chen@intel.com>

Hi Junjie,

On 03/30/2018 08:58 AM, Junjie Chen wrote:
> When creating vdev dynamically, vhost pmd driver starts directly without
> checking TX/RX queues are ready or not, and thus causes segmentation fault
> when vhost library accesses queues. This patch adds a flag to check whether
> queues are setup or not, and adds queues setup into dev_start function to
> allow user to start them after setting up.
> 
> Fixes: aed0b12930b3 ("net/vhost: fix socket file deleted on stop")
> Signed-off-by: Chen, Junjie <junjie.j.chen@intel.com>
> ---
> Changes in v3:
> - Update commit log, refine duplicated code
> Changes in v2:
> - Check queues status in new_device, create queue in dev_start if not setup yet
> 
>   drivers/net/vhost/rte_eth_vhost.c | 69 ++++++++++++++++++++++++++-------------
>   1 file changed, 46 insertions(+), 23 deletions(-)

Nice patch!
Thanks for having handled the changes that quickly.

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Maxime

  parent reply	other threads:[~2018-03-30  7:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-27 16:05 [PATCH] net/vhost: fix segfault when creating vdev dynamically Junjie Chen
2018-03-27  8:56 ` Tan, Jianfeng
2018-03-27  9:02   ` Chen, Junjie J
2018-03-27  9:10     ` Tan, Jianfeng
2018-03-27  9:24       ` Chen, Junjie J
2018-03-27  9:42         ` Tan, Jianfeng
2018-03-27 10:18           ` Chen, Junjie J
2018-03-27 13:54             ` Tan, Jianfeng
2018-03-27 11:28           ` Maxime Coquelin
2018-03-27 14:01             ` Tan, Jianfeng
2018-03-29 12:35               ` Maxime Coquelin
2018-03-29 15:35 ` [PATCH v2] " Junjie Chen
2018-03-29 13:16   ` Maxime Coquelin
2018-03-30  6:58   ` [PATCH v3] " Junjie Chen
2018-03-30  7:32     ` Yang, Zhiyong
2018-03-30  7:36       ` Maxime Coquelin
2018-03-30  7:35     ` Maxime Coquelin [this message]
2018-03-30  7:43     ` Maxime Coquelin
2018-04-09 12:37     ` Jens Freimann
2018-04-10  8:11       ` Chen, Junjie J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5fae9b23-ab90-9dc0-56b6-999e639dac64@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    --cc=junjie.j.chen@intel.com \
    --cc=mtetsuyah@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.