From: Marcel Ziswiler <marcel.ziswiler@toradex.com> To: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "krzk@kernel.org" <krzk@kernel.org> Cc: "linux-imx@nxp.com" <linux-imx@nxp.com>, "aisheng.dong@nxp.com" <aisheng.dong@nxp.com>, "jagan@amarulasolutions.com" <jagan@amarulasolutions.com>, "frowand.list@gmail.com" <frowand.list@gmail.com>, "alexander.stein@ew.tq-group.com" <alexander.stein@ew.tq-group.com>, "olof@lixom.net" <olof@lixom.net>, "tharvey@gateworks.com" <tharvey@gateworks.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "arnd@arndb.de" <arnd@arndb.de>, "marek.vasut@gmail.com" <marek.vasut@gmail.com>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "festevam@gmail.com" <festevam@gmail.com>, "alexandru.marginean@nxp.com" <alexandru.marginean@nxp.com> Subject: Re: [PATCH v1 14/14] arm64: dts: freescale: add initial support for verdin imx8m mini Date: Fri, 14 Jan 2022 13:28:11 +0000 [thread overview] Message-ID: <5fd41ac1242e0cebbb77eb1a83c3f4350c34296f.camel@toradex.com> (raw) In-Reply-To: <c80ac4a7-d401-00c3-c6c2-61bc9a600590@kernel.org> On Mon, 2022-01-10 at 09:47 +0100, Krzysztof Kozlowski wrote: > On 07/01/2022 19:03, Marcel Ziswiler wrote: > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > This patch adds the device tree to support Toradex Verdin iMX8M Mini a > > computer on module which can be used on different carrier boards. > > > > The module consists of an NXP i.MX 8M Mini family SoC (either i.MX 8M > > Mini Quad or 8M Mini DualLite), a PCA9450A PMIC, a Gigabit Ethernet PHY, > > 1 or 2 GB of LPDDR4 RAM, an eMMC, a TLA2024 ADC, an I2C EEPROM, an > > RX8130 RTC, an optional SPI CAN controller plus an optional Bluetooth/ > > Wi-Fi module. > > > > Anything that is not self-contained on the module is disabled by > > default. > > > > The device tree for the Dahlia includes the module's device tree and > > enables the supported peripherals of the carrier board. > > > > The device tree for the Verdin Development Board includes the module's > > device tree as well as the Dahlia one as it is a superset and supports > > almost all peripherals available. > > > > So far there is no display functionality supported at all but basic > > console UART, USB host, eMMC and Ethernet and PCIe functionality work > > fine. > > > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > --- > > > > arch/arm64/boot/dts/freescale/Makefile | 4 + > > .../dts/freescale/imx8mm-verdin-dahlia.dtsi | 143 ++ > > .../boot/dts/freescale/imx8mm-verdin-dev.dtsi | 67 + > > .../imx8mm-verdin-nonwifi-dahlia.dts | 18 + > > .../freescale/imx8mm-verdin-nonwifi-dev.dts | 18 + > > .../dts/freescale/imx8mm-verdin-nonwifi.dtsi | 75 + > > .../freescale/imx8mm-verdin-wifi-dahlia.dts | 18 + > > .../dts/freescale/imx8mm-verdin-wifi-dev.dts | 18 + > > .../dts/freescale/imx8mm-verdin-wifi.dtsi | 95 ++ > > .../boot/dts/freescale/imx8mm-verdin.dtsi | 1277 +++++++++++++++++ > > 10 files changed, 1733 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dts > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dts > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi.dtsi > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dts > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dts > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi.dtsi > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > > > (...) > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm- > > verdin.dtsi > > new file mode 100644 > > index 000000000000..23eb695a5266 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > @@ -0,0 +1,1277 @@ > > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > > +/* > > + * Copyright 2022 Toradex > > + */ > > + > > +#include "dt-bindings/pwm/pwm.h" > > +#include "imx8mm.dtsi" > > + > > +/ { > > + chosen { > > + bootargs = "console=ttymxc0,115200 earlycon"; > > earlycon is a debug tool, so should not be part of mainline DTS by > default. Entire bootargs property looks actually not needed. Yes, I will remove it in v2. > > + stdout-path = &uart1; > > + }; > > + > > (...) > > > +/* Verdin ETH_1 (On-module PHY) */ > > +&fec1 { > > + fsl,magic-packet; > > + phy-handle = <ðphy0>; > > + phy-mode = "rgmii-id"; > > + phy-supply = <®_ethphy>; > > + pinctrl-names = "default", "sleep"; > > + pinctrl-0 = <&pinctrl_fec1>; > > + pinctrl-1 = <&pinctrl_fec1_sleep>; > > + > > + mdio { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + ethphy0: ethernet-phy@7 { > > + compatible = "ethernet-phy-ieee802.3-c22"; > > + interrupt-parent = <&gpio1>; > > + interrupts = <10 IRQ_TYPE_LEVEL_LOW>; > > + micrel,led-mode = <0>; > > + reg = <7>; > > + }; > > + }; > > +}; > > + > > +/* Verdin QSPI_1 */ > > +&flexspi { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_flexspi0>; > > +#if 0 > > Please drop it or explain with a comment why we need dead code in Linux > kernel. Yes, I agree. > > + flash@0 { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + compatible = "jedec,spi-nor"; > > + reg = <0>; > > + spi-max-frequency = <80000000>; > > + }; > > +#endif > > +}; > > + Thanks for your review. > Best regards, > Krzysztof Cheers Marcel
WARNING: multiple messages have this Message-ID (diff)
From: Marcel Ziswiler <marcel.ziswiler@toradex.com> To: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "krzk@kernel.org" <krzk@kernel.org> Cc: "linux-imx@nxp.com" <linux-imx@nxp.com>, "aisheng.dong@nxp.com" <aisheng.dong@nxp.com>, "jagan@amarulasolutions.com" <jagan@amarulasolutions.com>, "frowand.list@gmail.com" <frowand.list@gmail.com>, "alexander.stein@ew.tq-group.com" <alexander.stein@ew.tq-group.com>, "olof@lixom.net" <olof@lixom.net>, "tharvey@gateworks.com" <tharvey@gateworks.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "arnd@arndb.de" <arnd@arndb.de>, "marek.vasut@gmail.com" <marek.vasut@gmail.com>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "festevam@gmail.com" <festevam@gmail.com>, "alexandru.marginean@nxp.com" <alexandru.marginean@nxp.com> Subject: Re: [PATCH v1 14/14] arm64: dts: freescale: add initial support for verdin imx8m mini Date: Fri, 14 Jan 2022 13:28:11 +0000 [thread overview] Message-ID: <5fd41ac1242e0cebbb77eb1a83c3f4350c34296f.camel@toradex.com> (raw) In-Reply-To: <c80ac4a7-d401-00c3-c6c2-61bc9a600590@kernel.org> On Mon, 2022-01-10 at 09:47 +0100, Krzysztof Kozlowski wrote: > On 07/01/2022 19:03, Marcel Ziswiler wrote: > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > This patch adds the device tree to support Toradex Verdin iMX8M Mini a > > computer on module which can be used on different carrier boards. > > > > The module consists of an NXP i.MX 8M Mini family SoC (either i.MX 8M > > Mini Quad or 8M Mini DualLite), a PCA9450A PMIC, a Gigabit Ethernet PHY, > > 1 or 2 GB of LPDDR4 RAM, an eMMC, a TLA2024 ADC, an I2C EEPROM, an > > RX8130 RTC, an optional SPI CAN controller plus an optional Bluetooth/ > > Wi-Fi module. > > > > Anything that is not self-contained on the module is disabled by > > default. > > > > The device tree for the Dahlia includes the module's device tree and > > enables the supported peripherals of the carrier board. > > > > The device tree for the Verdin Development Board includes the module's > > device tree as well as the Dahlia one as it is a superset and supports > > almost all peripherals available. > > > > So far there is no display functionality supported at all but basic > > console UART, USB host, eMMC and Ethernet and PCIe functionality work > > fine. > > > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > --- > > > > arch/arm64/boot/dts/freescale/Makefile | 4 + > > .../dts/freescale/imx8mm-verdin-dahlia.dtsi | 143 ++ > > .../boot/dts/freescale/imx8mm-verdin-dev.dtsi | 67 + > > .../imx8mm-verdin-nonwifi-dahlia.dts | 18 + > > .../freescale/imx8mm-verdin-nonwifi-dev.dts | 18 + > > .../dts/freescale/imx8mm-verdin-nonwifi.dtsi | 75 + > > .../freescale/imx8mm-verdin-wifi-dahlia.dts | 18 + > > .../dts/freescale/imx8mm-verdin-wifi-dev.dts | 18 + > > .../dts/freescale/imx8mm-verdin-wifi.dtsi | 95 ++ > > .../boot/dts/freescale/imx8mm-verdin.dtsi | 1277 +++++++++++++++++ > > 10 files changed, 1733 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-verdin-dahlia.dtsi > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-verdin-dev.dtsi > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dts > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dts > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi.dtsi > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dts > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dts > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi.dtsi > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > > > (...) > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm- > > verdin.dtsi > > new file mode 100644 > > index 000000000000..23eb695a5266 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > @@ -0,0 +1,1277 @@ > > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > > +/* > > + * Copyright 2022 Toradex > > + */ > > + > > +#include "dt-bindings/pwm/pwm.h" > > +#include "imx8mm.dtsi" > > + > > +/ { > > + chosen { > > + bootargs = "console=ttymxc0,115200 earlycon"; > > earlycon is a debug tool, so should not be part of mainline DTS by > default. Entire bootargs property looks actually not needed. Yes, I will remove it in v2. > > + stdout-path = &uart1; > > + }; > > + > > (...) > > > +/* Verdin ETH_1 (On-module PHY) */ > > +&fec1 { > > + fsl,magic-packet; > > + phy-handle = <ðphy0>; > > + phy-mode = "rgmii-id"; > > + phy-supply = <®_ethphy>; > > + pinctrl-names = "default", "sleep"; > > + pinctrl-0 = <&pinctrl_fec1>; > > + pinctrl-1 = <&pinctrl_fec1_sleep>; > > + > > + mdio { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + ethphy0: ethernet-phy@7 { > > + compatible = "ethernet-phy-ieee802.3-c22"; > > + interrupt-parent = <&gpio1>; > > + interrupts = <10 IRQ_TYPE_LEVEL_LOW>; > > + micrel,led-mode = <0>; > > + reg = <7>; > > + }; > > + }; > > +}; > > + > > +/* Verdin QSPI_1 */ > > +&flexspi { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_flexspi0>; > > +#if 0 > > Please drop it or explain with a comment why we need dead code in Linux > kernel. Yes, I agree. > > + flash@0 { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + compatible = "jedec,spi-nor"; > > + reg = <0>; > > + spi-max-frequency = <80000000>; > > + }; > > +#endif > > +}; > > + Thanks for your review. > Best regards, > Krzysztof Cheers Marcel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-14 13:28 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-07 18:03 [PATCH v1 00/14] arm64: prepare and add verdin imx8m mini support Marcel Ziswiler 2022-01-07 18:03 ` Marcel Ziswiler 2022-01-07 18:03 ` [PATCH v1 01/14] arm64: dts: imx8mm: fix strange hex notation Marcel Ziswiler 2022-01-07 18:03 ` Marcel Ziswiler 2022-01-10 23:58 ` Laurent Pinchart 2022-01-10 23:58 ` Laurent Pinchart 2022-01-07 18:03 ` [PATCH v1 02/14] dt-bindings: gpio: fix gpio-hog example Marcel Ziswiler 2022-01-07 18:03 ` Marcel Ziswiler 2022-01-12 1:58 ` Rob Herring 2022-01-12 1:58 ` Rob Herring 2022-01-07 18:03 ` [PATCH v1 03/14] arm64: defconfig: rebuild default configuration Marcel Ziswiler 2022-01-07 18:03 ` Marcel Ziswiler 2022-01-10 8:39 ` Krzysztof Kozlowski 2022-01-10 8:39 ` Krzysztof Kozlowski 2022-01-14 13:24 ` Marcel Ziswiler 2022-01-14 13:24 ` Marcel Ziswiler 2022-01-07 18:03 ` [PATCH v1 04/14] arm64: defconfig: enable bpf/cgroup firewalling Marcel Ziswiler 2022-01-07 18:03 ` Marcel Ziswiler 2022-01-10 19:30 ` Song Liu 2022-01-10 19:30 ` Song Liu 2022-01-07 18:03 ` [PATCH v1 05/14] arm64: defconfig: build imx-sdma as a module Marcel Ziswiler 2022-01-07 18:03 ` Marcel Ziswiler 2022-01-13 18:42 ` Stefan Wahren 2022-01-13 18:42 ` Stefan Wahren 2022-01-14 13:39 ` Marcel Ziswiler 2022-01-14 13:39 ` Marcel Ziswiler 2022-01-14 16:24 ` Stefan Wahren 2022-01-14 16:24 ` Stefan Wahren 2022-01-14 16:30 ` Marcel Ziswiler 2022-01-14 16:30 ` Marcel Ziswiler 2022-01-07 18:03 ` [PATCH v1 06/14] arm64: defconfig: build r8169 " Marcel Ziswiler 2022-01-07 18:03 ` Marcel Ziswiler 2022-01-10 8:40 ` Krzysztof Kozlowski 2022-01-10 8:40 ` Krzysztof Kozlowski 2022-01-14 13:25 ` Marcel Ziswiler 2022-01-14 13:25 ` Marcel Ziswiler 2022-01-07 18:03 ` [PATCH v1 07/14] arm64: defconfig: build ads1015 adc driver " Marcel Ziswiler 2022-01-07 18:03 ` Marcel Ziswiler 2022-01-10 8:41 ` Krzysztof Kozlowski 2022-01-10 8:41 ` Krzysztof Kozlowski 2022-01-07 18:03 ` [PATCH v1 08/14] arm64: defconfig: build lm75 temperature sensor " Marcel Ziswiler 2022-01-07 18:03 ` Marcel Ziswiler 2022-01-10 8:41 ` Krzysztof Kozlowski 2022-01-10 8:41 ` Krzysztof Kozlowski 2022-01-07 18:03 ` [PATCH v1 09/14] arm64: defconfig: build mcp251xfd can " Marcel Ziswiler 2022-01-07 18:03 ` Marcel Ziswiler 2022-01-07 18:03 ` [PATCH v1 10/14] arm64: defconfig: build sdio mwifiex " Marcel Ziswiler 2022-01-07 18:03 ` Marcel Ziswiler 2022-01-07 18:03 ` [PATCH v1 11/14] arm64: defconfig: build nxp bluetooth as modules Marcel Ziswiler 2022-01-07 18:03 ` Marcel Ziswiler 2022-01-07 18:03 ` [PATCH v1 12/14] arm64: defconfig: build nuvoton nau8822 as module Marcel Ziswiler 2022-01-07 18:03 ` Marcel Ziswiler 2022-01-07 18:03 ` [PATCH v1 13/14] dt-bindings: arm: fsl: add toradex,verdin-imx8mm et al Marcel Ziswiler 2022-01-07 18:03 ` [PATCH v1 13/14] dt-bindings: arm: fsl: add toradex, verdin-imx8mm " Marcel Ziswiler 2022-01-12 1:58 ` [PATCH v1 13/14] dt-bindings: arm: fsl: add toradex,verdin-imx8mm " Rob Herring 2022-01-12 1:58 ` Rob Herring 2022-01-07 18:03 ` [PATCH v1 14/14] arm64: dts: freescale: add initial support for verdin imx8m mini Marcel Ziswiler 2022-01-07 18:03 ` Marcel Ziswiler 2022-01-10 8:47 ` Krzysztof Kozlowski 2022-01-10 8:47 ` Krzysztof Kozlowski 2022-01-14 13:28 ` Marcel Ziswiler [this message] 2022-01-14 13:28 ` Marcel Ziswiler
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5fd41ac1242e0cebbb77eb1a83c3f4350c34296f.camel@toradex.com \ --to=marcel.ziswiler@toradex.com \ --cc=aisheng.dong@nxp.com \ --cc=alexander.stein@ew.tq-group.com \ --cc=alexandru.marginean@nxp.com \ --cc=arnd@arndb.de \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=frowand.list@gmail.com \ --cc=jagan@amarulasolutions.com \ --cc=kernel@pengutronix.de \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=marek.vasut@gmail.com \ --cc=olof@lixom.net \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=tharvey@gateworks.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.