All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <Julien.Grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	nd <nd@arm.com>, Andrii Anisov <Andrii_Anisov@epam.com>,
	"Oleksandr_Tyshchenko@epam.com" <Oleksandr_Tyshchenko@epam.com>
Subject: Re: [PATCH v2 4/7] xen/arm: page: Clarify the Xen TLBs helpers name
Date: Thu, 9 May 2019 20:32:25 +0000	[thread overview]
Message-ID: <5fe19f3a-e17b-04b5-ff15-5579ebe789eb@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1905091307080.25766@sstabellini-ThinkPad-T480s>

Hi,

On 09/05/2019 21:13, Stefano Stabellini wrote:
> On Wed, 8 May 2019, Julien Grall wrote:
>>   /* Release all __init and __initdata ranges to be reused */
>> diff --git a/xen/include/asm-arm/arm32/page.h b/xen/include/asm-arm/arm32/page.h
>> index 40a77daa9d..0b41b9214b 100644
>> --- a/xen/include/asm-arm/arm32/page.h
>> +++ b/xen/include/asm-arm/arm32/page.h
>> @@ -61,12 +61,8 @@ static inline void invalidate_icache_local(void)
>>       isb();                      /* Synchronize fetched instruction stream. */
>>   }
>>   
>> -/*
>> - * Flush all hypervisor mappings from the data TLB of the local
>> - * processor. This is not sufficient when changing code mappings or
>> - * for self modifying code.
>> - */
>> -static inline void flush_xen_data_tlb_local(void)
>> +/* Flush all hypervisor mappings from the TLB of the local processor. */
> 
> I realize that the statement "This is not sufficient when changing code
> mappings or for self modifying code" is not quite accurate, but I would
> prefer not to remove it completely. It would be good to retain a warning
> somewhere about IC been needed when changing Xen's own mappings. Maybe
> on top of invalidate_icache_local?

Can you please expand in which circumstance you need to invalid the 
instruction cache when changing Xen's own mappings?

Cheers,

-- 
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <Julien.Grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	nd <nd@arm.com>, Andrii Anisov <Andrii_Anisov@epam.com>,
	"Oleksandr_Tyshchenko@epam.com" <Oleksandr_Tyshchenko@epam.com>
Subject: Re: [Xen-devel] [PATCH v2 4/7] xen/arm: page: Clarify the Xen TLBs helpers name
Date: Thu, 9 May 2019 20:32:25 +0000	[thread overview]
Message-ID: <5fe19f3a-e17b-04b5-ff15-5579ebe789eb@arm.com> (raw)
Message-ID: <20190509203225.-o6vM3ZLcw8nLr5eiADdQIZW-uvCOAniPGTXpA_ralk@z> (raw)
In-Reply-To: <alpine.DEB.2.21.1905091307080.25766@sstabellini-ThinkPad-T480s>

Hi,

On 09/05/2019 21:13, Stefano Stabellini wrote:
> On Wed, 8 May 2019, Julien Grall wrote:
>>   /* Release all __init and __initdata ranges to be reused */
>> diff --git a/xen/include/asm-arm/arm32/page.h b/xen/include/asm-arm/arm32/page.h
>> index 40a77daa9d..0b41b9214b 100644
>> --- a/xen/include/asm-arm/arm32/page.h
>> +++ b/xen/include/asm-arm/arm32/page.h
>> @@ -61,12 +61,8 @@ static inline void invalidate_icache_local(void)
>>       isb();                      /* Synchronize fetched instruction stream. */
>>   }
>>   
>> -/*
>> - * Flush all hypervisor mappings from the data TLB of the local
>> - * processor. This is not sufficient when changing code mappings or
>> - * for self modifying code.
>> - */
>> -static inline void flush_xen_data_tlb_local(void)
>> +/* Flush all hypervisor mappings from the TLB of the local processor. */
> 
> I realize that the statement "This is not sufficient when changing code
> mappings or for self modifying code" is not quite accurate, but I would
> prefer not to remove it completely. It would be good to retain a warning
> somewhere about IC been needed when changing Xen's own mappings. Maybe
> on top of invalidate_icache_local?

Can you please expand in which circumstance you need to invalid the 
instruction cache when changing Xen's own mappings?

Cheers,

-- 
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-05-09 20:32 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08 16:15 [PATCH v2 0/7] xen/arm: TLB flush helpers rework Julien Grall
2019-05-08 16:15 ` [Xen-devel] " Julien Grall
2019-05-08 16:15 ` [PATCH v2 1/7] xen/arm: mm: Consolidate setting SCTLR_EL2.WXN in a single place Julien Grall
2019-05-08 16:15   ` [Xen-devel] " Julien Grall
2019-05-09 19:52   ` Stefano Stabellini
2019-05-09 19:52     ` [Xen-devel] " Stefano Stabellini
2019-05-08 16:15 ` [PATCH v2 2/7] xen/arm: Remove flush_xen_text_tlb_local() Julien Grall
2019-05-08 16:15   ` [Xen-devel] " Julien Grall
2019-05-09 20:03   ` Stefano Stabellini
2019-05-09 20:03     ` [Xen-devel] " Stefano Stabellini
2019-05-09 20:17     ` Julien Grall
2019-05-09 20:17       ` [Xen-devel] " Julien Grall
2019-05-08 16:15 ` [PATCH v2 3/7] xen/arm: tlbflush: Clarify the TLB helpers name Julien Grall
2019-05-08 16:15   ` [Xen-devel] " Julien Grall
2019-05-09 20:05   ` Stefano Stabellini
2019-05-09 20:05     ` [Xen-devel] " Stefano Stabellini
2019-05-08 16:16 ` [PATCH v2 4/7] xen/arm: page: Clarify the Xen TLBs " Julien Grall
2019-05-08 16:16   ` [Xen-devel] " Julien Grall
2019-05-09 20:13   ` Stefano Stabellini
2019-05-09 20:13     ` [Xen-devel] " Stefano Stabellini
2019-05-09 20:32     ` Julien Grall [this message]
2019-05-09 20:32       ` Julien Grall
2019-05-09 21:46       ` Julien Grall
2019-05-09 21:46         ` [Xen-devel] " Julien Grall
2019-05-10 14:38         ` Julien Grall
2019-05-10 14:38           ` [Xen-devel] " Julien Grall
2019-05-10 17:57           ` Stefano Stabellini
2019-05-10 17:57             ` [Xen-devel] " Stefano Stabellini
2019-05-10 18:35             ` Julien Grall
2019-05-10 18:35               ` [Xen-devel] " Julien Grall
2019-05-20 21:01               ` Stefano Stabellini
2019-05-20 21:01                 ` [Xen-devel] " Stefano Stabellini
2019-05-20 21:59                 ` Julien Grall
2019-05-20 21:59                   ` [Xen-devel] " Julien Grall
2019-06-10 20:51                   ` Stefano Stabellini
2019-06-10 21:03                     ` Julien Grall
2019-06-11 18:15                       ` Stefano Stabellini
2019-05-08 16:16 ` [PATCH v2 5/7] xen/arm: Gather all TLB flush helpers in tlbflush.h Julien Grall
2019-05-08 16:16   ` [Xen-devel] " Julien Grall
2019-05-09 20:17   ` Stefano Stabellini
2019-05-09 20:17     ` [Xen-devel] " Stefano Stabellini
2019-05-08 16:16 ` [PATCH v2 6/7] xen/arm: tlbflush: Rework TLB helpers Julien Grall
2019-05-08 16:16   ` [Xen-devel] " Julien Grall
2019-05-09 20:32   ` Stefano Stabellini
2019-05-09 20:32     ` [Xen-devel] " Stefano Stabellini
2019-05-09 20:43     ` Julien Grall
2019-05-09 20:43       ` [Xen-devel] " Julien Grall
2019-05-09 21:37   ` Stefano Stabellini
2019-05-09 21:37     ` [Xen-devel] " Stefano Stabellini
2019-05-08 16:16 ` [PATCH v2 7/7] xen/arm: mm: Flush the TLBs even if a mapping failed in create_xen_entries Julien Grall
2019-05-08 16:16   ` [Xen-devel] " Julien Grall
2019-05-09 20:40   ` Stefano Stabellini
2019-05-09 20:40     ` [Xen-devel] " Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5fe19f3a-e17b-04b5-ff15-5579ebe789eb@arm.com \
    --to=julien.grall@arm.com \
    --cc=Andrii_Anisov@epam.com \
    --cc=Oleksandr_Tyshchenko@epam.com \
    --cc=nd@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.