From: Bagas Sanjaya <bagasdotme@gmail.com> To: Hou Tao <houtao@huaweicloud.com>, linux-block@vger.kernel.org Cc: Bart Van Assche <bvanassche@acm.org>, Jan Kara <jack@suse.cz>, Jens Axboe <axboe@kernel.dk>, cgroups@vger.kernel.org, Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>, Johannes Weiner <hannes@cmpxchg.org>, Jonathan Corbet <corbet@lwn.net>, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, houtao1@huawei.com Subject: Re: [PATCH v2] blk-ioprio: Introduce promote-to-rt policy Date: Wed, 22 Feb 2023 14:38:01 +0700 [thread overview] Message-ID: <5ff2b68a-a8fb-7901-2c38-1056a2c59f70@gmail.com> (raw) In-Reply-To: <20230220135428.2632906-1-houtao@huaweicloud.com> On 2/20/23 20:54, Hou Tao wrote: > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst > index 74cec76be9f2..ccfb9fdfbc16 100644 > --- a/Documentation/admin-guide/cgroup-v2.rst > +++ b/Documentation/admin-guide/cgroup-v2.rst > @@ -2021,31 +2021,33 @@ that attribute: > no-change > Do not modify the I/O priority class. > > - none-to-rt > - For requests that do not have an I/O priority class (NONE), > - change the I/O priority class into RT. Do not modify > - the I/O priority class of other requests. > + promote-to-rt > + For requests that have a no-RT I/O priority class, change it into RT. "non-RT" maybe? Or the original wording is better? > + Also change the priority level of these requests to 4. Do not modify > + the I/O priority of requests that have priority class RT.> > restrict-to-be > For requests that do not have an I/O priority class or that have I/O > - priority class RT, change it into BE. Do not modify the I/O priority > - class of requests that have priority class IDLE. > + priority class RT, change it into BE. Also change the priority level > + of these requests to 0. Do not modify the I/O priority class of > + requests that have priority class IDLE. > > idle > Change the I/O priority class of all requests into IDLE, the lowest > I/O priority class. > > + none-to-rt > + Deprecated. Just an alias for promote-to-rt. > + > The following numerical values are associated with the I/O priority policies: > > -+-------------+---+ > -| no-change | 0 | > -+-------------+---+ > -| none-to-rt | 1 | > -+-------------+---+ > -| rt-to-be | 2 | > -+-------------+---+ > -| all-to-idle | 3 | > -+-------------+---+ > ++----------------+---+ > +| no-change | 0 | > ++----------------+---+ > +| rt-to-be | 2 | > ++----------------+---+ > +| all-to-idle | 3 | > ++----------------+---+ > > The numerical value that corresponds to each I/O priority class is as follows: > > @@ -2061,9 +2063,13 @@ The numerical value that corresponds to each I/O priority class is as follows: > > The algorithm to set the I/O priority class for a request is as follows: > > -- Translate the I/O priority class policy into a number. > -- Change the request I/O priority class into the maximum of the I/O priority > - class policy number and the numerical I/O priority class. > +- If I/O priority class policy is promote-to-rt, change the request I/O > + priority class to IOPRIO_CLASS_RT and change the request I/O priority > + level to 4. > +- If I/O priorityt class is not promote-to-rt, translate the I/O priority > + class policy into a number, then change the request I/O priority class > + into the maximum of the I/O priority class policy number and the numerical > + I/O priority class. > > PID > --- The rest is LGTM. -- An old man doll... just what I always wanted! - Clara
WARNING: multiple messages have this Message-ID (diff)
From: Bagas Sanjaya <bagasdotme-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Hou Tao <houtao-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>, Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>, Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Zefan Li <lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>, Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>, Jonathan Corbet <corbet-T1hC0tSOHrs@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, houtao1-hv44wF8Li93QT0dZR+AlfA@public.gmane.org Subject: Re: [PATCH v2] blk-ioprio: Introduce promote-to-rt policy Date: Wed, 22 Feb 2023 14:38:01 +0700 [thread overview] Message-ID: <5ff2b68a-a8fb-7901-2c38-1056a2c59f70@gmail.com> (raw) In-Reply-To: <20230220135428.2632906-1-houtao-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org> On 2/20/23 20:54, Hou Tao wrote: > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst > index 74cec76be9f2..ccfb9fdfbc16 100644 > --- a/Documentation/admin-guide/cgroup-v2.rst > +++ b/Documentation/admin-guide/cgroup-v2.rst > @@ -2021,31 +2021,33 @@ that attribute: > no-change > Do not modify the I/O priority class. > > - none-to-rt > - For requests that do not have an I/O priority class (NONE), > - change the I/O priority class into RT. Do not modify > - the I/O priority class of other requests. > + promote-to-rt > + For requests that have a no-RT I/O priority class, change it into RT. "non-RT" maybe? Or the original wording is better? > + Also change the priority level of these requests to 4. Do not modify > + the I/O priority of requests that have priority class RT.> > restrict-to-be > For requests that do not have an I/O priority class or that have I/O > - priority class RT, change it into BE. Do not modify the I/O priority > - class of requests that have priority class IDLE. > + priority class RT, change it into BE. Also change the priority level > + of these requests to 0. Do not modify the I/O priority class of > + requests that have priority class IDLE. > > idle > Change the I/O priority class of all requests into IDLE, the lowest > I/O priority class. > > + none-to-rt > + Deprecated. Just an alias for promote-to-rt. > + > The following numerical values are associated with the I/O priority policies: > > -+-------------+---+ > -| no-change | 0 | > -+-------------+---+ > -| none-to-rt | 1 | > -+-------------+---+ > -| rt-to-be | 2 | > -+-------------+---+ > -| all-to-idle | 3 | > -+-------------+---+ > ++----------------+---+ > +| no-change | 0 | > ++----------------+---+ > +| rt-to-be | 2 | > ++----------------+---+ > +| all-to-idle | 3 | > ++----------------+---+ > > The numerical value that corresponds to each I/O priority class is as follows: > > @@ -2061,9 +2063,13 @@ The numerical value that corresponds to each I/O priority class is as follows: > > The algorithm to set the I/O priority class for a request is as follows: > > -- Translate the I/O priority class policy into a number. > -- Change the request I/O priority class into the maximum of the I/O priority > - class policy number and the numerical I/O priority class. > +- If I/O priority class policy is promote-to-rt, change the request I/O > + priority class to IOPRIO_CLASS_RT and change the request I/O priority > + level to 4. > +- If I/O priorityt class is not promote-to-rt, translate the I/O priority > + class policy into a number, then change the request I/O priority class > + into the maximum of the I/O priority class policy number and the numerical > + I/O priority class. > > PID > --- The rest is LGTM. -- An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2023-02-22 7:38 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-20 13:54 [PATCH v2] blk-ioprio: Introduce promote-to-rt policy Hou Tao 2023-02-20 13:54 ` Hou Tao 2023-02-21 16:37 ` Tejun Heo 2023-02-21 17:27 ` Bart Van Assche 2023-02-21 18:04 ` Chaitanya Kulkarni 2023-02-22 7:38 ` Bagas Sanjaya [this message] 2023-02-22 7:38 ` Bagas Sanjaya 2023-02-23 1:08 ` Hou Tao 2023-02-23 1:08 ` Hou Tao 2023-02-27 13:03 ` Jan Kara 2023-02-27 13:56 ` Hou Tao 2023-02-27 15:02 ` Jan Kara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5ff2b68a-a8fb-7901-2c38-1056a2c59f70@gmail.com \ --to=bagasdotme@gmail.com \ --cc=axboe@kernel.dk \ --cc=bvanassche@acm.org \ --cc=cgroups@vger.kernel.org \ --cc=corbet@lwn.net \ --cc=hannes@cmpxchg.org \ --cc=houtao1@huawei.com \ --cc=houtao@huaweicloud.com \ --cc=jack@suse.cz \ --cc=linux-block@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lizefan.x@bytedance.com \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.