* [PATCH] xen/pvh: increase early stack size
@ 2018-10-09 10:32 Roger Pau Monne
2018-10-09 11:01 ` Juergen Gross
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Roger Pau Monne @ 2018-10-09 10:32 UTC (permalink / raw)
To: linux-kernel; +Cc: Roger Pau Monne, Boris Ostrovsky, Juergen Gross, xen-devel
While booting on an AMD EPYC box the stack canary would detect stack
overflows when using the current PVH early stack size (256). Switch to
using the value defined by BOOT_STACK_SIZE, which prevents the stack
overflow.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org
---
arch/x86/xen/xen-pvh.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/xen/xen-pvh.S b/arch/x86/xen/xen-pvh.S
index ca2d3b2bf2af..58722a052f9c 100644
--- a/arch/x86/xen/xen-pvh.S
+++ b/arch/x86/xen/xen-pvh.S
@@ -181,7 +181,7 @@ canary:
.fill 48, 1, 0
early_stack:
- .fill 256, 1, 0
+ .fill BOOT_STACK_SIZE, 1, 0
early_stack_end:
ELFNOTE(Xen, XEN_ELFNOTE_PHYS32_ENTRY,
--
2.19.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] xen/pvh: increase early stack size
2018-10-09 10:32 [PATCH] xen/pvh: increase early stack size Roger Pau Monne
2018-10-09 11:01 ` Juergen Gross
@ 2018-10-09 11:01 ` Juergen Gross
2018-10-10 8:03 ` Juergen Gross
2018-10-10 8:03 ` Juergen Gross
3 siblings, 0 replies; 6+ messages in thread
From: Juergen Gross @ 2018-10-09 11:01 UTC (permalink / raw)
To: Roger Pau Monne, linux-kernel; +Cc: Boris Ostrovsky, xen-devel
On 09/10/2018 12:32, Roger Pau Monne wrote:
> While booting on an AMD EPYC box the stack canary would detect stack
> overflows when using the current PVH early stack size (256). Switch to
> using the value defined by BOOT_STACK_SIZE, which prevents the stack
> overflow.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
I'll add a "Cc: stable" when committing.
Juergen
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen/pvh: increase early stack size
2018-10-09 10:32 [PATCH] xen/pvh: increase early stack size Roger Pau Monne
@ 2018-10-09 11:01 ` Juergen Gross
2018-10-09 11:01 ` Juergen Gross
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Juergen Gross @ 2018-10-09 11:01 UTC (permalink / raw)
To: Roger Pau Monne, linux-kernel; +Cc: xen-devel, Boris Ostrovsky
On 09/10/2018 12:32, Roger Pau Monne wrote:
> While booting on an AMD EPYC box the stack canary would detect stack
> overflows when using the current PVH early stack size (256). Switch to
> using the value defined by BOOT_STACK_SIZE, which prevents the stack
> overflow.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
I'll add a "Cc: stable" when committing.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen/pvh: increase early stack size
2018-10-09 10:32 [PATCH] xen/pvh: increase early stack size Roger Pau Monne
2018-10-09 11:01 ` Juergen Gross
2018-10-09 11:01 ` Juergen Gross
@ 2018-10-10 8:03 ` Juergen Gross
2018-10-10 8:03 ` Juergen Gross
3 siblings, 0 replies; 6+ messages in thread
From: Juergen Gross @ 2018-10-10 8:03 UTC (permalink / raw)
To: Roger Pau Monne, linux-kernel; +Cc: Boris Ostrovsky, xen-devel
On 09/10/2018 12:32, Roger Pau Monne wrote:
> While booting on an AMD EPYC box the stack canary would detect stack
> overflows when using the current PVH early stack size (256). Switch to
> using the value defined by BOOT_STACK_SIZE, which prevents the stack
> overflow.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Committed to xen.tip for-linus-4.20
Juergen
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen/pvh: increase early stack size
2018-10-09 10:32 [PATCH] xen/pvh: increase early stack size Roger Pau Monne
` (2 preceding siblings ...)
2018-10-10 8:03 ` Juergen Gross
@ 2018-10-10 8:03 ` Juergen Gross
3 siblings, 0 replies; 6+ messages in thread
From: Juergen Gross @ 2018-10-10 8:03 UTC (permalink / raw)
To: Roger Pau Monne, linux-kernel; +Cc: xen-devel, Boris Ostrovsky
On 09/10/2018 12:32, Roger Pau Monne wrote:
> While booting on an AMD EPYC box the stack canary would detect stack
> overflows when using the current PVH early stack size (256). Switch to
> using the value defined by BOOT_STACK_SIZE, which prevents the stack
> overflow.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Committed to xen.tip for-linus-4.20
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] xen/pvh: increase early stack size
@ 2018-10-09 10:32 Roger Pau Monne
0 siblings, 0 replies; 6+ messages in thread
From: Roger Pau Monne @ 2018-10-09 10:32 UTC (permalink / raw)
To: linux-kernel; +Cc: Juergen Gross, xen-devel, Boris Ostrovsky, Roger Pau Monne
While booting on an AMD EPYC box the stack canary would detect stack
overflows when using the current PVH early stack size (256). Switch to
using the value defined by BOOT_STACK_SIZE, which prevents the stack
overflow.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org
---
arch/x86/xen/xen-pvh.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/xen/xen-pvh.S b/arch/x86/xen/xen-pvh.S
index ca2d3b2bf2af..58722a052f9c 100644
--- a/arch/x86/xen/xen-pvh.S
+++ b/arch/x86/xen/xen-pvh.S
@@ -181,7 +181,7 @@ canary:
.fill 48, 1, 0
early_stack:
- .fill 256, 1, 0
+ .fill BOOT_STACK_SIZE, 1, 0
early_stack_end:
ELFNOTE(Xen, XEN_ELFNOTE_PHYS32_ENTRY,
--
2.19.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-10 8:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-09 10:32 [PATCH] xen/pvh: increase early stack size Roger Pau Monne
2018-10-09 11:01 ` Juergen Gross
2018-10-09 11:01 ` Juergen Gross
2018-10-10 8:03 ` Juergen Gross
2018-10-10 8:03 ` Juergen Gross
2018-10-09 10:32 Roger Pau Monne
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.