* [GIT PULL FOR v5.5] Various fixes and enhancements
@ 2019-11-05 9:03 Hans Verkuil
2019-11-05 9:55 ` Jenkins
0 siblings, 1 reply; 4+ messages in thread
From: Hans Verkuil @ 2019-11-05 9:03 UTC (permalink / raw)
To: Linux Media Mailing List
Cc: Ricardo Ribalda Delgado, Nícolas F. R. A. Prado
This series fixes most of the smatch warnings/errors (one remaining smiapp
warning goes in via a PR from Sakari).
Also some improvements for handling default compound control values in the
control framework from Ricardo.
Regards,
Hans
The following changes since commit a4260ea49547aa0c84c353f9de5998a0315d89fe:
media: sun4i: Add H3 deinterlace driver (2019-10-24 19:07:59 -0300)
are available in the Git repository at:
git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.5p
for you to fetch changes up to a9cd173233e5cbeb9f23a701c859a1776de08784:
v4l2-device.h: fix typo: putss -> puts (2019-11-05 09:38:34 +0100)
----------------------------------------------------------------
Tag branch
----------------------------------------------------------------
Alexander Popov (1):
media: vivid: Fix wrong locking that causes race conditions on streaming stop
Colin Ian King (1):
media: siano: fix spelling mistake "ENBALE" -> "ENABLE"
Hans Verkuil (10):
vivid: media_device_cleanup was called too early
am437x: fix smatch warning
mtk-vpu: fix two smatch warnings
rc/ite-cir: fix smatch warning
em28xx: fix two smatch warnings
ti-vpe: fix smatch error
ov6650: fix smatch warning
mantis: fix two smatch errors
vivid: add vivid_create_queue() helper
v4l2-device.h: fix typo: putss -> puts
Nícolas F. R. A. Prado (1):
media: vimc: Make capture devices and subdevices use different link_validates
Ricardo Ribalda Delgado (6):
media: v4l2_ctrl: Add p_def to v4l2_ctrl_config
media: v4l2_ctrl: Add const pointer to ctrl_ptr
media: vivid: Add an area control
media: v4l2_core: Add p_area to struct v4l2_ext_control
Documentation: v42l_core: v4l2_ext_control
media: v4l2-ctrl: Use p_const when possible
Seung-Woo Kim (1):
media: exynos4-is: fix wrong mdev and v4l2 dev order in error path
Documentation/media/uapi/v4l/vidioc-g-ext-ctrls.rst | 5 +
drivers/media/common/siano/smscoreapi.c | 4 +-
drivers/media/common/siano/smscoreapi.h | 4 +-
drivers/media/i2c/ov6650.c | 2 +-
drivers/media/pci/mantis/hopper_cards.c | 4 +-
drivers/media/pci/mantis/mantis_cards.c | 4 +-
drivers/media/platform/am437x/am437x-vpfe.c | 1 -
drivers/media/platform/exynos4-is/media-dev.c | 7 +-
drivers/media/platform/mtk-vpu/mtk_vpu.c | 4 +-
drivers/media/platform/ti-vpe/vpdma.c | 2 +-
drivers/media/platform/vimc/vimc-capture.c | 2 +-
drivers/media/platform/vimc/vimc-common.c | 85 ++++++++--------
drivers/media/platform/vimc/vimc-common.h | 4 +-
drivers/media/platform/vivid/vivid-cec.c | 7 +-
drivers/media/platform/vivid/vivid-core.c | 261 +++++++++++++++++++++---------------------------
drivers/media/platform/vivid/vivid-core.h | 1 +
drivers/media/platform/vivid/vivid-ctrls.c | 14 +++
drivers/media/platform/vivid/vivid-kthread-cap.c | 8 +-
drivers/media/platform/vivid/vivid-kthread-out.c | 8 +-
drivers/media/platform/vivid/vivid-sdr-cap.c | 8 +-
drivers/media/rc/ite-cir.c | 2 +-
drivers/media/usb/em28xx/em28xx-i2c.c | 4 +-
drivers/media/v4l2-core/v4l2-ctrls.c | 19 ++--
include/media/v4l2-ctrls.h | 4 +
include/media/v4l2-device.h | 2 +-
include/uapi/linux/videodev2.h | 1 +
26 files changed, 232 insertions(+), 235 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL FOR v5.5] Various fixes and enhancements
2019-11-05 9:03 [GIT PULL FOR v5.5] Various fixes and enhancements Hans Verkuil
@ 2019-11-05 9:55 ` Jenkins
0 siblings, 0 replies; 4+ messages in thread
From: Jenkins @ 2019-11-05 9:55 UTC (permalink / raw)
To: mchehab+samsung, linux-media; +Cc: builder
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/patch/59841/
Build log: https://builder.linuxtv.org/job/patchwork/23533/
Build time: 00:45:34
Link: https://lore.kernel.org/linux-media/6020f449-5ab8-87a6-ff0b-6607da4796eb@xs4all.nl
gpg: Signature made Tue 05 Nov 2019 08:45:40 AM UTC
gpg: using RSA key AAA7FFBA4D2D77EF4CAEA1421326E0CD23ABDCE5
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg: aka "Hans Verkuil <hverkuil@xs4all.nl>" [full]
Summary: 12 patches and/or PDF generation with issues, being 0 at build time
Error/warnings:
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0001-media-vimc-Make-capture-devices-and-subdevices-use-d.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0001-media-vimc-Make-capture-devices-and-subdevices-use-d.patch
patches/0001-media-vimc-Make-capture-devices-and-subdevices-use-d.patch:21: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0002-vivid-media_device_cleanup-was-called-too-early.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0002-vivid-media_device_cleanup-was-called-too-early.patch
patches/0002-vivid-media_device_cleanup-was-called-too-early.patch:6: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0003-am437x-fix-smatch-warning.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0003-am437x-fix-smatch-warning.patch
patches/0003-am437x-fix-smatch-warning.patch:4: WARNING: A patch subject line should describe the change not the tool that found it
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0004-mtk-vpu-fix-two-smatch-warnings.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0004-mtk-vpu-fix-two-smatch-warnings.patch
patches/0004-mtk-vpu-fix-two-smatch-warnings.patch:4: WARNING: A patch subject line should describe the change not the tool that found it
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0005-rc-ite-cir-fix-smatch-warning.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0005-rc-ite-cir-fix-smatch-warning.patch
patches/0005-rc-ite-cir-fix-smatch-warning.patch:4: WARNING: A patch subject line should describe the change not the tool that found it
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0006-em28xx-fix-two-smatch-warnings.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0006-em28xx-fix-two-smatch-warnings.patch
patches/0006-em28xx-fix-two-smatch-warnings.patch:4: WARNING: A patch subject line should describe the change not the tool that found it
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0007-ti-vpe-fix-smatch-error.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0007-ti-vpe-fix-smatch-error.patch
patches/0007-ti-vpe-fix-smatch-error.patch:4: WARNING: A patch subject line should describe the change not the tool that found it
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0008-ov6650-fix-smatch-warning.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0008-ov6650-fix-smatch-warning.patch
patches/0008-ov6650-fix-smatch-warning.patch:4: WARNING: A patch subject line should describe the change not the tool that found it
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0009-mantis-fix-two-smatch-errors.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0009-mantis-fix-two-smatch-errors.patch
patches/0009-mantis-fix-two-smatch-errors.patch:4: WARNING: A patch subject line should describe the change not the tool that found it
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0010-media-siano-fix-spelling-mistake-ENBALE-ENABLE.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0010-media-siano-fix-spelling-mistake-ENBALE-ENABLE.patch
patches/0010-media-siano-fix-spelling-mistake-ENBALE-ENABLE.patch:26: WARNING: line over 80 characters
patches/0010-media-siano-fix-spelling-mistake-ENBALE-ENABLE.patch:27: WARNING: line over 80 characters
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0011-vivid-add-vivid_create_queue-helper.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0011-vivid-add-vivid_create_queue-helper.patch
patches/0011-vivid-add-vivid_create_queue-helper.patch:15: WARNING: use relative pathname instead of absolute in changelog text
patches/0011-vivid-add-vivid_create_queue-helper.patch:16: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0013-media-exynos4-is-fix-wrong-mdev-and-v4l2-dev-order-i.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0013-media-exynos4-is-fix-wrong-mdev-and-v4l2-dev-order-i.patch
patches/0013-media-exynos4-is-fix-wrong-mdev-and-v4l2-dev-order-i.patch:12: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL FOR v5.5] Various fixes and enhancements
2019-11-09 15:01 Hans Verkuil
@ 2019-11-09 15:21 ` Jenkins
0 siblings, 0 replies; 4+ messages in thread
From: Jenkins @ 2019-11-09 15:21 UTC (permalink / raw)
To: mchehab+samsung, linux-media; +Cc: builder
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/patch/59983/
Build log: https://builder.linuxtv.org/job/patchwork/24142/
Build time: 00:10:32
Link: https://lore.kernel.org/linux-media/ff5eacbd-f3c5-f5d9-88a1-a74ff6ff36f7@xs4all.nl
gpg: Signature made Sat 09 Nov 2019 02:56:59 PM UTC
gpg: using RSA key AAA7FFBA4D2D77EF4CAEA1421326E0CD23ABDCE5
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg: aka "Hans Verkuil <hverkuil@xs4all.nl>" [full]
Summary: 3 patches and/or PDF generation with issues, being 0 at build time
Error/warnings:
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0001-dt-bindings-sh-mobile-ceu-Remove-now-unimplemented-b.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0001-dt-bindings-sh-mobile-ceu-Remove-now-unimplemented-b.patch
patches/0001-dt-bindings-sh-mobile-ceu-Remove-now-unimplemented-b.patch:10: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
patches/0001-dt-bindings-sh-mobile-ceu-Remove-now-unimplemented-b.patch:10: ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 43a445f188e1 ("media: sh_mobile_ceu_camera: remove obsolete soc_camera driver")'
patches/0001-dt-bindings-sh-mobile-ceu-Remove-now-unimplemented-b.patch:22: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
patches/0001-dt-bindings-sh-mobile-ceu-Remove-now-unimplemented-b.patch:25: WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.txt
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0015-vim2m-media_device_cleanup-was-called-too-early.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0015-vim2m-media_device_cleanup-was-called-too-early.patch
patches/0015-vim2m-media_device_cleanup-was-called-too-early.patch:6: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0016-vicodec-media_device_cleanup-was-called-too-early.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0016-vicodec-media_device_cleanup-was-called-too-early.patch
patches/0016-vicodec-media_device_cleanup-was-called-too-early.patch:6: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [GIT PULL FOR v5.5] Various fixes and enhancements
@ 2019-11-09 15:01 Hans Verkuil
2019-11-09 15:21 ` Jenkins
0 siblings, 1 reply; 4+ messages in thread
From: Hans Verkuil @ 2019-11-09 15:01 UTC (permalink / raw)
To: Linux Media Mailing List
The following changes since commit b0b1c88f1c19aeedb260d1889a7d19838617c97c:
media: arm64: dts: allwinner: beelink-gs1: Add rc-beelink-gs1 keymap (2019-11-09 09:17:26 +0100)
are available in the Git repository at:
git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.5r
for you to fetch changes up to abcad34ef8966113959c8deed3592ae661fb2f1d:
vicodec: media_device_cleanup was called too early (2019-11-09 15:29:09 +0100)
----------------------------------------------------------------
Tag branch
----------------------------------------------------------------
Chuhong Yuan (1):
media: si470x-i2c: add missed operations in remove
Dafna Hirschfeld (1):
media: vimc: upon streaming, check that the pipeline starts with a source entity
Hans Verkuil (3):
v4l2-ioctl.c: zero reserved fields for S/TRY_FMT
vim2m: media_device_cleanup was called too early
vicodec: media_device_cleanup was called too early
Hirokazu Honda (1):
media: mtk-vcodec: Remove extra area allocation in an input buffer on encoding
Jernej Skrabec (3):
media: cedrus: Properly signal size in mode register
media: cedrus: Fix H264 4k support
media: cedrus: Increase maximum supported size
Navid Emamdoost (1):
media: aspeed-video: Fix memory leaks in aspeed_video_probe
Philipp Zabel (2):
media: coda: disable encoder compose selections
media: coda: disable decoder crop selections
Pi-Hsun Shih (1):
media: v4l2-ctrl: Lock main_hdl on operations of requests_queued.
Pragnesh Patel (1):
media: dt-bindings: Fix building error for dt_binding_check
Simon Horman (1):
dt-bindings: sh-mobile-ceu: Remove now unimplemented bindings documentation
zhong jiang (1):
media: v4l2: Use FIELD_SIZEOF directly
Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml | 2 +-
Documentation/devicetree/bindings/media/sh_mobile_ceu.txt | 17 ------
drivers/media/platform/aspeed-video.c | 3 +-
drivers/media/platform/coda/coda-common.c | 6 ++-
drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 9 ++--
drivers/media/platform/vicodec/vicodec-core.c | 4 +-
drivers/media/platform/vim2m.c | 4 +-
drivers/media/platform/vimc/vimc-common.c | 10 ++++
drivers/media/platform/vimc/vimc-common.h | 8 +++
drivers/media/platform/vimc/vimc-streamer.c | 13 ++++-
drivers/media/radio/si470x/radio-si470x-i2c.c | 2 +
drivers/media/v4l2-core/v4l2-ctrls.c | 7 +++
drivers/media/v4l2-core/v4l2-ioctl.c | 26 ++++-----
drivers/staging/media/sunxi/cedrus/cedrus.h | 7 +++
drivers/staging/media/sunxi/cedrus/cedrus_h264.c | 93 ++++++++++++++++++++++++++++----
drivers/staging/media/sunxi/cedrus/cedrus_h265.c | 2 +-
drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 9 +++-
drivers/staging/media/sunxi/cedrus/cedrus_hw.h | 2 +-
drivers/staging/media/sunxi/cedrus/cedrus_mpeg2.c | 2 +-
drivers/staging/media/sunxi/cedrus/cedrus_regs.h | 13 +++++
drivers/staging/media/sunxi/cedrus/cedrus_video.c | 4 +-
21 files changed, 183 insertions(+), 60 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/sh_mobile_ceu.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-09 15:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-05 9:03 [GIT PULL FOR v5.5] Various fixes and enhancements Hans Verkuil
2019-11-05 9:55 ` Jenkins
2019-11-09 15:01 Hans Verkuil
2019-11-09 15:21 ` Jenkins
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.