From: Dmitry Osipenko <digetx@gmail.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: leonard.crestez@nxp.com, lukasz.luba@arm.com,
enric.balletbo@collabora.com, hl@rock-chips.com,
thierry.reding@gmail.com, jonathanh@nvidia.com,
abel.vesa@nxp.com, chanwoo@kernel.org, myungjoo.ham@samsung.com,
kyungmin.park@samsung.com
Subject: Re: [PATCH 2/2] PM / devfreq: Add governor flags to clarify the features
Date: Fri, 3 Jul 2020 13:46:30 +0300 [thread overview]
Message-ID: <6027cf29-ea6f-0a27-3e39-a80c24b80bb8@gmail.com> (raw)
In-Reply-To: <20200703100810.12304-3-cw00.choi@samsung.com>
03.07.2020 13:08, Chanwoo Choi пишет:
> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> index e94a27804c20..620ecd250d7c 100644
> --- a/drivers/devfreq/tegra30-devfreq.c
> +++ b/drivers/devfreq/tegra30-devfreq.c
> @@ -765,10 +765,12 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
>
> static struct devfreq_governor tegra_devfreq_governor = {
> .name = "tegra_actmon",
> + .flag = DEVFREQ_GOV_FLAG_ATTR_COMMON
> + | DEVFREQ_GOV_FLAG_ATTR_POLLING_INTERVAL,
Hello, Chanwoo!
There is a typo here, it should be ".attr = ".
> + .flag = DEVFREQ_GOV_FLAG_FLAG_IMMUTABLE,
> + | DEVFREQ_GOV_FLAG_FLAG_IRQ_DRIVEN,
There is a typo here too FLAG_FLAG ^
> .get_target_freq = tegra_governor_get_target,
> .event_handler = tegra_governor_event_handler,
> - .immutable = true,
> - .interrupt_driven = true,
> };
>
next prev parent reply other threads:[~2020-07-03 10:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200703095657epcas1p4347374f533f0cd84430d548a3af12b79@epcas1p4.samsung.com>
2020-07-03 10:08 ` [PATCH 0/2] PM / devfreq: Add governor flags Chanwoo Choi
[not found] ` <CGME20200703095657epcas1p15695a8d0d48e5bf0b195cc5f893a0e72@epcas1p1.samsung.com>
2020-07-03 10:08 ` [PATCH 1/2] PM / devfreq: Clean up the devfreq instance name in sysfs attr Chanwoo Choi
[not found] ` <CGME20200703095657epcas1p187b7f90a4a33da7791a83a78760f3a91@epcas1p1.samsung.com>
2020-07-03 10:08 ` [PATCH 2/2] PM / devfreq: Add governor flags to clarify the features Chanwoo Choi
2020-07-03 10:46 ` Dmitry Osipenko [this message]
2020-07-03 20:34 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6027cf29-ea6f-0a27-3e39-a80c24b80bb8@gmail.com \
--to=digetx@gmail.com \
--cc=abel.vesa@nxp.com \
--cc=chanwoo@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=enric.balletbo@collabora.com \
--cc=hl@rock-chips.com \
--cc=jonathanh@nvidia.com \
--cc=kyungmin.park@samsung.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.